From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEE6C7EE2F for ; Fri, 3 Mar 2023 19:51:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F1C96B0072; Fri, 3 Mar 2023 14:50:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A2386B0073; Fri, 3 Mar 2023 14:50:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 169B06B0074; Fri, 3 Mar 2023 14:50:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 044096B0072 for ; Fri, 3 Mar 2023 14:50:59 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D18111C6CC3 for ; Fri, 3 Mar 2023 19:50:58 +0000 (UTC) X-FDA: 80528630196.03.93A3360 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf05.hostedemail.com (Postfix) with ESMTP id 12C2B100013 for ; Fri, 3 Mar 2023 19:50:55 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tb6rpy1h; spf=pass (imf05.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677873056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oi/Dc6KdT1oRSvAHPhZ8feRgUthVwWLJjDowTGLD+9g=; b=ak9K47dj20pclLK95QsKRHQubpLtrwx6fgA1IP3gYwi92DWunDLzufSBth49a7+VMPHAp6 ZYGw9I90nldVMdbMZPefsXjrNutoBKAAEog6xtbgmSrAsxU1u8nNzYNCUtIe/w2JPrfUkH wmfA3NpDqh4/quB7gMNVGZxXNt5TQfA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tb6rpy1h; spf=pass (imf05.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677873056; a=rsa-sha256; cv=none; b=7PM9o0xIU16/v6AQ3yPwi1KkryZvvuNx62YqVyYpqBkvlM6BXWblELRwiV2iMpdsteXima yQOluc2ONG4yP3oOb8PgktXwhNcXktTtruRvW8S76Od0dSU9KXwGGbCFAZva6EPj9VpWJe 535Cu1IM4PbA8FPUDVbIaatHV/JQN6k= Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 72B9E21D64; Fri, 3 Mar 2023 19:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677873054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oi/Dc6KdT1oRSvAHPhZ8feRgUthVwWLJjDowTGLD+9g=; b=tb6rpy1ho2utbbrh5ZB/0Wp5HxLnJSqZjnZhd3Wm6auX8oYZ0wx65gfD0JgXp38C7KdZu8 JWkF+I4RKGTLHf4hYf4kVjMT76O0ILVG4ZO5sQmdi2sJ0oM3UrZK5PSleUZ8LBiaiqtQoT ZW2LOGJ551WE0/L5hAD9VUnUltbAG2I= Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 72D4D2C141; Fri, 3 Mar 2023 19:50:53 +0000 (UTC) Date: Fri, 3 Mar 2023 20:50:52 +0100 From: Petr Mladek To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Andrew Morton , Joe Perches , Andy Shevchenko , Steven Rostedt , Vlastimil Babka , Matthew WilCox , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable v4 2/3] mm, printk: introduce new format %pGt for page_type Message-ID: References: <20230130042514.2418-1-42.hyeyoo@gmail.com> <20230130042514.2418-3-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230130042514.2418-3-42.hyeyoo@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: mxo5pa1ejkhbxsouccf48k1htgj8xwjw X-Rspamd-Queue-Id: 12C2B100013 X-HE-Tag: 1677873055-448312 X-HE-Meta: U2FsdGVkX19lL4kHUQlTb68KV1kyBLlBqkndkOmO7qtnNamS2zg0xFMYtLt9ylthzodLRXFFqBoAZI3F2Rb8pVabYD/xP9BTY6k6uXVyU+fJQt7s5rW4uog/FdAvn6NkZU3hpIlQ5QJ/dxG9HUnHtXatDtEKPzmAeRSEq643VBmxmPes8PgI7nDg9/mFzRCJ1t84Xq0BwMUnRYboZSHCCGDYTOR2ZqtS9A5+qcaUAbS2moki3v89TLpXXcVFNv/FV6PtkC310ypNnvHsjlRGZU75VtipOFz02Vpk6x6vOMYy1CO+wKWBpJueZ+D2qk+O7SI3hW1edganz/Cnh50M9cI+evswUs2qrHGkMp5l7i8JoFs2irATZjMTbrflR1LPfclxHEsdKVrlr4Cbui5F9/DdG4Cp5IgbxEilV99GKEuCvt88N5M7jWQlN683rmZRGs5/++h3rMkIFZcqKJCp297vbYjFQsW1iVy6W1IDcHMk3tJlfMkxZpyDga16MVbQvU0K3uifS5y8uX0GUBJfwX0UQnumZBeGbeSfYrq8K7suGwkmBaPXO0MB29dGNCjb92akLeCJlYLVku9ZF/49SG0e9dGSv9gbrKwmASLU5y46GNWCWa/BU/FUCO8xCNCpvjoROYz7MYfgeHD7B9lh4Lx7gEPU9VnuZpMrVUhXU/XGxpHur1Age0/8shdZu5bn6hsIhXHqMSyaY6SCwFLhPonosllPmvKplJd0DKyeStrwUG3KEzHoxXoZvvq5BKSA/+p7W77vnPt8uEfxxJtL7igkPE2PAn4jWJn3uMRWCrosvGlZcx5kmszV7NWhjLsQNCj5SkRG5oRBUg9Xki68SHKjRBrFkqtwOR45rSysTbqezD6/etE+ZqSn5eyejAqrglJsoWAmolw3RuJjQZJ5BzvnEKe3byPdvNBbdClj2IMvPufzpiMs8PFkU0VLP7zRdhZJCFmxhpgUoomdoGa mmwd7GnH 2/XB+yNKAudTcrDZydxxxBFOE7dVUMalqZya91BPNYILOXZgFo/m0bUwnf30mzwutS3mtZpPmJUO4d+3D6bfurUTLE+BV+rz9I98RrkZu2c1mC37193jMzxi/Yi5FHSEeY3s87Bb6yltAQRTPWNGB+B/JpRUnvcaublb8wcGjEJC/9TldijE/BhSbHw6kotLWoQ7DUizD3eLYX5eID6fZHF3Lov9AXXoPu3HogyyDseceAkvi4ZDtSRxt1SWYvOVQR9ocyQqNkxRt8CHJZZaVj5qN0dPt8AdXpqBPalB8ofDm5TFmAT0oourO15PE5sZGtiRLpW11FKDy9A8tpgZbgrFYmwADtktYoiMoLudLtKNn1DI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 2023-01-30 13:25:13, Hyeonggon Yoo wrote: > %pGp format is used to display 'flags' field of a struct page. > However, some page flags (i.e. PG_buddy, see page-flags.h for more details) > are stored in page_type field. To display human-readable output of > page_type, introduce %pGt format. > > It is important to note the meaning of bits are different in page_type. > if page_type is 0xffffffff, no flags are set. Setting PG_buddy (0x00000080) > flag results in a page_type of 0xffffff7f. Clearing a bit actually means > setting a flag. Bits in page_type are inverted when displaying type names. > > Only values for which page_type_has_type() returns true are considered > as page_type, to avoid confusion with mapcount values. if it returns false, > only raw values are displayed and not page type names. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Petr Mladek # for vsprintf part I am sorry for the late review. It has somehow fallen through cracks. Best Regards, Petr