From: Petr Mladek <pmladek@suse.com>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew WilCox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH mm-unstable v4 2/3] mm, printk: introduce new format %pGt for page_type
Date: Fri, 3 Mar 2023 20:50:52 +0100 [thread overview]
Message-ID: <ZAJPnG2LqjvXkC/Z@alley> (raw)
In-Reply-To: <20230130042514.2418-3-42.hyeyoo@gmail.com>
On Mon 2023-01-30 13:25:13, Hyeonggon Yoo wrote:
> %pGp format is used to display 'flags' field of a struct page.
> However, some page flags (i.e. PG_buddy, see page-flags.h for more details)
> are stored in page_type field. To display human-readable output of
> page_type, introduce %pGt format.
>
> It is important to note the meaning of bits are different in page_type.
> if page_type is 0xffffffff, no flags are set. Setting PG_buddy (0x00000080)
> flag results in a page_type of 0xffffff7f. Clearing a bit actually means
> setting a flag. Bits in page_type are inverted when displaying type names.
>
> Only values for which page_type_has_type() returns true are considered
> as page_type, to avoid confusion with mapcount values. if it returns false,
> only raw values are displayed and not page type names.
>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Reviewed-by: Petr Mladek <pmladek@suse.com> # for vsprintf part
I am sorry for the late review. It has somehow fallen through cracks.
Best Regards,
Petr
next prev parent reply other threads:[~2023-03-03 19:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 4:25 [PATCH mm-unstable v4 0/3] mm, printk: introduce new format " Hyeonggon Yoo
2023-01-30 4:25 ` [PATCH mm-unstable v4 1/3] mmflags.h: use less error prone method to define pageflag_names Hyeonggon Yoo
2023-01-30 12:35 ` Andy Shevchenko
2023-01-31 8:38 ` Hyeonggon Yoo
2023-01-31 21:09 ` Andrew Morton
2023-02-01 12:14 ` Hyeonggon Yoo
2023-01-30 4:25 ` [PATCH mm-unstable v4 2/3] mm, printk: introduce new format %pGt for page_type Hyeonggon Yoo
2023-03-03 19:50 ` Petr Mladek [this message]
2023-01-30 4:25 ` [PATCH mm-unstable v4 3/3] mm/debug: use %pGt to display page_type in dump_page() Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAJPnG2LqjvXkC/Z@alley \
--to=pmladek@suse.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox