From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAFEFC64EC4 for ; Fri, 3 Mar 2023 23:09:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30A1D6B0072; Fri, 3 Mar 2023 18:09:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 293276B0073; Fri, 3 Mar 2023 18:09:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 134316B0074; Fri, 3 Mar 2023 18:09:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F1DD86B0072 for ; Fri, 3 Mar 2023 18:09:19 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C08AD1A057A for ; Fri, 3 Mar 2023 23:09:19 +0000 (UTC) X-FDA: 80529130038.12.E933C7D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id D350340004 for ; Fri, 3 Mar 2023 23:09:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Xup5Yqvv; spf=none (imf27.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677884958; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=idhjeImW2x4WSmgXwGQh1eQ5mm6+wa13qu5LRlgfpnQ=; b=cWvugQtCrJt/ShoatM/MyuUlFTpczktSjJa+nE+gs04K8U8X+mwRRUXDz3MQfgyfAEF/Rb RXjFEJYFRY89QGbLs/7Vwg0svcy/FTPamk76gyTFwrBjskQrTLF2hLF7nUwHZCDXyFvNiR 4/p1JU70AvsTAPvztP0A/pxQmgVMWrI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Xup5Yqvv; spf=none (imf27.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677884958; a=rsa-sha256; cv=none; b=FniDMxpIEu2glQ/mQt0v/bV6jLblu7MXoLpvPbELK7A3rYi5QxG49vaJTY+Qry8+QmpO4C esOtQvOuzH6mvmZdWYJYKS/MNGyBiIhtsZbIrHeUDRn0KlFWNByQt1ndBd8Z+BFazy/s1a YrwefuShkpr7bd/r10Iv3fytXLMfDHw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=idhjeImW2x4WSmgXwGQh1eQ5mm6+wa13qu5LRlgfpnQ=; b=Xup5Yqvv5hPoglL9giPHFQRJ+X opxPYoziOD5gF3xKtZO2z60fGVLexvq/35K4GUmVl1zjLnl1VJNcyQCOAnEMCw2SPYRU8ztYQ1xBN Wd09yO9i0JBSsdkzoyFUhWFM7e8psQiZTrFVD0qQ2Szw8THXF2kbhYTbowyR7R0JwEbRK4JuURgXA U+a5rmLB3bxAc653/ez1Io2N/QTHnYLNDd54wz3ygwsscZxh3ACHarLbWwkmy+8IgMU7crmq6JFZa 85Pi0ElDLwWYO/vnPVOkX+ckXlnltF1DDLdFuSmms3ADh+cT9dfT5KTy75DXOSapcMP94va4EkM9w Qetat49Q==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYEWV-007mVT-Hd; Fri, 03 Mar 2023 23:09:11 +0000 Date: Fri, 3 Mar 2023 15:09:11 -0800 From: Luis Chamberlain To: Keith Busch Cc: Matthew Wilcox , Theodore Ts'o , Pankaj Raghav , Daniel Gomez , Javier =?iso-8859-1?Q?Gonz=E1lez?= , lsf-pc@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [LSF/MM/BPF TOPIC] Cloud storage optimizations Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D350340004 X-Rspam-User: X-Stat-Signature: db9atkeiewnrftnu3tcx8zy5e648g9wo X-HE-Tag: 1677884957-585335 X-HE-Meta: U2FsdGVkX1+NrwtWl62cbiZ23/Gpi2ocV+F6qlvn8Y2jWsoQf5ggvCDbLRTKesHf3bo8qSpQqWifwcKl7kIgpplhZm1SzC+JueJVDqrd1UCY6Jmm/anuA96KxlF6nNoDNDSH5BQt6H4HhtcJ7kZEasTAUvOOKlhpB7rb+nMnA54hi1q3LEdOC6KnbnuscrmvYi5waUeUC1YwJzF7zGTzBFnf56zZ7IT3ry1Yxg/8NEChq47SDNXJsSaRyiY1MvMYF+k+vWQIluFtxqEkkE4lw7eVP+/cth/3+bnKBAhgmJbspkspxLGPKVcWPBjdsWmzFP4s6r4xu2Jrcnxu+dgElUDlHph3G3D8P9GgZ/lzWEExz26Ny+m1IHUtU4pi+v2HbTzmA8GuQpqqENljBPBjWRUKI0qYn+1NwtGu3fBxqLX4zyM+I2pe5WM7ZPb64ODdqluLr6sgY5M+VcUg6+LbPTyU1gHfUIi7iXftW57CvaA9DaztzmAaHngRRFazG767PcQzBIPgfGZrs1378Je/ZORlZbH1OqCR5pb62Gr9qeiKZXsenBYsXiAXGigTaNB3kvtdUFvuxy670QZgafVjo7eFEJXBatX22TLNeQE7DeG+vG4jmK5tWr4jBDhjau7AQq4+4J+wHZCowzrqbqVUdOJ8wicA7tBMMJI6YzxQ23ADgy2tG4vX9DBl6eCrxwwkqCM3n8maeofJau4VL1NyLzJrO17VdGW28XzKbpeZ6UlIh5vRYaCuQ480uZzp2n29EGnBg9R6wHbXg+lVYq5xUNPPyoWv7hmElQUw5ovX4GJzd6O0XOXzGM/F8eEC1AxszTiaYN+y6vXL2QsYLQUa6lQQJQDEI1YLoKkRBPxTfi2TN5EcdZjn3Vn7kqHEdYKulxiW+SkeW33vHh8TerfemaI3P36BH+dOoienKQUalyXKzGWr3+2BKqOS9yqhhELY6mt9T8mKVzqUI//m+OW KLjajmn7 sq5aeGyNqOpP+XiEdAML5OK528jefFVcHLM6kmvOQSGhLJOvhdiFfAUiH//MPD/JbPplKPa2kpf35QjlUnyTuPVPatXrHw2GwAsmbNxjGoG42nBOgF6BlXFixn9aQJeHyrxz5n9peHn9S/M9gsj3njN6XabV/dz2rT2zyUpBILuq678BosBp8iMHOWQPZfxWFgm3FEh7XZtzhoQEyJ7/LIH/RFoVvF9uBBXHrHwNu53gpVz/Z9UX0w1rKlM8CAiR7gD5HDa5tmcnezPJ6sqMf19pAet9N6mKbep6jGPhA4mXbrqtgtEZaq91Y/BspzOt+yp4rgAkZAJs2pdc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000070, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 03, 2023 at 03:32:08PM -0700, Keith Busch wrote: > On Fri, Mar 03, 2023 at 02:14:55PM -0800, Luis Chamberlain wrote: > > On Fri, Mar 03, 2023 at 03:07:55PM -0700, Keith Busch wrote: > > > On Fri, Mar 03, 2023 at 01:45:48PM -0800, Luis Chamberlain wrote: > > > > > > > > You'd hope most of it is left to FS + MM, but I'm not yet sure that's > > > > quite it yet. Initial experimentation shows just enabling > PAGE_SIZE > > > > physical & logical block NVMe devices gets brought down to 512 bytes. > > > > That seems odd to say the least. Would changing this be an issue now? > > > > > > I think you're talking about removing this part: > > > > > > --- > > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > > > index c2730b116dc68..2c528f56c2973 100644 > > > --- a/drivers/nvme/host/core.c > > > +++ b/drivers/nvme/host/core.c > > > @@ -1828,17 +1828,7 @@ static void nvme_update_disk_info(struct gendisk *disk, > > > unsigned short bs = 1 << ns->lba_shift; > > > u32 atomic_bs, phys_bs, io_opt = 0; > > > > > > - /* > > > - * The block layer can't support LBA sizes larger than the page size > > > - * yet, so catch this early and don't allow block I/O. > > > - */ > > > - if (ns->lba_shift > PAGE_SHIFT) { > > > - capacity = 0; > > > - bs = (1 << 9); > > > - } > > > - > > > blk_integrity_unregister(disk); > > > - > > > atomic_bs = phys_bs = bs; > > > > Yes, clearly it says *yet* so that begs the question what would be > > required? > > Oh, gotcha. I'll work on a list of places it currently crashes. Awesome that then is part of our dirty laundry TODO for NVMe for larger IO. > > Also, going down to 512 seems a bit dramatic, so why not just match the > > PAGE_SIZE so 4k? Would such a comprmise for now break some stuff? > > The capacity set to zero ensures it can't be used through the block stack, so > the logical block size limit is unused. Oh OK so in effect we won't have compat issues if we decide later to change this. So block devices just won't be cabable of working? That save me tons of tests. > 512 is just a default value. We only > bring up the handle so you can administrate it with passthrough commands. So we'd use 512 for passthrough, but otherwise it won't work ? Luis