From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB8FC64EC4 for ; Fri, 3 Mar 2023 16:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18D4D6B0074; Fri, 3 Mar 2023 11:02:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13D9A6B0075; Fri, 3 Mar 2023 11:02:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F20616B0078; Fri, 3 Mar 2023 11:02:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DEF606B0074 for ; Fri, 3 Mar 2023 11:02:18 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AAFA3A113A for ; Fri, 3 Mar 2023 16:02:18 +0000 (UTC) X-FDA: 80528053956.09.0FC1465 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id EBAF3C0017 for ; Fri, 3 Mar 2023 16:02:15 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sl1U8UXp; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677859336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a61vCLGPtw7ytsuivCnnaSA8TTux/ew1GXnO2PIM6zc=; b=nB33Cw11SKJXvN/lkUB8Y3EKfz7pD7A2ZKTQu5OfCepdqHbJ4ajQlaBk+0eXFdU0ZCOk+w wRsTzecCtckP4HhELfT7rCej6jNCAc0IqK4TBSiZxNovS2pHBPNV7mABGYs9XS6A4Rmbwi 1OsxdsDtWWVk4F5CA88ZtiQz4gsgaTQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sl1U8UXp; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677859336; a=rsa-sha256; cv=none; b=ZYWiPzWfzaTiafjAjlyXG1QvQ3J7nm8N3+Mt1raYM0SCoCgqE0HK24eCsT05Up8LHOtv65 sDwOsV3RNbw7+7JxkjdQyERFSml78eivST4e9+d/A04SH8pEiGKcW44lMjU67sC9f/B/Vo 4werYV8SKyhSPDRwbrarvwh13S8+T+Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a61vCLGPtw7ytsuivCnnaSA8TTux/ew1GXnO2PIM6zc=; b=sl1U8UXpCLNhOfwHysl9WpB/2H xt/mbpCW2+7f+sFCHI0rLgv00mzL/mURYeMG2TtC4kp4zXgm6G1Ftyc8IaQotvjv0y7dlzwv5FN1a mQgNBRi2fdsQ4cJspqff8wgITzcyblPbLTUFwihxnZhLXa2rmTRvqERmbOr0Mw/8mappWNymP9sz/ 34yLwES7mduMh72ypGwnGe1tOEuANrIakykmNSN8XfFU5hnu2sMmb6AkYzxAI2DrKLMlKVwyjxzdf wm+Z2zqcRqAxAdxLRAGP5Oskesw6Kt8hZTRid0cH/lM2FaYAQ/vZrCbsnJ4cKUMqZl9ze9Kk7s+IK 7/olMkqQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY7rH-003Dre-IC; Fri, 03 Mar 2023 16:02:11 +0000 Date: Fri, 3 Mar 2023 16:02:11 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 30/34] mm: Use flush_icache_pages() in do_set_pmd() Message-ID: References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-31-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EBAF3C0017 X-Stat-Signature: mx3mwp5iko1spu3p544bokbfcfw4tcc5 X-HE-Tag: 1677859335-861558 X-HE-Meta: U2FsdGVkX1+ZuoHdHGmw9wFyxLZm8bPLQYA+ISkHhq+QYsWX21R7iRN5b/1TuiVSMXVQkFfWHQUlKBW5OeJvF+0w4Sfy/oK+EYEwguk8rBhCDg3mDoX+HxYGE023uisND1/hLNfWOvuHxEh9IUiugOCHfHTuEVw5s/Ntlq3suS2JVHHTmi61WNyn2e/du1SUs/NAa+FErEV7zITeMNjCi2q3HF3dpzY2wP58oJ85BD1WmjnkxwyijrhSEM5USBUxnNHuMPffLBQdmn1VxgkIx8tmFY6hsu/agYfo1jtoICpbNGTiX7c1UESslxPdzKYD9dYoN5ODj4cUkldiI3boq3YKxfjPrZbOAvPRU7DzLxjbc5FU6wSeWP6juIZje/lpAbsWOseCAvUQu/9i6Wwjg9cPa40cBdolXE60FBWW9fUnH2aZ75P39CfqswjDwufDJLbwNPGQGbGBhD/W360g5U8KWBPGVbhw15koySVOicdxrj4pLcEpQK5B4w1JYXLt/ee1k3e3l1Zbjgte2HAMjbwXiqmXuquwylYQYZDwAyk4bKP+m1oL302P4JXhHKhD1SGOF9jHp9HlxGpgFcr6KdJx03YW9a5I5gMnGtQGGBBY+fEoeftukdSx3K0f8Biq2SWbkWDV17fbU5DH1z2wJbnHT3nqrVLP6ZgTZHAMtBdIdrLGaZQK+SmUlvHSDU5adbKQp3+Dn+Ep7iAc5aZbxoJy1ojeojPAa6KTaHEt7Z3/heCoivmb6Da1yc59rnXuhUcyu+d8kgUD2wr5Vl57G3QjMX86WwOD59TXuBu6CzMj7v7u5CAhFzPHUFgx+mnvYfYKRA4R7VbdV3uK2hRQKZZAMyj1FbH9T2c2LDebRaHbGSOkTiLtTq0zXGu0g8IhcyfXOMIo2s5UTOu/jPG0rGQIeHAvXqlt//3Ade0etSjt1C4bji/xH7XeUw0Qw6qAljeCtLUssY+cqAu8rzt 0weQ5YEv 8XBxm61DyY3QnF3Tm7gt1M8K4ukia3NtE0m6WUlLhGrf3s1QY97uBk88HAFuc41BDxwrinX7sHKIUvcrutyDC/zlzq6FhVAWGlpe+LgA5QEUg9HqV3/5yHoA+gBxyKO4Y18EztgkepqeRelD3u7tz/tBjj6UU/CudF/AxbiKGk5jnVb7pCMNjjjbsHpsVkoKlJc7ZKX9nsHTfh5S6mhIoq1xhAm98pNff+EgPQGNHc/iv9LZPxn5YJ9zlXN/EvKkVKfOg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 03, 2023 at 04:02:01PM +0200, Mike Rapoport wrote: > On Tue, Feb 28, 2023 at 09:37:33PM +0000, Matthew Wilcox (Oracle) wrote: > > Push the iteration over each page down to the architectures (many > > can flush the entire THP without iteration). > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > mm/memory.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index bfa3100ec5a3..69e844d5f75c 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -4222,8 +4222,7 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) > > if (unlikely(!pmd_none(*vmf->pmd))) > > goto out; > > > > - for (i = 0; i < HPAGE_PMD_NR; i++) > > - flush_icache_page(vma, page + i); > > + flush_icache_pages(vma, page, HPAGE_PMD_NR); > > > > entry = mk_huge_pmd(page, vma->vm_page_prot); > > if (write) > > -- > > 2.39.1 > > I get this: > > CC mm/memory.o > /home/mike/git/linux/mm/memory.c: In function 'do_set_pmd': > /home/mike/git/linux/mm/memory.c:4191:13: warning: unused variable 'i' [-Wunused-variable] > 4191 | int i; Yep, caught that one last night. My build test must have been with a config that didn't include THP. Thanks.