From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71598C678D4 for ; Fri, 3 Mar 2023 14:36:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D94766B0078; Fri, 3 Mar 2023 09:36:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D44C56B007D; Fri, 3 Mar 2023 09:36:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0C126B0080; Fri, 3 Mar 2023 09:36:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AE4D86B0078 for ; Fri, 3 Mar 2023 09:36:17 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7E1A9809FC for ; Fri, 3 Mar 2023 14:36:17 +0000 (UTC) X-FDA: 80527837194.15.AC962BA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id BB50E1C000E for ; Fri, 3 Mar 2023 14:36:12 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=djGddxHu; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677854174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RNF7tIvXrJlST0kgsjuf3CReNXFRNJwUAA+6JXLdxxA=; b=ZNTGRXuqAhvViHkTVVfg/0vb2aAVCmu271Q4pepncCvyxKr5VRKUASfAj7b61ZkQow3FJo tnsB7JPdlWN8J7+2mqYdkAkO8n6ufrYyWhITRFv3mJRrsfcSppjiekIAW9WhH9GDkRoLfa SWwh4KUdBgW5M3Y9QTSW6DmTUkVma9g= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=djGddxHu; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677854174; a=rsa-sha256; cv=none; b=TIjox3nUpL01A3D9gmo2fckhlLQT3ErdgSATsHHyzwTkJFkgvSKIYIccS9qPlpHwRSD6wi YNvWxychiJyvkv6rSZE60cilMBmK0bXp7nW807RdwgmUojx4kufaJidDdRrQUQBI/Hwd03 MxvUvh/JoiRwVwSmbvb/ZwJ3uG6TgYE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RNF7tIvXrJlST0kgsjuf3CReNXFRNJwUAA+6JXLdxxA=; b=djGddxHuTTz+lnBhzse5Zv9A6R 4PE0Mf/b99KsEleETaVhuWyZV2GcBmsT9v2DM53l92xwzgApSh6dpsxAwy2Bxr3LHJrgvFy30Adk+ OWSw7vMzkwamYU8ABPIb0zM9hEU7xzmYK64QNUQD5xb5wlT9yVMNCePKbbOP61+lo8yTXn1w24Asn IeYo3RoAM6MBuTun6GrSJSXG4N2gTnAW7y6ctc4oxGMB5hYzhTPGJC4mIjYRxucl4/+6sdewQ4PNg 7a4wmrbtS6ajDcUQecqWOH+lkuoZzeOy7SWvNAj9o63WSefpjgLaeXO9zqvNRwIbLygVV7VGRy0r3 v4c81f4g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY6W2-003BLG-H2; Fri, 03 Mar 2023 14:36:10 +0000 Date: Fri, 3 Mar 2023 14:36:10 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Subject: Re: [PATCH v3 11/34] ia64: Implement the new page table range API Message-ID: References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BB50E1C000E X-Rspam-User: X-Stat-Signature: yxisg1xomfmmurks4cp7xs9zco8tkhu6 X-HE-Tag: 1677854172-437561 X-HE-Meta: U2FsdGVkX18U2ZwviNzPzWldnS6tPWBODgM6PhQy+zx4SmmPvMjSK+RlUTzpKOjOlobgA4U7f1hDg1u9p0Ig/S7X8sM34vBTtOXbUuW9VB09DYo2bUXRIMhNMvacs0atoylG8/SF62mKqgjrPToBCSpCOpI+TLZaXcehd/q8Q94efoAF39J3XeTPWs1ASN79HPL4CpLtFhAohdED0xfSJJuvb+h/FnWB5ZhocC3niduCjPZkv/1ZOd3LDBX/phKuWA7yisoQgmxJK5nKFilromiJLS5bgBJAhu0nIeLHXY2OwKrtYByPzQFzwNqofP9lPc7CsurPNettd/jd8k8w8NX8K/A/ZVwVZshG1qQWqfPlwePQe22rHuHPAk6VDIf7LqBQN94aDBoWOt5QkoZFMTA1boynKYbwc6mpMLQk4IdvqeEaXhps0qVlEqbM3Y+3yRA5wA7qrofz4bA0guTfALUYbIlh6kvZcC73zYl3lTQ6a9+uWryEF3sBdiq67+hB16ay0dkCJgydA5vEJjlugJbDS5BI4NP8Urpw6muQkn7FJUWzusWPEJ5I+U1r63l+gOOsW7SF+YOYCBslZLM+om9gIx3BUed2aDV5BEqWHUWH0zIK+6G258uxtNQs/Hi5ZI8daT83ZK+Qmq3Oah1y0f22HHxPF7JRh2df2c+Kk1B4QwrYLZcnGycwteBd1ThryPE9NZg3PgyiSCjYo92x1ybv2NOIKQGFxSfQmYkh2bB2GveSF5ia5dOQlrkEfI64ZVaxo1d0Hz+0zKSs60OlJLm29Aq8dSXTpUO3B5xpadKqgs0/XV22oAU6v4WWRS0OrDV6OkcQfB2n2VqUxzb308605rcv9HcMVWCs3FwU8wRc65aHQw+iwc1KAcONVRWwVCeSrp0lsz/IwGcb1V2kFQNlwXwQp3Av0S6HNZKweE7Sj1wNwPM0HyrT+8gMn4/ueWbzqHgkeFh5bGfxO+d WfiYvAYN 6sR5wPGx2I8XsR/gBIdoO0/9i3YMq0T8ZodKV/gyS+DjqqBrDHI4sOE6tRG8FxG/iWCsqCR8TLykU9weG2ttsFKal3nnvCF8ARsV7bGWt+M+l/Z9w2rTGBSmT9ypjnSGio4evrn/LZmVFUNitcaDzw4k9dw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 03, 2023 at 01:56:36PM +0200, Mike Rapoport wrote: > On Tue, Feb 28, 2023 at 09:37:14PM +0000, Matthew Wilcox (Oracle) wrote: > > void arch_dma_mark_clean(phys_addr_t paddr, size_t size) > > { > > - unsigned long pfn = PHYS_PFN(paddr); > > + struct folio *folio = page_folio(phys_to_page(paddr)); > > + ssize_t left = size; > > + size_t offset = offset_in_folio(folio, paddr); > > Build of defconfig failed miserably for me without this: > > diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c > index 12aef25944aa..0775e7870257 100644 > --- a/arch/ia64/mm/init.c > +++ b/arch/ia64/mm/init.c > @@ -69,7 +69,8 @@ __ia64_sync_icache_dcache (pte_t pte) > */ > void arch_dma_mark_clean(phys_addr_t paddr, size_t size) > { > - struct folio *folio = page_folio(phys_to_page(paddr)); > + unsigned long pfn = __phys_to_pfn(paddr); > + struct folio *folio = page_folio(pfn_to_page(pfn)); Huh, TIL that only some architectures have phys_to_page(). Thanks. I'm going to use PHYS_PFN instead of __phys_to_pfn just to reduce the diff.