From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87B4C7EE2F for ; Fri, 3 Mar 2023 10:34:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A6FA6B0074; Fri, 3 Mar 2023 05:34:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 456F26B0075; Fri, 3 Mar 2023 05:34:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31E9E6B0078; Fri, 3 Mar 2023 05:34:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2178E6B0074 for ; Fri, 3 Mar 2023 05:34:13 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EC0CC8099F for ; Fri, 3 Mar 2023 10:34:12 +0000 (UTC) X-FDA: 80527227144.30.FFDAFDF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf24.hostedemail.com (Postfix) with ESMTP id 32043180019 for ; Fri, 3 Mar 2023 10:34:10 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="PFQVdQ5/"; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677839651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T1Tkn+kx6S9N6uy+PK/LA7YHLawPtZR5S9bwGnIJqNQ=; b=3vISOiMLluGJY/wiUTh1rkCN24AQK0PKS+yXG91TgyC//d3FNZsdWN+V+X6G1ScPsMDj3r w7W4JGZW5eZMHNNZTSIAw81zPtjY4Bz4sDdQam91V0HQ5+iukqp/zUDFFjYeqXSu7UmJls N7ZbYPTx/VlfDfJJjBzAkFnKG7gWtuA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="PFQVdQ5/"; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677839651; a=rsa-sha256; cv=none; b=qbNGDkn6qvhD3EYJmVw9AWIVM3GBimCgL0YfH3Ebh77Cc5Z4LLlsZbbQSMbvftxx08Fx9M EeTDki7CNgVXak9wtYmh6kD9mac2swhe6S94LjDYLuf3SeVGQGtci1qtIUQCVtmMMllVrf ZaMkP4qZsykMS2uhukMPurqZLlyw9Cs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5257CB817C0; Fri, 3 Mar 2023 10:34:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52BF8C433EF; Fri, 3 Mar 2023 10:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677839648; bh=XKj25EOwdMQ/e4nJyVZY9U2p6+v/6uaMPztAGk8sI44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PFQVdQ5/nUJ1aYxf3f9wyV08jeot6+gIuwrVHyhxveL2saZ8afYaTpmnSkOP8jlae 8pctxGHg3RoQdj35MmDA4D8uZ5jYplxx1gIaIS2thfzGTTmZJwlrdi2lgdT5noOuNv Ym5lO1lx8MgqIDooD6yjnQzh3pnT/OePZl7rKVeXKDrnvKpYtc4zBsJeQdECjY9bWy Qm2Rp0lmnF3AgJjC/06Y61owRlWGk0xKqjW5JpORgCkTDczyJad/vrXy606d7jWM+Y noWlFsFRHzvdK48dgLKC17enu3IaWTCDd5TcR5D19ZDDmMzvPgFiLAhVTkM0Gmn3bV vSTvHWkVgmnvw== Date: Fri, 3 Mar 2023 12:33:55 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/34] mm: Add folio_flush_mapping() Message-ID: References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230228213738.272178-4-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 32043180019 X-Stat-Signature: q48nj6bzbpir1zs9d6r4ozie9xiuz65a X-HE-Tag: 1677839650-36228 X-HE-Meta: U2FsdGVkX19NG+P9XOQmsKO2fePKcAQ79e+dxl9DdiqNoWdYRVg2o+01Lxhs1hlgWOyPAscfLqdfwhRwF39Wbmx28sIpcKB+SiTTs6qWZmk67d3SCpPXKa8fSFv1SH6KExKQwQFQ5Fq+jo9LaLGv34ylmUfcgzZ33iUB+UO0v8pPpd8A9Jg9LScSKURFoErXHX15E3A7IoOt1bw9ecG/UgBK9t0qKVxO5ozrbftXTlag43YMiExF4rfT7KTrUwHhEOUBEPmIOWkmyqI/laYULZPNWLAlPp/pnduHUdVIlMy0FKBkrzjwMqgSqiSgpn6W4HKlKpv5ax0i5TzA0fRfR+NVkvfLwoKr51E4kMKKaO0+E1SvF6rM6C+BvKRRjL59QuvwzIL+kVs/N6ZsfwJYFmIBnHdGWBGJyBjJzRCU2TvzNtugWL5LvB12/B6eiojZTqOArLrH9mNohmgiYFEip4WrYJ58/XSsleJdnI2PdCAx4AlXRRefBuHYTuSPHV7OJmlHORYvMgNbyVmc4QsVmQhfaq6B21A+Z9EbUbYsoToBTu2Fgw/Dgih9AvId+kcgPyNlMtILHTTUSzGlgoxpCfBPONIi1uAfAx8cYCAe1wusHkfGt2hNrda7t+a4qWGgxWmHPo2uZFeagDmBaPYvJrhV818hc1PCMpU7nfhYO/PnVxll6BEEGh6aHjNjRclOU9j+UolQYD1695lDjtopEXW/BNgC6gosFI9m/hmfQzMrXowjSLC3E9sSTeDOQzwAS0u9uzIYqx4GcS/6JB4wrvilzjuK34JV6GqEj5uYfVBakuE/v0wl0DJ/tAOHIDkLuLHiXUTPjAk0rdUxmW84+zoJvFkK1jj4fl5xwuogqfW2cQnrAWa1KAADc0EO5zmBM3oN4J1adKV6Xa89mmVGD3tmoGExs+x+WdAlXaZ1mkitTpmGZN32O5nJRggKdFPKTfE2DaOraf4mK6HYcmF sXHut2Pu lDUakvzqdQs28qfkYbFrgS/KyoKxnR2hw8Xb+j+H1MRTR3r9q6avxdMDP1cH9+qEkgtcrSBlfrOyWa7tUNOvSZCddiY9OvUs+xeqQfx254icl1C8XcpVZ9P+UV1GmpOLo8Fchr0u460TTsNb1iCKOaL5EBtVUfwbaU6Lawu3/UVTk9lNlX/VDG8SxSrZPCH2xRYpnbEqE2aFG/Lzb2sYnzOX2euFTiYOtp7DJoqMR0jQCttMGt7QcpXhWwO3zmhJz8NUSgqBLHw2BXjyZG9Psw5JWVD1h1kJS2I+w24wHzNFV5uD8MpJ7NlRBTElRqn1GWTdviKqX/oSNA+CzhtPZNhKMrB8LJcIjv+im+G+HpOkSl3e+7tL+o5M6jGadwR9MNJWNLQRH5PGpLnYIA1LR6KmxJSJU61DZUtNM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 28, 2023 at 09:37:06PM +0000, Matthew Wilcox (Oracle) wrote: > This is the folio equivalent of page_mapping_file(), but rename it > to make it clear that it's very different from page_file_mapping(). > Theoretically, there's nothing flush-only about it, but there are no > other users today, and I doubt there will be; it's almost always more > useful to know the swapfile's mapping or the swapcache's mapping. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 26 +++++++++++++++++++++----- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 51b75b89730e..1b1ba3d5100d 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -369,6 +369,26 @@ static inline struct address_space *folio_file_mapping(struct folio *folio) > return folio->mapping; > } > > +/** > + * folio_flush_mapping - Find the file mapping this folio belongs to. > + * @folio: The folio. > + * > + * For folios which are in the page cache, return the mapping that this > + * page belongs to. Anonymous folios return NULL, even if they're in ^ folio ? > + * the swap cache. Other kinds of folio also return NULL. > + * > + * This is ONLY used by architecture cache flushing code. If you aren't > + * writing cache flushing code, you want either folio_mapping() or > + * folio_file_mapping(). > + */ > +static inline struct address_space *folio_flush_mapping(struct folio *folio) > +{ > + if (unlikely(folio_test_swapcache(folio))) > + return NULL; > + > + return folio_mapping(folio); > +} > + > static inline struct address_space *page_file_mapping(struct page *page) > { > return folio_file_mapping(page_folio(page)); > @@ -379,11 +399,7 @@ static inline struct address_space *page_file_mapping(struct page *page) > */ > static inline struct address_space *page_mapping_file(struct page *page) > { > - struct folio *folio = page_folio(page); > - > - if (unlikely(folio_test_swapcache(folio))) > - return NULL; > - return folio_mapping(folio); > + return folio_flush_mapping(page_folio(page)); > } > > /** > -- > 2.39.1 > -- Sincerely yours, Mike.