From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55E08C678D4 for ; Fri, 3 Mar 2023 10:12:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 860726B0072; Fri, 3 Mar 2023 05:12:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E99C6B0073; Fri, 3 Mar 2023 05:12:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 689DE6B0074; Fri, 3 Mar 2023 05:12:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 536186B0072 for ; Fri, 3 Mar 2023 05:12:32 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1F2DDA0BED for ; Fri, 3 Mar 2023 10:12:32 +0000 (UTC) X-FDA: 80527172544.05.8CAD839 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 6D676A000E for ; Fri, 3 Mar 2023 10:12:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kzpbJmGq; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677838350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/P46oLsCvYOIjjSqhFc0NAAzq+hp4dQSZt9c5bEsqcA=; b=wmW6XUrTxayb4HzFPHOLG07LnktNwCVbG3XPAHGyyQXtRmgJRq9ZFo7DuUVX+u0MkMWPsE Or1tRm6bIo35AuWNy4cBWiqAufqDuCGbhEHoZf1FOR4on3zTBKvXvX8dSFxLqsY55v66eX qeFzNV5UTfEMH+2VBDx3OzPDEJlZTxw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kzpbJmGq; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677838350; a=rsa-sha256; cv=none; b=pJK68onKiefE93ZhaAJDlcYb1eRix1zDGXLhdECGhHue8sfuUcisY1zZhVasXQv+OlFgZd CZ3uPnifD8ISkImavLg0+r2rfcPpgmLxod8VBChPA8MQRkSAUt4KyZTqtKG8sUCPBk+2/G CsBPyl91Mr81ttbiHy2O45maGqdZzAw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E91E61779; Fri, 3 Mar 2023 10:12:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA015C433EF; Fri, 3 Mar 2023 10:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677838348; bh=zSP4xjwQDlAEcT4eSELsSnu2Y/RaPLRuo7VgSU9hATs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kzpbJmGqcPtZzscYVDHWsmdWQW6SKzVuhMclSOjXhPrrrIAwDMPiAAx/rOFShYwzq Kr+JfFrJVM3sl5VseW8UNnoprCOZF4ziydHLqf85WCKsuW5ubdpetFjWNhk1kjceQ3 bhVtKp5heJU7SSdumpCxpXZ4DxPncpb0+DOwv60UEDWVbMnxVyDe9Ku6WidET+QBMv awVxJrXjlg6o/Gj0+dV1JcTkX1jt4ZKdyGGUeLp3eOwRZ9GVblITo3I2c5MCzT1hIF JafFcg+3/MgdK+GAwP0v5tgNrFMnO1RvI4rGXpVra83zceVjtaPDlf64HqrQulqkBO 2y0ta9IrKc9ig== Date: Fri, 3 Mar 2023 12:12:14 +0200 From: Mike Rapoport To: David Hildenbrand Cc: Anshuman Khandual , linux-mm@kvack.org, mike.kravetz@oracle.com, Jonathan Corbet , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Christophe Leroy Subject: Re: [PATCH V2] mm/debug_vm_pgtable: Replace pte_mkhuge() with arch_make_huge_pte() Message-ID: References: <20230302114845.421674-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6D676A000E X-Stat-Signature: zpe8ttxpmmdhxqu8ajzdqttt4rdkffbh X-HE-Tag: 1677838350-762546 X-HE-Meta: U2FsdGVkX193aIPq42cT2dc48GZfvud5dFhITudqYjufNHaZUrqD3GUlu4UAMmcePdP/VInq4eXx5mdAsGaDnEo8m2uR8ILFldQKmeeP8FUxbrEq8OAG0U7308kYIXvFjYvbh5bMZLrw2x8xaugAoIDMpIVH0UhyAXnFPpPBSH9p/cZ9CkfkHYrVq6anXXPKaTISqcEJeYhn+zgXperYRcBTs4DZN8E0MURbK1s4U0bv/3u09ypC3XJ2Krm7Nr/jMOqFuV5Yf/3xmNuSW+Xx8+j888pflIV1YqLWJHRueB4M5sJ4pENOaVir/BDmwh9cxHEBpPqPO3L258fVs9tc2O40I8S7CQ7zrDFhaI2KEVEveWrmWh5DEpKcrqN7J+1VuaS0KSxixhL4y3ze2iGTPNyCZszN00wNamHS9I9C624p6V/+1RXYRlylf+NKu7ccNQDPIs66gEl7N851S10L+D5zSE/n1QuHmUKdaK3Q1ebmDdZWvrSYaXXSAt4p7idGYZVnDLNwbNgBouY4hchb5e4neMLaLk+wl0jeb0WhmmFWihCfVAenyuIldZNqU7nbyDrNmwVY47q8+2ypre1m8005de4UOTmNP0UGkc0rNCFhsjfX6gQLgI5laAdIW4Ma5xRQzBwzxDf5vSv+c41U8UmABb1LrcUDHh2gcAWS3+dDhMgzbK9CK5PB1mGDvvSGrj5s7yZ+zuXpNocF83JYxitHinHfQO0SBaVnlj8AR+Shi+eSlzGOBUr3FyMgy+JEnsvIvl40d0qYS0fcx3ZTnHhdPE25urouxnrKIcNIfiSRNvXa7OdMBy1enJ112ifkch9SCjsMy3Dpfa8bjoxwUyb8xeBEYr6UsH1HTo0d+aAdnfL6Mb0M+gHaWBY/1zSI6jTDGl8j8R8FBwC0vMuaaJFu7ltJdZSGMQl2OWQuu38OOhzE9TMyxcl0VKjX/hslGleQp0Sfd4Vi5V2LxUX JWW0tyYj /KRVO6WxzBM33RYkZNjCxWY32jrwT8VAkhYymXYybCV5SLXjwC6X5DZfOOLkUofT3a3WCc+Wa7NRuuXhxa0kUxz4+Ue9rN4CcKse1ab+hHalVhS6ntmMAi48IIhjIeCxf6r031T7g4Jc31jN1Z6H+gAx/s3aTUXKAS78GFX3IPCnh3q1/xQP26RRlH7bg0i/QPG/JI/KzT8uNu/ELZvtqO8QHrCRaJjxOaQFcP/FFrsJul1bVtvLJz/7AFxRvRLMOaW/X0tqq4uWS/HuKv+plfR+tDRZ3xkEy4loogmnnaCtljBf3+hN8Jj4fykyLoS1Nz7tLr8o4BXEV6bp8kSL/EvTI4+P16A1B76qS9ew8ooXDWVIqRqTBG2rcRFoA/vZrP0V0CsjIQv2bq6vE5KOHPh3S3hUMAkswmY2EdLmX7x6fv/r/M3O0WgXt1QsfhEWq/XCTVTFzJxPTQQCdk25c9aaTMVN8LbeBv5IzWt9x+jt/TfO/V2St/KCH6QWIwrrzJAiC1oS7ExFHgrqAQxt/YA1qaOBk3N4+ut1wIPIWFNBdKWkJ1UEAteWd/yl8/kMbDnpddwuMJPbxSpbaZeOEDcaaLOaGHesWJXFxatzvyT3haQWvS/aIV6R/HjzJ2N3fBwoevmJBSA7zE05bJ1sQX7QAuUn6qp0O+bOiaH2z153EMNmSCg92edD4OxK86+NYu6HfJj7XCpEc8y8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 02, 2023 at 01:42:21PM +0100, David Hildenbrand wrote: > On 02.03.23 12:48, Anshuman Khandual wrote: > > Since the following commit arch_make_huge_pte() should be used directly in > > generic memory subsystem as a platform provided page table helper, instead > > of pte_mkhuge(). Change hugetlb_basic_tests() to call arch_make_huge_pte() > > directly, and update its relevant documentation entry as required. > > > > 'commit 16785bd77431 ("mm: merge pte_mkhuge() call into arch_make_huge_pte()")' > > > > Cc: Jonathan Corbet > > Cc: Andrew Morton > > Cc: "Mike Rapoport (IBM)" > > Cc: linux-doc@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-mm@kvack.org > > Reported-by: Christophe Leroy > > Link: https://lore.kernel.org/all/1ea45095-0926-a56a-a273-816709e9075e@csgroup.eu/ > > Signed-off-by: Anshuman Khandual > > --- > > This applies on latest mainline. > > > > Changes in V2: > > > > - Send PMD_SHIFT and VM_ACCESS_FLAGS as arguments for arch_make_huge_pte() > > Changes in V1: > > > > https://lore.kernel.org/all/20230302031833.360679-1-anshuman.khandual@arm.com/ > > > > Documentation/mm/arch_pgtable_helpers.rst | 2 +- > > mm/debug_vm_pgtable.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/mm/arch_pgtable_helpers.rst b/Documentation/mm/arch_pgtable_helpers.rst > > index 30d9a09f01f4..af3891f895b0 100644 > > --- a/Documentation/mm/arch_pgtable_helpers.rst > > +++ b/Documentation/mm/arch_pgtable_helpers.rst > > @@ -214,7 +214,7 @@ HugeTLB Page Table Helpers > > +---------------------------+--------------------------------------------------+ > > | pte_huge | Tests a HugeTLB | > > +---------------------------+--------------------------------------------------+ > > -| pte_mkhuge | Creates a HugeTLB | > > +| arch_make_huge_pte | Creates a HugeTLB | > > +---------------------------+--------------------------------------------------+ > > | huge_pte_dirty | Tests a dirty HugeTLB | > > +---------------------------+--------------------------------------------------+ > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > > index af59cc7bd307..7887cc2b75bf 100644 > > --- a/mm/debug_vm_pgtable.c > > +++ b/mm/debug_vm_pgtable.c > > @@ -934,7 +934,7 @@ static void __init hugetlb_basic_tests(struct pgtable_debug_args *args) > > #ifdef CONFIG_ARCH_WANT_GENERAL_HUGETLB > > pte = pfn_pte(args->fixed_pmd_pfn, args->page_prot); > > - WARN_ON(!pte_huge(pte_mkhuge(pte))); > > + WARN_ON(!pte_huge(arch_make_huge_pte(pte, PMD_SHIFT, VM_ACCESS_FLAGS))); > > #endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */ > > } > > #else /* !CONFIG_HUGETLB_PAGE */ > > > IMHO, it's a bit weird that we are starting to call these things "arch_*". > PTE operations like these are already mostly arch-specific helpers with > custom implementations (and some generic ones in asm-generic as a fallback). Yeah, probably a better name for arch_make_huge_pte() would have been pte_make_huge() > So this one certainly sticks out now ... anyhow, change itself LGTM ... > > -- > Thanks, > > David / dhildenb > -- Sincerely yours, Mike.