From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45357C678D4 for ; Fri, 3 Mar 2023 14:02:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D391E6B0072; Fri, 3 Mar 2023 09:02:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE8DE6B0073; Fri, 3 Mar 2023 09:02:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB1A86B0074; Fri, 3 Mar 2023 09:02:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AD7626B0072 for ; Fri, 3 Mar 2023 09:02:22 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7B4EC1A128D for ; Fri, 3 Mar 2023 14:02:22 +0000 (UTC) X-FDA: 80527751724.05.D3DA24D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 4F9ED140032 for ; Fri, 3 Mar 2023 14:02:16 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aW4ocQYB; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677852136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SwtVvAPfWaolDSl1+PvVMCt8lh4Ccp4besMQj+o4Tho=; b=6Eaz1GQwrG5pAn24PfQfQPfUzvrR/n7LqnghROP2UjIrXQVOGRC24jg6V1vnzG6d7tDohY +Nx0HpJamDRYlA7qv9liPbfd6cexirR+g6bmt7l3iT0vLWVwTekvI6wtPLwK8JwE+AECaF SUatqNIbn3KaGFFdwW0WXyQND12UroE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aW4ocQYB; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677852137; a=rsa-sha256; cv=none; b=yJaP1CwHhkUEAHhdkgG7OT/iwTSgGeHG9S1WOXdRr8xOGW+OgBntP0J86YxR5w3FYZ9DL8 EfZ4vdkCRqzzGwN4+NFv3tfyyUWU64B5nLAOjCqtxBwYjuVZT7HxoJ/LUnKKCPQ3o0mGLj DAc4yZcf9ycARhziNz4Lk8IpFsGcaAk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E82C6181D; Fri, 3 Mar 2023 14:02:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4F1AC433EF; Fri, 3 Mar 2023 14:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677852134; bh=D2lATwcmN4e22YZ5aHLO1Pv+OgVSoP6nsGri2C6eY78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aW4ocQYBp4uogb72z4sv47K6g3fT9l+F4mRbGdRLzIKGvY21PnFHBkN13xd1wWH85 3Au16CfOJrrkSmTPBoGE3q2RFFf/mC1S2lfOAZ4U7pyMUpK/qT9T5nMMmGIcjE5V7r ilBNJZQmYAm+inSqsXGSVMxGH11OnAx1qp2xzqCwDgYPR4VcV4n0ryrN4FPDG9IFwp ZA2qUwhmgYHDzNWMPyjZsa0+fog7PVxQ5yh3usUCzseq2o4nKCU0BxgxBdWxZJJWMX tAczGM5E7R94IVlsjyhupZCDS3aGxmeGrwEkUc2dGN6DQJ3NDEMZfR5AKQc3eXHHVk A9dcEcS52Lvlw== Date: Fri, 3 Mar 2023 16:02:01 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 30/34] mm: Use flush_icache_pages() in do_set_pmd() Message-ID: References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-31-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230228213738.272178-31-willy@infradead.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4F9ED140032 X-Stat-Signature: 5bedsr17jiw736pj1suaegjw4ntq9oak X-Rspam-User: X-HE-Tag: 1677852136-942943 X-HE-Meta: U2FsdGVkX196eb+yBtwH7CD/MH1vh0bnjWyVIsqUvnuuuXymn939lmen0/gBMVAHrpY6fh2yCP5kiajCPzgnfjiUKAx8WQNAGJLXlRwCDDx2zPM19SK0dxV9dZ5Av9+AA2lUrtmU9xuLCos8N1fSmcK3rX5AIBoC3V5qH8T70FkRJKR7tY7wEJHAmcc3VNCZRKirsAqJygOV8xLWNhaAEfEH0J7W26JLs++CrkUr0K58DSxRsHEL1fxh+3dfzf4dFIBJsgXXrmxOqdi2TUL/L4jb5YhpYTIWz2bUFTP+jrx6fPvE/+BuX3l0+6MoZWu1YO57WTELYbmXavEZyoUr5jAz9x5fXefcYjo4mHycwDKgXdRUckuWCtWoyXS5kolYlI0msTZWu674Jvwmpi7CPxH6NYftTv7jJiKa10vfkCbUHK4C47MkQOanMjoADGUaoRBm2lyTgi86251NoU+QemUTsbQ6lNUlRstvh1Zs/aVpqBzBn0sp1eAoHMXC1BksEYr7RNxhiGRyN04wH00SeXCFPMpzpOapd5fSSgIkIAPpV3YuiJOglfFViglLjBEoe3DPPS6IkO3qdYJn3b2FtWa5PiYzjLzkahrj0pi3GS7oRcBFX9q0xYt87gBuanTlLrYvUC+tV9PlkmI1F28Kbllb78rmcF8Nw1dxRzcCw5FgNvj+Iwak1Su4yXcTkku7nG1N6qxuRARLPE7NoQC90V5sQHOxrmL0vigsIFcBqEF5JhdXy1Tx/1IbhSfZWXvuq/ujLo6/p6bmpEp4Tx1XOLPB+jZ3KBHJorS0QncQKh0tcLYjqY0yk4qiWkMlAgd0ot6tPJBYUQHrFUD8S6zTqaZV3OG+PLpxEL4q/KoyiXVheGW+4GBzxhLbUvU6BkK70JOrPDZJRCWM80czt4Bwe2sN56KONrk6kxcEoGtox0VropcVoR7un3LgHWXOgiY+L8pp7a9Xs1xVrsd+NNk OCxhSzV6 YnItO3b7dRvYhlwYdv6uFYvKOLs7B5NGWN47/GqXdf2YqaCibwqbrThwKLnYXgM88vK7lsZTo7rII7lCyDcpx1O0E6rcfUVJJ3EjLp8ynFMeAsWV/UBalpDlNkNVYBG+BSHgweDjmt1FQ1q/k+oEmg5336p3OW1oEn4TU+xdJHKssYB0X7d0xdHoztd69iKJIHBfvp1K/8VtThOZA0rfN7mecX4sRp4elqYbBUOqs/pXnhxuuNiQmN5q7BvPQZgnS1Twx5KTYFa+J/lJCP8HpR3N09stDF1vcEizlzmeR3wQ9M/cDyxFBM6KpU8FozJVKpBYFqg7o19hi7ixlBe6vp+x9KxtaW1s/+ebgU2hzPme1pgZVruFxfRVv8cIbhLeoB+u+vA1rNK3+s6mF0C7HD0rZ0xfwPB8lmFPe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 28, 2023 at 09:37:33PM +0000, Matthew Wilcox (Oracle) wrote: > Push the iteration over each page down to the architectures (many > can flush the entire THP without iteration). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/memory.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index bfa3100ec5a3..69e844d5f75c 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4222,8 +4222,7 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) > if (unlikely(!pmd_none(*vmf->pmd))) > goto out; > > - for (i = 0; i < HPAGE_PMD_NR; i++) > - flush_icache_page(vma, page + i); > + flush_icache_pages(vma, page, HPAGE_PMD_NR); > > entry = mk_huge_pmd(page, vma->vm_page_prot); > if (write) > -- > 2.39.1 I get this: CC mm/memory.o /home/mike/git/linux/mm/memory.c: In function 'do_set_pmd': /home/mike/git/linux/mm/memory.c:4191:13: warning: unused variable 'i' [-Wunused-variable] 4191 | int i; | ^ And the patch here makes it go away: diff --git a/mm/memory.c b/mm/memory.c index cc7845ff09ba..c359fb8643e5 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4188,7 +4188,6 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) bool write = vmf->flags & FAULT_FLAG_WRITE; unsigned long haddr = vmf->address & HPAGE_PMD_MASK; pmd_t entry; - int i; vm_fault_t ret = VM_FAULT_FALLBACK; if (!transhuge_vma_suitable(vma, haddr)) -- Sincerely yours, Mike.