From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC239C6FA8E for ; Thu, 2 Mar 2023 22:32:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 679506B0072; Thu, 2 Mar 2023 17:32:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 629386B0073; Thu, 2 Mar 2023 17:32:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 518D16B0074; Thu, 2 Mar 2023 17:32:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 40C946B0072 for ; Thu, 2 Mar 2023 17:32:55 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1DCE9C0844 for ; Thu, 2 Mar 2023 22:32:55 +0000 (UTC) X-FDA: 80525409510.03.0449244 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 10F2B1C0002 for ; Thu, 2 Mar 2023 22:32:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNhf0xhS; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677796373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wEn2MpA7p6zktO3lvlB6/EyreWsKvVgm3mI9NlrG6Hs=; b=TL3Y3MSCOjdOAH9FIHTW8G0xm0pTS4mzpvP25qzqQozazJrjrYpwuw2pJRh0fH77ooUtRl rMdxbQRi7f+e28xau6ZhknLijWQhtnXIXc1H//hIfAirbKuI4M2Avr5iNyM9Yod2bNw7Th NogNyCTreLV08QQA3Oe6X1QgDU6QWao= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNhf0xhS; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677796373; a=rsa-sha256; cv=none; b=vvVEHulIFSoLOU9qu17jXe1KwwzouHmBWcPJRx0b8cUUvVjmMw/j+uC72v/tSqc3/dRlKI HbNV8ushVporCZ/UXHC4hExhMlEQfwL5Ze7fclucmG6lAhX55jYMlh8/GQRfbCnc1apO24 M5RyBKGr7pTanu/iGU69MhyfUQxisEc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677796372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wEn2MpA7p6zktO3lvlB6/EyreWsKvVgm3mI9NlrG6Hs=; b=MNhf0xhSUVdiYSp4K6wl79ZOMf+QRR5yitX7Ipiymjvrf/4JEyet+oqWYwjj0XtzimGxwV Sal4k5JrHkRspi+eG1+tdyvDYhjMK7smK4ho1IXRRxWxTgrBnJWotSCsVy7KkP+edjKRTg uOC+4wPL2smapTpgNlPnO7wojRFKiZA= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-575-G3r2iYT4NeKSdlfzVezLhw-1; Thu, 02 Mar 2023 17:32:51 -0500 X-MC-Unique: G3r2iYT4NeKSdlfzVezLhw-1 Received: by mail-qk1-f200.google.com with SMTP id d72-20020ae9ef4b000000b0072db6346c39so283067qkg.16 for ; Thu, 02 Mar 2023 14:32:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677796371; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wEn2MpA7p6zktO3lvlB6/EyreWsKvVgm3mI9NlrG6Hs=; b=hStqZQ3QkHKPvNuo4nYMu7HIbH/hhEGp+hOr3TD6NpvNAas4pUp+IzbAMfTj2P76mJ v41pYUm6gOGVPlj7xw6ihO/ALRUePOmHlmVlOl9XpfGaX7zkyWw5CUdm4HnkbEXlvvOS AgC8P46+Uv2eAOkc/fK+/uQgrjtkN/0aUC0lHrPB6LsMO9w7OLJqgh/jxDVU1aklltE3 IzRqM5TxVMT5ieJK3MjSbGsKgy2SekLkyyMEmqkEx529Zb9pI5jCKqvUD4PbSZvYtWXN Z62zJP+nTDnWg7QCrO8mJx9y6VFM9+X//X8U8vHSsy+ApNJq9QTSWK91XeEJhk0vkPHj pLoA== X-Gm-Message-State: AO0yUKVmgnBj7/x1eKkUE3LCjyIE7G5gfX3WEyiEp09BPzZ0a9ZdloP6 +t0BnnHWIPv5W2wUP4GVv7aZXF1ZeiUXvs6SbmnNNzCu8gv+5Uyto+JUXpal+uPx5KIxNPvKcsw cHrjlLZARDPY= X-Received: by 2002:a05:622a:34d:b0:3bf:d71e:5b08 with SMTP id r13-20020a05622a034d00b003bfd71e5b08mr22871081qtw.3.1677796370800; Thu, 02 Mar 2023 14:32:50 -0800 (PST) X-Google-Smtp-Source: AK7set+TPwvYbDcJf1DhJuI5EDnyoIv2/ltKJZAapCZu0h7yWl5Ber6Ev+UUzrhTJaqq0QNzi05a5Q== X-Received: by 2002:a05:622a:34d:b0:3bf:d71e:5b08 with SMTP id r13-20020a05622a034d00b003bfd71e5b08mr22871057qtw.3.1677796370558; Thu, 02 Mar 2023 14:32:50 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id 29-20020a05620a049d00b00741a984943fsm538443qkr.40.2023.03.02.14.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 14:32:50 -0800 (PST) Date: Thu, 2 Mar 2023 17:32:48 -0500 From: Peter Xu To: James Houghton Cc: Andrew Morton , David Hildenbrand , Axel Rasmussen , Anish Moorthy , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: teach mincore_hugetlb about pte markers Message-ID: References: <20230302222404.175303-1-jthoughton@google.com> MIME-Version: 1.0 In-Reply-To: <20230302222404.175303-1-jthoughton@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 10F2B1C0002 X-Stat-Signature: y8u8x8qtmu45orjfui393w7zozibgrun X-Rspam-User: X-HE-Tag: 1677796372-809893 X-HE-Meta: U2FsdGVkX18X0QFeTFNWkmGA23V9GLqsuqv+hV4YMLEOQMjZsHNmdiTpBGHfhgn1F1mf2Xv4WAuCqshXxJxF+Qtnb3yfj+nEPYR0L1/lUxYtdODX8+TXsi5Gy/B5POUz4HLQkoLS+ULnlwxSwoA7VA+WXSzs/ALGoUlk5ankyZLlYZ7NjLWRpRh1TKYVEoo3Pc/OSYj8anYg80O7ASXKgCyyVMkw2ldkKz8G38F5hGfugK4CBRJIXi4nm5zm6zhnzT/Ee3RlTr8NEro7SqpyFMMnix9SxxyJEmx6j4isGjC5D+yVXgrhr3z/VXb6Ipf6ib9/aPC24RDsxuCxc4FLFUMvss2/OFBvjVNWbo4aYxxwRPWbpt+0W/E6+UERHrv5nuUmlxdBpDr+h6MMftH53mkZxwfdXBMI3sSfy7+c/b3X4EnY1hsSdPJViFrSMCy+ktsb4TvgkMUKJpkEAnCiJsPJCUt5y3ta8HOmuhDsyaDy+9pkzNVb1/Okf2ATDh6CLzRNEVS0WCFHWLiJN1adpDbH5fggtfQMei6bL/MnXFLg7eNs3JmHrk6zHzJ743ldkMRSdUNWEA0CXLY8ErNFW/XCmLADhRw7TbzNDistTWi/iIz3R4GdvD5zRtZCyWSJjkmUV9PB2BHSOpae17gE9xn4rPqGEvh41d0uNM7m8tf0xFu7HM4qN/27jS7t6Yf5ezEOqkuA8nzzaUrrrBZK1g00fS/SfHbpnL4GXPb7de4yYN2qN/pcmr+eH+zBiSWrtLkXUfi0RwGEbnl+u98lklrFDPAtNAUrXa5iFJQhslfa/1psIwM/SmliUZ2TgKPNhqwFS/J0t3NdOJnEr2pR45iraVq3TeJNXb/Gng14tfPkX3p15cjfU31bsSKys0I6q3SJanfRekbiArBW9qoDCrcUl186Pr7hURnm0Gb0o/aoWZKcYc4AWXjjepmTFyRIxT5IVs9URCZed1rWFy8 YJKh5Yaf 35iHZeiBW+uKdyyjpzeELNd5oiLAnBuwl6SAcGzKwFzG/SLncnypFplAgMeTKjyihh1jo66Pu9rWNB69wpuWfNy5b1/biSB9NPdXTsj9rKCYQQ5Ok/oYiqwHJWQEzS6tXXv6+B2kyJ17RHHfRySVWmRl1FMg0Vjxyx9DU21mzQqiZTvIvawtMShDAZtjg5N175OvI5ucYlx0SJ6TKXBomPuus4nXJdbPrREzpqT36vXzEcD7OPooQkDkP2+JSQq74ba2xr9h3zG7/KVi3sdKf8ulyFXNMRhchsjRGtfbKnIdOmEPBUECNT145kOCX2ga2s9JRG4ch0Gvilir7WmBn4jJ3IfY/2Fav64YSVifntlulQc3HbHyc7l1RbdylDHoZuW2EGY3IWMHfnHKehWR8eUNF0xjzmCwdxjdSrY5hgUbBT8iUrXxvLPxFZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.012413, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 02, 2023 at 10:24:04PM +0000, James Houghton wrote: > By checking huge_pte_none(), we incorrectly classify PTE markers as > "present". Instead, check huge_pte_none_mostly(), classifying PTE > markers the same as if the PTE were completely blank. > > PTE markers, unlike other kinds of swap entries, don't reference any > physical page and don't indicate that a physical page was mapped > previously. As such, treat them as non-present for the sake of > mincore(). > > Fixes: 5c041f5d1f23 ("mm: teach core mm about pte markers") > Signed-off-by: James Houghton Acked-by: Peter Xu Thanks, James. -- Peter Xu