From: Peter Xu <peterx@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Christoph Lameter <cl@linux.com>,
Aaron Tomlin <atomlin@atomlin.com>,
Frederic Weisbecker <frederic@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 10/11] mm/vmstat: switch vmstat shepherd to flush per-CPU counters remotely
Date: Thu, 2 Mar 2023 16:30:41 -0500 [thread overview]
Message-ID: <ZAEVge3W3bL+GNtx@x1n> (raw)
In-Reply-To: <ZAESOs/EeMCNp7YX@tpad>
On Thu, Mar 02, 2023 at 06:16:42PM -0300, Marcelo Tosatti wrote:
> On Thu, Mar 02, 2023 at 04:01:07PM -0500, Peter Xu wrote:
> > On Thu, Feb 09, 2023 at 12:02:00PM -0300, Marcelo Tosatti wrote:
> > > +#ifdef CONFIG_HAVE_CMPXCHG_LOCAL
> > > +/* Flush counters remotely if CPU uses cmpxchg to update its per-CPU counters */
> > > +static void vmstat_shepherd(struct work_struct *w)
> > > +{
> > > + int cpu;
> > > +
> > > + cpus_read_lock();
> > > + for_each_online_cpu(cpu) {
> > > + cpu_vm_stats_fold(cpu);
> >
> > Nitpick: IIUC this line is the only change with CONFIG_HAVE_CMPXCHG_LOCAL
> > to replace the queuing. Would it be cleaner to move the ifdef into
> > vmstat_shepherd, then, and keep the common logic?
>
> https://lore.kernel.org/lkml/20221223144150.GA79369@lothringen/
:-)
[...]
> So it seems the current separation is quite readable
> (unless you have a suggestion).
No, feel free to ignore any of my nitpicks when you don't think proper. :)
Keeping it is fine to me.
--
Peter Xu
next prev parent reply other threads:[~2023-03-02 21:30 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 15:01 [PATCH v2 00/11] fold per-CPU vmstats remotely Marcelo Tosatti
2023-02-09 15:01 ` [PATCH v2 01/11] mm/vmstat: remove remote node draining Marcelo Tosatti
2023-02-28 15:53 ` David Hildenbrand
2023-02-28 19:36 ` Marcelo Tosatti
2023-03-02 10:10 ` David Hildenbrand
2023-03-21 15:20 ` Mel Gorman
2023-03-21 17:31 ` Marcelo Tosatti
2023-03-02 17:21 ` Peter Xu
2023-03-02 17:27 ` Peter Xu
2023-03-02 19:17 ` Marcelo Tosatti
2023-03-02 18:56 ` Marcelo Tosatti
2023-02-09 15:01 ` [PATCH v2 02/11] this_cpu_cmpxchg: ARM64: switch this_cpu_cmpxchg to locked, add _local function Marcelo Tosatti
2023-03-02 10:42 ` David Hildenbrand
2023-03-02 10:51 ` David Hildenbrand
2023-03-02 14:32 ` Marcelo Tosatti
2023-03-02 20:53 ` Peter Xu
2023-03-02 21:04 ` Marcelo Tosatti
2023-03-02 21:25 ` Peter Xu
2023-03-03 15:39 ` Marcelo Tosatti
2023-03-03 15:47 ` Marcelo Tosatti
2023-03-15 23:56 ` Christoph Lameter
2023-03-16 10:54 ` Marcelo Tosatti
2023-02-09 15:01 ` [PATCH v2 03/11] this_cpu_cmpxchg: loongarch: " Marcelo Tosatti
2023-02-09 15:01 ` [PATCH v2 04/11] this_cpu_cmpxchg: S390: " Marcelo Tosatti
2023-02-09 15:01 ` [PATCH v2 05/11] this_cpu_cmpxchg: x86: " Marcelo Tosatti
2023-02-09 15:01 ` [PATCH v2 06/11] this_cpu_cmpxchg: asm-generic: " Marcelo Tosatti
2023-02-09 15:01 ` [PATCH v2 07/11] convert this_cpu_cmpxchg users to this_cpu_cmpxchg_local Marcelo Tosatti
2023-03-02 20:54 ` Peter Xu
2023-02-09 15:01 ` [PATCH v2 08/11] mm/vmstat: switch counter modification to cmpxchg Marcelo Tosatti
2023-03-02 10:47 ` David Hildenbrand
2023-03-02 14:47 ` Marcelo Tosatti
2023-03-02 16:20 ` Peter Xu
2023-03-02 19:11 ` Marcelo Tosatti
2023-03-02 20:06 ` Peter Xu
2023-02-09 15:01 ` [PATCH v2 09/11] mm/vmstat: use cmpxchg loop in cpu_vm_stats_fold Marcelo Tosatti
2023-03-01 22:57 ` Peter Xu
2023-03-02 13:55 ` Marcelo Tosatti
2023-03-02 21:19 ` Peter Xu
2023-03-03 15:17 ` Marcelo Tosatti
2023-02-09 15:02 ` [PATCH v2 10/11] mm/vmstat: switch vmstat shepherd to flush per-CPU counters remotely Marcelo Tosatti
2023-03-02 21:01 ` Peter Xu
2023-03-02 21:16 ` Marcelo Tosatti
2023-03-02 21:30 ` Peter Xu [this message]
2023-02-09 15:02 ` [PATCH v2 11/11] mm/vmstat: refresh stats remotely instead of via work item Marcelo Tosatti
2023-02-23 14:54 ` [PATCH v2 00/11] fold per-CPU vmstats remotely Marcelo Tosatti
2023-02-24 2:34 ` Hillf Danton
2023-02-27 19:41 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAEVge3W3bL+GNtx@x1n \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=cl@linux.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox