From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9AEC678D4 for ; Thu, 2 Mar 2023 20:55:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB1826B0071; Thu, 2 Mar 2023 15:55:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E62896B0073; Thu, 2 Mar 2023 15:55:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D28CD6B0074; Thu, 2 Mar 2023 15:55:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C26026B0071 for ; Thu, 2 Mar 2023 15:55:05 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9426E41033 for ; Thu, 2 Mar 2023 20:55:05 +0000 (UTC) X-FDA: 80525162970.06.7A94462 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 7B8331A0019 for ; Thu, 2 Mar 2023 20:55:03 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZqNI053S; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677790503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JFNwRi5/Kf0+dhWCteiH7bI3G3kdg4tmsNAULgUWudU=; b=VPgrUxswGYbyeIgvwwkBgQkC83MqHFD7S/umK5vvKBS+laasYetCe8f1nIJNLVpBfZwdEk HehdUIQFRrW1CmNv7Rvpp8K+v/WMyB04F5gR4HbNRMXH9muzD1zfDZWo7fV2w87fwfFe1Z muaFOxNIs3ua/ttoWMd4cWfT+wyLG/Q= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZqNI053S; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677790503; a=rsa-sha256; cv=none; b=GAigyNrQFhjHfW01phbMHmgCjd51+rAlWvIYI0JtzTxaO7WBmbyjwBsDvlbQd628sd2Cg7 YglnOYyQlZyuze2vYgBZSMYMu6bzyiDhXTpY3gcJuRZhWaoUogZQCk4aRBdjULLgvHUiJW TZw5IaKqy69ARL+o8YqQxCB1f+pFcMI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677790502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JFNwRi5/Kf0+dhWCteiH7bI3G3kdg4tmsNAULgUWudU=; b=ZqNI053Sgm1HVt0YGeJvGyR2WePOtFNJrfhE/ZDOlAdd51Hl+Mt6ut0A5H1VCsi5Uuhx25 4hesCJcBhYz6YUitXrvGBYEAPnoxZZEwxTU5zFTzvwYIQqiXiiha6FCU3vNd1c6qcDPBUk gfVKGMwlLJ4ZK1FT9GEdm+Ur9O1nziI= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-588-sSTcvyrpMiSGHxt_2_za6g-1; Thu, 02 Mar 2023 15:55:01 -0500 X-MC-Unique: sSTcvyrpMiSGHxt_2_za6g-1 Received: by mail-qv1-f70.google.com with SMTP id d27-20020a0caa1b000000b00572765a687cso287234qvb.19 for ; Thu, 02 Mar 2023 12:55:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677790501; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JFNwRi5/Kf0+dhWCteiH7bI3G3kdg4tmsNAULgUWudU=; b=Ibeeha5UXpPzAtQS0avO6mtKrVC1nWrdZfe8nQ8edovWtJH3HVyRUjlROiRaC8zl3K iqTpzGlNivEi0OHHZdN/+7pfzZIE2zdSJF61r2NIXKf6O21bymHPh8yzdB4C+JQj0i1g vKMnF4H2uO9Dq8Xn2R5LVJ2Mdw3W2Qa4WfrBwnrM+YmtdhtRbQunU7schsUOB1mWjnjP p4kRmgBxp8texTrZFG2zv/Tt7SjEFsTwlFf0WCRyL43u00XQhfVFbNMaCGR7LQpU++N5 3EJLuOSYCqtFs+KAUv6xPQXoczzTsvNOUuO0sbUn/CfxcdoBemdBlwD7+0MjrDTva0uf 1KQg== X-Gm-Message-State: AO0yUKXFsVfsRnju4hhq/4LLAxX2x2wSAhwpo/TldARAZc7c7Kh5nF/b OQOZbnhlAC33MljVPFbwR0TK9kwWmnIzpQVp1hhw1qbZ92mPRZp65E5+JViFiWCuCJ4sdUVxZVP puRhMWSP9a9w= X-Received: by 2002:ac8:580f:0:b0:3bf:daa8:cacc with SMTP id g15-20020ac8580f000000b003bfdaa8caccmr22508107qtg.3.1677790501163; Thu, 02 Mar 2023 12:55:01 -0800 (PST) X-Google-Smtp-Source: AK7set/ubbtWdRYZkqIy9VA/XhPef6Jat19o3BO5H4dq+GIJeNCcLCDeIo3yS8UHjDDuwM0qJdYPkA== X-Received: by 2002:ac8:580f:0:b0:3bf:daa8:cacc with SMTP id g15-20020ac8580f000000b003bfdaa8caccmr22508087qtg.3.1677790500922; Thu, 02 Mar 2023 12:55:00 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id z24-20020ac87cb8000000b003bfa8e1b7d1sm402654qtv.32.2023.03.02.12.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 12:55:00 -0800 (PST) Date: Thu, 2 Mar 2023 15:54:59 -0500 From: Peter Xu To: Marcelo Tosatti Cc: Christoph Lameter , Aaron Tomlin , Frederic Weisbecker , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 07/11] convert this_cpu_cmpxchg users to this_cpu_cmpxchg_local Message-ID: References: <20230209150150.380060673@redhat.com> <20230209153204.818774692@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230209153204.818774692@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: 178qhscp9oag89fjbmid7o9ha934w386 X-Rspam-User: X-Rspamd-Queue-Id: 7B8331A0019 X-Rspamd-Server: rspam06 X-HE-Tag: 1677790503-66318 X-HE-Meta: U2FsdGVkX18NlLrg21bHXvETV4eMQfp/XIqPfo7Cz164Zw8s1MlyIIFCYqY2l0aIvW4uew04ocfIfjVU/1xZdy5/3qmVEe6r2biisjjNmYReYkH/6GhdeGjJJaZ2QLQW+Pwj2/+kxh6OnEfsi/VhIJuY8mAJlW5wIeE8ToShUkbY5TlAh+SanOJpduBwq9Cn5Satye25jC9wrmkKKafs1EWITFLwDq8UaLny3bnrQ4Ik/CAxcVFrfL4R6t+xGgdU55VqLUfbMstdQLCEfxW314TVsNrNdg0UGXB4MjDur0TGgq9w53BhdIscVeicchUrH/WXmxHk0Tvxr0ExEgC1VWFD4U5xCxb6WSbAJAkDmHbW6PMOyFDSh1MhTY4GfZL2SGcmM7YhAosbaa4xfLrFnMLq8x8yFmG4P/Cve/xis4hNchOYFUEupkHgH0LVPlT8MbQc44+1Sg0aPvxnUfykBBoFV53TjvcIf74CqUfITABAtUrRHfUbr8ZnT88svmjJLQWXbn90LxnFia3n/6P5LS3PVhXLbxeVLtvzAdB5rlrLTb+2/a5FlYSHYOcwqpQF0PXql8dDcIxWep3TLHKfNl3cFU/qQvOt77KoncyGL2jNYrojk0UdeU6VOCYgWIk4Cl+Ybrs3eHZxsiaRW/Vw+bse8x5QNIBT/3Q8UYE08A72AbKztyWEwJpZF+7vZFH6wKmRnD0Ro0lORbAQX0r9a6FvuuYe1xLMCkYeBrgN+Dc0l8fyaNLQesQXm/6CU1skVrcFsYrngGGG6+jVC0gTyQjwHBBWR5ul3UC2ZVHCh6MYYRRtEaFJt6mOF39LBiBKIsUqgH6VPMrbVCJwFDUuvMEZx7KFrWz/T/xjz/TQCoh4kKWei2uqEIm1riQ88xkxW2UHIC8gWhGRzFLz9eCgB6KC3scnMDk+Xbb+Rl/fQWwuAgd+MDqTtExFxOldWyRL2sfUAXOtXPM0Sieckvc fnX9O7Qu 2QhYFDByquFgQNFh64DwVR2YcClhiUMDgZntlDZhIZFb1BE4UbjQcmdNxC1QxLccari+E9uMGMtc6V3tdLU+yzxb40WWxggvbYjCaS3jRgsY7k0/Pta4jcExMgl9n0tINA6wUswa/728aYBWasYLiVbHuSLxRMTtmDIjzNWf+lRVdaJ6FdQZlo/4qSx0qMqW8mFCXTE7EOFOeYZjlwIavcVfckQDHpidPtyUL318TQo2wW7fpMIQXaSBzZCzSn1J7LFTIPys8z9DBuBOOnSxPfnJFm8x1agzJK1ipNEHxoY30CcvRsEmX5Q/hiID+dBCX9DQ3XiCRpNi6Odg4y490iD+9RMcvjmv/W/0PfYcl2v8Sz2hEOZtGVXIMvPv3Q2brFNpvjnvTIrmHMFpHjYgTixTShBRSUOT1L+WQr8JMTp2CrjhQ2ns7WHDJi/S0UewD1MU6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 09, 2023 at 12:01:57PM -0300, Marcelo Tosatti wrote: > this_cpu_cmpxchg was modified to atomic version, which > can be more costly than non-atomic version. > > Switch users of this_cpu_cmpxchg to this_cpu_cmpxchg_local > (which preserves pre-non-atomic this_cpu_cmpxchg behaviour). > > Signed-off-by: Marcelo Tosatti Yes afaict these are the only pieces that uses the helper besides vmstat udpates. Acked-by: Peter Xu -- Peter Xu