From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81EF0C678D4 for ; Fri, 3 Mar 2023 00:20:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCCB56B0072; Thu, 2 Mar 2023 19:20:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7D156B0073; Thu, 2 Mar 2023 19:20:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C44AB6B0074; Thu, 2 Mar 2023 19:20:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B129A6B0072 for ; Thu, 2 Mar 2023 19:20:49 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 750AEAB5EE for ; Fri, 3 Mar 2023 00:20:49 +0000 (UTC) X-FDA: 80525681418.26.C3210C3 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf16.hostedemail.com (Postfix) with ESMTP id 9CC80180013 for ; Fri, 3 Mar 2023 00:20:47 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MrvVWeac; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677802847; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d09pCOgXcgV83C5wemsdhBVk0296NBI8B2AYqKA+7dU=; b=ZSLXdWDa8ElaxwObHGv2ZI7FYyKd6DZnpVmeTs6IW3m1X811dTDTbsk98LVtrQvFaZqPXQ SvTQKmLK1v6wMU7DdQuIUd3sMX4JqetQy8PzB7srB531yyb3fJLqyRI0l/M5ZmiAitrXK6 z2iydk5rW5VzJETd9sjnNo4BxORo3lU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MrvVWeac; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677802847; a=rsa-sha256; cv=none; b=hFdweWxrR+jLwCSvHdogimcLIwHRknL3k5Rjhn5KPsB+3iLPy1DXL5R2a5PVliqQLQKCBL DFjui0ujZDb4BxcK2eXkfYOMne7UWDkHp363qd5AMS5Q8Hv+eiBDM6g77Xn6Fb7iiV7Atr k9/UY3ceimOYvWNAZRukyUicuV7vmmI= Received: by mail-pl1-f174.google.com with SMTP id z2so998510plf.12 for ; Thu, 02 Mar 2023 16:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677802846; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=d09pCOgXcgV83C5wemsdhBVk0296NBI8B2AYqKA+7dU=; b=MrvVWeacOGbHYAss+0b0UfKFXAgWPUAjaSE3KrOxbvQTyXppP3i9vNMcr5+oSVq9P/ ZywpC6Z9ycWmjoGGMsHRKs8tH8muNIP8Huy6GkjYF95XZ3lHDaCZOOJ3IwyiTyG7qYa1 4OJluaibGhUA1U3lIRA+9NYvr54VMzQdojt2Yx44sK9fNgIKEw67O2tXZR05M/0aSP1J LTGl5JlcqPBGDvpCo4VGQ8j6puZp5AdnMpWbTmf1irJNE7lmIBClRKGb2g7npqGPJHZk Gn/9ZcwjtMdiyhaLdNIs3BUlDvBqxRHno9YVr5LrXBUUWupZEfk0qq0yN6KoBWdbmCC+ yTxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677802846; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d09pCOgXcgV83C5wemsdhBVk0296NBI8B2AYqKA+7dU=; b=R9ZKLTMYgLAGjRLw1/EZhcSo7zjj+2pT6DnaDgN/K6ASB+kVk1n4XOSvIZQQIdFZ/F JtrwwRwBVqJLMV5bwvXxWWNwlul2sZrrJFMJV7qM6p/Ql8RHZp8ZvwJ5jnGI/dLjt9NW liuCEx/drTyPKbSMDvKBXhmhvWyJVOCr68hXkJTVSu2a41YwWqXxeoLGh+Ur8Tj3hZnG swe3xk1W08pjsXT793ljgBTTSTdzW5lRJDU5TKxMyU70sGPzJ01Yr2EN6iL6E9CefDSl xIMUkSEFFN4LEWacACgCw4IyZQrD7Qw5zh0sYJFIjccIFJ5XdcDqurCcx8ujFhyOn31O nrSg== X-Gm-Message-State: AO0yUKWCsi6P1v/Mv9Ri2wd9PLqZcEKuOgZ0urWwiS+4Sm7PCVeZPv+P f27dd4e70/gpCDDadKN6ayM7SC4SNjw= X-Google-Smtp-Source: AK7set8vX00BwuBZA80O/1JUZspBj7SyOlV5bp212BRM7TU1Sun75OVJm6gc/CRv2RFc8HxAHSh53A== X-Received: by 2002:a05:6a20:6a1c:b0:c3:2bef:bd62 with SMTP id p28-20020a056a206a1c00b000c32befbd62mr363394pzk.1.1677802846323; Thu, 02 Mar 2023 16:20:46 -0800 (PST) Received: from google.com ([2620:15c:211:201:4036:e990:6bc4:4206]) by smtp.gmail.com with ESMTPSA id r7-20020a634407000000b005038291e5cbsm248330pga.35.2023.03.02.16.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 16:20:45 -0800 (PST) Date: Thu, 2 Mar 2023 16:20:43 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 3/6] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9CC80180013 X-Stat-Signature: 3hc8aa7cgjht4mxyoh4gnxsihmbezfhy X-HE-Tag: 1677802847-653084 X-HE-Meta: U2FsdGVkX19vGuuMF9j9UcwrCYq8mvJlPgDmO9xcj7n2oF1j4zraSrW4aosawGb2EdCn0aF3QjM24Ht9wZL6PJjqzCAbFyewZsvFgecBPP1y4nxZQlU4qIE08Nte2dLhfjY+i8i1IPnmEyFheKuS7x6Fu24a0zvtBfcuxwOhFodu5hOcuwkNIe+2w2pn1nuZj1amH59X2h1cm/ahj8gYsjhl/p2JgTdf5uNupZraRkcATkSDWaz/AknCf8b0B0JlX2ud3V9tpEvpmjE4r904yFj65sm1aggnuYzRzoS/9QS0fvIBFu/VK/I+Gj7JcJvC6k1gNXdfNVDuQmLcCuPp4onvHEHrzkCzA+qeagxR/FAADjhMv8KC6N6LsoJayJBSgNZpiw4vqNEQ5PhcaGI8N4X7eEc4i85R497Il6vIiruKdg7lnmZbqVG8QiwbVUEGhVXM1eq79NnTsSN8g2SBDuTgqy7ued9+ymRBMftI0n9aA7aMLUROMYtTrxc8mF9TheMjUT9hF/rf/HNM735chWR+AP0dvPnqfKaef9YjNb4SURmkqkK6L1CzBTnkz0XP/kYk2/GX15JQNMUKgamHL8Dv4s7eAyHnbg3oH3Mv07OfhVb2DRvCz+5fFLO8FOABhjOtm5zp+pDDmtbmBlg5KQNiRsrdagMeZU3dIFjeNSYag63H3wS8oJ80U67XI5Aisjud4BJeHT9RkksxrfjOU4X3IR11opbpeuzsmrhPVczrz79+tEpZN5lBJ40XCVUags+UdlF3ij/NrZCIYAqjRd2JEhBqn37hG/PYs2tC9PlRa3S647c+AyfucjcVRIjzdXqDQO3DGJtw+tbPYuWk3ckEf6XVxmn492xGbnAGeD9F73yZwQXXDhWka3U8eeorLWwXRhDxgwFLhGAun3NHvoKExOn43A/IUbcIAtjPa5x8Vks3cJRy0OB05prRZi203F33jz1EIB19WYb2s+Z giYcEEjq 11U/+gagXMR+lqZya7JDG/4n/Qu7wSe4SY8YCPcpEpaUAV8tz6JeWD9XjurteM+kNbGwgYj/eRFMvHQ3r+eVJuW3LJSCWEfFvwJ+T5IwkFdS/N1+303XtMbUnu635fTC51+DPpG7AC7xRqOPRIIXPGfB5+VZURah3pi11DIrTJe68CDl3+XvvDOBpk7J/U7Q/jB2BDdvtLQTGJgkXXLCYJhGOQVa5okQsNQU6zU/czkK/LpGay7dUqgF5VyZQMk2voNdtwzPrrqfaic4gkM2HcTnaBhLn/meC68rr7yK/7M8CkZ/6sHShdXFd6dxFBmavHXeKDLYmDHJUj9bl/Rn/JylC/n7uCq3rziPQqTb2s6hOWgqPewlFyTGwtPgKrSTyc1zlZdkd4asSAO2QGAVlS7TQaFLcW/3Hg20+6gLsdJVlz1oSTcZ9GOgGoyB218hRwKa4uVWrk717QdohI0ac5wuLnm1OPX6RySJHEmKZ5cswD0C30xwG2B4TFOh4khLfx87+eb9e1U4aa5n1RakJDT+ao4CMuRly8vq7aWOA3DowLZA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000203, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 02, 2023 at 09:53:03AM +0900, Sergey Senozhatsky wrote: > On (23/03/01 16:28), Minchan Kim wrote: > > On Wed, Mar 01, 2023 at 05:55:44PM +0900, Sergey Senozhatsky wrote: > > > On (23/02/28 14:53), Minchan Kim wrote: > > > > BTW, I still prefer the enum instead of 10 define. > > > > > > > > enum fullness_group { > > > > ZS_EMPTY, > > > > ZS_INUSE_RATIO_MIN, > > > > ZS_INUSE_RATIO_ALMOST_FULL = 7, > > > > ZS_INUSE_RATIO_MAX = 10, > > > > ZS_FULL, > > > > NR_ZS_FULLNESS, > > > > } > > > > > > For educational purposes, may I ask what do enums give us? We > > > always use integers - int:4 in zspage fullness, int for arrays > > > offsets and we cast to plain integers in get/set stats. So those > > > enums exist only at declaration point, and plain int otherwise. > > > What are the benefits over #defines? > > > > Well, I just didn't like the 12 hard coded define *list* values > > and never used other places except zs_stats_size_show since > > If we have two enums, then we need more lines > > enum fullness { > ZS_INUSE_RATIO_0 > ... > ZS_INUSE_RATIO_100 > } > > enum stats { > INUSE_RATIO_0 > ... > INUSE_RATIO_100 > > // the rest of stats > } > > and then we use int:4 fullness value to access stats. Yeah. I don't see any problem unless I miss your point. > > > I thought we could handle zs_stats_size_show in the loop without > > the specific each ratio definary. > > For per inuse ratio zs_stats_size_show() we need to access stats > individually: > > inuse10, inuse20, inuse30, ... inuse99 Does it need specific index in the enum list? I don't mind having all the hard coded index if it's *necessary* but wanted to try we could make the index with base + index on demand in the loop via simple arithmetic.