From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16DADC678D4 for ; Thu, 2 Mar 2023 17:41:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3DF26B0074; Thu, 2 Mar 2023 12:41:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EF4F6B0075; Thu, 2 Mar 2023 12:41:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DD8E6B007B; Thu, 2 Mar 2023 12:41:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7DBB56B0074 for ; Thu, 2 Mar 2023 12:41:51 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3117080F18 for ; Thu, 2 Mar 2023 17:41:51 +0000 (UTC) X-FDA: 80524676022.17.2A6CB07 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf09.hostedemail.com (Postfix) with ESMTP id 59866140013 for ; Thu, 2 Mar 2023 17:41:49 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=sRSXGveL; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677778909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BxNVxQxpUa9EQo7tVoxpRgg3ciw7b1eHgoO8lDNIC4g=; b=mVhxwaUmlD3Kn3adFP5QXJIh47XoZlrLg6BqiVvH7bZqhzGLrxXsfjg+RPdQC3MfzVyYWt 83iS0M4QCrjJtNrcbhxTTgzOHqK8vzi2eh3Hbi43JJrP4fF0Qu2l0F6+fMXSMflqALCk80 9BYEMXZB4csGmZWTv6bnZ9AWWKB6lI8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=sRSXGveL; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677778909; a=rsa-sha256; cv=none; b=09pTFttSpYqMTae3p8pY/y+Yw42C1v5WwH370L/4MynIiEDyoHCtYdF2wf2m+FL8LEjPvY R7gNr9Mc/+/m8eYWzo+FYMYcY0Ai8hUBIxEzM1a/B7VXSk9YbmTWiWtTQCgsuzzi/vsxgn xcu3EzF5+DvbHXBdzdH4tRcGie02imU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 263AA220A4; Thu, 2 Mar 2023 17:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677778908; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BxNVxQxpUa9EQo7tVoxpRgg3ciw7b1eHgoO8lDNIC4g=; b=sRSXGveL2AxhYFLe9CL6gEeYCvl9WiMlJb1JB6ba2xNlKm3NIYjul+j63hydUrBXrBsWH8 jS4XB5rta541t3pGOeXW3wZVJBd6ZnvYmZXdTfeYKZPmKyo8ILT8HZ9LH7OqGsOCPzKPs2 h704ERv8SZ/bl/SRJYsneFT5PXFiT9E= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 00A9513349; Thu, 2 Mar 2023 17:41:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id erg4OdvfAGRQTgAAMHmgww (envelope-from ); Thu, 02 Mar 2023 17:41:47 +0000 Date: Thu, 2 Mar 2023 18:41:47 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: Johannes Weiner , tj@kernel.org, lizefan.x@bytedance.com, peterz@infradead.org, johunt@akamai.com, keescook@chromium.org, quic_sudaraja@quicinc.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] psi: remove 500ms min window size limitation for triggers Message-ID: References: <20230301193403.1507484-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 59866140013 X-Stat-Signature: ugaf1yd4cqwne45qjwr891hybqynj9bb X-HE-Tag: 1677778909-314480 X-HE-Meta: U2FsdGVkX1/7bAzvE1O46zZC8e7sZAwXoY+P1hpjOG9Y60ODZBlvIKywRK6C+ElR9ONU5YtwywA3hFSp+M2HYFiKgIbV52WpaA51mFnVFoefsOhESKD1rjMfJg7BuorQ55lh0xaJ5wLB4cQ54x8thgaUXad6kzcpKp8d7ZeX5gzCsqgujhxCriWjvKDTiTzo9v/D7K4AoHl98Ey6NCW9LJklOB6A6VSSACpbMd+IoEklWBJ6cFpodxSYxlH/jq6t0X7Nlt7Z8j/hfrZ2cMweloTE3qMi5brCBrjo/rYDOYWAkVJSzX0fn+jclr26j/n22+OVRoQxkCeKDR0qPWgS17Z4xtpUV3qD5UU1kCO94311hodm8kqVq6AINQA2GCiQ7+lq4qCy0ccR0nSebg6a8A6c1wJdmMZYv3CFmOZGJ+0xTjkYi2UZTeC5TkOux4qmY8UVS6YXmW0ZukpiM7aNQIymB4s5VoeUNGWgxHHQGm7zsdd4wRPCLZVSDPDP/FoSS0VKhbV1/EPJ6+OLITxEu0N70DCqb2kM/1zLfryh6jdeMVqHyo0rU7NII3QM+TCb7ZosoY9QfUBx/uOiNkGgN/4ZRWbHEP2nH1gfbCkXDHEmnxNELMXxR8WQMPbBqcqXDbrmy2wVqV+Xshbe6EZwslIGlO+kCEXpw1vTcReyi4Evp0kSCvgeSJsr4IRJwB6JB73gahi8ktYPo4FZuP30n93oIU+dHMr3iEhe/X02QPdmipC0/YzdKudrI7WxBGNAbUAfHmci4HKv1sbJNy2VpPjxxbCb8x8sQcgKiZJ4zwDVOCC281kECd4jnkpmXhpdrWreRSPm0iOnkLdoT+bvznrL7tPvEQJvTWudTdB8IokDpetlANLL0ucsZQdIPxDsxW+ZM3AxK6UZTzkzf2Bt7KS0ZNsfXSY64wvGz64hH81tyJ6hqHe5bQy+qdUFKHExPLJEVIQRMxXFR1/z7hw hSbOVoWv xpX0AtlfbT/5MuJ1ticxYwoDbCBD5TDSMFTzPy/x2nZKcUQ8qKiq0YCImsqeWim62FGtQYwwas4ZjuciVm7AEE6xIDlUjQocTsmygTXWmhZzPaWYPbhPaY8ujPhuybXMP9XTGxow+eI25RSjVwWjDFOWSa1af0VtdjzU58vKcZH79qwA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000028, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 02-03-23 08:13:54, Suren Baghdasaryan wrote: [...] > Let's roll this check without additional changes and then consolidate > the checking inside psi_trigger_create() in a separate patch. If > anybody objects to the late permission check we will just revert that > last change without affecting anything else. Permissions checks at write time are problematic because userspace cannot drop privileges. Also I think it would be an antipattern for how we do this in general. -- Michal Hocko SUSE Labs