From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBD6C6FA8E for ; Thu, 2 Mar 2023 09:09:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C78CD6B0071; Thu, 2 Mar 2023 04:09:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C26AF6B0073; Thu, 2 Mar 2023 04:09:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B159F6B0074; Thu, 2 Mar 2023 04:09:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A10FC6B0071 for ; Thu, 2 Mar 2023 04:09:32 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5C72D120C97 for ; Thu, 2 Mar 2023 09:09:32 +0000 (UTC) X-FDA: 80523384984.17.B061D39 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 8ED634000C for ; Thu, 2 Mar 2023 09:09:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mf7i5btw; spf=pass (imf11.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677748170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BAmp8cQXmAY8O+zkFjEu1kD8x7lwlOJ1BmEXR6luRcA=; b=2xdVjBghYVaOaaxr/P72JU7uXEzTmlq6pQy8E25QDwUVlv0ZsY9f73mN6vbgr9WjiTyoZ+ 6Duvx/1N34sbpeZSMyDgMHjDvfYTypwcEvOiu2BVDIX7kVPGdgiOBppKltBiJvpnyTEDX/ BBLgQ2JK86jwIiSagxwdR/kaOl0uG10= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mf7i5btw; spf=pass (imf11.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677748170; a=rsa-sha256; cv=none; b=A+WiaIAFn2uyr8evCZlOUakRMlRTQEMMGDJdiTNo6BRm3DeiyYU3BC3wHofxlI2rOFGSZw fzD5gSHlHTwUI+jj86qMbQ6AWhTIjbazrKnecVmJd/VxZ4g6Aa1ZzPEl/55nI4R9Q4KC/5 L6Z79E7sb8FLfP4+YTJwZxqsUo8irFA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677748169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BAmp8cQXmAY8O+zkFjEu1kD8x7lwlOJ1BmEXR6luRcA=; b=Mf7i5btw/inxfHGyyEtjHuKN2H7+PIyB+HXIq9QB0N4pMJiTkaFtVcNFHs3M4UdkLHMyGb yn2Vmk6JO7Hf+iaCDBVap+X31AhfG70NbO+jVfGR/Yfo4ob33NIu1/EY+s6BuLNYOPa30I rVxV0KMiaDUObMRQG27vwU3Li3hH4ao= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-357-S7owwZrhMpm03B2s7hegTg-1; Thu, 02 Mar 2023 04:09:23 -0500 X-MC-Unique: S7owwZrhMpm03B2s7hegTg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C59DD80351F; Thu, 2 Mar 2023 09:09:22 +0000 (UTC) Received: from localhost (ovpn-12-142.pek2.redhat.com [10.72.12.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8382492B00; Thu, 2 Mar 2023 09:09:21 +0000 (UTC) Date: Thu, 2 Mar 2023 17:09:18 +0800 From: Baoquan He To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org, Geert Uytterhoeven , Christoph Hellwig , Luis Chamberlain , Thomas Bogendoerfer , Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org Subject: Re: [PATCH v2 1/2] mips: add including Message-ID: References: <20230301102208.148490-1-bhe@redhat.com> <20230301102208.148490-2-bhe@redhat.com> <5edd5304-ef11-4607-9189-a07613ecfee2@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspamd-Queue-Id: 8ED634000C X-Stat-Signature: n4ggyu6w9monn4i84hu9zj864kywhbuy X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677748170-343973 X-HE-Meta: U2FsdGVkX19cukHpiXpzlarWjtIr4f/jmMyIebQ30pe4b1hkRRUwmtrztlhgS6w4tYI5UcosQ5FeefFZ2ckJYTDZXCy/Ao/eAvaP7ygSi1dE2QxC2b4CTN63LvkabUFRLyCd14bPRRtCtYoTLW11mLjclbnZgBI1cEnk2s01hH0U0szRoIn/dSjBiib2WVORWJSgrAl1peqBTGr0941RU3GGnf7KFyEh2Gi/IhLZygPch1wt5oYslBKQ4WFQt2zgZUMIj2BJadtvL5Ns7I9t3I2wdu+k2Z9ArUT1flfr1ZmWD2kj8L2X45r0/lhfuoF0R2x+bRmlSjMNc+P9rGCS1Ki4BJy3CUwxfEn0FVaSMy/U8PMyHmsQ5VU5R54d3Ppkwvv+712GV40iMt6XdfTzirG5qH+ucYzyXBZY0zKgfldeDYgh+mMBGKK/lsdgAI724F4a/p6d9jXScmP3F11/zAGIqIv5rLw7DLDPYJs8WFlTeCG4LoJYzrjRfQuanmeidmPDQQFx/f2rLBKcRbByZ2kDHldTNsCp1C+wdoHWlXJ3fBKx+eYOw8b1uKRstGx61JcyqzUjexC5oGstPTjgxX6S9681HwRBb/g5Zepdw6yZA1D9ksJ6jPhXFenobrRc10qVEjot53n3c5BwR2DRsErt/8Jk8ntULeg2lR7ynQwPThEEiXIHYxfFaoyQsqWQPcFW+OHlbEMPAhZnWuQHPDZvlzPt5TiAH/SqI5eimrLDTfdyx8ACjUkD4lDa+6GqD5zdWvRdGGZLkCzDf05LQF5MoBVmWpKaKJGQ1MimOlR9gTEeBs2LpORXvEJ7Ok1R0aN1ZFtQpm/1Qt5gNakET/myvhrPtACP43c/32GiOIivoq9HRO4CxpAgaYmi1XF8b6KD8y66tmPMnupnL70KnSJFLf7oKePlzWXNMORHDY1k6NN9sDdMj/jUTof4J4NDzVPMXVgDllkkg2c94wR 9Pg78bWC W8VG9jH/iHiiJWw+lOfaAm4OMuo26WzyDwZZoJRTkyS2cg32Y/oBc9UYhrKXv0VxkLwI+blVo4ybXFwSrHgW6exbFEK23s/055xLb4kdOpKU9HT6TD7Lz2I8B9Wcy5MMgG8xQg/Ja7lUt6U8u1es4T8RBZNfJ+4uxjZmG9gYZFiSY+QSa5yjklUQLOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/02/23 at 08:12am, Arnd Bergmann wrote: > On Thu, Mar 2, 2023, at 05:12, Baoquan He wrote: > > On 03/01/23 at 03:06pm, Arnd Bergmann wrote: > > > > Yeah, defining mmiowb() to wmb() directly is also good to me. I tried > > to comb including sequence and find where asm/io.h is included, but > > failed. Mainly asm/mmiowb.h including asm/io.h will cause below > > compiling error, the asm/io.h need see mmiowb_set_pending which is > > defnined in asm-generic/mmiowb.h. Moving asm-generic/mmiowb.h to above > > asm/io.h can also fix the compiling error. > > > > ============= > > diff --git a/arch/mips/include/asm/mmiowb.h b/arch/mips/include/asm/mmiowb.h > > index a40824e3ef8e..cae2745935bc 100644 > > --- a/arch/mips/include/asm/mmiowb.h > > +++ b/arch/mips/include/asm/mmiowb.h > > @@ -2,10 +2,8 @@ > > #ifndef _ASM_MMIOWB_H > > #define _ASM_MMIOWB_H > > > > +#include > > #include > > > > #define mmiowb() iobarrier_w() > > - > > -#include > > - > > #endif /* _ASM_MMIOWB_H */ > > According to the comment in asm-generic/mmiowb.h, the intention is > to have the mmiowb definition before the #include, though this would > only be necessary if there was an "#ifndef mmiowb" fallback in that > file. If the definition to wmb() works, I'd go for that one and > leave the include order unchanged. Ah, I didn't notice the comment. Then will change the definition to wmb(). Thanks.