From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26AC0C7EE30 for ; Thu, 2 Mar 2023 08:41:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53B186B0071; Thu, 2 Mar 2023 03:41:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EBA46B0073; Thu, 2 Mar 2023 03:41:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B2E06B0074; Thu, 2 Mar 2023 03:41:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2A5516B0071 for ; Thu, 2 Mar 2023 03:41:30 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E96681403AB for ; Thu, 2 Mar 2023 08:41:29 +0000 (UTC) X-FDA: 80523314298.06.F727E09 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf11.hostedemail.com (Postfix) with ESMTP id 1BC5E40019 for ; Thu, 2 Mar 2023 08:41:27 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Rszkk4uw; spf=pass (imf11.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677746488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K1YXVoCyOwxQNnderTrmDeMC40tQAhZcHa0ukb6R9Ws=; b=8KiRzL1f2gcAtusVZ10W2fRasz+fIgn0+TFxdAKCNKeW8nFRuLQyJ+yBsBsG+Rg/hm4X0h AoqLQEe50cktMgvEFN3cKb7VgMfI7H3NvlQYX6p/wo0JSblRJWadd+vNtrBwtFHqtd3M1u Gh7vMoHetCuYWO0WIm3dyaqm0JDlG20= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Rszkk4uw; spf=pass (imf11.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677746488; a=rsa-sha256; cv=none; b=pXqa/3NMnNu0M0/bh1ZGOH35iK4rqM7PZKAmMfhCU28or4edZAxuF/NleGgdH53EPnNKVJ N+vIc9HsUKOhnxtpYWl6sR91i1Q8TxHiZ/inctW8L8SfSIt2uyE7hHYpbpRygM86pphlWH BQqdSqGADKEuIpYN2Oz4QvLmGs0//+I= Received: by mail-ed1-f45.google.com with SMTP id a25so2020373edb.0 for ; Thu, 02 Mar 2023 00:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=K1YXVoCyOwxQNnderTrmDeMC40tQAhZcHa0ukb6R9Ws=; b=Rszkk4uwKQuXpOD256yevOsKDiLr4NPBQeo7kAGO8nrR5c7v+uWhDLhg1c7DXe9CCg 6sFJnQQ4ys8Xt1HBqHwDBQrCCPYrMZ6BlscFKL4kizHDhu5qs0Eh1RxAjc23brCl9Qui hLLRgbOMAGA591ODRdSldDjRHtZ2mZSN8n5Vl9ar1h5eHetOevpSNJNTs26ycj6OaG0L 4L1Pd9hLwD1fUZaSEIK2u125UT6now9zJlMBhpMWKs1c/5nVFU6lq/vXdOsheBdpLFsr B8E2UMZSfprRlDOChYnYKKNzt5pl2CyVD9OZJZjYlsvamVh3NNY2DITQQ/F7gUn2Qwtb +sFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K1YXVoCyOwxQNnderTrmDeMC40tQAhZcHa0ukb6R9Ws=; b=ami7Gn+MghGgjlezFRc5Us24PvR6T/81wGnBGuXNcXrV2Mlp9X0xT1bLMflgK8/iy3 cRAmlJpbGqmGJJqp7Yil9ifrj9dabw0+E5c5XTLV/Z5CGnNr/CNHKsMUcYXq3c24Hqta z5fjty1LTdZSlRHhvIac0v5ONaXhbu0RN+vynBG1jdF/c/hjaqUs5BkfvvLHLejZFX1g dj26XI5/szciuSYmWdnwplmjmhQdecie5W9xa9d3v3JH+xFCXrhMIVfLZV8HDDjtpZ22 btUWg53Hv823qZ7inGXG55z3LNq+k+TP9jOIpFfi8dNSK+RiFKjTbrF7pqcMwLV5Sxfg yZgg== X-Gm-Message-State: AO0yUKWaGxvtlXzFuPwW0yWG33lSEl4DQeWXY1YMcQWHZy8hwhRV4yLn bAdXPbvOLSI+QSMXN7JDXAI= X-Google-Smtp-Source: AK7set+Wnc63PgyHHQ3ShMaX4eflGRmShodrFGCyynYYDAJoy+XWo1MzU/OGJ7YL2Ydiea70Fhp+9w== X-Received: by 2002:a05:6402:1250:b0:4bb:f229:9431 with SMTP id l16-20020a056402125000b004bbf2299431mr1280219edw.19.1677746486483; Thu, 02 Mar 2023 00:41:26 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id a98-20020a509eeb000000b004ad601533a3sm6665583edf.55.2023.03.02.00.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 00:41:26 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Thu, 2 Mar 2023 09:41:23 +0100 To: Arnaldo Carvalho de Melo Cc: Dave Chinner , Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Matthew Wilcox , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann , Namhyung Kim Subject: Re: [RFC v2 bpf-next 0/9] mm/bpf/perf: Store build id in inode object Message-ID: References: <20230228093206.821563-1-jolsa@kernel.org> <20230228220714.GJ2825702@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: wffjj1cxygx8dta3ngmmsdbmgo6hj3dc X-Rspamd-Queue-Id: 1BC5E40019 X-HE-Tag: 1677746487-948602 X-HE-Meta: U2FsdGVkX18wukzAjsoXNfYrxJuH3FFKZKSxm7eNlokTWMVK+u2k5wk6sJ0qe4kFJbvI6ZkKGLeOI7ZcgeiGyRevp04tFyBtReAMdI4NsfQjpHie60/IYb8NKrBNBzKA7vt+gNO/Uhjo1KLRDdSfkgRzONwCNThINdcWhqOVgA4JANqj6TX1ed5kUmk3VvrzvKoJ2gWFjxqvZIstcoVhJaoADunJ/gh+5/N9bROkD4ryL6GXHWVDdD999RgaSYz3j7WqijUnqLM6RBDCsF+GjHQwsOBmiNpqsN3sCKtWKy175CGH6ycjyShUYk2emkANxlxP63Z1geiNhtlaE6EKIqswlQdUH9rAJPg8bNiKgknk/btqEHwxsg2qASeyUfs6ZwfH2Q79kEvxfXix4XxFZk2bb2GfMXTjEGFajZ9GjP7fgOrusYeRprnAlCXoB9AbhPE14VW6r2dc7AKUHqczzpdZ5RTE+B6DQ8+4V9mEccdRB9r4F/2N9tacxdLU8Egmhk91Z19NTWeGO+dZmeMB6T7wR/tTJaPLNn+CDZF+SY1X1i62VyjqGlAi5UovuD2PNvpNXG5/FU/HshZyNMWpOyL20BXO6AAep2b0pXsAeTLyuJtXzTpWrtpzISwBScSM6RGNdIvpblnK25d8tBZLcGnSK0mjW628rZkHGDbs7xbli4cveYunMWw39A62BHw+LCX7Z7Ir6P+rZnJty08Vh8aC19hP5th/iw4AhTvg9fTWE86oi4fe7cP5eiXaUOQLRzkXIJzTj1pZQOWKjF9Wf86waJPEC1XXrIlPu6xUa3DzwDn9UrS3D6Ar3EXZngf6/iyt2spjH4Ot75Zvpu0Tyy5DTzx4z0Sq4P8eWhBPYLm0flgM8l7t9Q5Dw9Ku0pqlX56lMb9y9wTwKHYX+KldGksit3CP43p1oijpuDzdGJKPcgiWHfmTB7PeeNuAO8EMkxv0AnZiYUkCiWLFfKl gNB4208l maKzZx6ydGpJh0ZNkiOSUT7ruVL+v1kWHTeQhHtxielTzqTwX4ean6d2K8wanrTiJOu8DXxvFV9Sk78dYwHqKc1WzHUQc9d/mZH4GbELnZRTqBevGDtjnDB2AS7pLgtaI/whvfWjT0lV4Ck6ZxySJ9s3BA+3vP0xjwOFnnkQiN2mL1r2WUWZBuaSUZarbrrkfUZoIQgt4GtFuThJu/o73LOw/j6z/6sQi0zILP4WhSnAtyzPnRgcppzSvGGNaVpixMYNZZMJv+EN4lCQ/Ss71pCyZp3lXqlGj6eNHp7rsQxp+MxuW4It1CJmnHiTfgd3KZvi0ptrQghX1AX4VLdwfx/s6+xCmDOFs+MnCtQspFbk9a82vBYtzNMgo4pSMTleQT2/hSsmD6MPJCVOK3TnbVHFIXHVkuIOBjXQaro/8AzHcEuJAPTHqQbJY4iY5PcKokpqohRUiWa6NrAy3pYt6hxeF+gawinZapHfUOzOUIEGSMmHq8IgT92UA/7WvwKmtpqGVGqClDMlY8pR5ok9lDQBvza315oe5w1ApK9zYiaWocZuHtqheRVJdop3sYlfvjEMieCtWlvBm6x/dM/SLoqo8yOruyYvcPN7MvlmrnLq98RaZ7ZzsQp2fOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 01, 2023 at 12:41:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 01, 2023 at 09:07:14AM +1100, Dave Chinner escreveu: > > On Tue, Feb 28, 2023 at 10:31:57AM +0100, Jiri Olsa wrote: > > > this is RFC patchset for adding build id under inode's object. > > > > The main change to previous post [1] is to use inode object instead of file > > > object for build id data. > > > > Please explain what a "build id" is, the use case for it, why we > > need to store it in VFS objects, what threat model it is protecting > > the system against, etc. > > [root@quaco ~]# file /bin/bash > /bin/bash: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=160df51238a38ca27d03290f3ad5f7df75560ae0, for GNU/Linux 3.2.0, stripped > [root@quaco ~]# file /lib64/libc.so.6 > /lib64/libc.so.6: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=8257ee907646e9b057197533d1e4ac8ede7a9c5c, for GNU/Linux 3.2.0, not stripped > [root@quaco ~]# > > Those BuildID[sha1]= bits, that is present in all binaries I think in > all distros for quite a while. > > This page, from when this was initially designed, has a discussion about > it, why it is needed, etc: > > https://fedoraproject.org/wiki/RolandMcGrath/BuildID > > 'perf record' will receive MMAP records, initially without build-ids, > now we have one that has, but collecting it when the mmap is executed > (and thus a PERF_RECORD_MMAP* record is emitted) may not work, thus this > work from Jiri. thanks for the pointers build id is unique id for binary that's been used to identify correct binary version for related stuff.. like binary's debuginfo in perf or match binary with stack trace entries in bpf stackmap jirka > > - Arnaldo > > > > > > > However.. ;-) while using inode as build id storage place saves some memory > > > by keeping just one copy of the build id for all file instances, there seems > > > to be another problem. > > > Yes, the problem being that we can cache hundreds of millions of > > inodes in memory, and only a very small subset of them are going to > > have open files associated with them. And an even smaller subset are > > going to be mmapped. > > > So, in reality, this proposal won't save any memory at all - it > > costs memory for every inode that is not currently being used as > > a mmapped elf executable, right? > > > > > The problem is that we read the build id when the file is mmap-ed. > > > > Why? I'm completely clueless as to what this thing does or how it's > > used.... > > > > > Which is fine for our use case, > > > > Which is? > > > > -Dave. > > -- > > Dave Chinner > > david@fromorbit.com