From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E870C678D4 for ; Thu, 2 Mar 2023 07:46:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F0DD6B0074; Thu, 2 Mar 2023 02:46:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A0E36B0075; Thu, 2 Mar 2023 02:46:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 869106B0078; Thu, 2 Mar 2023 02:46:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 72DE26B0074 for ; Thu, 2 Mar 2023 02:46:00 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2A66780349 for ; Thu, 2 Mar 2023 07:46:00 +0000 (UTC) X-FDA: 80523174480.22.711A8D4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf29.hostedemail.com (Postfix) with ESMTP id 6527F12000D for ; Thu, 2 Mar 2023 07:45:57 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=PoUWiCcN; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677743157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7SZzZlo51hCIHj63LTnZFCuHCo+OU2sc9qkPk8oTs2I=; b=yNCx8pcWLdDHi8qyTE7VYg+Vb8o9SyDTkmZboqkQZLgKB10Eb7V+TURsz/z8Guult7+noq uaYzretGPCvDnIXAk/buV/J9Ykn3NGaNryv/Rn2EJxC8w8XmI4gfCNosAh2jLLB2lP/j7n bcwQbkBdxAF6CD1imK/mJs6GleCiDzw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=PoUWiCcN; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677743157; a=rsa-sha256; cv=none; b=cHf8CxP3V9yVTHuGSe5LXYPP3M1z3cZOUl2vsMbC5mpkLyIKwGJDXoWTSevkC9qBLFOll5 fqFwJIAfpHNinQN6064R14lCwjnYN4wpekFg6xt2E4V6VdPa3/KB+73KO0zQ+0W6nQovGE dYNK2dZGtu+1HIorfbZSGI6bNOQthwA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CDF1221AF6; Thu, 2 Mar 2023 07:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677743155; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7SZzZlo51hCIHj63LTnZFCuHCo+OU2sc9qkPk8oTs2I=; b=PoUWiCcNQHCkdj583LO/FEOzanT+eGRGNnnMQXkh+OfyWi2LsHSbfwSozqB15GQI/8Ri8X P1l5KOj4fAx4C4zxe/Ae5eUXN4hUaYsonTKFaVqDtPYn9rtvdPEnvrE9IC+m2V3QvabOV9 NI7eTsquRnQMQeYbffgmB0EYO7eD2Yo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9F81013A7D; Thu, 2 Mar 2023 07:45:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3Lm5JDNUAGS7CAAAMHmgww (envelope-from ); Thu, 02 Mar 2023 07:45:55 +0000 Date: Thu, 2 Mar 2023 08:45:54 +0100 From: Michal Hocko To: Valentin Schneider Cc: Sebastian Andrzej Siewior , cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Peter Zijlstra , Thomas Gleixner , Vladimir Davydov , Waiman Long , Roman Gushchin , Shakeel Butt Subject: Re: [PATCH v5 2/6] mm/memcg: Disable threshold event handlers on PREEMPT_RT Message-ID: References: <20220226204144.1008339-1-bigeasy@linutronix.de> <20220226204144.1008339-3-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: d1zf5g7gmuapja5aoicot51bxk9ef4fu X-Rspamd-Queue-Id: 6527F12000D X-HE-Tag: 1677743157-813914 X-HE-Meta: U2FsdGVkX1+H47kbIa42egKj0B6Yh6sxtSUh3tbqjRmmQrKOFYmHjoxthp8J4fMwJMvW5+1IdlkdpHEQS+NXMowr5Kf64gfSakDRkPKhsqAcLbM0vUBfLXuwgf8zQywJWFA+k2e/cXwfqRw6EcQ3a/09jmJUMWUaxh0d2uuqUXqLuDQnw3ZbZ/pEcGf6SaSWqDZVAdrtPS4dsTPD7nF4dKjm+fk5p/XiNOYzJygaLBqyjx/e774WNxvhj3VUZAmrO450g1HQNX8rSfg54sDjzQJklNAP4zijVaGKu6xuvKMFMYlooUSqU+2mJ9ItJvQQ6B9DQ5Fqlg/hYJ5AA3uZ8b/3uiGukE58aI1uox1nRroTRNk9eOtKn4BKYm4mGTKxBbPdv/WwF2ezVUkZkDjb2xLB0WWbldSoDo8rkzgMiU5cPLzMX1fXOc5CspGWRraOEqHYMFkSg21w8+MHRo3pFQElZ/59XKrQGpcRDmJA9fUUMvpYIyPrJql6hXAfDLNOZyuX/WLIvNNLHIUUTbqhaxMQBZDTeGFm9S4q2s1OGdgcj/jzVawJ7H5egkjl+5zKHfed38HjaYtaQ9JNata6JK2epgwSnsB6EIui4Atgu4VYPJLm2jYcHp089BsY+r7H6+4eOS6TDX/HQQv7YuWr7LskeqskqJr72YBDCmCY2I4Eff4tD1pb+PaOTI0CxsmTQoxymkMZ+/rnjtnAR2viulCi2L9rJnefKsp+NAbbLLk5lm8Vb3W1hcTzYITtSWRwuFX/Pb6VzXrVF+KyGRvK/xUVDTV8A4W7hWBEwov7G2dDx5L9H/Q8zNL+Y+k93M0J9WgvNss4qGWRFwZZd/gf/bxEQI8r/2vqcr6GfE3GtwYDatQlm96LBTVpghjsLHLv3XuMdw2LEnNBh8K9oLPOhcYknh/Vg645IwguukQGM3NbTuCyycDH3XVMnA75PakYVabRHiD5UEbVfymUeKk 4Z9HDxrm rZIBZvbwNYyhbJRrh3XCFl1Xc/jntoGNJmmXp7HYEDAuv+dARDo9LgOP9E1Tyj0z84qcnCXRyDBjuVNgSZ5gOGz42bKfI9xuC8OMPMnJ63AP83IKZYE9MlRLY9s7qGsJQkXDC2kGa8LPJuX44fHb+UolF5jdViS61NaHYGgOblJd4/vzRhMOrgLHoQdUENymxNjKfWeaen62T/StJ+6Y3pkEiWgmgMsaLavo5BI3XLNmnYJ7aZIGv0S+IO580vQ31Vhuyk158bFIH48Xe2mT2ae7C/BuGXrosLHrf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 01-03-23 18:23:19, Valentin Schneider wrote: > On 26/02/22 21:41, Sebastian Andrzej Siewior wrote: > > During the integration of PREEMPT_RT support, the code flow around > > memcg_check_events() resulted in `twisted code'. Moving the code around > > and avoiding then would then lead to an additional local-irq-save > > section within memcg_check_events(). While looking better, it adds a > > local-irq-save section to code flow which is usually within an > > local-irq-off block on non-PREEMPT_RT configurations. > > > > Hey, sorry for necro'ing a year-old thread - would you happen to remember > what the issues were with memcg_check_events()? I ran tests against > cgroupv1 using an eventfd on OOM with the usual debug arsenal and didn't > detect anything, I'm guessing it has to do with the IRQ-off region > memcg_check_events() is called from? I would have to look into details but IIRC the resulting code to make the code RT safe was dreaded and hard to maintain as a result. As we didn't really have any real life usecase, disabling the code was an easier way to go forward. So it is not the code would be impossible to be enabled for RT it just doeasn't seam to be worth all the complexity. > I want cgroupv1 to die as much as the next person, but in that specific > situation I kinda need cgroupv1 to behave somewhat sanely on RT with > threshold events :/ Could you expand on the usecase? -- Michal Hocko SUSE Labs