From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF0A5C6FD19 for ; Mon, 13 Mar 2023 14:11:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38BC56B0074; Mon, 13 Mar 2023 10:11:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33AE06B0075; Mon, 13 Mar 2023 10:11:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22A326B0078; Mon, 13 Mar 2023 10:11:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 125DA6B0074 for ; Mon, 13 Mar 2023 10:11:23 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D1D811A0AFB for ; Mon, 13 Mar 2023 14:11:22 +0000 (UTC) X-FDA: 80564062404.25.ED07E78 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 79352160032 for ; Mon, 13 Mar 2023 14:11:19 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678716679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SkQWqLybTqzWcN7bT++7wpIVdyOpNTcu7VCW55YOnMQ=; b=XsoMw73ozWqOgokTueHPrDjApBOPYsNTLuaGBmUn1U6YVXOXHCQ5Bfz5/Z1ttVAUuN3b+8 THubgEEaVbvtRDKQHdS987mxMP5dxD73GlVoH3UGVwjBMFP1AnojXwAIEFlo7nWN3IR53D Ec+dpHSoPk6QS15C49iu19yd2S2Y0S8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678716679; a=rsa-sha256; cv=none; b=T0BU+Al46fOa8gJDzVGdzSri2h/JJSBuK38+nJSwq58DZWSgpEv4qxkmK9E9fis95NXheJ f8N6ADGPAK64P6I3oMA7ZXbzt+2noOeuFlti0mDzjP1G7/82OQLIM670ZMRJWW97Hoybxo DsBRQQRFB7jntHDmSqRgp1fFlRDWwZs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 795AF612D3; Mon, 13 Mar 2023 14:11:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 204A1C433D2; Mon, 13 Mar 2023 14:11:15 +0000 (UTC) Date: Mon, 13 Mar 2023 14:11:13 +0000 From: Catalin Marinas To: Joey Gouly Cc: Andrew Morton , nd@arm.com, acme@redhat.com, izbyshev@ispras.ru, peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan , Kees Cook Subject: Re: [PATCH v1 1/4] mm: deduplicate error handling for map_deny_write_exec Message-ID: References: <20230308190423.46491-1-joey.gouly@arm.com> <20230308190423.46491-2-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308190423.46491-2-joey.gouly@arm.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: qui4zhx1z7c5pfqpj9ugcqjdqc3x3ycm X-Rspamd-Queue-Id: 79352160032 X-HE-Tag: 1678716679-921412 X-HE-Meta: U2FsdGVkX1/VhP47lcYBo2olB69ZahXiw7zVf+G5UvnQyl7faCarojKrkrs+vcz9CHI/+wymH9wiYM5tMnwaE4ZZ7idw8mgSb2cKIpnapxH+syNBGsJt/o6XswiZ9GLtNuapHC4bOM6V/qOriV3RhEXoeK50LRyI9XIyQ+5J0S+C8LNh1oqsCyWkx68oUhjMQgWfdtmLcBkJHoOlE3p37HIAKjrq91DjN2BWuYaYVt2u7zcDEbgNRq7p2NeBRFYvEo2Uhh6fnDSrsxw8H9lU9F0w8dzjL/teDhvotLYYdLbNQqMkeEsRLjdBUf0gnswb0qrg28DgYt5KVtEMO02QxRsfw0VEsRdQIrIq8EeBiGVih05D+cl3ma4Z1A5jvVF9ZKS7LDTmnQjD/x8YvQThA1JNQ0BjoXrf3eaGc5ARO/sGb+KHXwQJE7YVMVOBvoNQ9IU6bJAZZo+uEg7ZqmsZIsjKgbzwzVam5gmSLscbuUPqw8ljnzKaATllRMlVgymuF6vyd6gvvSD5aTiPkAVMFQQSSp07O3lq+TwJtry8oNBE2sMF4pyIiWYT+uMD25rFPjDFLm6RP4BkaBRvaC4mqHmsfwh6RV3HDbwibS1U3+Jt4i66Ftv8ahj0d4mCr65MA/9+TesEoGkHZVqQALy/E8a/x3socd754mUjhOHpR55rGMgso7qXxPMz4ZnTclBwMMRvFEuAlfNaEl6YvMQwuA6AGzb4AJ+8eejawYsO4vN0AUoWd/25zESQcSv3wLpZ9h0bcq25fYd4TemfuwhtaRK9lo+Ai/qcXn2R79t3LLnjeE42ZFhMvg6uc5SS4IdVtQoSAG3+vX89xcW9wtBYmiNz1L9M6XSfsKuFxRwl21CfjlM4suEZgy252snX0fltlyMn92juJVwDvk3MP0PsUrG5j0sNcatmUGp3fZfHCmU7Dfi0KYg5sg+CkfLSAYjQRTvvkscZjZ/Gfv0eyc4 bmPekFkS VlJ/u5Ef3DVBmwZmK/BJH48Ml7Ek1ywA4rDUN+2kIjDsURLTw4CmLMRDy9jpvewqb4bMnrzrM/3albYAcSi0ZAlMx6vPAZ7wI6woACAWh+/vo4WeU/jBgg69xdyskwDjB/DBnUBAYd7F08oNPXYz3P2lxvOu0vrCSlsgYYwK6mvSVAAlYGHArM71AFQYzaEv+gMGCXO3BYEzbbW6n1FtP6DuIC4ktKhmNIq1+m8LLadWmT9gbkow6yw+RQ7hscgzhvSxTgbeMnbcl4F9lE+YzrSi6bYeVllONBoHUyFyO60ON3+kV/PQU9aiu2NDa1jbElrYkD418U5fMe1LC8CHHjaka+km9iniOLfczDZAaHd9b3H4uW53CuL4eyAqlP1nz8rKPnBe+vlbABCyE/iM+Vw8+MGLrOSQ0IGdLvpowue4zlQkHprPqsjBJPCnIsZUFPI1OB7d5lA5slo0tt55s3grOWDKNbX6EXT8JdEn2kKPxePX68jBN31xk0Yv8ajkQAiqJIdjiVZLx2rAJ8K4mdQ5fTlZLSNSqZ/NkG74p79HIYeZZnl+VDBBcLEyImfbCAusVMMIWgdg3sUPftFMATeGDP4Z58Sjfm1yMEsTHT62bYsyu/dFGoe7e4oWPdi+wge92ZKgLgfD7mhNHMvuT3SDlu33czvW1R3XxO9IkyOTiP2ikr3aKNRI9EmWwVSgrUyzk/r2Ou+CQKwvSu7m4sCYuuYsZE8lUXdQrJUuOuFcwKt4hGFy13krn5bjPJIUq0ZUDHGXDr7WYyZhRjdxz8IgJfCWCkWaRH+ZR8sps4k+c6YJffBPXDNEH7JXMy9JWGgjBd2nv0NlurETt5B3mhyvMWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 07:04:20PM +0000, Joey Gouly wrote: > Commit cc8d1b097de7 ("mmap: clean up mmap_region() unrolling") deduplicated > the error handling, do the same for the return value of `map_deny_write_exec`. > > Fixes: b507808ebce2 ("mm: implement memory-deny-write-execute as a prctl") > Reported-by: Alexey Izbyshev > Link: https://lore.kernel.org/linux-arm-kernel/8408d8901e9d7ee6b78db4c6cba04b78@ispras.ru/ > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Andrew Morton Reviewed-by: Catalin Marinas