From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8C6C6FD1C for ; Sun, 12 Mar 2023 09:51:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA50D8E0002; Sun, 12 Mar 2023 05:51:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7CB18E0001; Sun, 12 Mar 2023 05:51:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A45108E0002; Sun, 12 Mar 2023 05:51:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 95E898E0001 for ; Sun, 12 Mar 2023 05:51:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6427E40375 for ; Sun, 12 Mar 2023 09:51:38 +0000 (UTC) X-FDA: 80559779076.23.CE76BCD Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf02.hostedemail.com (Postfix) with ESMTP id 8E7E280003 for ; Sun, 12 Mar 2023 09:51:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OiBlMquF; spf=pass (imf02.hostedemail.com: domain of mike.rapoport@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=mike.rapoport@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678614696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xYJHI/EfuMD9TjucsF8nMSkY3NaUSb9pPppxfCuZDtQ=; b=lx4hKLB0wPfqkg9T6yP0bzJ/KVETZEebNV+yvPupa1rMwQ+b5mw7jmeD73O7tH+x9Zha8l MjYA7FIBsydeQitteUQKuIfqcw2k/kThmWh/DEU5gp2PhMpmWSQBaKp4k3pPzgW+GRWfRD UAP9yZWCHexFHxI+XpCNsFizrMuhjY0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OiBlMquF; spf=pass (imf02.hostedemail.com: domain of mike.rapoport@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=mike.rapoport@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678614696; a=rsa-sha256; cv=none; b=QKwrpBztxN1CvaCf1uvB/+8+IEFnERdrBzRXdXAac5k7HfxC0x5d3P1Wllv8upWiN9WJk5 8O7FgaV8GM4y2TDSNNAiYFq4Vzh/84OU7V6M25PTE7v2fZkkHrzeU9f6uLNLdtZyDKhgXo zGXieuxHaCQbv9NY6SV/QYAslObtNsI= Received: by mail-wm1-f45.google.com with SMTP id o11-20020a05600c4fcb00b003eb33ea29a8so6057574wmq.1 for ; Sun, 12 Mar 2023 01:51:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678614695; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xYJHI/EfuMD9TjucsF8nMSkY3NaUSb9pPppxfCuZDtQ=; b=OiBlMquFJnyyh0cAOpI2tT1Me3j63TVo647wS6ZQswQBwnUeQ8LgvVpjlys9jG25og vdv8uSLoo7AUTayhdsyH1O8dgkDZ37x328pHo08RFZ5Xuk/48Rcop4yvzh0A1gy1Txj5 EtIVxwohuMaInKlyst/QMyenkSXOSuVw31f7OPghF6U1B0J8u+HLKPplK7EnA0jNDZEw yiUrWFpjtDT+fuQLwUaFWwQBXHuGnrpWPT266/16zOwe4Gj8iDI38YvDWqogbhEyC0f9 pcG7CecBK8fm/W49akwnJhN7juow123XP57SY5v3uApZwwOppBnuEImLdsoQ5sCavKSY k0Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678614695; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xYJHI/EfuMD9TjucsF8nMSkY3NaUSb9pPppxfCuZDtQ=; b=dcwa51pJ+4XxzadYJGO+AmSRvMj+vAOuERzF6SAbGKYIi5dci2V06wv0fNYihBb23Q cBsyQA3Y3ZX7RbbHHdBuGV/GGWdBb4GPToG7voTMnESN7JXo4bgXJIK8yaDG6b0tUPRy 76ABkfAEPqIwB6Um10FZDrrin2o9jUCbYc2fSDUk2LZVil/LJ91mCYvzrt7tNl/k58AK VpJd5I2KhB0cRrOuqkaD5NgzCY+0uChmu0L1Xe4eWGN5lFzza3A3YP5QHqQ823EqaR7w gh82jxOOwDcB9YhHTO+VjdhBR3sCjZ19Wq+g1r4/+7IkWziNArfuAUt3NTUKjXOQcbc3 z9yQ== X-Gm-Message-State: AO0yUKWlWryJl33MpBGztimSDedRD4zIUFHHOHybNYmDZe9qxs2FmC8B cApo9/P/OkTiBZT6IjOKrDw= X-Google-Smtp-Source: AK7set8I3/sMJfHoJWj4ZIL2psjhEh4qxAjjoLRfwfTwFlR33kxlCpaOUoNVNDvt8zsUZAGLuExwBQ== X-Received: by 2002:a05:600c:45d2:b0:3ed:1fa1:73c5 with SMTP id s18-20020a05600c45d200b003ed1fa173c5mr1583270wmo.27.1678614694886; Sun, 12 Mar 2023 01:51:34 -0800 (PST) Received: from kernel.org ([46.120.23.99]) by smtp.gmail.com with ESMTPSA id hn4-20020a05600ca38400b003dc1d668866sm5407218wmb.10.2023.03.12.01.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 01:51:34 -0800 (PST) Date: Sun, 12 Mar 2023 11:51:29 +0200 From: Mike Rapoport To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org, "David S. Miller" , Eric Dumazet , Frederic Weisbecker , Jakub Kicinski , Joel Fernandes , Jonathan Corbet , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Mike Rapoport , Neeraj Upadhyay , Paolo Abeni , "Paul E. McKenney" , Steven Rostedt Subject: Re: [PATCH 0/7] remove SLOB and allow kfree() with kmem_cache_alloc() Message-ID: References: <20230310103210.22372-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310103210.22372-1-vbabka@suse.cz> X-Stat-Signature: hangdpz8aoxwz73yc8e3kaqkgjsbgeqq X-Rspam-User: X-Rspamd-Queue-Id: 8E7E280003 X-Rspamd-Server: rspam06 X-HE-Tag: 1678614696-518198 X-HE-Meta: U2FsdGVkX1+1HIT0KszOa8v1UVYZbfNtsYz27Tc9jpIkeiXFEqHDRRiylaNf98e9F1HO8yM3NijkuEhGjSHdPzuKGHgjQ2cc6F7QQ76OSr+9FTLl2vyXy79+9OYwIisTt1x8SPP/O0YDJokQeqsAOUs/mxSHNZcZdkHqqA19VqUdXMEuhV6uKu4oDjN0vBme8DPDlr+ibsFzmhuahqW6AIor8pD4zIrqEpXor9RXdXBJk9mAYxJRd8Qd75hpkK7g+rzEKrM/Cvnw9UqGCblWc1zmZlVQ8Ar9QEXPHgRPMUwjx3dTRi+H8Rpb3FsWZnnYi7LVyf0L99nGuBEyBwRfoC+6uPdgyfeK7U6bLL6Wg+SOoO5w2hBak/3BIvNd2v7iECGIeGqFnYxO0vadC2uQfW6wiGC+jXGkh8AyQSG4AR8lwFPvb4jJ/Vb7Ewn4TShWxIPBdybpiIN7SZgK80T8vioIOOqYJsLwSTKdz3Qf/Ztqj2vlw+vHn+7xy3ra066a4Hu/0UlWvBvaTs7E3LGsaphSvSUUZzenItZd1O6qwinITebCyiHUeUjfv7Tq/HTS8EMYGR2yrJfJtXxP6ighp3R2s8iF3Cut3G4x3/eqPca6TolZBhvhJPO/tYxiuUwOrnCoes3GIxd1SKm89P/G8nyzDRWFwuWZEwZykYLc39VcAeg64gwaD057EXQjV1qhrhUqhgRVcl/3Wr993+5jDtQgw5BmUkvZhc0iS4eg2/OP3/6VzD2yYMK9+LpkHh0fbqGbJSomD60P9S7mUJtez87bgh/8UM3p9XnRECgKociSlfdFEuXwDggPDDDggNh2vBcZEBu9KVRBfgli22SalJDwKXd19atZfORuigWljBp5cf3PnZexsV7Y2ybCPnzV/b5Nxwa4GGRRUy2AuTkfD85SgOhWPUI/IasXBcawiU5qb/FzbP/rVonplJMwvqLc06PltxgPshVhaYuEyhL 35d44Nrx lq2Fb/JPCJZ0tWo/2psypODoL+4KWQdXgfqhVUbOea3sRpJqGpfrdIeiySTb6liIY/RCmbpJPbp+kX6U5Sv3rvrEW9tfor/M8fos01zAwQk1q93ta9h+qHEJjrP6kmq2+kD4p6m0BRHYPZgPMoNmraWW0mmE3ou3xIwiyTaUpPUy4o5lD3P8UTHX/MrZP9adXXHT3MVrJx4o78jeFY1s4e57DCA0/5GqZDV6+ogk9BE3COGUbDyQeu0GxbdHZ7zAz6QjmvEJqIlFJOMiZ6xdOgujtBE5WcReZTFjhPkQ0Q231Ghzq+JuvqJQ3Ur7Hgd0nJg5OmOY/yBzKllPrD0yGOoqgVmHXOs7KbFGD88dmMHiOn93/C1w1GeID4cZAm2Gnmo6I7Pr7kizPOp1FjGkYBvayhkgNLoBrJVr7ZItZjlIGvR7pU6vVDDJNPMSIvrpOcIoXG5NCHCtO8jicobZjIfeTegMnFfdQBTPDJ98HMZR6c0Of6KJKpMhUXuPBn6N8UFdBjizjrg7oOKVj1Jlu54rKmBlvTPgO2ezEOves6C4GB4BdBqka4nnWFJMrP1/kqQc297Q0A0ZUTvyf5MzjDd8NKqoVlgIMGuwkgmYu9VonXkM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vlastimil, On Fri, Mar 10, 2023 at 11:32:02AM +0100, Vlastimil Babka wrote: > Also in git: > https://git.kernel.org/vbabka/h/slab-remove-slob-v1r1 > > The SLOB allocator was deprecated in 6.2 so I think we can start > exposing the complete removal in for-next and aim at 6.4 if there are no > complaints. > > Besides code cleanup, the main immediate benefit will be allowing > kfree() family of function to work on kmem_cache_alloc() objects (Patch > 7), which was incompatible with SLOB. > > This includes kfree_rcu() so I've updated the comment there to remove > the mention of potential future addition of kmem_cache_free_rcu() as > there should be no need for that now. > > Otherwise it's straightforward. Patch 2 is a cleanup in net area, that I > can either handle in slab tree or submit in net after SLOB is removed. > Another cleanup in tomoyo is already in the tomoyo tree as that didn't > need to wait until SLOB removal. > > Vlastimil Babka (7): > mm/slob: remove CONFIG_SLOB > net: skbuff: remove SLOB-specific ifdefs > mm, page_flags: remove PG_slob_free > mm, pagemap: remove SLOB and SLQB from comments and documentation > mm/slab: remove CONFIG_SLOB code from slab common code > mm/slob: remove slob.c > mm/slab: document kfree() as allowed for kmem_cache_alloc() objects > > Documentation/admin-guide/mm/pagemap.rst | 6 +- > Documentation/core-api/memory-allocation.rst | 15 +- > fs/proc/page.c | 5 +- > include/linux/page-flags.h | 4 - > include/linux/rcupdate.h | 6 +- > include/linux/slab.h | 39 - > init/Kconfig | 2 +- > kernel/configs/tiny.config | 1 - > mm/Kconfig | 22 - > mm/Makefile | 1 - > mm/slab.h | 61 -- > mm/slab_common.c | 7 +- > mm/slob.c | 757 ------------------- > net/core/skbuff.c | 16 - > tools/mm/page-types.c | 6 +- > 15 files changed, 23 insertions(+), 925 deletions(-) > delete mode 100644 mm/slob.c git grep -in slob still gives a couple of matches. I've dropped the irrelevant ones it it left me with these: CREDITS:14:D: SLOB slab allocator kernel/trace/ring_buffer.c:358: * Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing mm/Kconfig:251: SLOB allocator and is not recommended for systems with more than mm/Makefile:25:KCOV_INSTRUMENT_slob.o := n Except the comment in kernel/trace/ring_buffer.c all are trivial. As for the comment in ring_buffer.c, it looks completely irrelevant at this point. @Steve? > -- > 2.39.2 > -- Sincerely yours, Mike.