From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 342CBC28B30 for ; Thu, 20 Mar 2025 21:38:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D84A280003; Thu, 20 Mar 2025 17:38:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9896A280001; Thu, 20 Mar 2025 17:38:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8772E280003; Thu, 20 Mar 2025 17:38:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 69A2E280001 for ; Thu, 20 Mar 2025 17:38:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0BA031CCE9D for ; Thu, 20 Mar 2025 21:38:48 +0000 (UTC) X-FDA: 83243244336.17.D35CAA5 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf14.hostedemail.com (Postfix) with ESMTP id 7CCBF100007 for ; Thu, 20 Mar 2025 21:38:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fvKBUQde; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of tj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742506726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NplCETYboA5gfIiU8nQL+yYivMNByrohBJFolxbhYAg=; b=kr/z22i+Zp9vXgV2AlE8r0WvESuZU3Zp392lGYzYGfYTXKXblAtK6gBY/DGT3ajbrLXLFg pvxKidBKIvQ+0+fLB5zlOIJlK+fB0q2GnMfFsUMmDdjQkU5+I8kznuN6TfteKX8Z95xeQT xZODmWBj6rV0wCl+ggR+ioZSmR6UwtI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fvKBUQde; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of tj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742506726; a=rsa-sha256; cv=none; b=j4+CddJjbt/R39fwbWd2Y4DJlr54E69GQ/u+hkC6OyGTDtnJM4wyelU/HAhQ+3yC1vW7Lk 3K4T5sTSb0PFd7elgIJssErPBkjLtTzrAf9re6B1gUrdGXUjpyCcgkZVvVQKMcnVDgzxE4 WUtaKePjcO7ILCyUzUrMsQw11mvTZWw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5F138A496ED; Thu, 20 Mar 2025 21:33:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F5FBC4CEDD; Thu, 20 Mar 2025 21:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742506725; bh=l+uV6QrlO1o0C6zHA5Uga6ejz6mwdtS+qTv3EQ5ApsY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fvKBUQdeb1ftmbQv/66Efm80c9aM6wBp3z8I0bZEsKA8vLwZq14mSCnEfzZjwBhOO XjDmTDsEptWQjjETOTqUzvcV9uNTSozlQqOKw3ljR1/rtUDDukVGHT+kxWU1hCkp// jmgA2dDMvxX5z9x7kBUOMg26+mC90PAAz+bldgVIv0Y2naPPyG1Y8kOzStcbJsERFv Y8QQm8f4OkaezL/HwjYnoqg3o91Z5dfqB9TqrTGH799Dg2njdcJTXrH7Tq6yK4SwnM x/8kflr4TIORNhYcs6naXGBGKV/GzwnuCoTEXD3jQpt3434JX62sey0waIY1jUAJwX ipVKuUh2pazgw== Date: Thu, 20 Mar 2025 11:38:44 -1000 From: Tejun Heo To: JP Kobryn Cc: shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 3/4 v3] cgroup: use subsystem-specific rstat locks to avoid contention Message-ID: References: <20250319222150.71813-1-inwardvessel@gmail.com> <20250319222150.71813-4-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250319222150.71813-4-inwardvessel@gmail.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7CCBF100007 X-Stat-Signature: are19qhjshxdixq9j61a5jijj5iz7izr X-Rspam-User: X-HE-Tag: 1742506726-458622 X-HE-Meta: U2FsdGVkX1821IXwuOyg0dQt7UTPTzeFY4Ngp7q7/P3zPvPneSeCaCRUolZVuigU5olnADWhLvZ/EkAnsWGzpyXpH6yuoox/yO6gMMsXHAqQA8UQyM1Wb+wZRXkzztciQL0H87/tQ9avvvbJCKxBHq+Xlf88PujhhJKbiz1KKexGhjqweeZhJvTXyuV/exXkz5ZUI00OAj1RdiH5B0pa0xsc2l7nxtz6FIyMDFCW96+4zKftRi6N23G1L02Ef4PJOGCFdeU/RtH5pfurom4Fnu91TteKOEIF7jekiZ+S/Ga+uJFGV6poKvUkbBUIltIN52e6DPPP8SHdbZgehdgx8kkYbgtLNZaiJWSEYQEsySH9anIkyQP5WwjwMqrzM0djJDN77ApVCpsSnr1BFfYScbvFXbI1ybImPjy/XcY1nE+mh+bNDjv92OZOeo9h9mfcfqFiLgzxpZqjFvjRNd93ChFBqa1fiNbxCDQuntUEru1Z5KVcwmAkNX5N0b6+al9g8tLEB7KT6xkH3+T84N8WILWu6AQBuhBJOjdXBIPA1GP0m1U1Nn4xGaVTLTP0cICDK37Salb5fqiFSHz/31NJ6F0VI2tyQrbxf0IcEMKU7tgrQZRAB84bOIygSOlfxF5y5WU5mhYPFUuRdVZ6/VU9rzKb8Ok7MZL9H8OrhAVudsOV6zc18DPLiHY4xkv2tRFFaw/YveFudkBpKr4mjtHufHAr5DDTchkE3w6f75JN4xpOTRVF5QY/9UCOh0THOrVgzUslSlQPPQBUIBF4PPzRmzf0p3/DURsavj84UGGfA7z9t8qFrKCGOXesa1avrX8FGIuYFk+SHDr4xqrzfybKlRrjXxBvL1PJAfklbhFc+5+cy+RxTrEhwjTIfW4O74c8YS+alhum61Q7MXFLpnBkn/HFeMVDmkHzoRU8D67fG1dQOnjlN2vma0N7g9EUgV/4UF2j2zLrt0x5Wjn13UT WhEFG7lq XnAgC9XUAvyu2Q1OcAsY/cG7oGyV4MW2fQDYsvUUikYJwteUdSVZLKqvlU0rRX9Y1XFr1tWzuL1HZdW7wJ8Ire4YnESIP63bqJA70Z6XffJ2J04IFaMvUjIbmHvGbD3SSFYwL+oTBkprzTEZMn+bhbGmXnDu/PnpJ91gdD63Dr/vNKVzYkirfyWKAeKziWiAyppDtMJyVy3IU7RCAS8AKS3Tdmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 03:21:49PM -0700, JP Kobryn wrote: > @@ -779,6 +784,9 @@ struct cgroup_subsys { > * specifies the mask of subsystems that this one depends on. > */ > unsigned int depends_on; > + > + spinlock_t lock; > + raw_spinlock_t __percpu *percpu_lock; Please further qualify the names. > -/* Related to global: cgroup_rstat_lock */ > +/* Related to locks: > + * rstat_base_lock when handling cgroup::self > + * css->ss->lock otherwise > + */ Comment style, here and in other places. Thanks. -- tejun