From: Tejun Heo <tj@kernel.org>
To: JP Kobryn <inwardvessel@gmail.com>
Cc: shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com,
hannes@cmpxchg.org, akpm@linux-foundation.org,
linux-mm@kvack.org, cgroups@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH 3/4 v3] cgroup: use subsystem-specific rstat locks to avoid contention
Date: Thu, 20 Mar 2025 11:38:44 -1000 [thread overview]
Message-ID: <Z9yK5KYoQFg4thTQ@slm.duckdns.org> (raw)
In-Reply-To: <20250319222150.71813-4-inwardvessel@gmail.com>
On Wed, Mar 19, 2025 at 03:21:49PM -0700, JP Kobryn wrote:
> @@ -779,6 +784,9 @@ struct cgroup_subsys {
> * specifies the mask of subsystems that this one depends on.
> */
> unsigned int depends_on;
> +
> + spinlock_t lock;
> + raw_spinlock_t __percpu *percpu_lock;
Please further qualify the names.
> -/* Related to global: cgroup_rstat_lock */
> +/* Related to locks:
> + * rstat_base_lock when handling cgroup::self
> + * css->ss->lock otherwise
> + */
Comment style, here and in other places.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-03-20 21:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 22:21 [PATCH 0/4 v3] cgroup: separate rstat trees JP Kobryn
2025-03-19 22:21 ` [PATCH 1/4 v3] cgroup: use separate rstat api for bpf programs JP Kobryn
2025-03-24 17:47 ` Michal Koutný
2025-03-25 18:03 ` JP Kobryn
2025-03-26 0:39 ` Yosry Ahmed
2025-03-19 22:21 ` [PATCH 2/4 v3] cgroup: use separate rstat trees for each subsystem JP Kobryn
2025-03-20 21:31 ` Tejun Heo
2025-03-21 17:22 ` JP Kobryn
2025-03-24 17:48 ` Michal Koutný
2025-03-19 22:21 ` [PATCH 3/4 v3] cgroup: use subsystem-specific rstat locks to avoid contention JP Kobryn
2025-03-20 21:38 ` Tejun Heo [this message]
2025-03-24 17:48 ` Michal Koutný
2025-03-19 22:21 ` [PATCH 4/4 v3] cgroup: save memory by splitting cgroup_rstat_cpu into compact and full versions JP Kobryn
2025-03-20 21:44 ` Tejun Heo
2025-03-21 17:45 ` JP Kobryn
2025-03-24 17:49 ` Michal Koutný
2025-03-25 13:55 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9yK5KYoQFg4thTQ@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=inwardvessel@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.com \
--cc=shakeel.butt@linux.dev \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox