From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D944C35FFF for ; Thu, 20 Mar 2025 16:59:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46929280003; Thu, 20 Mar 2025 12:59:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 418AA280001; Thu, 20 Mar 2025 12:59:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E140280003; Thu, 20 Mar 2025 12:59:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0E112280001 for ; Thu, 20 Mar 2025 12:59:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6BDA2C173A for ; Thu, 20 Mar 2025 16:59:37 +0000 (UTC) X-FDA: 83242540794.01.A3550D2 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf03.hostedemail.com (Postfix) with ESMTP id 6A44520009 for ; Thu, 20 Mar 2025 16:59:35 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Bm1mQpll; dmarc=none; spf=pass (imf03.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742489975; a=rsa-sha256; cv=none; b=YcsRuRqlX0NTPf749wsyjxiFP5GpfPaSi3AWfaxP6Io8bhZ1ja9MWO5GYxlPhC+s2Z+vLm b/HAj+2IIt6VkwpiPbdATP91MPUazltvDOo2cOWZkLizbI+DaApaWS9G0H2JrYPDZmwI9m 3IF4i+MATdyC6xIq8y+UsZbwFInjgfA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Bm1mQpll; dmarc=none; spf=pass (imf03.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742489975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ipib33z3sn+yQKX9c566UprPG9ZeHYaheF0uNRUCV3M=; b=MV7u5ma9wEOTCgOOkzcHdXbH50KEB7RB5lAQE3Em7OzDa6rxv/uwK62XSvkUsqZwfI7w1x eqYB3Yd+2CmhHmknTczg/NvltFfhJdBDg/c42OyKzsa/FxCLEurpKdGsqOj5QjHO1i+O5y jN7927pu7oTO7EcHvAhAhvxjzRRRRe8= Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7c04df48a5bso112866285a.2 for ; Thu, 20 Mar 2025 09:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1742489974; x=1743094774; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ipib33z3sn+yQKX9c566UprPG9ZeHYaheF0uNRUCV3M=; b=Bm1mQpllCTLZ33iEgu1WH2k/etBsOawGYAOCLrzcg+b4aEewrjuaUZlzw97FP1OV5K m0N+UA5+6vKa/+8ITczJ8YZSoXHl+oq1e7WKx2lVFNdmA5kHshrE8xx8w5jD6FhaTUlV Bjdpkbr7ivYw1F1B8wzn26SBz9y7Nf+DANIH1DhiiikkLHQHPb9eKQxnBX2pu+JWm5HQ VgSErkHKGQ7hmG06AUfViVxYTC7r9QYNHS+r1FSnUPG8le/NJJ/P5MbNk4AhvjtxIaVx lUrD3kv5Xpcd9KYsclZkkCvgGJdN2igqk/uEaQ0Q6D+ahQEoNUOA3jCgngXX6V2qTHIu ejgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742489974; x=1743094774; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ipib33z3sn+yQKX9c566UprPG9ZeHYaheF0uNRUCV3M=; b=nK3xVyRdyoG6Vg2X5UfsPgHnobs8qO6yuBfOHMlBSe9es7k9mM23TrwPLe1LUWI4Zd ufzhehmWdQ1llo8n6FunRf5CHrQCVRL93OgVDcytQixMQvxUdlJbEisIKnUqwkSImgVC tGxhSrjswZjr0yCboXo0KdjroBEsrHBLpRN6vaZDwBDJeWB0BEulzPmon51nAqmvRlRH lWHBayntuiw7l2BeinuknGekUI9yn6QPTen3WY6MMINvZ3hCdpXZHBBSXcK4Zl/4weuT sUOChbKFPw0s++3lfNaZDHSUZAaVlATfmAsteKJ4OE8t06y5mWwmtqivMjej3ifymrAw C0LA== X-Forwarded-Encrypted: i=1; AJvYcCV41V7lekuW76FdV/Uh3CKpPsEkKasFVpYBo56bHmhO//a3bZEnWIhaxLZf2KvLldY9qT60ZgjhSg==@kvack.org X-Gm-Message-State: AOJu0YyLn1pwN334k7qMydmiOImpzsQF8n9EuoqQXCuiNJYqfEpU71P+ yKSrCXsBeMy9ffEAKFXWd+cIhf1BtDXveYKgZGd4fvJ/9r+Ue7OjA7k7h3ztCio= X-Gm-Gg: ASbGncu1hyyHFR3e+UU1ThibOCuRI7T3I8oYYoAxozI5bEUrblKRtHRl4oBfYSm4ni1 h1CNrNOyvf/KMR6xrIKLlL6/Fk5cO668+e93FH8cgWCciANhACqcQ1zra5VBmUaovrfo+LrD+s6 7d1csKbaiJBW96o2npy81nerHyNxO0EOqYlkFA6NUEzFom+tt1mhNRxFWNfa69/YP6YXUk3bftG 2eb1YfF5QnPVPbjV/Un0f0PNEWPpLmSrEjO8Oy6QLF9IzAGvDsE7CBEezvTyydJAxOOFTRLUUys kdsyHkAWv5lxUjpnLmqs//ac40wKSM3fWzjD+SKUkON+ghZsApGwfsG0xzjfJlJf2K3sF55mZCg /sVZkfpnyJf6l7XMigWpbulfZ07U= X-Google-Smtp-Source: AGHT+IElzU98u73kWcMh/UGf7sxJFt1GG443MOL7RYcIkJXTEKBGeUAa+MD93tb0ZxGrkPDd7DzAKA== X-Received: by 2002:a05:620a:c4c:b0:7c5:5909:18d8 with SMTP id af79cd13be357-7c5b0c8875dmr458154585a.14.1742489974499; Thu, 20 Mar 2025 09:59:34 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5b92ec688sm11579385a.64.2025.03.20.09.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 09:59:34 -0700 (PDT) Date: Thu, 20 Mar 2025 12:59:32 -0400 From: Gregory Price To: Rakie Kim Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v3 1/3] mm/mempolicy: Fix memory leaks in weighted interleave sysfs Message-ID: References: <20250320041749.881-2-rakie.kim@sk.com> <20250320054010.914-1-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250320054010.914-1-rakie.kim@sk.com> X-Stat-Signature: fnni6b9bj7qrh8f7fmpj1z7oynwtri4f X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6A44520009 X-Rspam-User: X-HE-Tag: 1742489975-298890 X-HE-Meta: U2FsdGVkX1/bOr/XfurOE6AnN3+U0WoCyd57vWk9MoUYg756lw2Z7Glts+a/0unCn9gvkvcd4SrWRtUQFUUU5e22yq0yUXnCwi8TILAnsEutMKeXHMXuMX4eydOdAAuAZnuvYFm+Ld/0aPmHW3lG0DNTutSCLTKV2LODl7TxVk6lmq61Q948iVcJ2TGUBE9gNKkaDHpbUiDSKun5XnpF3PCGzaty+/Wkz3BY0olXbDSwuPYe9Kj5OZb+Fl2IP+NLbrI9x8y3xV5cewTXiUOKp0iRd6UukqhOPekuzaUIltR0c3MMX4X3By4hlHrvLOio3uOtenyK6quT+qaWccgmMslBs48/Kkuo+F5VyJOlu1VKoPeUBe41LTyzE6qY+3e3peaXEZett0eweQcBbd2fpxFau15T4f5v7vRSoEwbV5x589dGkU/VQ/RzZaXYkSeMORX8cwFkb3eJGyoNC+W+DTcKCWEZk4v/Bt4pzLxveKlgZ3+0buQdXzjA4lbdnH7G+nYLgD12oJyeZWp+wV2KuVk4esxuiGU8g/HYPncPPKrq+6RS4YYa6SRURIe/b8qj6JkFz3v4vL8+5/BK4uwbsSJ4p8jtqeT2uLLmQIlzrCX34BjMqu/mc6YQjuOzAbQ6VQks+vxW7ekkDu4m4J1pDIDG7lHUX3tPwTiT/L4HezWkP6Cp3ml5uxUcy1y6dyePvrx876ZnheDExzYkvjyWm+BhcFXYw/aBMAe25jtnEtYfWvz0cne94k1J1gG86cfDu8Ja3yNkbbvTXZfa+UPnWBgyoO/mhyHHOLTF1SaU8tQtbWqI1PSo89ovJANkxfa3td8EpOJsAMxj+7aeazqM+NqIj6gkus6z0bbWFw5ln5a3+j7ePAagBGZPW3D37DYRuzwMQ7vRyvWN6M1M7ZgSi8neCmoztXj6EIudA2iN+tuiaMOcMYc59ReSM4ZgHJsavJQ+kKzN8i4w3cJCv2l AZfWyo8+ UXrhq7XhKnMgOd+Sp1QjjUHopLqRRxLwtqd6mvnHyq8UMA4DHXoP+BHc53Rn27gyEpVGTrxvWM8ycJf0gvuTZL7JNGKibZyTq3iCvOkSyxU3aIQWpRsXrTIqzO1y1JK6RPeejMKpbnM50tvQAh17ueXnJlZqDFMHqBA87Bi3PcN5miuKgzQDeJUV97yrz5mL9uotKxFWtU4ZZOhM8jMi2jDqojerEUReftZquvGtPTb7IpRbYhUjYl2bk0OC7ssHMP9A+0ILBMzd6EYRTjsITQ8TOzQ5wMFBU2FoeHOYVwcAbHGnKmcKznM+Hzta9WOwRvaodLs4BDXFDT+ZQ6BQ/XdiON6bX4TmV3FnvW7Ljs+FgjBuiL9zse5CnrGIEXHC+HEwwpL549Eqc2omIrd1SQ05KcVKHpNaMCjtHPBEuLJEM7S97qeunNQlTMFs9ncQaxKXxHXxePOoisgs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001228, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 20, 2025 at 02:40:01PM +0900, Rakie Kim wrote: > On Thu, 20 Mar 2025 13:17:46 +0900 Rakie Kim wrote: > > Hi Gregory > > I initially planned to separate this patch from the hotplug-related patch > series as an independent update. However, after reviewing the code following > Jonathan's suggestion to consolidate `kobject` and `node_attrs` into a single > struct, I realized that most of the intended functionality for Patch 2 was > already incorporated. > > As a result, Patch 1 now only contains the `kobject_put` fix, while the > struct consolidation work has been included in Patch 2. Given the current > design, it seems more natural to keep Patch 1 and Patch 2 together as part > of the same patch series rather than separating them. > > Rakie > The point of submitting separately was to backport this to LTS via -stable. We probably still want this since it ostensibly solves a memory leak - even if the design is to support this work. ~Gregory