From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120E9C35FFF for ; Thu, 20 Mar 2025 16:27:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 180B0280002; Thu, 20 Mar 2025 12:27:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12F08280001; Thu, 20 Mar 2025 12:27:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3842280002; Thu, 20 Mar 2025 12:27:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DAA2F280001 for ; Thu, 20 Mar 2025 12:27:28 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C20CCC16A3 for ; Thu, 20 Mar 2025 16:27:28 +0000 (UTC) X-FDA: 83242459776.03.DB6BDAB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id D1045140012 for ; Thu, 20 Mar 2025 16:27:26 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uyvierVq; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742488047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+XGyK17VNfHnVYETWffBN7SGjSJqT62GP+tR5Jc+Ncw=; b=qDdVITwd/PvcngYMyM/BTHyxvl9s5yRoiY5PIm5KoRVEGqeotDgY7HUu2F1854ZksjFPlr VMbbXS1OrJFkFYqnW+ljXUs4IYGfq5cMsQzC/p4bMWPIvmM57jtChIvOfF6E2cjsolWVi8 HbrgEjNCgJWjJPo5+QDUw38xVDZKWps= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742488047; a=rsa-sha256; cv=none; b=EYKVLQshIp+6Af4jkQELIUOqEbeo1anbu+OWQqDPtB3t5vuiCRjAVKlOHWgkFkInaC3Mja rF1JVTpCNURWfyyYvY4ypfaiV8Ax5Lust+oxWz0fpMZPQwDpv2oU71Wey3tRFbdlEOIrHi dqpZzGeXa/u3sRncLAOuzDSieneQ2qc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uyvierVq; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+XGyK17VNfHnVYETWffBN7SGjSJqT62GP+tR5Jc+Ncw=; b=uyvierVqVh+ez4Jl8iribAOwM+ fjwQ3mRizK/R6sD6olsiGv0i6WAZ2X7UMWbPbRWi5kfJ33XKKkcYDBuNitLy7/M0iUBRqivkC4l1F C3mCLd21MoBQ+2SawSVR/vJ1hF5RV9+3p7OmRqzmFp3tGRwQoG9nXIYYx8Zr3GWgw+7fBK9mHV9Rt 4DCDG8TYb/ncpwDP1ixgam6Q55mNc7cNmzWeCMcNOrPoSdkqENUU9P6qRR+R1Narw22WhDwJGQKXI e87m1zBx+HCHupHvTBTzQ2J9RuwqVN8curp/y/JJzk1cuCtxE28LvInjpQWOBAnKmuNn6jDHV7TSX m37soGgw==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tvIji-0000000EDcS-2StW; Thu, 20 Mar 2025 16:27:14 +0000 Date: Thu, 20 Mar 2025 16:27:14 +0000 From: Matthew Wilcox To: Bart Van Assche Cc: Luis Chamberlain , leon@kernel.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk, joro@8bytes.org, brauner@kernel.org, hare@suse.de, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [RFC 2/4] blkdev: lift BLK_MAX_BLOCK_SIZE to page cache limit Message-ID: References: <20250320111328.2841690-1-mcgrof@kernel.org> <20250320111328.2841690-3-mcgrof@kernel.org> <5459e3e0-656c-4d94-82c7-3880608f9ac8@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D1045140012 X-Stat-Signature: erxztbfpx9zoashjody95uizw71wepa5 X-HE-Tag: 1742488046-639465 X-HE-Meta: U2FsdGVkX1+B8ccVO8APPMgBugbUnZ3p+qdnCkOczfk3S10V/UuMWUG9kXEtPU34ZiDC3MR+KEf6V0j6newOHyV4+ADmogxt6ax6NwF4EaeTsI8kqamaB7HsWm6ILjp6/Qdg+E0kQoU1xuf4JX1il1NixXE7zIJyS0hgG00q8XT3AwOFv49Enc4EDMUap/weL23cYw5C0MMLVdEAs/5oiwQP7LNAteRIMgUQ+U1iLOKbLneP7Bl+eUDNEau1tXatTACMDE02wCb8R3yW+CB4+vckvgp/VnvLUTOhHIPdJzvH/7dk2lUsPktc/yReix18TXKyeyH9LBtricPz0vH/laWOEHhP9Lf0iXlqj7wyjwOD0viYaugfvO4SshXfsHGd91VvHTbHNcFM9pBqLKA+E8fjKhnCgiwNBzJ0qqiSZyb6JCfa6/ymFvx/xOajBWIpipKl2sxlKjaeO8bcOFNnWOcvvVXSh9Vv1JkCib68n+CPbYwRGlItcD4zOdBRdGz4/nUBSJRRTGUqwO5jCdHcR9LUIH/zSdWV4Hee0Od0JpW1ZTlWjh970wesYHlFHTOFwUUiiotTT6Jd/t8SRRWGqRDv7SsfSR9j+Lg5MCkh+kiLhd+E85ByB+o3JLnmXkWXrFnMIvJ0Tc5dALuEcxreCHlL0SLks6Zk12+oRPLLm5lKFU+navxL/7ooMikOyIdOyl5cH6+pYqJ827IiAxO/7/ohSY3J0SHyY19G4vNaEnHSUts6ypPl5N7GWWCS1/EvbrpkIVuie1uS5ryXfxygxXne6xVF9QojmSky3YQbFtGfsXHftxfT42VKmpdGjTfHSuDksaf91qveUKya83TF6Jd6fqW9MVDN5aaV6QFJS3I3bMz3fWF9VHvCCV4xpIrb6UHHUSOvmTpyJM9m6GumsMy5YyWsp/R6IDbtdS9vqC+GdfLpBsvUzKr8928s25Yy1cHtXzY8yocfkl2sqC0 N3eh6B2N eRvzgMBE7BJM+1k7mKJNfOQwg0M7CCO7XAzaPVgEppAvIjnyS+Wo4GPnfHSZJ1pf8HrWAoimys013nBspJBm2FnrwAEGOiqX4MzcW4OKYOtPE6qAJQ2swrLLN0ZIKP9nRX1GnoL6aZJaa9fMHTdtpFN7dcVf4fdW9F7Ff4C2nl+rusuvyPzTE+ukSd+wcX40IoYaELC8qgTLCVFP5YYV01VoMpBC39JdtjfwamJbdBbC9rn7xnK6dLxQzOMvq1S0D/51kH7XVbbZzihMWOC7XlYGLG8n+HfDkv4ems15amYK0NsNl8x2VxuFZHLQieZLFv/oywdrygYy4MeYOy7Cnh/Is2ORX3kFOICRq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 20, 2025 at 09:15:23AM -0700, Bart Van Assche wrote: > The patch description mentions what has been changed but does not > mention why. Shouldn't the description of this patch explain why this > change has been made? Shouldn't the description of this patch explain > for which applications this change is useful? The manufacturer chooses the block size. If they've made a bad decision, their device will presumably not sell well. We don't need to justify their decision in the commit message.