From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3D7C36000 for ; Wed, 19 Mar 2025 22:53:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6A7A280005; Wed, 19 Mar 2025 18:53:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1C6A280004; Wed, 19 Mar 2025 18:53:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DFC8280005; Wed, 19 Mar 2025 18:53:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 714A0280004 for ; Wed, 19 Mar 2025 18:53:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2C2C51404EC for ; Wed, 19 Mar 2025 22:53:25 +0000 (UTC) X-FDA: 83239803570.12.217FF9D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf20.hostedemail.com (Postfix) with ESMTP id 7DDA01C0002 for ; Wed, 19 Mar 2025 22:53:23 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YtV0RUua; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of kbusch@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742424803; a=rsa-sha256; cv=none; b=26bDEIALORu9DgPYbMR1OgYrCuMGlSnsjcmwbe8PWcFHoCpWX19ic/ZEH41DhYkbIFtTGX nJiyJl1zswoohOiFk8H4Z3467N9n7IfmWZ2fIrILHfSxJGdyBK4V6qQidjZbGnZ0UPZO9t paVf2zAJxZAE5MHRHvuH3QjGl61xKzk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YtV0RUua; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of kbusch@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742424803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=taWB0uXbzkRB1mUN9KZfaLzgtuo90Ci8LAw7+KXQGL8=; b=t5L/AuQ0SqOOv+X6VmaPb/+iitiTMdUIHosh0k/AqN1xy831S/+Q2+oX0fDoWUgytZD9KV XMuLMy6zy8107aHGdJ5qb2esBiwNChXCowRoWTf/hlJJpj3n9NViWTijemKg8YrEBUfhks IzEjuasafS79wkXDnvankXfJCzs+kqw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 491F9A48A8C; Wed, 19 Mar 2025 22:47:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBFFBC4CEE4; Wed, 19 Mar 2025 22:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742424802; bh=d+VUlRbK15AHSFijWQvk3uMYQmbTQJLLjN8PURft8ho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YtV0RUuaJkhmaEiHB2PZgmeMLgwQjqAjWPMrJzalJ5tRkWiU3WCYb2rYplF0qvr+K i5ozLcRQ1OlREyfH48tOvBsxYt8jTyaIMyXgbEAca6fi8fi+p/9Gq/MRJ7Bh2uVqUN wmI7HM4E3ma4o8IXmYOyYnICbjxoBcT+m6es1oj9vlLDldHht8CNIBmVWR8cx510b7 ym5o/hft4iG4Zk4jNqPqe4RAJ+xS9ngXXJGD/HvBrZ+PTkLGRhMe20E2P4MDYweGDw NYT0xOhlkQnL39VU5LlqSOCljukD8PlM396DMxP1/UdyMhQC+yHuzUuE2FaB6fsGtc Lsip1fIhVxvwA== Date: Wed, 19 Mar 2025 16:53:18 -0600 From: Keith Busch To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Gavin Shan , Catalin Marinas , x86@kernel.org, Ingo Molnar , Andrew Morton , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Alistair Popple , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Borislav Petkov , Zi Yan , Axel Rasmussen , David Hildenbrand , Yan Zhao , Will Deacon , Kefeng Wang , Alex Williamson Subject: Re: [PATCH v2 18/19] mm/arm64: Support large pfn mappings Message-ID: References: <20240826204353.2228736-1-peterx@redhat.com> <20240826204353.2228736-19-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: fppm1fbkbuitoe7dty4w449xfmgzwchh X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7DDA01C0002 X-Rspam-User: X-HE-Tag: 1742424803-87987 X-HE-Meta: U2FsdGVkX185J/iZml6FGjgp/UjQAmOuZE/Jn1qVHMEyAJbVS8LzpW7NGHrQC9dpw1kr04BkqXebQnqNIqAmL6tPzJm2HvZ8fJdxtBf1g5Ywg83igU9kxjGdHANr8QpTn3k9uol362xBjNrMnkubXHCbzrHfwSomgz6T4YOWZDHJMxlH8zX19NgKCCJJ0LrU46ZysSoeyR6R/3EDNU/dqi3jeF69FjGswrfXvs55A+rR/Ez6oSFFIxZ/1pfdgFD0OZucc7iSZ1dRP5f13NO5y6iZ48bfqzrl6wPIeYnWWWdav6ebEHibOrcdenNC0WnpMCDbgcIkLHPZ+4GHjY7Zbi7neTCElkdB8UjwwSSCCSQuXbzHM9aNxdxEq6Qnt886t+KYLQpbmzOHOq3+DpeX5PbSGdddz4liCtRlBLXtpCJYFLZE7YkVPVnOkjC5fWqupANGu02a6k+jKoF+byq+Z6o+RlE65Lk7K6JZ3/6oji/cv0JMROUdAY/eT9WhRGHMDuRJBijkM4uFW9KeGYJI5xA+eriU59LSmkF2lgRo75QY8DCsxopM6h+WrbYXUUBxeCPoP5+4gbru+fyby1Or8CTIGUh+XgGJ6xI44zBCsV4UatWrH0Yov6mF+LuvqOTSgCpSFte6GR75W6tHViCAhz66JiTey1wg2DX8Vqm0JXZq/v96BG3X+I5xGwSdSSMQ5V0H5ZYoNfE/nlqao+tEQcrRunIymcBYIAY+eWtvkZvqbkVF/R+WUnJbhmu4JDEeg224h+f/QcqPgfeDMb4n5Sd66c94qCjr3NbhGzcS1NSpyZf6Y7LM3kqkZ5WmYA/pAJK8hHVEFlDfU1cUI/W5yRgTbJPkd6aLQ01KnORhOO3tpwSqsuM5/lG+SQMeb6Bg07xKmZmCykZvWFnkfmOMxbQl2iA9y7iTkMuKaGMIBA5xa9LpD+G8WlXXs6VehGEtviUgDNG8vjKhYAE4QBp F6pOioV9 nWe8vjsQSOsM1xFywP4t8FvM7ak4QiZpMkL++5iqx8qGv2VmAVAEyZABThhitjs8CisFIzAUdqSVLsQJmG+sSlTLJfvs78978axiR9Ek/veu+p2r+2baJsBQTOL7JkM8ogoIxzzxy/iuiUImPe+P+n889fby4qpJBLq6kMKmWhrtO5iA/nYZD6EOlf04aILKeWl41SknytgwtHz/PkBRxQB8Dnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 06:46:35PM -0400, Peter Xu wrote: > On Wed, Mar 19, 2025 at 04:22:04PM -0600, Keith Busch wrote: > > On Mon, Aug 26, 2024 at 04:43:52PM -0400, Peter Xu wrote: > > > +#ifdef CONFIG_ARCH_SUPPORTS_PUD_PFNMAP > > > +#define pud_special(pte) pte_special(pud_pte(pud)) > > > +#define pud_mkspecial(pte) pte_pud(pte_mkspecial(pud_pte(pud))) > > > +#endif > > > > Sorry for such a late reply, but this looked a bit weird as I'm doing > > some backporting. Not that I'm actually interested in this arch, so I > > can't readily test this, but I believe the intention was to name the > > macro argument "pud", not "pte". > > Probably no way to test it from anyone yet, as I don't see aarch64 selects > HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD, which means IIUC this two lines (before > PUD being enabled on aarch64) won't be compiled.. which also matches with > the test results in the cover letter, that we only tried pmd on arm. > > The patch will still be needed though for pmd to work. > > I can draft a patch to change this, but considering arm's PUD support isn't > there anyway.. maybe I should instead draft a change to remove these as > they're dead code so far, and see if anyone would like to collect it. > > Thanks for reporting this. I'll prepare something soon and keep you > posted. Thanks, good to know it wasn't reachable. The reason I was conerned is because the only caller, insert_pfn_pud(), just so happens to have a variable named "pud" in scope, but it's not the pud passed into the macro. So if this macro was used, it would just so happen to compile by that coincidence, but its using the wrong pud.