From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B23CFC35FFA for ; Wed, 19 Mar 2025 22:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC253280005; Wed, 19 Mar 2025 18:46:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4C2E280004; Wed, 19 Mar 2025 18:46:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9E2E280005; Wed, 19 Mar 2025 18:46:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 89358280004 for ; Wed, 19 Mar 2025 18:46:45 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 76033A978A for ; Wed, 19 Mar 2025 22:46:45 +0000 (UTC) X-FDA: 83239786770.01.EA61A65 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 112D61C0006 for ; Wed, 19 Mar 2025 22:46:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QhBC3rG8; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742424403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Axll5Mi+5wEaWyklP7NmIivlU8IChwyIqobsotZaqY=; b=Mz2fQuzClnAlHXivgHe+5AXikNyBGC49L+ttDp116orTOeb5IFnVuy8X8s5REKDODErK/8 b8c/TmwudOwcYr50l6G+4TkvlTXek2GCu12XfmSRYGaWJZY63rhl/pR8zXY8HxP+KQSFI2 bJhYrshIND6kUdpZwr8m0f7SpBfQQ7k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QhBC3rG8; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742424403; a=rsa-sha256; cv=none; b=WbVsJgXFoqt4I4LvnFeuwEIqcfI73gU/0LftkWaV+j1pqfRH1UtKiP9dn2ubcu4qvUocN+ mr4HUcZhY0F4F0zX8Mgtpv2G/BFi7Pt/DqWdgtM4fJnFMpapkPWkGjEyYeFACvX55k/67k sAJLQJuZD2g1aO790xU0ks+OIDeKgHI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742424402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3Axll5Mi+5wEaWyklP7NmIivlU8IChwyIqobsotZaqY=; b=QhBC3rG8cmAwUuiItBR34NUuTrw7CTbt4fmvG3VVuT1kiQdVDZ7wQkuJeeLOtwOgqKfyJK CDKcxNpj+767wPRU4PpPJ5BdtbqWI0aSKzSLK9KKHC+4iXYPNL15RBnP70X4Mp+kO7JZcy 9nwNK+gkuzxleA1VRnwWpIMueAcquq4= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-9nUk15LhNbGnm2-kSq7OnA-1; Wed, 19 Mar 2025 18:46:41 -0400 X-MC-Unique: 9nUk15LhNbGnm2-kSq7OnA-1 X-Mimecast-MFC-AGG-ID: 9nUk15LhNbGnm2-kSq7OnA_1742424400 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c572339444so33802385a.3 for ; Wed, 19 Mar 2025 15:46:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742424400; x=1743029200; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3Axll5Mi+5wEaWyklP7NmIivlU8IChwyIqobsotZaqY=; b=dUmb1a8MLDcU8DFMH2wdoahOvjwZLF1KC9uJcA/SS7GyuzzcQZfUWEWhMbpJFx2YEO tLKOMk5Yq2BbJNHWDWHpqiuy3n9nsIGrDP3Aamenp3yCdMAObpcKdmzdo1zWJLFwtunK I6BO/yz6zGrfRYKDLcXRlga7Z2LUnch8kCtEowpH//eWKb+plKTf0zyEihhenXGW1xvP CTox5jDMnZt5bMNczEbf2MUB1OnLfkmBo6GSpZqj+WESqeg/PHxzjMouIwjsfOb9OsHN j+mwoPixQJI0Lp5nRuSnS08McAfez5+/4dxQoXpmvkCDpmGpRPFOAZbgAGBXpDNwrxSw WiIA== X-Forwarded-Encrypted: i=1; AJvYcCWMO/E3QvTNrDJ1geqpFZnyvaNjLslMSu1t1B5ucYCMpsRWVrbKq6LLKlNneGp3RjWhIOXYbx18LQ==@kvack.org X-Gm-Message-State: AOJu0Yz7Ts7hOVPfujcTa8DirKKkcT0wvPxp6esLM4h4+pvuX65MdVd4 Q3OHtMDWPC8tEtiAoaD/bj9nXj8Y6Mf7FmPpQPDWmdBv/8ei9qFIjWjbZr8Jr2Hi2SdbxgLsiJN u2AO6fzUrE56x15xjEscZa8AW0FOhKuvsf8AcHWiNKN06YRPx X-Gm-Gg: ASbGncuxVhDcqluSYwWIBX0XYcq1QQbM/zyXJdLjHcDMx0R+3NCE4FpuO5YkGKCH3sh IrJkUpGEyR8Asfp5x29UQLeDhtZ1eTBbw1qmVkybYfklOSec3kRIEBBfgKvlXM6c2ZLmy+13nvw YbTWUvz79pqDtSGBCfS+8NJIBjXTCVZG7yzXiiktiGVagfQFTr5KLMZSM2jM+P0pFtdNKwVppmp ym2dqIbYiUkjrYILvX9u3Pb6dN3jWhOtwH/x5ICAK2oyvgN0NMoHNDN8Gt94i7OSrXVw+ZGoFZg D3dAzYs= X-Received: by 2002:a05:620a:46a3:b0:7c5:3b52:517d with SMTP id af79cd13be357-7c5a84d9048mr821829985a.54.1742424400708; Wed, 19 Mar 2025 15:46:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHVqyT+WlTFMbuzlij17W/8zZbsASQKuVXERgdl8uzrUKPSgGPykK/7AJobATtMc4xtw1MMQ== X-Received: by 2002:a05:620a:46a3:b0:7c5:3b52:517d with SMTP id af79cd13be357-7c5a84d9048mr821825685a.54.1742424400401; Wed, 19 Mar 2025 15:46:40 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c573d6fbbasm920353785a.78.2025.03.19.15.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 15:46:39 -0700 (PDT) Date: Wed, 19 Mar 2025 18:46:35 -0400 From: Peter Xu To: Keith Busch Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Gavin Shan , Catalin Marinas , x86@kernel.org, Ingo Molnar , Andrew Morton , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Alistair Popple , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Borislav Petkov , Zi Yan , Axel Rasmussen , David Hildenbrand , Yan Zhao , Will Deacon , Kefeng Wang , Alex Williamson Subject: Re: [PATCH v2 18/19] mm/arm64: Support large pfn mappings Message-ID: References: <20240826204353.2228736-1-peterx@redhat.com> <20240826204353.2228736-19-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rpwXcYj8_sJcQL-8USf0kA5HL9ec606JEfu6GE5XFs4_1742424400 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: wm1nqxzj5c5efoyype5q4bjsieb4qmpj X-Rspamd-Queue-Id: 112D61C0006 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1742424402-830115 X-HE-Meta: U2FsdGVkX18SJtFSj9pL768GN0BiTNHjJDE0LV0fW+W71wD/IvMbk/puq2il6vIRHFqr1ZevO5foLSOxcLL6psEcztqd0gaXD/0918gAbjrigkSMLjFIouUUzZX+P+ZTkCK4MuAYYGtCUBEHoZreJPGH9wRcpX0mWwL7Ey6L1Di7bwMr5rQ513CiWH90oH5JTfN9cZz4Cke5vKYWixwtK/wh8uJGvpRCFPLaWSNPfEM3YYTkwNoiIB/RKUMKjT9KuPua8xs6rHHntBDBhFFQaGjCbucT54tT4vnYjNMYF7lx36+OT82KIg0YzEVrr5ddVZ7WL0coCmexIFrdz+Fvugj/+mOw39fHPu3FwRWIvFlxvph43InA8xyKtBYiibhuqJD7R73F1jWhuWkXDjapTnsAEDlt0s2YeDGHzPterZ+ILvbUJ7qMbczYx80HYLyDQd/C+ALnHPD45WvqAUV4V1miDiuVd/W5yUA8Mj63kIxizElL9UHr2WJGm1mLQ4Sj3tVywYpwByhpqfUikRyB4cyRqIj4a6hXle0OSEecGrAinNn494v5Gz5P6wB72eTOS2YCj7otIynpDfBZVI9AqmCFcCaYnWhrvB3qgXGFp/NFUa8QamUAUkS2ffqcqSVVAXQw7rZIcc/gRoUnj/3ax98b8Gj4UhCWqIxWCfshngI+DYx0LyH+7Gx1S3qdTLPtig/IfChcjDEr3IAvsGU3Hb3f/aXfI6DFgkQ7DOGvq38ZlwaQxeOp/SCSXqmAKsGXp/+e8pl0N/FD1EF144/riC+FMunqMpXieR61UpBv3duNygwszYOxklAGQs1SU+IUsLjLJ3iSstlex9apfJmVpcmn2fRSfTPC23ls1eiXO7/II99NlR/2oBWLs9E81vjE5WZ2IWJwRSx+i3eCTawH7CcE078GMT3KyhPtZ6LELvDtmMzl8dxuk/+1kJo4Zl//2M9+W7XMVcvl+xpHcJI EWrhv35a LghQRKK3jnMH8NVxGNQn5wIBOgqdDibnQ7rGU95cqu6sW9P6AbXexlpX5zxI8Odn+gfbuKL0zLhysILIFsTPSHlaYp9O63XrPUdB2mCiLbW15uiCDpsm7Z7Fwu9smfJZoXDk7rB3cYFcFvv9VJ7WE6rrDTb4wm+MUvSyLd01WwLdupheMJAAQhO860LdJx5YswHfvBCDzutzPSbjaqcge29RiNOkus6kC79jR9AHd3iuGCqrnRO7kcRyceDhp3w3GWMkdRYiGJ3UiE8antCl3y6cY2usVx8D9e1EhCwpErAQrknqoIGM3FlH2U8HtKQICn+yNxR+PFG71VWqbgLPwZcXMf/J2T4YS6lInvNRDA+vFt9wa6Hp591tlBoJEu25Y/IFb7aMJSht/gAKbCKtRw3too9N+PGVS2vTS1vijbTAXXaqliYjzQ0lyTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 04:22:04PM -0600, Keith Busch wrote: > On Mon, Aug 26, 2024 at 04:43:52PM -0400, Peter Xu wrote: > > +#ifdef CONFIG_ARCH_SUPPORTS_PUD_PFNMAP > > +#define pud_special(pte) pte_special(pud_pte(pud)) > > +#define pud_mkspecial(pte) pte_pud(pte_mkspecial(pud_pte(pud))) > > +#endif > > Sorry for such a late reply, but this looked a bit weird as I'm doing > some backporting. Not that I'm actually interested in this arch, so I > can't readily test this, but I believe the intention was to name the > macro argument "pud", not "pte". Probably no way to test it from anyone yet, as I don't see aarch64 selects HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD, which means IIUC this two lines (before PUD being enabled on aarch64) won't be compiled.. which also matches with the test results in the cover letter, that we only tried pmd on arm. The patch will still be needed though for pmd to work. I can draft a patch to change this, but considering arm's PUD support isn't there anyway.. maybe I should instead draft a change to remove these as they're dead code so far, and see if anyone would like to collect it. Thanks for reporting this. I'll prepare something soon and keep you posted. -- Peter Xu