From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C457EC35FFA for ; Wed, 19 Mar 2025 21:48:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A6EC280003; Wed, 19 Mar 2025 17:48:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 256E6280002; Wed, 19 Mar 2025 17:48:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 148A5280003; Wed, 19 Mar 2025 17:48:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EAD31280002 for ; Wed, 19 Mar 2025 17:48:42 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 20C3E14031B for ; Wed, 19 Mar 2025 21:48:43 +0000 (UTC) X-FDA: 83239640526.12.EF538A2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf08.hostedemail.com (Postfix) with ESMTP id 9BB16160014 for ; Wed, 19 Mar 2025 21:48:41 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf08.hostedemail.com: domain of cmarinas@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742420921; a=rsa-sha256; cv=none; b=nYDDDJkUz5ZKnrdxkdjVpnovACh4ErKEoplrb/bWsLGreUTR2QzAk9UM/D8+J6Jg0FrvAG OloUaMJVZcp0frxnPC8Kb0emqQWpyrUBvsYr/CeH8JKgS6q7xJVyz5L79e4M4Y2g23JiP7 XwcEM16/Zr9XsvOWYhBruvZgb1+MkHI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf08.hostedemail.com: domain of cmarinas@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742420921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n8xNWERaIEY3t44CdV5gdS76hxjc40sM+pkTx8sfr/Y=; b=Q8jbuGXMMzS2+9IL/7Z+yBy0kIXneSTCzxAFZGKC6YcfV6YKKj+DqFCX90qV6B3IHuWJCC HKNq5lWiZpWUN65Nd0eQpwgt22yM5X9q8JiAM5dTnDGU5VXbGYZALsmFHL3EMnHJj+MQWi 6uw3o8wev6tFDVfwQg/TK+8bVm7PaIQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 53D6361158; Wed, 19 Mar 2025 21:48:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C465EC4CEE4; Wed, 19 Mar 2025 21:48:33 +0000 (UTC) Date: Wed, 19 Mar 2025 21:48:31 +0000 From: Catalin Marinas To: Jason Gunthorpe Cc: Oliver Upton , Marc Zyngier , Ankit Agrawal , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "will@kernel.org" , "ryan.roberts@arm.com" , "shahuang@redhat.com" , "lpieralisi@kernel.org" , "david@redhat.com" , Aniket Agashe , Neo Jia , Kirti Wankhede , "Tarun Gupta (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , Zhi Wang , Matt Ochs , Uday Dhoke , Dheeraj Nigam , Krishnakant Jaju , "alex.williamson@redhat.com" , "sebastianene@google.com" , "coltonlewis@google.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "ardb@kernel.org" , "akpm@linux-foundation.org" , "gshan@redhat.com" , "linux-mm@kvack.org" , "ddutile@redhat.com" , "tabba@google.com" , "qperret@google.com" , "seanjc@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 1/1] KVM: arm64: Allow cacheable stage 2 mapping using VMA flags Message-ID: References: <8634fcnh0n.wl-maz@kernel.org> <86wmcmn0dp.wl-maz@kernel.org> <20250318125527.GP9311@nvidia.com> <20250318230909.GD9311@nvidia.com> <20250319170429.GK9311@nvidia.com> <20250319192246.GQ9311@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250319192246.GQ9311@nvidia.com> X-Stat-Signature: wje6o6ef75muigw9gtgd7oy79f4kisaf X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9BB16160014 X-Rspam-User: X-HE-Tag: 1742420921-561393 X-HE-Meta: U2FsdGVkX1+DTAbFXGXStvN/mrhhK1uPr1Konw7sJWokUbJf88a9qb8JYZS0FQDz+lv+g1VOpyzk7DmUQCKItsa/MsFwQiTLDPZdJQDgc1dP2s9fUn5bxjsyWZG6oYncTfOYyLQHJ8iVqWQkztdD8CQYmimdM65ILf8H72ZBaq6UPEQCzQpf/G3pfXarP7zxDo2EkVyhUw8Brbc4oBNlFO5jR6LHxf/Sh/6WAx+okRjnnEHtK1p5F9cQzhn8Xa4zPGCsBWl2fG3qtRKrCF4cDTQEa8IHjKDVlaB/NhSgLO0qHe67IeVx0WDZ1nxg5bNwxpoz+HzufQm0uA7OKwe6EdB+NDnmWUA1sTFlNcbjdCb1qlGCPK/KNqmInjPVDnjxUERKDCDJx/rkd7F+uSolkYtawQeFe0JPIdVUXfynoh5Y1GOiOmjmg5GCqVylzD24o5sS+PhJCewKh7WgK3QeFRLYwbwXLi3bZWw/+83WKb/1GPwrt0EZWVda6T6IaH64sfkNrI75ONP7B/KcXb2qd9tu+lvBYEVWfy/xWdOYPGoCBOcE9PkrrPkqCtDIQENbl6MfUDHRjCWOWhJvaYPDarEZPBDN2gnHC6oOiFrNSQ5qxQEdc1xWBNvKFQljxMOt++GDZF3uaDoaxyX7d1EGSaX6kq+0cEILW3IOg9zeqy9oyCXAJSOqZsJbK/6oukPFSFuEiQB05oa7b0XlfY4TgA3j3K+MVXo0ZTRAZLKGsnlGTQn24iQeCojHcsitukiMS89oamQJd3VFvAU3Kh56lJvM0RhpKucvRtk151h3ruwhkLNkUVc58fy3ZaJjIIlXpO29YKo07D6wRhfc4J6ngzhrjp/dOnXLbmZ9vhcg4ps2jnca58R6KHmXFgR13+bPeRJBC9z96VVi0BgaOm2R3gUwvgvtwcKCLa5A78qi2BHFRMfyHi+gAnFoeHqQYT6E/qmsiqoeUFf50A26hNf RzQxL6PT fsbFoqNXS+asCnyEMLGZJ33fll5toWKeb49BDcrexwOA07qt2799d8jCFnzChlBSUtV92StHpkvoKH9XAKEcxDtCcw6rpbpQckZGKdplSszLoC6Z+qEQfyIzHVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 04:22:46PM -0300, Jason Gunthorpe wrote: > On Wed, Mar 19, 2025 at 06:11:02PM +0000, Catalin Marinas wrote: > > On Wed, Mar 19, 2025 at 02:04:29PM -0300, Jason Gunthorpe wrote: > > > On Wed, Mar 19, 2025 at 12:01:29AM -0700, Oliver Upton wrote: > > > > You have a very good point that KVM is broken for cacheable PFNMAP'd > > > > crap since we demote to something non-cacheable, and maybe that > > > > deserves fixing first. Hopefully nobody notices that we've taken away > > > > the toys... > > > > > > Fixing it is either faulting all access attempts or mapping it > > > cachable to the S2 (as this series is trying to do).. > > > > As I replied earlier, it might be worth doing both - fault on !FWB > > hardware (or rather reject the memslot creation), cacheable S2 > > otherwise. > > I have no objection, Ankit are you able to make a failure patch? I'd wait until the KVM maintainers have their say. -- Catalin