From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF292C282EC for ; Tue, 18 Mar 2025 21:53:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9ED25280002; Tue, 18 Mar 2025 17:53:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99B63280001; Tue, 18 Mar 2025 17:53:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83D87280002; Tue, 18 Mar 2025 17:53:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 62DBE280001 for ; Tue, 18 Mar 2025 17:53:17 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5F769C02C1 for ; Tue, 18 Mar 2025 21:53:17 +0000 (UTC) X-FDA: 83236023234.29.69E5E44 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 0D52540006 for ; Tue, 18 Mar 2025 21:53:14 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hoAZRSXY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of raquini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=raquini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742334795; a=rsa-sha256; cv=none; b=SAC4i8Hwx0QcYt+jpYT04CIchkTPZ7dSzC9lY4elirFLiq8U8xFuEGndXvnIEItgArq0LN siHntPdsuFd3B+Fd7Eicf4LUSh4JhMBnlrLtFoJa8L9UnL0EWsWemMZsXA3P0y/x/+leDm 6OhVw2bQPA+ak6LoM3jv1RpFJ0W/Wj0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hoAZRSXY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of raquini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=raquini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742334795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P8s99RB2PpTDqfRG24VVcz21yHqoAi9hghS96iW/bhA=; b=Yb87Zb8qzf9AYuDj+pCu2M/IwVbygqKWF8xcuFRT0UM5bVPgxPgKNpDkFRawDMoXnEY3P8 l1Snqvq6JL9dhB+O8bW3gui2+E4VLAFWDli52jzkmMoFz73HN6x1qN0tzWT2eQRar4fzIh GzLiHiIqm7f40BSRW1/wffM4BCOokco= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742334794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P8s99RB2PpTDqfRG24VVcz21yHqoAi9hghS96iW/bhA=; b=hoAZRSXY6uA3LmKWhtL+cj03PQlxZTiw49FoWTMeo7j3iFWEQbvk+nTdi+xYHhtGoxQ+aX dtXwyRNrsMVR5mWh7Fmv/bYo7RCuO6EjuDGCWF8Xh3pbOuX8C5P4lmf9ek7HccKJU2JPnW XXecx4f6U28t17PJOhtf2EvVm1wrb88= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-bGoKlJxCN16FGbJHsTtAPA-1; Tue, 18 Mar 2025 17:52:08 -0400 X-MC-Unique: bGoKlJxCN16FGbJHsTtAPA-1 X-Mimecast-MFC-AGG-ID: bGoKlJxCN16FGbJHsTtAPA_1742334728 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4766e03b92bso119963161cf.2 for ; Tue, 18 Mar 2025 14:52:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742334728; x=1742939528; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P8s99RB2PpTDqfRG24VVcz21yHqoAi9hghS96iW/bhA=; b=I3x5bZZ10ElVmTQOc7UPL2KJA7SmfOuzNFxn/lScOCrJNLuhEblEVHqjWQ3tvJHeuR n7qn7zgYRAzKGTrISV1N0rc2qRFTMtwmr8ro+Hsto2ZYGMhYB46kok+iumsPeRZH8pkp Bc1nhHxw6H6MLFufttU1qx13Zp6BmhNISTqBj5IkLeJDN24Ehxc/YzYAxaViJZRQdALU HV7Y6n8IHG5QVfYCuO3pKA08El9ym9K0z9yroHNec/FIa8EW7Xg+S12x7pB7NL54cJ66 V4VlhEnaL/sZADD6xfpDmigvYF8qxQJn3eSJzjZ3Mb9pFrdY2pXpCh9QATfzA0cIk2Uz GCwg== X-Forwarded-Encrypted: i=1; AJvYcCXgGY5+YJeZxmkwEXIjbcHhF7bcKcDg2aiMGhAILYc4HHxc/YhzQ00ZSEZ0P6eFhhHf68kkcIP/yg==@kvack.org X-Gm-Message-State: AOJu0YyO9LcIBmXwuF8aVJdZhl4EB89SSPxR5orJMlxWsXvS1CfKAUJv QkZwlXOVRcGFOEV0FYP+ntPJJgKPQNRUQtysRXGZ/K5D1zJdqSuzfVW9vk6c9Z7OBBTjU4C9VZ6 WB3ChlnA6xoLJBK8TTVc1tO3ah0eITS34jY5cm5Ogv/A5VjhH X-Gm-Gg: ASbGncvrCS2fCdN+LEDjJ1PqvdrjmrVZKH/T5W2tDstouN2XiicwWhVb3S8qoK7ydbC gKMjFQ3DzXY1ULzC63NSpxnBd7YqHT7hC06IYbKNdv2aTzlGvKji6N03W0E+KZXM9Jcz+lTEIiN 7Po0uJJOZMs7gUqIZXTyZzbz85KtzuoAFtT8hQnlVR+s7UiAy4DOkwYeS50eI/fy6PwqM3KbLWJ gR+ZboycJYYNyD2FeII5sl5OO4WM3yorNSD6nLliGVAK3tgawsxOxXtjUgVTnu1y1/hl7TK+q/s cjY4+304dOayxCQ3RUEHJVUyvOnxB1h5B52rcD5+96/ggAqP5WWyY+Szxw== X-Received: by 2002:a05:622a:1f8c:b0:476:8f41:7b93 with SMTP id d75a77b69052e-477082dba8emr9166001cf.12.1742334727871; Tue, 18 Mar 2025 14:52:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9iadiDCeFSnKYTy5zZu49JXvC/XH7qcUqaifbR4vUmmBSoPoKlm8Jka1F6LmghgXAgSL6nQ== X-Received: by 2002:a05:622a:1f8c:b0:476:8f41:7b93 with SMTP id d75a77b69052e-477082dba8emr9165661cf.12.1742334727552; Tue, 18 Mar 2025 14:52:07 -0700 (PDT) Received: from athena.aquini.home (c-76-23-219-111.hsd1.me.comcast.net. [76.23.219.111]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-476bb82c170sm71481971cf.77.2025.03.18.14.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 14:52:07 -0700 (PDT) Date: Tue, 18 Mar 2025 17:52:05 -0400 From: Rafael Aquini To: Ryan Roberts Cc: Andrew Morton , Shuah Khan , Peter Xu , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 2/3] selftests/mm: uffd-unit-tests support for hugepages > 2M Message-ID: References: <20250318174343.243631-1-ryan.roberts@arm.com> <20250318174343.243631-2-ryan.roberts@arm.com> MIME-Version: 1.0 In-Reply-To: <20250318174343.243631-2-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BfuRfJHjTZ5_fN6yDUNpr6mdqOAxBt9xgdcMF7CyjxE_1742334728 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 0D52540006 X-Stat-Signature: ae3n941pihuw6ps4hscn5k6bnugq8iuj X-Rspamd-Server: rspam06 X-HE-Tag: 1742334794-755326 X-HE-Meta: U2FsdGVkX1+D7l0fws27SNlthUsSR6cyEw3dBY+oEpZpl9BYqyDxXGeNHaf2B52NZx2IbFWsF+4DdcdHkU1oN5hiMh9ArXmA9HNlAQ2BxwHoxx63mVK056j6Va5x0ifyL8yqTlZDLzq15+DjJZkkxHl8uFPXjCl1Ouj/Xes3wLpQTd1WZU+bW9ZKHb0GD3me41QvpQbkVCwszI6Uy+J42TdeWMlFD2RfWYw9VEv1kY1TWOpng3U/QSfNozSceUbxE3UQGx4k4B88QipiuQ1SHSiImYOLPe0uSqVaY3d/vIHYj/mCqYAXaZojR5dT8p3ODrDeeAvLrD8SZhoHfd6URC88Idm1jRTVHdNZ8OrlPnZOeCn5viR2GY8f9Bwa99NUdSOZlY3FMa7Q7Uy1gW1aYIpMpGtv+mHfIAg+Eud9RoFah+0i8y8/Hl0CDtNroYxx7UDLHmf4rcZH/9/Qlmxj8Q4oD24yrEuE5P+zd2tSCBhuVBdSnUCbuyYe8iIs1FOjYFveUbOreu+WSLaLiC+JBv2AaN55kRnbErypjCh3rUEGrZ+K283ou39j3uwYym6jVBzqezEB+cunT1xJsqNrSuhQ2op1C3i9tLeiC3VKlcif0lRI1AAn3RzEmGZLnaluxMfn24OW+fkdZJOzV5nkv9I3rv2T24JJtYsaMB3wAfRj9QpnnVRqHwPxK5s3FfIWOI13syNFXO3uXmtl9SP5wdqxYbM3wqEXGPCVCu3CFqWPV3BWYi4uMJ5UNplwjy08YiwODI8ApG7Fr5zljD93QsgcQlMmJX+NHbYioXW6KqZzgWYK59v/S2Y7tveDeQJOMJRbUHQ9VMfnNkbbQvZc4M1RguNPgdSrLuVnIOtW6Nj1QYpcyzQ47v8p7ybqHFib1uuvk1vP+l5AQLSIIltFByVEuvJ6p45npftTDyYQmVZsl94PwgwchsL4SeL2bAc9lcHuQntRk3e8Xj94Rpu V8ecK8A7 aOYaW6b+rLNnZRb3Grvj9rzPTHVdv8SsZYgpGP5weWLci4W847kw8T8cxDdPhLxz4HhckzM9kOpxw+JH59wyvbFibqtMOCApXIQb4iwNCnnHbQRqd/tiC8V0Bf4KfRVWsqW0JK1vMET8ZeLUBKl3nsUykUtJ5S1IiGJ5o0JJYf8sCuvoU1gT/Lu9SwB2DtMoSQHsJdTpfwhAOrqJbkai/S/7p3n2t9hi0czDbMUAi3LI6wHW82QbP9vTzEeJLrpQr3ZsYDZbLJp9C7kYb0Ob0iHUumL1vKiJUa8FSACUwCqmUkD9XmLYzgdpH5c2dx+WKkI+oRpzlV8ekitZqarVgfVxBN1uMB6p2xc5bSDb7jROjSL/C46iCPOagaf/XQqVwdSQU9LjZmpXnDZGEIxewuFMhpaAnzrDG0jAS8JM/eVOtNzlcP53hgDFI8t71ZYHO7G8aZA4AtMP0Z9Rl7+QNFTA0Ez2HrSJQA9ZAkOJ+Xch/0DrfanOhGMQ+UrKeNrOMJqLp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 18, 2025 at 05:43:40PM +0000, Ryan Roberts wrote: > uffd-unit-tests uses a memory area with a fixed 32M size. Then it > calculates the number of pages by dividing by page_size, which itself is > either the base page size or the PMD huge page size depending on the > test config. For the latter, we end up with nr_pages=1 for arm64 16K > base pages, and nr_pages=0 for 64K base pages. This doesn't end well. > > So let's make the 32M size a floor and also ensure that we have at least > 2 pages given the PMD size. With this change, the tests pass on arm64 > 64K base page size configuration. > > Signed-off-by: Ryan Roberts > --- > tools/testing/selftests/mm/uffd-unit-tests.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c > index 74c8bc02b506..6973e57b227a 100644 > --- a/tools/testing/selftests/mm/uffd-unit-tests.c > +++ b/tools/testing/selftests/mm/uffd-unit-tests.c > @@ -26,6 +26,8 @@ > #define ALIGN_UP(x, align_to) \ > ((__typeof__(x))((((unsigned long)(x)) + ((align_to)-1)) & ~((align_to)-1))) > > +#define MAX(a, b) (((a) > (b)) ? (a) : (b)) > + > struct mem_type { > const char *name; > unsigned int mem_flag; > @@ -196,7 +198,8 @@ uffd_setup_environment(uffd_test_args_t *args, uffd_test_case_t *test, > else > page_size = psize(); > > - nr_pages = UFFD_TEST_MEM_SIZE / page_size; > + /* Ensure we have at least 2 pages */ > + nr_pages = MAX(UFFD_TEST_MEM_SIZE, page_size * 2) / page_size; > /* TODO: remove this global var.. it's so ugly */ > nr_cpus = 1; > > -- > 2.43.0 > Acked-by: Rafael Aquini