From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B03DC282EC for ; Tue, 18 Mar 2025 21:49:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E1B5280002; Tue, 18 Mar 2025 17:49:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76AB5280001; Tue, 18 Mar 2025 17:49:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E66B280002; Tue, 18 Mar 2025 17:49:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C842280001 for ; Tue, 18 Mar 2025 17:49:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E948DBA8ED for ; Tue, 18 Mar 2025 21:49:23 +0000 (UTC) X-FDA: 83236013406.04.4A708F5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 921DAC0004 for ; Tue, 18 Mar 2025 21:49:21 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NEbjP61U; spf=pass (imf28.hostedemail.com: domain of raquini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=raquini@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742334561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=58J0WtzHN+XruwLvzjWC2+8B6ewmNYbb2pF2W6UzGCU=; b=WP3G4ORpvq1miNnw5CZayAO129JhMwz6FK2JSEDziTfEM+zTUVIDh5RolX4qlKRVAKx7ic 6AaDAlDZCRkzGm5bd5/bN2X+evJ81CK/17AOqegeMcYHPb5JIzUGFFCxVJA6bchhfOCaXa HpoZClfrfgAa0kkr/IGK2dl+clxbL2U= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NEbjP61U; spf=pass (imf28.hostedemail.com: domain of raquini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=raquini@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742334561; a=rsa-sha256; cv=none; b=die3Q041fYUXbWB9C9dKpIzbpK0HwrjfxTGBPzh5h/riyk3DBWhIPwrAP1nJBHz4lwlAam IyIdSRsVLmEfi+NTyhGmpJ8r2H7IdVYXibkw04PG1CY4p/wSqfja8GVkmnaM7V/rvhpyZB JUhXqUgAM+MiA4xeyvKa8/AR9QWV2Lo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742334560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=58J0WtzHN+XruwLvzjWC2+8B6ewmNYbb2pF2W6UzGCU=; b=NEbjP61URooIT4dVMwhomFsjfgbrrE0lkuT/rJ+liPl7y9DLeZi0N2yQp5e/7tAB1krv0a hl9krqVwgHjafxqrBUIw+o1D345ma3ldwcRaRSJidDw1s/PH4EelBOohaQXz8d+/0y0gqx 5RY2Sk95Db3x2KCSOq5zzDSYBpi8B0c= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-17-Uwu4gRhaMIuc9T7G9t1p1A-1; Tue, 18 Mar 2025 17:49:19 -0400 X-MC-Unique: Uwu4gRhaMIuc9T7G9t1p1A-1 X-Mimecast-MFC-AGG-ID: Uwu4gRhaMIuc9T7G9t1p1A_1742334559 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4767e6b4596so116633731cf.2 for ; Tue, 18 Mar 2025 14:49:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742334559; x=1742939359; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=58J0WtzHN+XruwLvzjWC2+8B6ewmNYbb2pF2W6UzGCU=; b=iaK1kXRNGR8nKRp0mGNy8eD+2dcQM0VcK1/qwPRu1v7qxeIpAbnOVzqdYj8UKk0zhk Z8N8at9MAS7Kb5UIJLjEVXmBEz+qD79o50iIDcGRn7Dka3sWBW5Kg4ILGs34yyjZi/Yl quhPoDHkxXSLcv3XoSBKUvmuDOmIyCAxZkhlRLIzLp6V5o8EruCgXMCQTojDB2t9YiJl StL9cIQTVEexJQIvRTEaiwVYqQYYm6R84gyWady4ioRl556SImYZgFHcdlutLAzbvH+f wxG8p5GaKAzMudygeiCwE4IYnR6ccvUZvpj0kpIHjaSZpqNLRcilr8Q80gi+Y0D/Sbz+ yvDg== X-Forwarded-Encrypted: i=1; AJvYcCX+AMwaEYyTiBkWz5gQ/GSGWC9FAr6wdiMmkE2sZLjxVntbcKwROxwSv69CFySzIq+zrhsKM5EyBA==@kvack.org X-Gm-Message-State: AOJu0YyKCBP7oou43M0GxgnuBil2ZKw6tJWoSlWW/SRylIn5VH1j713g wzDr/zOfeVv0HNEXXoOtOujhj7LVM+6iuNelx5rHkIskHgjb4zi3XROMAk8Ei1oTWBz0/+47aJs oy090qcVbCRZwxALQBGmTRUaxb26isU0cyzi04Apdzoom7zVi X-Gm-Gg: ASbGncvLBlKzrhCliBUNuz8cwtmkJEQ8VyjfLZEm0yEA8j58fFSGkuy6tplKmGvwo83 VdsR9d1b/gKHVXbR3+nSgY3kZXBMP9BcodTfGRUYPLSSRuFhlhGO7OvSY/wpZv8lKwksXCsKnWW JmGa40/5XtR7+ck4KythzV6AwVSTvFy0v0jWOo/xqQFsWPdoOuy1rVZ27tj78A7m4HJYgqu6JLF O1A4e7639RJS6sdoSBEVKddPuuRwN2Xs+uL9EAO6Ygn2ehfyEIsY1aG0bUu6c7VeeVlMQUQXB/u PG+4E6ebHrr9pHbkBhrLzDsjSdU707NYE0TfQktaBS9mcEkwOs9ebn0Fog== X-Received: by 2002:ac8:6906:0:b0:476:9e90:101d with SMTP id d75a77b69052e-477083742c0mr8342761cf.38.1742334559045; Tue, 18 Mar 2025 14:49:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHP4jMLDMm4qeIr3gb+Qpzz/BJtD8FlAlNK9t+Fynuz9KAkWXXiz8RJxCEgXMubULSSCa7A0A== X-Received: by 2002:ac8:6906:0:b0:476:9e90:101d with SMTP id d75a77b69052e-477083742c0mr8342551cf.38.1742334558773; Tue, 18 Mar 2025 14:49:18 -0700 (PDT) Received: from athena.aquini.home (c-76-23-219-111.hsd1.me.comcast.net. [76.23.219.111]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-476bb831e02sm71444371cf.73.2025.03.18.14.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 14:49:18 -0700 (PDT) Date: Tue, 18 Mar 2025 17:49:16 -0400 From: Rafael Aquini To: Ryan Roberts Cc: Andrew Morton , Shuah Khan , Peter Xu , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 1/3] selftests/mm: Fix half_ufd_size_MB calculation Message-ID: References: <20250318174343.243631-1-ryan.roberts@arm.com> MIME-Version: 1.0 In-Reply-To: <20250318174343.243631-1-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Enjaq_10xu2n29pfTIaGrJdUe6KBnlIQfSmpu6b5teY_1742334559 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 921DAC0004 X-Rspamd-Server: rspam08 X-Stat-Signature: dufm3yj8gyi9ucp1nk3ys3n7qqmfsz4x X-HE-Tag: 1742334561-27413 X-HE-Meta: U2FsdGVkX19KWJvkZpfhL/WiAmlbiQDahAZvsHex3QGCeJG6ri32a3NibqoCm3/eYFyU47orJA6cNFn29/tk+Gdfmv7/zn11t+2R7ai3RHxpz3hepgydT6W0im9RHHcGT+EnwLQtHwM0jdVrwNSi2n/evdt9TlN3EvwXAmGHvTrGPE9Gdn56sWV1EOWhO/O7p6Fv9rymC8i9Gmz88S+H9y9CUg+Noa2ecrMu+wQ3cSBAvVTFCmBq/2u6+jpxkTPBgD+GoPBLE5Q/q2yJtDxSpaJgFFJ5wU0Ae+4U742WzS7+WnB2yrxIpU4qLCXdTGZuhlsSkFdxgnFRGJW81o0ln+u/XVbMt3tJFFSKFPhwHgVjOsIUlDEjztBLRYD/tEP3c+LAVOJ3uD3ht22otRfElKZBSkwVq91fNR2kVV8IEv0kh4EuDrNYo8Ul/jIJMsjYqlqOj7IZ0u7vpEUWldmJqNM1RN4A80Fu5n+Sx9McY8rM/FKKGGvWw2LURZ4NyjUiTlQ8E5UxYEfUmruoaRPTJcwywEwcPmtE5cBu6gqycwHhca774vBER+bY3TzDucsLAxyOnxDfU+11njWCEwOdPQzYAF+aL8l/y2br+k5dUdAj/rJAhkYNZMqkkkimk9KPp/5yoluSlnLCXhN18PqvjCwsys9MSNuzbG5IMVPHJqmHHo19sj3E3XNJpYLiIn61c8XbcLRgzKaFvpZgMhSdiJRRkkwCwG1CTtx17VEk+KvTNkpewqq6/9Goy/r7+nOZsW0bPqZ7SI914wEhKH7bm/YGlPGYz7bIwAfXTsd8eXT+EGgyHfVOTJmFYqp2md5n0/F0ObYvwiBwMAbewz8v04iprv3HX8kayAGlppULjhnJqePEimYtY1YA8YpvR0jB+ciAOpIl/4uzWbJbTr3R1cWjl2RFiBRJWCms781xKngvTVq2RWmxfph1IjrpiGoYFBbrNH5sae96B6mrkyp tshAlUg5 p+3ZRPuc7DUI4/nQJ2yuPPgK+zePAgs4KAYfr7nVoAJFsLyGi3yyWzt9DBkN+EbDp1zh9v4MCny82kL2tfI0A1JbDceiiD6Rn/opy6Yx2DHQAcb0SqULfpQWMXYe9KU8q/Fzay2owNwTi9A3OhfOFLNnLwcDYvV5or99Rh5btdqYwuUn7I1uipDATecccSPbgcHvPUGVAFecZWA4wSc93/kqB7n/1tXtVk6vHqww6Qar89Md21dagdyAbqSgponcXiBcgnTM8NgzAwd7gJlRnPyVbTDgk4DtJhbLRwy8pgq2XCjEi96f4u9FwZ8vI8gyv2ProrrysueKyAOlEY5g1m56NunpgqVm9co6Dx8ni22OgbI3C4iJZbtSwpE3fhbQR4l1yA64Qb8WZZIMWTitgTWtrSbYywN17JX4iS/GgZ5Q57hz6yCepUTPMINOalr/KccIa0hsDhe/FCe2Xu5vBUVKpaq7uHYWFIXDNPWPc7MlIUAJz3D7bFQFnp9/lEH/pzJJ9Xl6qE/3XOCGLtHDUn4pedzIBDGQRVT82DhuzVcvlKivG5YAXcp6ffwrXsUX9Jylo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 18, 2025 at 05:43:39PM +0000, Ryan Roberts wrote: > $half_ufd_size_MB is supposed to be half of the available hugetlb memory > expressed in MB. But previously it was calculated in pages since > $freepgs is the number of free pages. > > When huge pages are 2M it doesn't make a whole lot of difference; the > number of pages that get used is just halved. But on arm64 with 16K or > 64K base pages, the PMD size (and default hugetlb size) is 32M and 512M > respectively. So in this case we end up passing a number of MB that is > smaller than a single hugetlb page and the test raises an error. > > Fixes: 2e47a445d7b3 ("selftests/mm: run_vmtests.sh: fix hugetlb mem size calculation") > Signed-off-by: Ryan Roberts > --- > tools/testing/selftests/mm/run_vmtests.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index da7e26668103..14fa9d40d574 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -304,7 +304,7 @@ uffd_stress_bin=./uffd-stress > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} anon 20 16 > # Hugetlb tests require source and destination huge pages. Pass in half > # the size of the free pages we have, which is used for *each*. > -half_ufd_size_MB=$((freepgs / 2)) > +half_ufd_size_MB=$(((freepgs * hpgsize_KB / 2) / 1024)) > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb "$half_ufd_size_MB" 32 > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb-private "$half_ufd_size_MB" 32 > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} shmem 20 16 > -- > 2.43.0 > > this one is already fixed in linux-next, see commit 67a2f86846f2 ("selftests/mm: run_vmtests.sh: fix half_ufd_size_MB calculation") -- Rafael