From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732EAC35FF3 for ; Tue, 18 Mar 2025 19:54:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3893280003; Tue, 18 Mar 2025 15:54:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE8C6280001; Tue, 18 Mar 2025 15:54:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6414280003; Tue, 18 Mar 2025 15:54:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2BC9280001 for ; Tue, 18 Mar 2025 15:54:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3AD6ABA386 for ; Tue, 18 Mar 2025 19:54:37 +0000 (UTC) X-FDA: 83235724194.09.FF17739 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id F14DC4000A for ; Tue, 18 Mar 2025 19:54:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="T/8aNWmD"; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742327675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=asmhHq8i6L+nn6qMOR3aoqUZwBNi/F5FrrH2+8dZqWs=; b=6YjLqAAJxFJtYQQUBhdPv4wuk920pWXp3lfCj7C5A1p5Sot1AydP+LEKxNCCQ9JvGTz5D5 hcKhW7phHKsoST0OjqsUVzQZToNTdMMPAjiO6ujgklykr1MchTNbkRnqE4brW+uvAK9OEN Rwcn0OIxSBiuvq1j95m8ZFRedx+m3c8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="T/8aNWmD"; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742327675; a=rsa-sha256; cv=none; b=Ez6jaKWaygF6QaMQGjPOvH5Q2fOCHdNlh/ZLnUcIl7mli2cNOtpbTsiHuCszIvNyfXFPlB jLx6lTnWp+N3JAkrMhBw/z+5g/qPjnRukY5SUHi1ijf0YcZawJbwIbazNhxq75uFt0Rr2j zipM6ikIxUd4yTvr1BAdmazdL9+Qteg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742327674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=asmhHq8i6L+nn6qMOR3aoqUZwBNi/F5FrrH2+8dZqWs=; b=T/8aNWmDkQ/+M/E4U40xlZJ4XoTAuMr9Egh9lcZKv+ENP0+kFKe0Rj1xJUFfKKZZJP4M7Q lFnz/BrhnIOEMfXwqDd1kckkyvJcVwMtY7SRFvbq0lSlgchpJYlh6Y+wEYrfzI8ddE5GWd u9YwxGS76KC+JTo/Mfifvlu4SFny0zI= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-fgCRQeEQMtOdDcywegu4ig-1; Tue, 18 Mar 2025 15:54:31 -0400 X-MC-Unique: fgCRQeEQMtOdDcywegu4ig-1 X-Mimecast-MFC-AGG-ID: fgCRQeEQMtOdDcywegu4ig_1742327671 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6e8f99a9524so203886646d6.1 for ; Tue, 18 Mar 2025 12:54:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742327671; x=1742932471; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=asmhHq8i6L+nn6qMOR3aoqUZwBNi/F5FrrH2+8dZqWs=; b=fBD93SVxn0eeS2KrmlCkApE8KaUtrYuoD/+Sfh7DEZz7g1/LS8DvB4hVvmgcHE6557 9C8JHpsKZ6UAz7sek9AgTKvN76KK+8HDLxQ4VrDC6ImtE3zr2OhaAOB/jp9MFmnNsZTX 5xWxf2KxnNzQImhmZeLeza+MwsPJUKQeb9vILtdqZN8wpNfCe7AOVdJDvXz6c8bmYc5u yZtf19JWxOfHh7kA4H516rFdOMc55CWozO8o72qiwsBT0cxuStk1B6GSyKGV5pCJpPHE 2tIynE6RLHwEIXCuKc1sAFeiQwDzeI+ZmDqgiynPBSCR/m/tIXhL7eN47vVo5wF+ZBfO waKg== X-Forwarded-Encrypted: i=1; AJvYcCVsdRxgbZfnLwKTlb/iK/NWVp18Yo9kQIepcO3gl+H4Dmt30LhTtkvZR7xfjZb7oEEKPuU1hetwsg==@kvack.org X-Gm-Message-State: AOJu0YwkgpmpmU2VUcdGv/bhZC/9lJJ1X8kW13lDyQwpZ4E3VfXDXLem B79f1NGendqDfSL2PS1HwiESZYGHdtgatzNlw5lAsu3VvqWKaA5UPyRXtqlS/pES40ttlnLlv/D RwUpaJ0SwcwVAFYHlgHpJ0Q80P9znDBu0ESgxaZY3eiDWHxzi X-Gm-Gg: ASbGnct18LY1OQ0bD0GqIxQ08jgLHm1z61eOS6fFxLtGhCpQBEgqb9aDXRlpZ2/LgGK /eFSxwiyM2eASnvlAUtJk14hSDHjvW6Gn9r1/z5uA2UoJ6X7wEfkB7WDJUnY8O+JL7B+yqOoEjI epyWBV8ovVtsYptuLdWVPgeWjwE7uBlHPrUK/SKKVpJVlS4PMiVVcodO09z2NvcMq/HtS5E8uq/ ukZtuapCuip4g4FTybxSIWhOXSGYwrFLx/pZqIBYE0QLIuEl8SkS4FJQjNgaIzaLlr3ZY+DKPOi H1gaLkE= X-Received: by 2002:a05:6214:f05:b0:6d4:dae:6250 with SMTP id 6a1803df08f44-6eb29428beamr1764186d6.34.1742327670838; Tue, 18 Mar 2025 12:54:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdWrfqZPT3Cscze64Kk4O7bgfCX1eO6rtfNSrfKwrt8NlWPtqGYeJZ5PC9d9TkD1v/NHhpZw== X-Received: by 2002:a05:6214:f05:b0:6d4:dae:6250 with SMTP id 6a1803df08f44-6eb29428beamr1763886d6.34.1742327670506; Tue, 18 Mar 2025 12:54:30 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eade34c51fsm70867106d6.109.2025.03.18.12.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 12:54:29 -0700 (PDT) Date: Tue, 18 Mar 2025 15:54:27 -0400 From: Peter Xu To: Ryan Roberts Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 2/3] selftests/mm: uffd-unit-tests support for hugepages > 2M Message-ID: References: <20250318174343.243631-1-ryan.roberts@arm.com> <20250318174343.243631-2-ryan.roberts@arm.com> MIME-Version: 1.0 In-Reply-To: <20250318174343.243631-2-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AZ61y15fzY-JHuMqSfg1sz6tpIEZR10otYMkL9n5RoA_1742327671 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F14DC4000A X-Stat-Signature: nim7rcfnwubrg1iqq3rysjczkbysmut1 X-HE-Tag: 1742327674-689707 X-HE-Meta: U2FsdGVkX1/AMjONtj6a3AswT/adZlJiordwmOiT0kOFJGbc4/0nKIKh2AMA4TbmKb2WgdxceEAb5FjR7XBrH5DEVkVdvYBB3Nr5c+9LdywDTm4t8V7+zbnFABBJ15CozZjQfAuduDmZBkFNOR50/hAvTp9QD6Az20G3LaDl/b/qyOe5kMKoGX8h2138hqduX5Eqi67LnvLunxzfn5t+5gOG0UBNhfNxDGpT9Nf+sjtZDgVK6DA/BOzmgpsl5znqfTeHA90Syo3TZViR6wpUhjlOJDhKTebKcaRWCPitHFkdyaVW0itak3Fmo/5JLieY/yOG1X6NSUiToAIsdDviiEHlCKS7IAyz93yAmxR4fJQQlJ5W0JLepjz6jICZlrHvLhtnKViOPcJi0q93+Duuw7SuhToLCl92xpQVmx3oISpuGSx4H6Z72UEDNlxozk+hfs8RGYpGs4TbYQZqMXy6VqRnPfjRgyN/YFdjnjRiSFQxWAemmYaYlcSKVO43qgzk8uyXSHkWqDdkhgSfzgBFvItDBDhEuFM4Bf2PO+6EAXlOHzmndrx4raakRRQPs3zEXmwZta1DN+t0sWRxq4VUO7bsDLWQjL/Dw4M4e4MTebTvjnbUERXrv8SwuDRTgmommotN8EOoE5JRa0xW+Cb8YewLeqMkAUa2fOmkfV0rMwlK+ZmtGn8f9V11VQVVwB25A1f75p9/JbIROL1rXFr96uAgl1aeD5O8seMp0IH7PS4DBUn2JGv9xR9R6xi5DEx0smj2MEqqIXR6aTELkeZWlED05Q3S5D65xGJn8QnynCB+FDhdRd96G/c/c5VB26z9Ko5SDtCgdXb+jiq+Jr1gxgdjpcyiWnHlvQX6FUGrsInAUujSyCYhbbtraMQDo+FDudWDSESQtDsx/niwoKy3q27GixGdh5omiXcN/aiYaSegfiqYxleG+kaoVfYtnNId9erzTi1KIsAVkDNyRqr bNKeeof7 zsHxvJBospaWgr4uolDP0hb/yG923yqQ03gaawbDbUm7lq1YNHNzEcoSM2UU/OESa1uhrK0qrATTbXp1/LNqjL6QCeBcD9BjsE/zk2vTayZZaP4nYd/s+GezM//RvcGjd/YzoqeDcq1NneHudHs9fYFdDjPaJ5tInKfTtnUC9vYfK+TGDfMKrskjYg6IsPfGD4Sl6duKxZVqqaI2oMg8kmLO6PChcXREmac72Y1akQXnscdZsJDehsJseHDNoQcSGJkyg2cJnaHn/YysD5F0b+vk9BgjX+mNSHn15vSc53rxQQI/qfj3mfyWXJfheDEVQBRFItG17xBnCuFbbcheSJWynspxC1E2SML6p59qBLfqU11tH/ALQ/lm9Or/uFsfolV+YAJVhHEOA3si/eQR6RWgtG3JajLxaxHfazPZINAVJgtuAt+lZmV5RtcoZHVzO0k7ssG4XYAqqU1NP6H1hSTGtDOGyFaYlPDUFfm9Ka2wbBBrlR4119UyLJL3mVcLFuO6b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 18, 2025 at 05:43:40PM +0000, Ryan Roberts wrote: > uffd-unit-tests uses a memory area with a fixed 32M size. Then it > calculates the number of pages by dividing by page_size, which itself is > either the base page size or the PMD huge page size depending on the > test config. For the latter, we end up with nr_pages=1 for arm64 16K > base pages, and nr_pages=0 for 64K base pages. This doesn't end well. > > So let's make the 32M size a floor and also ensure that we have at least > 2 pages given the PMD size. With this change, the tests pass on arm64 > 64K base page size configuration. > > Signed-off-by: Ryan Roberts Acked-by: Peter Xu -- Peter Xu