From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ECF3C282EC for ; Tue, 18 Mar 2025 19:54:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AB0E280002; Tue, 18 Mar 2025 15:54:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8591A280001; Tue, 18 Mar 2025 15:54:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FB22280002; Tue, 18 Mar 2025 15:54:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4DF97280001 for ; Tue, 18 Mar 2025 15:54:27 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 913DBC02DA for ; Tue, 18 Mar 2025 19:54:27 +0000 (UTC) X-FDA: 83235723774.03.3500913 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 38C25140011 for ; Tue, 18 Mar 2025 19:54:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WodENyOv; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742327665; a=rsa-sha256; cv=none; b=HH2R/ybWw3ljOD3AV6Qvz6iWQQArnI0FxFP7q3NmJE2C443B2YJqah9EqMxCFYcfFOYT+C fDqdzdKu/hHjmuIpT5p4b92JGES8j4WzQyg1rxAd5tXfyHWKWd809O35Lvc/hUxERPrGu/ 2V36t4UHii6ns52N+VyxLruSoK1JgXY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WodENyOv; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742327665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LasTBrSWGR5sQxUfOwRL2ur1vR2D1dZLqM5vVjnoeRs=; b=iQnYuiWQw/Hp4lynJkmHBffMviDWgLdSCIgbFUgDlbXtomnGXpHnBRoD1IAPlqMC5/xO3H iPViZebzEYGORj0htrcpcsHvm3DsMKMnVJfM3BWUEVIFEs34GTs6WitnQ5/BXTw6usThmS c/kNmrp8rx/kKADdSW8qS9lgOAyaXPM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742327664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LasTBrSWGR5sQxUfOwRL2ur1vR2D1dZLqM5vVjnoeRs=; b=WodENyOvEKzT68P9OgKQ1FuRBl6iTL8cv/f/wt4t2ihLhbYIMvEBafiJNBTG3/nuSDemGb yy+xNUeTMqB/znAJtlamm1uf92NlDGBKtHuEpTWu9AgM8Lbnzwiq9BekltJZP3o6aaJXRK 8dYCRRS1lzEG30CD+tuJib3u1wwQo8Q= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-5a_FBtIrOz-3ngDq_525Qg-1; Tue, 18 Mar 2025 15:54:21 -0400 X-MC-Unique: 5a_FBtIrOz-3ngDq_525Qg-1 X-Mimecast-MFC-AGG-ID: 5a_FBtIrOz-3ngDq_525Qg_1742327661 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6e9083404b7so123988456d6.1 for ; Tue, 18 Mar 2025 12:54:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742327661; x=1742932461; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LasTBrSWGR5sQxUfOwRL2ur1vR2D1dZLqM5vVjnoeRs=; b=euYAmksr0vcdouIkb1ShzKTmCL9jOVSZTEaum4yp/HW+ireL6x4SZjMqfFYTdx5q1f 9ogb8K7gn0HhsnfO2P3mtlEwrNKDM/TASXT4OKnOCp6FSVpQxNTKeY8g45MuqzHU/mHd WIX3FheckcUxkMKQxSCu0q4IQOAPjEMIKXAJGS9Vw2hXKcR5wywtwJ/oKo5hAM+Qgk+i hDAID9MeUBIpXsqUunqgL9HEyo1r6LpCDlYWs3QelODOek2xpIci0uBCvKt0CjpvIp2R FdqcI0lSj1rT1lLBnR9biqg9sbHpSkS/UBIWNwV7QDPENwTnW30PNWfVrbzUQh40qFhv jHuA== X-Forwarded-Encrypted: i=1; AJvYcCXMUMsDN+/0D4kfGbemJIXBnK+yZWHiFdYhSxc68v5iSWvzvec3cKYQVPKOMtVkJ/FKBzWynrIZJQ==@kvack.org X-Gm-Message-State: AOJu0YwRJ6RjMcumcW4rpkLRQFrXKuSoCdC1qGWdRcT7mrZapWMk79hB ynQyHfY8TCMbBAZhLtf7b+2FJ2otZy21CZyUe3qzUFprVCjRJEgYGmXxXoEsj4TXw6v+LpAB6+j Pkd/JxozTs3eM43808OdSHbfwyPaNeRTN7omJhQwcD8NPoe0a X-Gm-Gg: ASbGncuCL2IVbWrM/dqvJd5JUiB8fPrNW0MjeYA+nPT3rlVD7T14WGsQEFMYcD8nkIQ rfwE/QJ6P23vL9vUEy76joxWEvil0ayHs1+N2LsgtDxDILfTtdqP0QnHG3XRCxWoSfOD2h0qosf ZfIdUcJHv5vGpy4IRIGMM7LSa32aPoeQxCdZvfKUJ1BxE0mTWawAeR+nB5UsJmzTszSXznWceRW NCvfYE82pbxWSeWJu5tY03f32tawM1+XLvsb2ObI6CcxSPfUNlXPZBH7lKTvOyLSLtwmiMcc1bd k3+68mE= X-Received: by 2002:ad4:5ca6:0:b0:6e8:f4d3:e8a5 with SMTP id 6a1803df08f44-6eb2928f340mr1592416d6.15.1742327661008; Tue, 18 Mar 2025 12:54:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHjORI09G97SxS+VrFqPvSDZYR9uQzLnjVnO1lN4zoYTKBPbgIFDgiAGZI1oEH4TLiRqsaJng== X-Received: by 2002:ad4:5ca6:0:b0:6e8:f4d3:e8a5 with SMTP id 6a1803df08f44-6eb2928f340mr1592196d6.15.1742327660697; Tue, 18 Mar 2025 12:54:20 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eade330dfasm70861166d6.76.2025.03.18.12.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 12:54:19 -0700 (PDT) Date: Tue, 18 Mar 2025 15:54:17 -0400 From: Peter Xu To: Ryan Roberts Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 1/3] selftests/mm: Fix half_ufd_size_MB calculation Message-ID: References: <20250318174343.243631-1-ryan.roberts@arm.com> MIME-Version: 1.0 In-Reply-To: <20250318174343.243631-1-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rqkc3C1Fuv3oSGTr5zCrM027cB5VfH_UWTmT0ErZCz8_1742327661 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: oxkqi5afa9uayxqqmqsqtmnxkja6rrgu X-Rspamd-Queue-Id: 38C25140011 X-HE-Tag: 1742327665-939007 X-HE-Meta: U2FsdGVkX19R0v3I3Stby9gsXjqK0ELb18ychmFlV1njdOmsd9M6fytPYjmmbzRIXHxXWJArScy5j7dOVI5yPC0KTQWn8hqO4KWG5WuVqzlzVd7SXKGAO5WAGquyNZRR+Y2hP1Xxs89pmtQQkigGCzvAdPev/+53tGdkMCwyDvYTQDsYymB5pqKA3SuDx4ibqBKUJzYk0+g15vJ/ZOnJu00kxyyKsa0ONZb7YARnca645n9AEZ64eef5M7IFO+XX3eWlyN6r2BK2epoLV0uB0HaGxNqN8PYnhjH3lAG7dnsAkHSWIILEuTl3LXWFBQ42PCCppOlDB4pKHcfS4pd8Mq6wxkbWPWo1nCpsu/FAGdmagbLG2GJbsV7/Y6+fTXjtiZp7TW8xABsanfhJAoqdgM+NcA/hDit7AtqNhGvg8EmfWJKFcSl45Gh46tBk/kjVnXHYq4CvHuedGjzUnYVsDuIEveaQpzgAHAyQaTmrmZuyT8OqKHsS+ZugmbXhPxUz5CokfUCyzUOJSgOdQ2zei4/Afv+rrJjby62yC8G/kdEgbsDWt99257w8Pw3VeQCuxzCGgJl5m61KWGHZjOUb+bQimveJr8XhGdXJkUhVbpHTKeNKdaZ0J90Md3OJBv+4nGSxd5bPhW4v/DFdX9zOYfowIdd3Es3V/SLr8yWyhC2WLaepG1ITABIbjnnps1Wq/rV58xCJpjULKcIgzlFPI8rx6FLqmWbRvRqByhPNTOsn57XgCNH+4s8Eap/m+RM/RPkzQB9VB2dqAxQxGuenU0Db3k6KzaAPjeyIcS3WSUhforIWWQzoJBo+/p2sSFEsY1iLz+uU8cbhUPFsTeg2bxWtBfEFKsW0J7M+uXSwHVX0ByybZ3/wMKpOHbMsipM0m/a3zK904+RJghwbmSQ2yPEgHB8H0ZSFoRyGRv8NRjFLYy/rmaGlVpC6bdbQRqMUZjoYPKFa92yEuafRPnw n/a4kfDq jKT2obPXvD8A3vF7M91E6CemadbVk9XEcC2/FHTD3nef+CNdedxGTINsxL+LhAzxm47cc57ZuWnAsRvO4Ky3HHxZuEqIty8L5AwbbZw/hxnvPnJcr4aLxBdqrJbvsgAV9TGhyGOu58BVAGkSlu+oOQrNmC0piba5yS9frN9yc/hXOG24v6ztfCr8gOAjOU2yCzdGgy9yI+7WCBNiT4JrdlvTvFQxsmYVOKBPo9PsK/qxBtrjhscQUKfIdE5VVH3dLnD65PGUgIbzW8xCnD6rVIPvLMebV5qxSNdRcPJWYHr0lcNoI4sVWAKFyArRxY9WQff+egXzVaj1LVYvrs1TqNEuGafWVex3G75Rkf0Vp3FYpiK5DNVBCDaPPvBwVIqsmwbENcwupw/zybI0vkYXMD0IkcVDBvA0d/8oXmbLoj5NYn67hUYzvX5vkH1Jxak9W/hMTyyXjfFgejAFO8CbFkctHWXm+QM6niOSTQY14wyD65Uw4CV5YRtJVm3LzT2r1mLPrKiMkzNW1E2PUlyXW6pl90r4ybFL6Mf3HF8BklF5yY0/NP+DeZDmpBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 18, 2025 at 05:43:39PM +0000, Ryan Roberts wrote: > $half_ufd_size_MB is supposed to be half of the available hugetlb memory > expressed in MB. But previously it was calculated in pages since > $freepgs is the number of free pages. > > When huge pages are 2M it doesn't make a whole lot of difference; the > number of pages that get used is just halved. But on arm64 with 16K or > 64K base pages, the PMD size (and default hugetlb size) is 32M and 512M > respectively. So in this case we end up passing a number of MB that is > smaller than a single hugetlb page and the test raises an error. > > Fixes: 2e47a445d7b3 ("selftests/mm: run_vmtests.sh: fix hugetlb mem size calculation") > Signed-off-by: Ryan Roberts There's a similar fix already in akpm/mm-hotfixes-stable: 67a2f86846f2 selftests/mm: run_vmtests.sh: fix half_ufd_size_MB calculation Thanks, > --- > tools/testing/selftests/mm/run_vmtests.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index da7e26668103..14fa9d40d574 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -304,7 +304,7 @@ uffd_stress_bin=./uffd-stress > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} anon 20 16 > # Hugetlb tests require source and destination huge pages. Pass in half > # the size of the free pages we have, which is used for *each*. > -half_ufd_size_MB=$((freepgs / 2)) > +half_ufd_size_MB=$(((freepgs * hpgsize_KB / 2) / 1024)) > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb "$half_ufd_size_MB" 32 > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb-private "$half_ufd_size_MB" 32 > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} shmem 20 16 > -- > 2.43.0 > -- Peter Xu