From: Matthew Wilcox <willy@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>, Jan Kara <jack@suse.cz>
Cc: Oliver Sang <oliver.sang@intel.com>,
David Hildenbrand <david@redhat.com>,
Alistair Popple <apopple@nvidia.com>,
linux-mm@kvack.org, Christian Brauner <brauner@kernel.org>,
Hannes Reinecke <hare@suse.de>,
oe-lkp@lists.linux.dev, lkp@intel.com,
John Garry <john.g.garry@oracle.com>,
linux-block@vger.kernel.org, ltp@lists.linux.it,
Pankaj Raghav <p.raghav@samsung.com>,
Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [linux-next:master] [block/bdev] 3c20917120: BUG:sleeping_function_called_from_invalid_context_at_mm/util.c
Date: Tue, 18 Mar 2025 14:37:29 +0000 [thread overview]
Message-ID: <Z9mFKa3p5P9TBSTQ@casper.infradead.org> (raw)
In-Reply-To: <Z9krpfrKjnFs6mfE@bombadil.infradead.org>
On Tue, Mar 18, 2025 at 01:15:33AM -0700, Luis Chamberlain wrote:
> I also can't see how the patch ("("block/bdev: enable large folio
> support for large logical block sizes") would trigger this.
Easy enough to see by checking the backtrace.
> [ 218.454517][ T51] folio_mc_copy+0xca/0x1f0
> [ 218.454532][ T51] __migrate_folio+0x11a/0x2d0
> [ 218.454541][ T51] __buffer_migrate_folio+0x558/0x660
folio_mc_copy() calls cond_resched() for large folios only.
__buffer_migrate_folio() calls spin_lock(&mapping->i_private_lock)
so for folios without buffer heads attached, we never take the spinlock,
and for small folios we never call cond_resched(). It's only the
compaction path for large folios with buffer_heads attached that
calls cond_resched() while holding a spinlock.
Jan was the one who extended the spinlock to be held over the copy
in ebdf4de5642f so adding him for thoughts.
next prev parent reply other threads:[~2025-03-18 14:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202503101536.27099c77-lkp@intel.com>
[not found] ` <20250311-testphasen-behelfen-09b950bbecbf@brauner>
[not found] ` <Z9kEdPLNT8SOyOQT@xsang-OptiPlex-9020>
2025-03-18 8:15 ` Luis Chamberlain
2025-03-18 14:37 ` Matthew Wilcox [this message]
2025-03-18 23:17 ` Luis Chamberlain
2025-03-19 2:58 ` Matthew Wilcox
2025-03-19 16:55 ` Luis Chamberlain
2025-03-19 19:16 ` Luis Chamberlain
2025-03-19 19:24 ` Matthew Wilcox
2025-03-20 12:11 ` Luis Chamberlain
2025-03-20 12:18 ` Luis Chamberlain
2025-03-22 23:14 ` Johannes Weiner
2025-03-23 1:02 ` Luis Chamberlain
2025-03-23 7:07 ` Luis Chamberlain
2025-03-25 6:52 ` Oliver Sang
2025-03-28 1:44 ` Luis Chamberlain
2025-03-28 4:21 ` Luis Chamberlain
2025-03-28 9:47 ` Luis Chamberlain
2025-03-28 19:09 ` Luis Chamberlain
2025-03-29 0:08 ` Luis Chamberlain
2025-03-29 1:06 ` Luis Chamberlain
2025-03-31 7:45 ` Sebastian Andrzej Siewior
2025-04-08 16:43 ` Darrick J. Wong
2025-04-08 17:06 ` Luis Chamberlain
2025-04-08 17:24 ` Luis Chamberlain
2025-04-08 17:48 ` Darrick J. Wong
2025-04-08 17:51 ` Matthew Wilcox
2025-04-08 18:02 ` Darrick J. Wong
2025-04-08 18:51 ` Matthew Wilcox
2025-04-08 19:13 ` Luis Chamberlain
2025-04-08 19:13 ` Luis Chamberlain
2025-04-08 18:06 ` Luis Chamberlain
2025-03-20 1:24 ` Lai, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9mFKa3p5P9TBSTQ@casper.infradead.org \
--to=willy@infradead.org \
--cc=apopple@nvidia.com \
--cc=brauner@kernel.org \
--cc=da.gomez@samsung.com \
--cc=david@redhat.com \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=ltp@lists.linux.it \
--cc=mcgrof@kernel.org \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox