From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 367F2C282EC for ; Tue, 18 Mar 2025 03:14:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43525280002; Mon, 17 Mar 2025 23:14:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B9D4280001; Mon, 17 Mar 2025 23:14:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25B20280002; Mon, 17 Mar 2025 23:14:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 04FC9280001 for ; Mon, 17 Mar 2025 23:14:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 294D0120942 for ; Tue, 18 Mar 2025 03:14:37 +0000 (UTC) X-FDA: 83233204194.26.5EB34FB Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf30.hostedemail.com (Postfix) with ESMTP id 564E98000E for ; Tue, 18 Mar 2025 03:14:35 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=m0u9wNZ0; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742267675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IZeTMBf+g0q25krQH/ZEBB1cUeFX0Xuv/Nwv4tjQGNI=; b=ocbcpQ6N3MgeXsR7GfGEMq8lPhPcK4XX0sHxayNunMVN0NdlMST9X1bMYIy6XW87Ug3jMY gqnqRYuXBUAMBuvkI3RH4j6LM3ods+etG61n1JFuRj3hdSGrvk7GK4mdfX3hJfoJjHXePU FsjyayHG2qegwlJAKma17xeGWPjBHNs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=m0u9wNZ0; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742267675; a=rsa-sha256; cv=none; b=c9C/xcYSlB4cRYoGughxYVtFiD9GRJQBu2FYCJjiQ6QHF0fTWN0GrUrDfpWhzPrV0q2m3E EMuT/oM+aRtRIwJubWoQkkXHBhGsESRDwchLqM++FBGYHXrtTpG9Tv4CnTlrbyK0oSo5j4 v1s3+N4miRIaHpqUd1ce2KqyvUNKRnQ= Date: Tue, 18 Mar 2025 03:14:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742267673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IZeTMBf+g0q25krQH/ZEBB1cUeFX0Xuv/Nwv4tjQGNI=; b=m0u9wNZ0SmH6yCYL3o8VGnrB6I/fyncmwqwcRsn2+ZvZ1wnUNHzSpr3fEgURY4Lp1jqUNU b9/ppxHjqYomnlVckaqIy08X7kJtBWdh+bJfg3qaKnXzhiaEfd2w2YKb4SgLNnbAgFIyyi 2CE2eEfL79uN0oYw13Zq7HyCMH1jptw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Zi Yan , David Hildenbrand Subject: Re: [PATCH v2 1/5] mm: Separate folio_split_memcg_refs() from split_page_memcg() Message-ID: References: <20250314133617.138071-1-willy@infradead.org> <20250314133617.138071-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250314133617.138071-2-willy@infradead.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 564E98000E X-Stat-Signature: h48i4iwhdokrhoj5g3k64dyru7isdznw X-HE-Tag: 1742267675-73558 X-HE-Meta: U2FsdGVkX19YPHW4ag4Gu1160dA7AcpnHBnUmCXkLd0vRgl/v3Q3L+nuedAvFXZ8xtj2V8jGCnxayU2vuCAZ5Id6YHb2OvlINrvI5qcky1nnogqnE6ct71ruMgWxlh0tKO11VQy2LCjiqY6lRBHVlh/h0gkz3sf6CtP168a5ricnsJN+okM4W3aBVyp6tvJM63uxxzlbFm4vOHpOEQKbMrQvDCdwsJT+WCDHb2wV4qZy+J4/iQCGtasRxk5OEcSpIyKI5xhvznV+AOdW9OCGXStNzcVWlsxILecGXzT494NBjEL/fqwETvlfmRAU2xEf9Oz9DvJ1ALB7Pcmev3yW6HmFSk16dwgKwU2OYfxVx+Xa+ymqM1bZwjMJPMr9DndbK2x77hrDk7v8YmCq3/dwy3V5NoX/rK4INlQLLWjNw/kMcp9ANjfUxMnJr3Q3NyrLccsTAkeph6BBvKGPEQqDmd3Kvb9tTfgqA5kUivC86hZvinVW/E8rjggLnJCQ9XVZTEYXlMncg6k62AUo4ALf1TyTR8j2DxmWb+hSkVT4dD7zv9pTNpe+z81n/DOkS0k9SEBu4GiL+9THid5e0Bv7p6kaL2aI7tzjAuFHOSdquzpoP5Qayv6oWIKRQBIMlBDjOiWRa60MYFdAoiBfbbOX1gbIZEG9w+cn+h3fKhRjy8RrY8izYOBQpE3Z9v19ehQTSmSIzpjDkQhZ1XnLxtzmDwzIhLf7pIQLYmDYXtBdrhx3uIVKjPJPcIDbeDXZ95R/EWlpbhoy6XF5DOWGVQxih609dZFgrVWt3YwmE8OqTGQysgpJ9HMJ55k6KqnP41qrCrYSR7Hxnor5juZoYcySmQhHtSBq2JWsSJyfyvKEzuRTQ+iA6VEvAGkKOurEEAlg8fYaQCyDkKR/hz+JuxPUk8OLCL0SVjpNuL4507pdyEoS1uGwnIHnS/ncvQaiJsyZSiyWrrkk/eFFeu5f401 wCIGZNvm /Si1+E2cnzSMEGovxRkC0G90M2jNbNp+pljxOn+NJv76XnDir5uZQXQJwy2FdnC/Las40EAv6kkDIE2xfXgyf/jfhNWxw3yrvZrcIjaB5u1m5Y/keS8/V3KvPOEtpS8zbMvpcX9PdvsUv5paH4E5WPSP0PhU/rjPHP0Ny9Y5p5u+9mD4lsyW0MdxnsHckPbc1iK1drbDUdhgLKEKcs87QPNc/FDwBvA8yc5M8WHNM3WHtKYspjhOOfne8NQz0h1MxZHUegU6eQ2QfiAjUp3T4RrUXxvXGal+M2NV0Ur3AwLR0iWdnCyk6EYel8ZSenO6aaYroCMdZrEeI28V+k088QqiIcImxNg7O9JQ2xvoTMODY1MEsetzUpFRF9UBKkf+XmWE9KV4GPLvEikndyuiXrE0V3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 14, 2025 at 01:36:11PM +0000, Matthew Wilcox wrote: > Folios always use memcg_data to refer to the mem_cgroup while pages > allocated with GFP_ACCOUNT have a pointer to the obj_cgroup. Since the > caller already knows what it has, split the function into two and then > we don't need to check. > > Move the assignment of split folio memcg_data to the point where we set > up the other parts of the new folio. That leaves folio_split_memcg_refs() > just handling the memcg accounting. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Johannes Weiner > Acked-by: Shakeel Butt > Acked-by: Zi Yan Acked-by: Roman Gushchin