From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD7BC282EC for ; Tue, 18 Mar 2025 01:07:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06723280003; Mon, 17 Mar 2025 21:07:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 017CA280001; Mon, 17 Mar 2025 21:07:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2205280003; Mon, 17 Mar 2025 21:07:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C2A3E280001 for ; Mon, 17 Mar 2025 21:07:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CACBC140789 for ; Tue, 18 Mar 2025 01:07:30 +0000 (UTC) X-FDA: 83232883860.05.2D79E67 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf16.hostedemail.com (Postfix) with ESMTP id 18CEA180008 for ; Tue, 18 Mar 2025 01:07:28 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BAxalUnB; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742260049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9mPeLIacidUCCPqGAAEH/lqRKjMQTyR3oZRrUoAsBGw=; b=PJcyC0Fwcbp9Pwt4dKSlmyjo4worJFmgA3QfJfrYhKlRQiCTKFrxrq4VKq0aabV6XO5LCk qvNGPWRFdgid6kr1SIJ/cgS+eaSo5w1Gec0P1z1b/Dl7C0Z2GQoIAWbFeQePvhcy9QOIxe XzuJWkz4sbc1DiX1m9KEVhTOArKZd2Q= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BAxalUnB; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742260049; a=rsa-sha256; cv=none; b=C3EWeT0tYEFGDfHBg6ZuHi3eynOHRXpcuSghNDxcEahmFjDttTGH7Yih/rtsTqXKlT5fYi w7quNqyPHL9EeKhzXblPzz8d2pDbq2SFRHnYoFHCTyr6X7HR27NoK9vKK10Ug5NZy3MX3C S8CtghAfK/ZXPKrLAvGGi8sFJ9wAklU= Date: Tue, 18 Mar 2025 01:07:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742260046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9mPeLIacidUCCPqGAAEH/lqRKjMQTyR3oZRrUoAsBGw=; b=BAxalUnByRD9ldhNz0FH+D2OiWjrXYA+0FmMAzx1K8mp1ZMvRk2BimXfnmVvfghjfnlRfO yFMkgKFnWXYFg7rF3TzWlScC79a7uk3NOcz9RRlvmi2XcT7w3G74o4/e/lNigrxoK5COcX iz9PX83xKCCNSrblZ9Ny/rcQiKiwVzs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , Vlastimil Babka , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH 6/9] memcg: do obj_cgroup_put inside drain_obj_stock Message-ID: References: <20250315174930.1769599-1-shakeel.butt@linux.dev> <20250315174930.1769599-7-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250315174930.1769599-7-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 18CEA180008 X-Rspamd-Server: rspam03 X-Stat-Signature: q7pdztuz47bisk8reuc4ww8uqj3rsmcj X-HE-Tag: 1742260048-801951 X-HE-Meta: U2FsdGVkX1/P5lnjP/buo5jkt5W6QmWAQasV5AS3S0jDQGE+86pQrycH7+rmfZlpaf8J+/5pCvImTMSxElwUkYy91QG3D0n3dUzlOp0QdazGYsEYIXrJdnVsKDQg6K3UALVm6uEMAoDLhF35cOasWrzTCItwqhkz4MET06Ob2RFhw62HzG8syslSkrCM5xr5R8RqZmSVuax1jwiO5hQAF5slQpb13jyaZ1kAjWvZBFL69pWiBZdtgKaybzMZp0gPlGrRFOY2r2kEdXFU208v3WMskaKtQafsEUMWx7lkN1elVxQApubtysbL2fCOA6mSg9hntmn0ZpgbCjxERhYNcQ5h2/vTybwogV9d8uV4pHpLzV69tEX3KHtb/Wny4KV6pf9yIJNQHEyxtNlj0MpaqR4SrkuV+Dt2FAzeSLQhyVHZz3fuR80N2lsPgT6C16wetzw5+3Jfg8TzkTJjKGn0I+BiskjH6fnu6y7uCbE99v1ngaVI27bcEbKB9YASeoqomNVAWoIuiFH21gMx+RsoeCH2LBsTLp6Tsv2hiRYTPqMoQ0i4XmV82j/9E2MeUwRPEYY7JRGvaaImf3gbfQ4Trth5thPsdiV4ikd8459Ml2K73zWNFTE05E4VJrmPMyCxjvxn4FAAT884B0LdMWxDoz6NOXCh0wtHU8a+cvZlnBVRNN3b9zcqrKz4FCXTESoCSonOTMQxnj1blf3sl5Ve8L1+stDAXjYXgyeq29G4qWGrxbcivBcm+e1mfgKb18L8Dg6RjKzz7DQlnQdpNDyQkdwI21FSxVDcswcOoWQT/BvTE0SuJ5eimEB0pqK5B9fKfRkRns3cnM6LrahzoJBcAC4CKmAr/Baul6ON2FyMCOzHsJLTgfVA+YZjxo9VfNMRoqaiqK68oBCTNVJZJ6GIDIcZMRRR5twdENoPRtWHD+Cqt5mx1YTBucbJ5b3MrIeZaV3DQdCwJcNdVmd/MLR Pdw7aVrY /aAbXIsqsDSjeYRg7UEpkcVWcdPd/7hXl0fHktslJJvSbehR+eWm0HwDntrPoW2/vby+882chVnP8ceZe0wSnvK7h/EHSHk/eUSlBORf/INxOZluAnSekeNaFqHLrtJ4e4gUQIPi2T3R/aEZTThn2a0Qlt+CkMSPpxkfe6pjvBarflOrsU2Qx9h2LiofV9ZWBc+wY4JHAPoIF0WjO/sRoLgSiKt4j1nFRWX0SfpcBLOai8YNSuVCLKes5v0u4pKXdwIEBtbb6+o7rHk8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 15, 2025 at 10:49:27AM -0700, Shakeel Butt wrote: > Previously we could not call obj_cgroup_put() inside the local lock > because on the put on the last reference, the release function > obj_cgroup_release() may try to re-acquire the local lock. However that > chain has been broken. Now simply do obj_cgroup_put() inside > drain_obj_stock() instead of returning the old objcg. > > Signed-off-by: Shakeel Butt Nice one too! Reviewed-by: Roman Gushchin