From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7EC3C28B30 for ; Tue, 18 Mar 2025 01:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EC9C280002; Mon, 17 Mar 2025 21:06:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09D22280001; Mon, 17 Mar 2025 21:06:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA74D280002; Mon, 17 Mar 2025 21:06:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CC8E9280001 for ; Mon, 17 Mar 2025 21:06:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B3DCEC05C2 for ; Tue, 18 Mar 2025 01:06:25 +0000 (UTC) X-FDA: 83232881130.02.A0243F6 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) by imf30.hostedemail.com (Postfix) with ESMTP id 06AAA8000B for ; Tue, 18 Mar 2025 01:06:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="m/rNdAR3"; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742259984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2XWWCmRgpKGwn8kqYz0QsIKLW/nCL2Ko63f6fBFovis=; b=R0jYuRNjuL7jK8VphBm2tkUbfgXTq/ZbwJKMUBo6s32BHF0BiCARga7++XdoM5sQwFSb7H iKWlVkrEHA4HwEEGhTJMLDDSRlxN1i09C/ZsuO7n2cI8vS1u649XGGXlZCAyhbKEbg5Dpq ZJymwYnvQrFiK4Ks7H3b+jAa+tiyMiE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742259984; a=rsa-sha256; cv=none; b=s6C0NSNuwFx9SMZ3lnun/Ertn+HgG0FMgoiJXCHQyqIRDU75QcsiyYe33KLxyjXuBcLtJC 4N+0IJo36M5toX5Utoth+RhvdEWgT1QS5CVSOtxg6jRxIbSgrZYjN8gXEQE0kA7HlRIOQi t7VHy8DTLxwNQFVCP6TrzC7GojmxOp0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="m/rNdAR3"; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 18 Mar 2025 01:06:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742259982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2XWWCmRgpKGwn8kqYz0QsIKLW/nCL2Ko63f6fBFovis=; b=m/rNdAR3Os3KCPDVX79nPb2RszuEGShq7cEWP9QO1y4UHZbS2f6gxQ+xIKjDLrhNCkj4M5 PWB86+t7ZYpG8ebUVTwtglOaXCAFTBi8OZLDJgE29uPqKHzMMJUzBSQ5saD2NIbM5QvVzN m0078RnqXPMjdrOD9OgQ5p2gqc+l7Jk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , Vlastimil Babka , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH 5/9] memcg: no refilling stock from obj_cgroup_release Message-ID: References: <20250315174930.1769599-1-shakeel.butt@linux.dev> <20250315174930.1769599-6-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250315174930.1769599-6-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 06AAA8000B X-Stat-Signature: 9ec1oa9qo8ti9c3osasgwcjimzqraqoq X-HE-Tag: 1742259983-142412 X-HE-Meta: U2FsdGVkX19CynzcoAsJgWmLKtyK7gbXN49poV+ql5h9gJVwdJncT2+yQ2dvW9WIKqXuMsiIjQsAhLSi0DTjHlmDdCGGto9R9Wy6KTlQbSARvNrwgO4jcPcRsuKAsEzlHHOK/sf29MA8/G0SqGrvLLBaDmMBeCrG5XP5I2TawoNxqHK8SYxjrxuIR2GCZBoHFh1Uk23JZid701R0nHxBnqfMjFODpSsAYWx68ogggyYojCBXu3q5E8oy1411Y4ymqj7zf5WLSMBknPGEMCq9H434sKDOSbq2oT6ARknJ9NlukUQSUzdaQsmNbgZXuf4/tcVI0viPzLr1+dCha02xADoXQYo+LnB7k28o3AOIN5Cf/yratlf9925585fCFQBZzIolb2YZ5As95UBYoRXe5ZNHETcvI0Z94xBrAdydpVo7Jijv79FdQ6nYMhQtpsclvyvZ34LlCv+t8AoGiozu6CU7iW53lzUYmzOTuqLzNvv5aU/yU1QQBDaO0TXxrPDsFNOEJDZDq7OBvMt4ZcohkPrEMVcyMdVGAbz3vgJIe2ADZvbZ2Z8AmQit2tviGiXXCATbZ9s6lPo7zB/5wq6nc0E4s65MTtQ9RongWj+maDpmRBC2x2QX9CKKU70j1b3XTxKjzhi22kNEAMOV/RYVeA8jEZTKJFW20TAB1H8N6o1DWeZXo0FPg8VoMLn5BXNZzKdvH/UZeP7qxecAgu64R0Ztd3owMtXB1PsaAcRed4DHIgzdZgwnhGMFpiW/FeB3lJED9bEvYFkc2y/O9Io1K3h95yiagh7MTr9psfyJdeCPhCerojjRjuf23LGim72bUa9hE1LgdYScnNBPOukd0TKBqAek9CXgVELk30B1fF3JTaqr2h2Q5LPliTR8Heqa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 15, 2025 at 10:49:26AM -0700, Shakeel Butt wrote: > obj_cgroup_release is called when all the references to the objcg have > been released i.e. no more memory objects are pointing to it. Most > probably objcg->memcg will be pointing to some ancestor memcg. In > obj_cgroup_release(), the kernel calls obj_cgroup_uncharge_pages() which > refills the local stock. > > There is no need to refill the local stock with some ancestor memcg and > flush the local stock. Let's decouple obj_cgroup_release() from the > local stock by uncharging instead of refilling. One additional benefit > of this change is that it removes the requirement to only call > obj_cgroup_put() outside of local_lock. > > Signed-off-by: Shakeel Butt > Acked-by: Vlastimil Babka Reviewed-by: Roman Gushchin