From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F3BC282EC for ; Tue, 18 Mar 2025 00:51:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E01B3280003; Mon, 17 Mar 2025 20:51:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D89A0280001; Mon, 17 Mar 2025 20:51:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2B0C280003; Mon, 17 Mar 2025 20:51:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 90B39280001 for ; Mon, 17 Mar 2025 20:51:05 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E75F516040B for ; Tue, 18 Mar 2025 00:51:06 +0000 (UTC) X-FDA: 83232842532.06.410404D Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf18.hostedemail.com (Postfix) with ESMTP id 7BEDA1C000D for ; Tue, 18 Mar 2025 00:51:03 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ESTHhjxm; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742259065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UA+S9ijBBuQefZIvauH3YzP1rEzc6s9swtHO60s8uN8=; b=ncXnsZe9dHNmLtEz4FwVlKHK+GdZdu/ohDFywhKZ3rKK8NZ7xlkWasG6tZTp9c5d7ZspJa L71I4bcMjTDGW7utKol9r2BC+xZODYhCPJt/K6eqYRegs3Lbbsa4OyDVja+BjgnSpGILoo MJulWxloq+GFNSxxk9BIHFiq3+9KEo4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742259065; a=rsa-sha256; cv=none; b=qZcLCnhP28Hk/olTqRSvGPPG6dJlRNPytPit9izZMnQWiwpp8L8d4Lrm0FKxNX2Ue2tnHf ZBkhOB0vL1cYBjdzij5QswRyTP9h6jZ3CMg1bXb6WhQyztoWvT2s77SmzCiC3lgv14jSXU ebrhZaiufBZ+rgZu9eS6JYUgG+/MKyA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ESTHhjxm; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev Date: Tue, 18 Mar 2025 00:50:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742259061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UA+S9ijBBuQefZIvauH3YzP1rEzc6s9swtHO60s8uN8=; b=ESTHhjxmk4yJHum91VRyK6GyODQ+fB6QDAnqhgJG/4vJo70QJVReC4QgZ/upcDODSQiaI/ KDPdd8arnvTPORC8rxzA7nbozCIuGSlpV67/rMNroCPfe61Q4ZTK7Ne4T6lH+ZyYkZphXf fGW0wpmZ7VaEhwB2lIyFgVczytLeQTU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , Vlastimil Babka , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH 3/9] memcg: introduce memcg_uncharge Message-ID: References: <20250315174930.1769599-1-shakeel.butt@linux.dev> <20250315174930.1769599-4-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250315174930.1769599-4-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7BEDA1C000D X-Stat-Signature: drmch68m3etmxz87wq5q51cgq1udfeax X-HE-Tag: 1742259063-932109 X-HE-Meta: U2FsdGVkX19qaw6ZK4RV/8061qyrClxkY/1I+oocDos4eUX+DAe1gSQDy8yqaEy/7PVYPBaRirLge0N0cZHoCozO3BE0WF+rtMqjevtcjmFfj4DY3HtXaUXaMsUcFnbWW9/3oabhgBfinicqCp4CD+mlGUY1oG0rZ6gC3Z7mFhAOUQg+HeoCkizyD7Ys+mezFFGYvxJADyYxF9n4kdG9YwEtn9yAEABmBqmK58qO8RccPGnCS96fj3s1m0DxHdUoNcEd2rpupcblYFLaT29LYPdIDLNLatk28Bz5yYHi6LBmw3wgj/kArI69PHy0ra6eEOgATuXDlT/8io2Y7inS4cP0a/uh7rtKn+BUJTO+QTT3qxsZNBcnC/9ifOFDbF4beVUIHyLw7ISSjZtMfZ4OZzbOJ50CHrNIvp+6ikeiDYwUIuMqfEoQcxU4gXvsLwVZJsid06MCGSsK291o79AFeaEsIkhiN8pOAOnQWNhSL30Do9zdctR70AywLPARb2Ebr6iGNOGnL0wB+ScqyS4uT5Ifd5H6360rDXrzIZKxiK0kZRZLPREtijl9Nkjfd8nDqZOMpGLn9jLOT686CJbWn2rZ/t9ulkp2ZfB7dzjR1y8s2zYlh/UzoBgyDWLGchqsQse8d3k8GLcFpwHVTVsHSUmqRUSsBrF5YMhNJ5lOGRY6vCfuojMMl/isWnxDHrs/SKB45pIiXYEduNr5YNd9pOt+ETUz8XqsN5Yd6wGvf6Zy83cHvREu2yBtFNoygePr4cl7HE0PPMWTqeLgScL6iSI1fU37i5EsGHb4kXaH/77IzxJFRe35x/KE8rnNYiDdEfTO0cx+Lo2t2Xq3+5bBkbNUcWyznWOGvVhD6VExpv19ZMFEtd9Z+KrmSC93XDuPZua+R6eQHlBS+eLQxIZ0lkVOFkjpDXeQvTjh7CZc4T45R/8oH6F314D7SqDHOdt+UafZdwRBxFzr7oR8hSS j4uLrroc z5x6YJL3fW0yXL54hlMHXNp/PT7iUyl7Xa0TLG0o5WUKy6QrC0NsEggLHqSfbX6MRkI536jDyKDck+xQlhHfSZvTGe4prkc+Pf7ZE6rj54kzd5j4X/YaUhOOaFXxv/v4PXdp4BQ5ebRZV9uV9axwQfj/nHqFUrzmLGKqQ8XhPUYH3seKR5GOqctEX0JvXhPIoc5+44jRO9NVLKsRikJwY3kkQz0nBiCmMFDPogRclTIUCvgVN8BQpgk2Ax684G2/GJDvaS28iWOPEYAg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 15, 2025 at 10:49:24AM -0700, Shakeel Butt wrote: > At multiple places in memcontrol.c, the memory and memsw page counters > are being uncharged. This is error-prone. Let's move the functionality > to a newly introduced memcg_uncharge and call it from all those places. > > Signed-off-by: Shakeel Butt > Acked-by: Vlastimil Babka This is a nice one! Reviewed-by: Roman Gushchin