From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B73C282EC for ; Mon, 17 Mar 2025 22:30:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 477AB280002; Mon, 17 Mar 2025 18:30:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 424E1280001; Mon, 17 Mar 2025 18:30:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EC77280002; Mon, 17 Mar 2025 18:30:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 10F19280001 for ; Mon, 17 Mar 2025 18:30:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1848655BCA for ; Mon, 17 Mar 2025 22:30:13 +0000 (UTC) X-FDA: 83232487506.12.31A3C56 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id A42BF4000A for ; Mon, 17 Mar 2025 22:30:10 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lnqQ8GWQ; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742250611; a=rsa-sha256; cv=none; b=0NZbVUCfZ5GpPMapIKOlg7QEWD7TY9XEodnN0TK2ZBpC5xt8w6/XmjSKT1l+At8cWj+p+l 4r8uuUJIhqhX+0M1XzTZjUqBvrTzILWursQd27BN9HqArjJBI6SmNrP3MEBxDZ9bllsU9W B9d19ye8FNpI+XDICWtnFD788tmIM0A= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lnqQ8GWQ; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742250611; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j5kfpSpCW3Y67C0StqdtkYxDyNl1nfMhxEJXQKT31Zo=; b=V1x2uZ9Td2agT13yb8669K5G3BWi0lmbgK3wasLXK35EgM6Q8FWlwN6lhCkh6y+ZOLIeYO iLYEnnDKNvTlFqUHlO3WlGGwI7d0C3YZxdZdWjAsdp0c0t7y4D5FlYQCsbfO4g4ESmKrmD p9rgwrRWX6/ayq0tJVjtQQw6OkQ3Myk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=j5kfpSpCW3Y67C0StqdtkYxDyNl1nfMhxEJXQKT31Zo=; b=lnqQ8GWQJPuTHf0POXM4ZAutD3 JO3eo1JAyCPUoWQLx5ExFjSN8D8EGfJcU6wdjr01FhiDe3p6f88sNLY1fnPaPUBfz2Zq5R/TDTs7E 2MOu2txj7EzeNRp7sZaCr4USvP3iJJCWjri8hRHVG2vb3yC91F3Ai4SHuyJSR5RizmcKcYdStTKGE Rq/JG6IIZ1WcJWh/fHEksb8Aoqdxaz3Q2A8fpmxq7Rys8oE83FTcdMVJJxAjCrXLGLdZvDHZ9iRby 0xQAQTktKcm1jIgBjuOu8xB0we1L6ivbHyrhDYdVPbYJDqTXrBScXqVGXO7IvXxua+5wNYKJCGZ8c nQg4YOfQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tuIyD-0000000A0Ax-2frk; Mon, 17 Mar 2025 22:30:05 +0000 Date: Mon, 17 Mar 2025 22:30:05 +0000 From: Matthew Wilcox To: Fan Ni , Thomas =?iso-8859-1?Q?Hellstr=F6m?= Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 11/11] fs: Remove aops->writepage Message-ID: References: <20250307135414.2987755-1-willy@infradead.org> <20250307135414.2987755-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: A42BF4000A X-Rspamd-Server: rspam05 X-Stat-Signature: ai4d4mekem3d9mwnhhrjzimc3twbiq6y X-HE-Tag: 1742250610-626427 X-HE-Meta: U2FsdGVkX1+7qkkt6ZwqqA0Ggmn4wbfyHq2igdYp+83RGxGvXdkUp5wrlSd04pjlgTSg35/JoiS+0HRSU5RLIT9zgqPioo7EM9HoqZGZg/iIRRf7FllWHWIxvCMDCRWNBzllP3fJyM71SMOliPSTmfVq7FpcsthMgETNsx5PjueOqZZJZZ0GlhWVdUndqiFqwDT/D7IJaujpDzPh/YMom89JZHUYOwtxIww9aPq0c3wVY2iJC05x/b/YyGlLB8qWIWFINF3uU8dY5uCBOjvcDnTOfUsPk4lYTWFnZiCfCwvoEqDJ7ZU3zKbIN/yYYKJBazu8Hh02pf2hsTDk5wM2akW2DHIX789Y71Xo5A/aO1j23sYkaPX6dvL6FlDCH+Zs9X0SLYVJiBOmqI5BQnMI48DhSKlVyJxliUtNbtiUjXTLktclWjlDtyMXk1ApLhXEGh+Tei+L3JTqYBn81dNPIykhEKzLarHvEk21awhjmpXUX05nCRNZAnSPpB19GGyGCLn94Hh8+l/qh3hZt/K4Krbrsg6voCcvtvuqjmLjuLCiF+STN4Kje8bhFnkJYJWxZlcYSqkcp+Rf6fn7LVSz7l68eqKfQQh3MO0129VEAIoqPyxq9QDgWhiXDgxxIX8UOyq6UJnG2B8zFUYCnOgtOLMF0aM9MwgrBVuqkJt97n9kZBaVvwts082pMakDYPBBh6AwWgLSOsJMaIucIUCJecve4JM5WR0EVh7SkmzQDdi9SCpPLFyOzdgOR3+FSTiNMON6hla7kCawbWNfLR3t/Ai2TI7/vyscSqihngpWcpa6MsSEoO+5xGbv1kmnFb0rp/Q2JbeLYqmH9uE0SsetupYmgfI0x2MbGX2obxsU6KutVns9qPZDMXNOdWSPy8yxOLSAyt1eUFzoXN01oZTDlG8RQIkFqyy++NtYIA1SYLexSwD/eBOr1dperUuiCXv45GOZn5HpJ/1yvMAQ1xw Pshv5MKa 5VDL66QWlZYR9t/OJBaOLH+MOsmdHecJyq+zHQk62RHRVuF4xh1bnBBVKo/1S072u8SGwbCrLtIaGU9Y9cnfAg+oJy9aOMt3Idx7sOY3tZw1zFUjb6adGyiV43efkfQCJPH8B+D1RuEVxjXgamQ+vjC42W7wmPnvHwyNJ8ytT7arXtWVP+Lkh99O3lnIRm03r860502Q33iF3VKEXqecm+kN00jiskU54NfQtENVEa1mv+PlNI570+C5W/h9svCDQ8CQxnlAJphPzLH+J4DSXR/ukIFpEdGCAGHBUPWGbTFlxErKi++Ko+mJ8DB+QSrM47HRaapGsG8uZZ4W2Rq2zddbjUA2r3zz4JA5BAnU1I9vBtS2QYICQt8jBH+B8vDvCF0Zf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 17, 2025 at 03:22:30AM +0000, Matthew Wilcox wrote: > On Sun, Mar 16, 2025 at 06:08:52PM -0700, Fan Ni wrote: > > On Fri, Mar 07, 2025 at 01:54:11PM +0000, Matthew Wilcox (Oracle) wrote: > > > All callers and implementations are now removed, so remove the operation > > > and update the documentation to match. > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > --- > > > > Hi Matthew, > > > > Tried to apply the remaining patches in the patchest (Patch 5-11) which > > have not picked up by linux-next. It seems we have more to cleanup. > > > > For example, I hit the following issue when try to compile > > ---------------------------------------------------------------- > > drivers/gpu/drm/ttm/ttm_backup.c: In function ‘ttm_backup_backup_page’: > > drivers/gpu/drm/ttm/ttm_backup.c:139:39: error: ‘const struct address_space_operations’ has no member named ‘writepage’; did you mean ‘writepages’? > > 139 | ret = mapping->a_ops->writepage(folio_file_page(to_folio, idx), &wbc); > > Looks like that was added to linux-next after I completed the removal of > ->writepage. Thomas, what's going on here? This patch fixes the compilation problem. But I don't understand why it's messing with the reclaim flag. Thomas, can you explain? +++ b/drivers/gpu/drm/ttm/ttm_backup.c @@ -136,13 +136,13 @@ ttm_backup_backup_page(struct ttm_backup *backup, struct page *page, .for_reclaim = 1, }; folio_set_reclaim(to_folio); - ret = mapping->a_ops->writepage(folio_file_page(to_folio, idx), &wbc); + ret = shmem_writeout(to_folio, &wbc); if (!folio_test_writeback(to_folio)) folio_clear_reclaim(to_folio); /* - * If writepage succeeds, it unlocks the folio. - * writepage() errors are otherwise dropped, since writepage() - * is only best effort here. + * If writeout succeeds, it unlocks the folio. errors + * are otherwise dropped, since writeout is only best + * effort here. */ if (ret) folio_unlock(to_folio);