From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E76C282EC for ; Mon, 17 Mar 2025 23:52:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3427280002; Mon, 17 Mar 2025 19:52:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE431280001; Mon, 17 Mar 2025 19:52:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAC81280002; Mon, 17 Mar 2025 19:52:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BD32D280001 for ; Mon, 17 Mar 2025 19:52:20 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BF602C046B for ; Mon, 17 Mar 2025 23:52:21 +0000 (UTC) X-FDA: 83232694482.15.B38059D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 08DAA1C0004 for ; Mon, 17 Mar 2025 23:52:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hszOd0A6; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742255540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ln9muO+UnoEXyYsgLcV9Ra/t7A/95ouFlMUsf8wdrpI=; b=tJG5S3JiGc1hIfBMZmcxJnzMZar96IVLeTa/J+WjaOoxVTm9852ZE5ZGujBIWAnR1rx+k7 efHWxyrBcetafGrUfSmltbV9GdGB6eWfvbvdVHXV2T24F4iFQCxF6sJVIoolZUrwI8iU+3 osSnlBp9lKTmQ5iC4MDG7WZDds4yl1s= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hszOd0A6; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742255540; a=rsa-sha256; cv=none; b=T4hiXRdtFFLOMlBggJ163hY4KpYvIwxmJPfhghK7ZMRx0ZVvEhAmYiHjDe0iBQiDxlSti0 S9zWL1jI0jDWLV/nAr0afnPRJNKXn50s2V4AtMwwcy5EIwtc0+WwBT+RsMyEWwM12J+JUg BFFgD2CK1siQSvgGemOfSwskpsBP6xM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742255539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ln9muO+UnoEXyYsgLcV9Ra/t7A/95ouFlMUsf8wdrpI=; b=hszOd0A6rkgJ5CDCoMBctPukdt9WOtLrLmQGWsDpv4cr5tITgbuOGi5M6poYCD/w8t9THo /gjcaHj0E764om2zObemR4NDjNeCueuex5s+GXbgZDwKnoc5PejbjJrQvo85oQKfSDfxcV oowggg9gyxFoo/UqVW+FOYXNkjEr+MM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-DU2R_2XDMkuC00OGsR7rfg-1; Mon, 17 Mar 2025 19:52:14 -0400 X-MC-Unique: DU2R_2XDMkuC00OGsR7rfg-1 X-Mimecast-MFC-AGG-ID: DU2R_2XDMkuC00OGsR7rfg_1742255532 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9C30A195608B; Mon, 17 Mar 2025 23:52:09 +0000 (UTC) Received: from localhost (unknown [10.72.112.23]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 53A23180174E; Mon, 17 Mar 2025 23:52:05 +0000 (UTC) Date: Tue, 18 Mar 2025 07:52:00 +0800 From: Baoquan He To: Christophe Leroy , Andrew Morton Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Arnd Bergmann , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, Oscar Salvador , Peter Xu Subject: Re: [PATCH v3 1/5] arch/x86: Drop own definition of pgd,p4d_leaf Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 08DAA1C0004 X-Stat-Signature: rkgxiknyp1ogd3prjr98uug1f4athaup X-HE-Tag: 1742255539-501779 X-HE-Meta: U2FsdGVkX19sGUNNX58DEcGKnQPK1EDl/xG94rUnzS5LRtcFXaZHq7RKOIlrmWagmX0JVCHt9yTJi8UygopVZfTZoxO1Qy2FFkOokdZkWsSxn5L5bIxyvfJPZ+jDzVYnePL7vuHIEmxdkQ/MkMqz0CZdy9+VysbI0pf6QK8/NWltEYI0yLT78YTMlfHoSnHZVtDjo7/6irbTYTNrjQZuC7LHZz0krbabKOXUi+89qjOaZU0Gt8RaVIXogfGzmDHzHZvmJWBYkp/LkWbQMX0cjP53EW5Ts1jjjObKpNoQkF9C22iL9wxt2uiFlSXQR3r0pLKp96Wlja+LEU30bhhrTj1b2Z/dzmMYSvuv0edjY7wbVNoxHNLTArUOIFAoJtykhdV3qO3LQ7ILZoQWzbFpsmcMap9kDnodI7FneAUx38mnYjPTwXcE8A+3wYGBiSAQbyrfwpJTTCBt8sQjaqMEd1n5+Hcmzn9gwi01IY8iat8aXzTRU7CTjxnDYuaer+sUxg59YkB9T/LR3RIE4vQ9GatMDRtQ/ArMMVzAFddBvyjlWpyEJhbVStk1/yY9dSYxOe4RdWQbcQcLDXBsJRBXrd2NXj0y+mG0rj189m8njrSJH0w+1jyBlz2ORavMCD9//W1HQQeYTlUcyK3skBFSDuy2jwUEBVPMpVpl4qEMEgJFzrpp6R2hReew/cQX77nWnqZcsY9wKxJJaXAuaDp6KcHR3yUTlpqbc0yZF8clJMxKQGGPAl9kVXsccifHn629ZU8jsdXg/uBeeFGevyAupeKziZ5ozdvlX7IGtY9w2HLeVvF9PTq+L5qEazT+e9Pi5xmRIyjgAB4M6dMve5oTyyAJzIieTA6QK5t3Iuihma06RKHgQeIGGFG+wXgs358cekuzdX1PvsUB9jSny97Au3yKXHFCou4WYKtUu1CB+4Cth/VAUV/02HVy2LxvpoEC6q9R5MRpX7sodQIa/b4 5F+UcfZb hkn8W+n/UTbuRiAJ4C3I95SbuwXvLs1c2k4TQ/ZXzPq1F4l5JNun+c/vjsKiLyYzFNkCpyKlu2NNZ5as+I90tLRZJGNyQW5/O3fLot7Kzn9O49H8bVguLueSzs4CSROLa1FVCK8v0EKG5R0Ui1JfDDEYmJyEV0BT4QbkneZQzand/dABx6p2DUHIpHKJrFmpzfGiItcEhTFXYGch9coclZJTNTU6Zz2WdQUTkGhHOMhU6qHMGDJ5gN8VsqMXW+WftZTubuti4kS+Y6YAyssTwJr8IQMlDAJzEpxwlWlCXCMn4cQqMZv1cZirmIe5FFR4tKhVy4rsOPwtVbRsl9vzU+VPc+xrtOJk1IzwY5oYt9s7bOhjsKVIai9HKvz3jiSx3qPmHetsqPga66SNQrzVVLYKBw4roDf5Vf3x5J8LxWu3rmqJWxubPjcd9KnXSit95ulz2ejB85fJKzW3q9rkhzYl8AP3qsoVcPGsFndoUY9urFlf/Yo5ZJBdZF1Lw+T+DiLTXZU6q5n5m6i8PuOjxaGb/930KCRtV7no1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07/13/24 at 09:08am, Christophe Leroy wrote: > From: Oscar Salvador > > We provide generic definitions of pXd_leaf in pgtable.h when the arch > do not define their own, where the generic pXd_leaf always return false. > > Although x86 defines {pgd,p4d}_leaf, they end up being a no-op, so drop them > and make them fallback to the generic one. > > Signed-off-by: Oscar Salvador > Signed-off-by: Christophe Leroy > Reviewed-by: Peter Xu > --- > arch/x86/include/asm/pgtable.h | 10 ---------- > 1 file changed, 10 deletions(-) Seems this series is missed. It does do a great clean up. > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 65b8e5bb902c..772f778bac06 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -252,13 +252,6 @@ static inline unsigned long pgd_pfn(pgd_t pgd) > return (pgd_val(pgd) & PTE_PFN_MASK) >> PAGE_SHIFT; > } > > -#define p4d_leaf p4d_leaf > -static inline bool p4d_leaf(p4d_t p4d) > -{ > - /* No 512 GiB pages yet */ > - return 0; > -} > - > #define pte_page(pte) pfn_to_page(pte_pfn(pte)) > > #define pmd_leaf pmd_leaf > @@ -1396,9 +1389,6 @@ static inline bool pgdp_maps_userspace(void *__ptr) > return (((ptr & ~PAGE_MASK) / sizeof(pgd_t)) < PGD_KERNEL_START); > } > > -#define pgd_leaf pgd_leaf > -static inline bool pgd_leaf(pgd_t pgd) { return false; } > - > #ifdef CONFIG_MITIGATION_PAGE_TABLE_ISOLATION > /* > * All top-level MITIGATION_PAGE_TABLE_ISOLATION page tables are order-1 pages > -- > 2.44.0 > >