From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F2CAC282EC for ; Mon, 17 Mar 2025 18:24:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35701280004; Mon, 17 Mar 2025 14:24:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32E16280001; Mon, 17 Mar 2025 14:24:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CFFF280004; Mon, 17 Mar 2025 14:24:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F1CAE280001 for ; Mon, 17 Mar 2025 14:24:51 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 90763B690B for ; Mon, 17 Mar 2025 18:24:53 +0000 (UTC) X-FDA: 83231869266.07.1728FBF Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf23.hostedemail.com (Postfix) with ESMTP id A98E8140008 for ; Mon, 17 Mar 2025 18:24:51 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=V0rODdTk; dmarc=none; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.41 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742235891; a=rsa-sha256; cv=none; b=8H6ydhuwM3zo7FSsOxB7hqouU2wHfSeHkyVl/bdtihSSQ4VfQf+DJHwjJgfdCUYRzL2xQT A7+DeOMESTiAM0dgfVZ1rrQDFAsRsVxcPWzQvJhucBpsuMOrmwSnEATIxqV+8q4kHNH6Jz VAB4UM0em4zOdNELxCWRj/DuVME6s88= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=V0rODdTk; dmarc=none; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.41 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742235891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qffRqeeaN/xyBcdXkC41yRxHN6rIHMJ0xVP8VR6XDiU=; b=xgKk2kz7Yu9OtdKRpsjj9rh/w5UACCAIcZeZaY4pm41hOlc9N5BN0ymt1R9cfZCqlQhhUD B2h9V4hxIbMwNwEaMQB2FMbks4xkcWnQBTzBDN0mdLrW7d9lv8cqdafFdVtakhoapohu/2 8Jee5hcQc2rAMwyUSCnwv/EukSD6vqg= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6eafac1f047so20696016d6.2 for ; Mon, 17 Mar 2025 11:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1742235891; x=1742840691; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qffRqeeaN/xyBcdXkC41yRxHN6rIHMJ0xVP8VR6XDiU=; b=V0rODdTkSHZE3MV52889wND7ZhSAPgCsg6YDqKOJHMfM9M965eUscKJuu/XRQgpWFx pQXdsJ5KZvvTWD97F1vSdDu3dKV9WoXsKUPun3bElfMk3N7u7u2C0ZlM/dimLTqHj4q1 nZLjTZp99dUOYKuKlTT5rjhNhEPjbpfgY7TnCCJVy7Sr8/erEg4nTsfG0DURtyxXnVlv sqhZiwsEx7g350vUuLRc9mKLFhCxF3DupLgUqRy+w0ZT9+2NJC2JZZsCg30asRYMpMYq FmOjYxdHe7go8Hp0pA5RyX/DGscQ/JlB+9Rlkeuj5X88sH+fl1SRnzDw1nXTJlwirBC0 Fybg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742235891; x=1742840691; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qffRqeeaN/xyBcdXkC41yRxHN6rIHMJ0xVP8VR6XDiU=; b=AoWdQX6S6aRB/0E6U6kygrhFZP4l9KgVbx48f6wZcy8ze4tLPTR96wLj2LnpfC/Pt+ Bq8/iff1bv0Ue7vRI7etUrhv3n+73NCZAnYtcXHbiKVowCGm+kON/i1ZzMJ87bu17GNY i0ha2ZSl+sWB8HDxqYwTDqW0ix8D9GTXNA0zanDNmzwkjdUtT3Thifr6+BC+omIRRR+4 hIW0OaIoXOFxcuoGCBTKpv/Xbvs64adtXzLxpNx1bfSOoK2ARtv+vgj3C5cY87pPdw83 +mUe/sSG2yjFNru/uLjPZwFdCi7imOmZyWnYAyGy9vqbJIBk+TPLrGowcC1quYuFs5wR a1iw== X-Forwarded-Encrypted: i=1; AJvYcCW3/waMpzHRns1SxuuC2/cRLSyromUlwdcLCKIdQepPYPeh5DXxmgn5VZ1Z7k90EcB9Rd1dbvwG8g==@kvack.org X-Gm-Message-State: AOJu0YyrG0iXMzC2ieMolyDs7YPRQaoEW2sBF+8bx1spoJVtyqBO8TKB ErdglFaPX5dtUBvx3huK+m5h+KTBfdWSvfmZEpz8QQo2I8H2WgQ4M1lAmj8DGKI= X-Gm-Gg: ASbGncuJPNofbftFGGkzEmzDd5rIn5EX8uDDNE31Vz139q4HCf255rrNCxvAbH8QIJv cTGtJwxwEK5sVt+LSZ3D+APT5TbkJXHX80eSimun80ELlgHmZVBj9BXnk9OfrJO+1VOOkEd1d0A 6N+QcCKGZxCdhMnYu9brvDLy1f8d0fD7iPuRFlkU3bYNJvio9fJWF4sWbMb5LLcwwS/KOo8vUTI /FXJnpYoYE/YxQYV9/nmi7iw2RsIzqzVAyqlNlz7oxGoY3MQSpGJ0hqdmy9TwL9duIuHNM/+4Gm yID6DnOhjgdnH+bZuj6Gxz1DYONWLpFZPPvAGNamq/yj5LZp968Y0GUAJfyagiNstlbFYIvqfV2 750SEg1qusF4WMsZcnbXmpPuhOXXMHOnQF4XhEg== X-Google-Smtp-Source: AGHT+IECAQV2W4ZfXVx/cTTr/lq8wcLUfss4PApt70+7/vAmtkEDvbuW09xiFSiw2Zhgj5gShBbs2g== X-Received: by 2002:a05:6214:2626:b0:6d4:dae:6250 with SMTP id 6a1803df08f44-6eaeaad4dd7mr242589906d6.34.1742235890789; Mon, 17 Mar 2025 11:24:50 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eaef289853sm39397646d6.25.2025.03.17.11.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 11:24:50 -0700 (PDT) Date: Mon, 17 Mar 2025 14:24:47 -0400 From: Gregory Price To: Bharata B Rao Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, AneeshKumar.KizhakeVeetil@arm.com, Hasan.Maruf@amd.com, Jonathan.Cameron@huawei.com, Michael.Day@amd.com, akpm@linux-foundation.org, dave.hansen@intel.com, david@redhat.com, feng.tang@intel.com, hannes@cmpxchg.org, honggyu.kim@sk.com, hughd@google.com, jhubbard@nvidia.com, k.shutemov@gmail.com, kbusch@meta.com, kmanaouil.dev@gmail.com, leesuyeon0506@gmail.com, leillc@google.com, liam.howlett@oracle.com, mgorman@techsingularity.net, mingo@redhat.com, nadav.amit@gmail.com, nphamcs@gmail.com, peterz@infradead.org, raghavendra.kt@amd.com, riel@surriel.com, rientjes@google.com, rppt@kernel.org, shivankg@amd.com, shy828301@gmail.com, sj@kernel.org, vbabka@suse.cz, weixugc@google.com, willy@infradead.org, ying.huang@linux.alibaba.com, ziy@nvidia.com, yuanchu@google.com Subject: Re: [RFC PATCH 2/4] mm: kpromoted: Hot page info collection and promotion daemon Message-ID: References: <20250306054532.221138-1-bharata@amd.com> <20250306054532.221138-3-bharata@amd.com> <20250313164430.bzkfyqmx6a5dj7d2@offworld> <038d0332-2146-4bda-adf6-03ef58dcc3b5@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <038d0332-2146-4bda-adf6-03ef58dcc3b5@amd.com> X-Stat-Signature: nibmrj9yxzanzmjb4zqyonsok7rj7j5r X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A98E8140008 X-Rspam-User: X-HE-Tag: 1742235891-368598 X-HE-Meta: U2FsdGVkX1/B+xezUOKAPLQijbuxS/5z0o5d7lDBxBqh6bt5aW8K3jjEquvZRCc4hQ940wED1RrE7PvltvMUhkKf5X2tY9uu5ADsJMF45hlWXPQkFNnm1MbcwIsV9RFaq5gdhLDvGUJFOS3Wsvlinp6A/dfSKuD285aqPcej+lPlObxp2rW9WcRNv1HBdtrtLdmRvfP3bRxY8qCNxz4ow4Ewv+vMQ9ADPJRy8XIH5X//c5T/fdakusm4Nw4tH16A74AiywASEO6QrGYPgXwgBF5kJduNDV9GB93ELMTkyNbSh1sNu8Ih+WCIILe6hN9nuOG4xaAlyH2pSlkJy9b1eOayXJUQ1dOTDqKo8eWExL/z8tZ1VDWl9t+W6xeionNJfAPIoR8Xeod7e04DpKtrJB0jy1CytITQEmC8hehb69vNlCZk5OdP6mvdOUllbK3jHBdD+5eccNUzh1/0ys+P+GZytrwl8pnmMa+Lgs80sYF4dZ9E10a2BmVYuOUoX7P8W/Gzcy0yIGquoYILg1gkWeFgBymk7RiYw1k7f7+8EJ1TuR5ZDsVA3w5v6rtpL7kRDFO9mme1dJGoV5IdFGE2eEWPx1p4pQMOoodKL6aaos0NLkjhKYa33kAdKzeR6XLBYVnve5FBWI52X333fJxmQGyJBf4QAk2Cw9Q8cN9ww5t03dQYQHzpdkUgS3Vac1awgqKbh0aVo7rVbSes1SHE95hIrwanVGhiGtU95TFtiqki18uLgxE6UV1CgUCkDoSrbSYkcL0nabcodxn4ueISqMFTINa+vhpKbpa8SbU9M/9SWPu+ufioNaP5jyAi0b+mRfHFOeIOzquzfQLG64aznjAPjyAAd9sdTbbgyUi8s0FoShcStX0XDtPhRff+C8Mt7xWdxeMo6aDeIyEzKkGuvK5kBNRLFLJF+x/2oQ/gkabN+wUrHBEZkHQdvazeP9nWavxk+BDcn5x5GTBuaD7 IeRYy2Wu jTH16jOfDoR6h9YaCIelNjc6phseBplOsqdHdGihUFfRGHapGgm48oEuJCTkchG60fi9/fNuiz+hIucFCeT/FmqJMyIjBZCn9k5AzrnoAzpIdzKI8b1ArhZgKAGyC1pRKWr/3fVyZ0B1rwLNbqhtnJ6rGiRInrE3elBuIdBlwZr/MT4qjjupr0dxAjy+Du50vw1tebGWNZG3Gy/+w2FZ+UZZH++COhriE39GSPtdpRHxQ7CvKYYuZaHDMoY2mUch4DCVPZn45VGsM3Kz9UmVosz33C3JDQ0j+veGksKw3jYH6LGbqg3rTkeGP5YodsYCYHAj7qbmdDmmhcTh4WTUsRT4KLJIpSuouOnO/8vkoXSHnbc6mGmVUDQuzHS0lTR9jfY8UqbcCK+LAAriHpxxrOdbMHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 17, 2025 at 09:52:29PM +0530, Bharata B Rao wrote: > > > > > kpromoted_recorded_accesses 960620 /* Number of recorded accesses */ > > > kpromoted_recorded_hwhints 960620 /* Nr accesses via HW hints, IBS in this > > > case */ > > > kpromoted_recorded_pgtscans 0 > > > kpromoted_record_toptier 638006 /* Nr toptier accesses */ > > > kpromoted_record_added 321234 /* Nr (CXL) accesses that are tracked */ > > > kpromoted_record_exists 1380 > > > kpromoted_mig_right_node 0 > > > kpromoted_mig_non_lru 226 > > > kpromoted_mig_lru_active 47 /* Number of accesses considered for promotion > > > as determined by folio_test_active() check */ > > However disabling demotion has no impact on this number (and hence the > folio_test_active() check) > I've been mulling over what's likely to occur when the Low but not Min watermark is hit and reclaim is invoked but without demotion enabled. I'm wonder if kswapd pushes things like r/o pagecache out, only to have them faulted back into CXL later, while new allocations stick on the main memory. You might try MPOL_PREFERRED with CXL node as the target instead of bind w/ the local node to at least make sure the system is actually identifying hotness correctly. ~Gregory