From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A047C35FF3 for ; Mon, 17 Mar 2025 16:24:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A3A5280004; Mon, 17 Mar 2025 12:24:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2510E280001; Mon, 17 Mar 2025 12:24:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F15D280004; Mon, 17 Mar 2025 12:24:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DDE52280001 for ; Mon, 17 Mar 2025 12:24:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D5B1C1202C7 for ; Mon, 17 Mar 2025 16:24:40 +0000 (UTC) X-FDA: 83231566320.19.71B755D Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf18.hostedemail.com (Postfix) with ESMTP id E6F121C000D for ; Mon, 17 Mar 2025 16:24:38 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dZt4iWYG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=jackmanb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742228679; a=rsa-sha256; cv=none; b=CCAsZ0Q2TAiNhlNxSMNVi/3nBAUF5C9HJlbyUoN+9HK9Di1A06fZFrVg/66yW7KngzzM6s YlOL0VPF+rblApKAz2QYdBLWxLP6KNbXdEr0ByZY9nprqwHny5sDaAlDKy0FHozfsMeIZP tj21JBRv2uPLI/Cu6ZyDnr6NyC9xZZM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dZt4iWYG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=jackmanb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742228679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eMt6/0rjATR1bwi+k8yOxA+2RImgBsoWOOfOgx1rzkI=; b=Sbj8BFAx7AG2JSfESNaQ5JsDqgKWbpwEcehmvsVKt5KzH5PiMvCn3yxUbClJergPdJPTBx tEe5BLoQ18cb9TV024OcPBo8KDLNbTTscD8+HbxC2wZelaLgMtXSWosDg9SkMu0ArhBlgs PJKDfoPKvwHiQnICViRtXkwZk5pu9XY= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4393ee912e1so11095e9.1 for ; Mon, 17 Mar 2025 09:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742228677; x=1742833477; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eMt6/0rjATR1bwi+k8yOxA+2RImgBsoWOOfOgx1rzkI=; b=dZt4iWYGD9IZkWFxbKBpozA6knVc5v4CXsb3JsGIRaOsDBhmu7C/8Op5hZiiR6CsXV SDEyeSd+nW7Tb1LdoaS2Q7RdTnaBYaFrCwJVvPyCTpTV9OCVbg5TaFNqxZ0+EbdajwkW cchHbVsoG7ciDw0Wl6FYDW2MGTdtVi+KACdnTFX1Sdp0u7vK9Fd/6kDh+hQoVhDLm7L5 Y3V+3xvUhjp6V5wGudpnOUmFplGkpZNR387LpHuFiH3tSA9WSyxjf/6fQzVu/I9GO2Xv ucjOd0V3XUha9LEy9pm0OiiouQ+OxHzQQZ5C70WWlzT5sp25qQjGNdSh6iC4/D2NjGUH p+jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742228677; x=1742833477; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eMt6/0rjATR1bwi+k8yOxA+2RImgBsoWOOfOgx1rzkI=; b=hOYHDsvlSc11Qhsyf0T3Q645g65X9jk9syb8C8bPGmteONWVXxsCPQESn9zvmXj2gh cmm7aFeuVTBhWpSr332JCkjpI8x83xkqMCT2d3W0AT5apgTj/uM6w4wT5tOdLPZnUqs0 rHdCNFeM+z4ohyQTcI1Dpy3c0h49p/fKENQ3oNI/9mYJ+c9XBWm9DTBPWPm8S/qBUnDv 6b66gXtKp6fq/AE7wSvsd4koktPLKo74WPDGmSMOH4FaKzpeN0PFI6AosBBEZo1dkgvN L8W2rgijWuGbYAVc/RcpqM91DGAVLRpXULxnivrWaQqPudvhMPazb4S1UpLXcJXtWWsw EZRg== X-Forwarded-Encrypted: i=1; AJvYcCX0GRDl2CKNj1NM4UFImHgY6s6Z7YK4Xpw0GMtpjmB5vZ2tziV0NcTc4TyoW/26WZ6VYaaPSbwgHA==@kvack.org X-Gm-Message-State: AOJu0Yzol4xShtidkYX/cS/7bydqK5VZ8LEIL+c4l+hr3DJ60YuMLaam /V/AhkRzids60s8viU2rPhM53xSET4EWin307EO2jW/qgVEY3+0kY66fcNm0LA== X-Gm-Gg: ASbGncuRU+R+dUI+6DJ46L41XxlJq8Y2dgQFBOLXAcpPbZqH04X9YtVHrW8hNWeKj3g hiAQ7dv2XVMa4rHhjLCj2TTy0/7M4DzuaRkUjWvwy3T+aV8HoLRX6YxzKiQq5gEZcSx/uRaTx6a e5mytarpCxwuc70VlIqjO04PZYqibn61j1jNJWZlgwQHuUx+aBSJMQPtv51vaxSNg3T7pOd9ZED VBfNeVFfDtzUmphAZd2foZU3eoavBgW9BWUL1kTdFnooMgJ1GnjX1DGav4A2vYn6VZppUCDu2m9 xueqK1974OYLTO5cCUhGldoPWrEmhIaGApxMFnADwT+UAWlfvrB0R+el2ix/YAQWfbQhQbJImbx kCGBKX4Q= X-Google-Smtp-Source: AGHT+IGX5F8BK9hIkJUun+RN+il0mFnmZHmhTvWuj/uMAcNnReRivdqAzP6qycjzG9REqfRUJe9+/Q== X-Received: by 2002:a05:600c:5cb:b0:439:961d:fc7d with SMTP id 5b1f17b1804b1-43d251f35edmr3260325e9.6.1742228677084; Mon, 17 Mar 2025 09:24:37 -0700 (PDT) Received: from google.com (158.100.79.34.bc.googleusercontent.com. [34.79.100.158]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c7df385bsm15243985f8f.4.2025.03.17.09.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 09:24:36 -0700 (PDT) Date: Mon, 17 Mar 2025 16:24:32 +0000 From: Brendan Jackman To: Yosry Ahmed Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Andrew Morton , David Rientjes , Vlastimil Babka , David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Rapoport , Junaid Shahid , Reiji Watanabe , Patrick Bellasi Subject: Re: [PATCH RFC 02/11] x86/mm: Factor out phys_pgd_init() Message-ID: References: <20250313-asi-page-alloc-v1-0-04972e046cea@google.com> <20250313-asi-page-alloc-v1-2-04972e046cea@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: E6F121C000D X-Rspamd-Server: rspam05 X-Stat-Signature: 4oij3xaxwsmxs7hs96aro16ogqiajwwb X-HE-Tag: 1742228678-740881 X-HE-Meta: U2FsdGVkX18IHlS1yuTzUT30pVTvINQH02IxQ6qEWka3zHunjaRTcA7/36C0KOWECCzRp2YsVHw2mnZoeP5amKJPuhwTHS4K627Mspy404krK9IL81RK8E/9b7X2mxBgr03PSDVaWr/uBHR6/UhdFGyqMrbTJUaL4M+aDgHTgFwz/UVsgGb2o+XnqnGsNGm23Y0fXCDYFIo2tMds0UyRO2s5WwPdl5EZOY+UVzS6ijn52tzjl3zjHl/Xq/SjJHzAkxrJ2/XZCy2GXhkQxwtDiSeYgZGWiMjlSHuJY8EM7ls7zDYTRcpR70QJemyxkfqT8ZqO2re7+0O13W9pNprzqaM9xNVB0KlU2ZQG2u7LzpLduf4GKISqGcvgRJoWLBDuGJMa/NZQwopkZSCl4pdDUURtgoXpphFtZ03P1j9ynIHDSXivnMOxDUJqOMfULadpnMGSFAJV7MS3QPcatoiiMhJl/GC2gpfmFsurAw3LodGPCBD5obSO4wKpvrCjWfBmjfYVPrRP1+GVOW0Wx5dFstLp/csogYtEPN44idiUE2DOeHyi/GPf4zcrwe10PYRn16dtXI4MxHzkwIQaI7M7/wrqT+nj9/6XX2A009ZjLFm6OfR5amZBcJOgy/tLjevdDATUHBCy/WMent/H1MpCtMOJ+AOyJWDyM1SkW23XQPohIIZ+8l4As+N4EKG89g4xvfOn2mFsMtesQFBaV4w5vDjfAQyThQQlbag2y3ifE+JjoKe20PChL37+eDgTWMt8lVq0L3FOPgkw4n0INa+46vEpkFUy5+GwpmfpSWMixReZND+iCWe+oaXBjPDYyIXRTF5ifVyPHEkU88yGfNS0B966sHdeqp707gSKnztwx5jsI9BqHzBnGm3PRJVvubf94vT1XhnsWMydgxjqWD8m1b1V7ArF8dg7iUJztaJV9Pl80annPql/EgLpCmHxCQvueca5iwLu+CaCndbofbt CeuZaQrd 4+oicVhhzkQwAsUoM/7NwfSUkjR7ws9Fixf6S6x2SkNuP86B1+h9Fq3T6Dx2/cADqTk0IoWK+wQUkVmL6x4omOpWBLNh+6aNJBn2Pchr2hsAbBO+Lg/mu7T/TThmOGznQzwkIxH4I3LfRP2g5WvIpGGHeZTI3oeI451uBrO8iEa6GFRshTLjxfJvj+k+25guIf16iImswNWBn+Hq3kMu3/zeTgyMkY90x/6Sn1zGa28VskVmG4mB6hIVcgX3BTrJyfYQhtakmqiEly/tIAjqtWwGmFBPu1M1GFJBRU3kjL5raG+oXad3XnqWh5QPWKVmyLufLOTrlCNvCyFdsaa9ZgXrxMaS9GjN2uhMGhVJPRuldHKPlQ2/s/97/4ZQow4rPOUzK9xshS8FjZCtnWxA2pZCvH8miHpuGZzX8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 13, 2025 at 10:14:33PM +0000, Yosry Ahmed wrote: > > @@ -771,15 +770,29 @@ __kernel_physical_mapping_init(unsigned long paddr_start, > > (pud_t *) p4d, init); > > > > spin_unlock(&init_mm.page_table_lock); > > - pgd_changed = true; > > + *pgd_changed = true; > > } > > > > - if (pgd_changed) > > - sync_global_pgds(vaddr_start, vaddr_end - 1); > > - > > return paddr_last; > > } > > > > +static unsigned long __meminit > > +__kernel_physical_mapping_init(unsigned long paddr_start, > > + unsigned long paddr_end, > > + unsigned long page_size_mask, > > + pgprot_t prot, bool init) > > +{ > > + bool pgd_changed; > > + unsigned long paddr_last; > > + > > + paddr_last = phys_pgd_init(init_mm.pgd, paddr_start, paddr_end, page_size_mask, > > + prot, init, &pgd_changed); > > + if (pgd_changed) > > + sync_global_pgds((unsigned long)__va(paddr_start), > > + (unsigned long)__va(paddr_end) - 1); > > This patch keeps the sync_global_pgds() in > __kernel_physical_mapping_init(), then a following patch adds it back in > phys_pgd_init() (but still leaves it here). > > Should we just leave sync_global_pgds() in phys_pgd_init() and eliminate > the pgd_changed argument? Oops, thanks. IIUC we only need the sync_global_pgds() call in __kernel_physical_mapping_init(). We don't want to call it a second time just because we mirrored changes into the ASI PGD.