From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF942C282EC for ; Mon, 17 Mar 2025 03:22:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4235280003; Sun, 16 Mar 2025 23:22:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF106280001; Sun, 16 Mar 2025 23:22:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E0C8280003; Sun, 16 Mar 2025 23:22:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 85D8F280001 for ; Sun, 16 Mar 2025 23:22:38 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7FC321CC31F for ; Mon, 17 Mar 2025 03:22:38 +0000 (UTC) X-FDA: 83229595596.30.F8AD857 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 54416140007 for ; Mon, 17 Mar 2025 03:22:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pVkdirYH; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742181756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vYT3SBm9OApcKhO8tAbEbIrDwgI7CdNQazUfl8IYf1w=; b=o5QeSUOj1zkkWQn6SRADGgSKhGNY1BMEUiQN49zPo4Uwu1OeUh4sDnTAk1OQTS3dNLnwvx SaKLHkOBebEFgqrcIeS4QrLcAhQMAotoCPmik+GYDde3CarqcNhpeT3u8akGLtZKqS/SSM jBEegD/22ZqtTG/VYFKfDVgxEyQECMU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742181756; a=rsa-sha256; cv=none; b=A1/fwpO2D1lFFs/ZAVcDDciXKQ+L4HjAkK2t3fAPQmuDoHM5fhluU+BUjN0mKUX1VhYZC0 MWrXQ+/KDiiWOlWfnyXbsC/gt36cq2RWiRtCxh2SHxGvt6a3xpY5d72jjG0jedCFZ+Ft3K nPkFQ8AMCzuA6inkATq8kp2GmtZGRSQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pVkdirYH; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=vYT3SBm9OApcKhO8tAbEbIrDwgI7CdNQazUfl8IYf1w=; b=pVkdirYHfWLQaKIN7ktDZAhWTK MaLt54W36sDuBHMl6zI3wqQsNmqUlyvQRKHYQA9q03mSYnYh/HtGzAao5TLl56ZtOm8EfbkIbnivl 3foYeY5J+4kbZM7udB5HwMuX2UzwpXIFklEMphnqCrESoPjBoFdTTFYvHCYSUGC5WXu05TNYe1BG2 k2CFyueT54exsXAw7amrdIpcKsgZzEEr5wAHaf2LnIP9GLjF0z25uYmlmVwt4bNaPvPV3Odcd96Qq Hyj/8+Bm0VP+OHxVURQZVf4hPuqB6SMiyZWFyesjVzsWv7MpBAUtqt1GaH9Flq6AK+DbPrR3zAArn cR1mnB7A==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tu13f-00000001Fxa-0NV9; Mon, 17 Mar 2025 03:22:31 +0000 Date: Mon, 17 Mar 2025 03:22:30 +0000 From: Matthew Wilcox To: Fan Ni , Thomas =?iso-8859-1?Q?Hellstr=F6m?= Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 11/11] fs: Remove aops->writepage Message-ID: References: <20250307135414.2987755-1-willy@infradead.org> <20250307135414.2987755-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 54416140007 X-Stat-Signature: nt55dguyoibh7m34f6gggrin9t3rk6h8 X-HE-Tag: 1742181756-389620 X-HE-Meta: U2FsdGVkX1+yfjXwuU1twJOH85kpFzWTSUKbAfKwQ/OzNivRaW6KX26I09vtcwzY5ObsWS/CqEhbZhJppTm8Wd8C5vyKk8dRHHpbjEnTl7gXvI8tEGCE2dCeogfs+sQp06QW5QFNPnDukWgmewo1L4dQ+FHKL2VrgKVQ8ZhBZaqzrlV7Z53euW/b/SSDMczSE9ZICtZe394dQ3pHb6z6bTDJm0Ryk/SRn/Yj5iZ+7q1DyKdJFS1c0RDvp+QWjuw5LjSO7Yqw+LMAt7aXJqLALHRmBQ3w0R3igc5aEO/AtJk8rd0ERoh1zUX4KTvHyOUEkC4h5I1jw2Zq57paHTlw1zG++6oDQDYkSGMD+EPxvgIj4GlDCupOh+S86Lm5DGD7+pKEtjPRj+nk4F1k8SMsZRtDibSuvppq6qhhwfqyLkKW4+j0oUYRYkeQyw3N2hNHMJCJd0t1dGw+UqqKBENz9wKR/7g0mFbkK5YnTsI823V4sCBy9YYrELX49B+dEvv/eZv1g/YkKnDTQ6HzPvsXk2kA7RnGMNRQ0Y2kKBJHEpaz0o0VU0MpXyjG9tmqqn/xS3XTOpoDYxp/FhyFSBgh40gVtHutPJov//Pu2En/8TCH+RjbUR009SXHHDDGMs+BTF/MQ1TIQ75AAxFlL35SkDgnH45GlabUtbuWIAK1FsyzPxTsnNHV8vzBIAIuO+9Mc+RKsx92S1OftJ2w92Q1RTxSqSgpDN+syc30OQiEge1j87qGwy1hoFZPc55oVME+L+ULaGXOAS1vFXR7HkiAX1hgJNutIPPGJtHoNQK5huk2n03DO8QQir9MGEwLB00wiWcOdqfEsqG/XWZAISwvyucJj7gF18nluV5VZJlcDqtyKFqLDJ6w5h8V1YG0L7QCUykZLSTYr8g3qpV2XDedyD9oirvMTicLdzUvGOp1cM1Qw8K6V0ozvTz7qj6bjC8pJmOCOT9M7Vz6IlHc3CR Lch3bNMs AwMeHFXc+6SdKHuRCyARhU5IGxgQCBJ7/I1a0i8sm6GiVkkpNIvZGznr5CxSm5Kj4xdSU4RRZdS5VCoIlJVSyuCCfV+sXiT9LABkcGjxvmBEOVAOJTIkpT4WgGNpkvrP/3TtP9wv67RhfSnP1Uf8qIu188UBaSGq6w0qDKgl8iItUH8FGrZuwg6gzDX+DYyDzV4+1E4OWCaauRiem4SiSBUZfKVQKbrPMtDBPg8La8AVEVsgcXQvI6Uodb6AM2ETLRJKzOl1svQbIP0+Fmu8Pk65sSrtwE3a5EcM3ILHoX2AqnALRvv9ikevbkB8ScOWEZGzuN6uYQg7BMdNcLt5hujg3cv3goxjcIDl71ClUjzc4NLrRK2pUdS+U8Tor7grbuwfw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Mar 16, 2025 at 06:08:52PM -0700, Fan Ni wrote: > On Fri, Mar 07, 2025 at 01:54:11PM +0000, Matthew Wilcox (Oracle) wrote: > > All callers and implementations are now removed, so remove the operation > > and update the documentation to match. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > Hi Matthew, > > Tried to apply the remaining patches in the patchest (Patch 5-11) which > have not picked up by linux-next. It seems we have more to cleanup. > > For example, I hit the following issue when try to compile > ---------------------------------------------------------------- > drivers/gpu/drm/ttm/ttm_backup.c: In function ‘ttm_backup_backup_page’: > drivers/gpu/drm/ttm/ttm_backup.c:139:39: error: ‘const struct address_space_operations’ has no member named ‘writepage’; did you mean ‘writepages’? > 139 | ret = mapping->a_ops->writepage(folio_file_page(to_folio, idx), &wbc); Looks like that was added to linux-next after I completed the removal of ->writepage. Thomas, what's going on here?