From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A452C282EC for ; Fri, 14 Mar 2025 15:56:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6100C280003; Fri, 14 Mar 2025 11:56:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 597D6280001; Fri, 14 Mar 2025 11:56:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EBD9280003; Fri, 14 Mar 2025 11:56:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 192F6280001 for ; Fri, 14 Mar 2025 11:56:09 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1E68B8BD9 for ; Fri, 14 Mar 2025 15:56:08 +0000 (UTC) X-FDA: 83220608058.20.33252E4 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf06.hostedemail.com (Postfix) with ESMTP id A235A180019 for ; Fri, 14 Mar 2025 15:56:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rRjApRQ8; spf=pass (imf06.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741967766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FKoGoA18ujKk5HU/x65AGFBw6cvIwE6a5BEmMBdMtSA=; b=fKrRdIOW655Bx/F33Y5hccXqJyMJt5OKSUY3DRSL1xo9cPrHvu0Bp7aZbLP+ux5+fVzXNp eRXVFCN4km95+qRrm6P8KRpqTEfoIwCO3RjWSbBXOWTb3QvBQcORaRGf8UAovv1+Id0weI OLCXJVKFklFTJgrL7O0bzHUMZkedfsM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741967766; a=rsa-sha256; cv=none; b=0cbPgo2rIDh82LOQcUiXQ8J0VRyVSRylp2YvPjra7ALy4YpspmoOHrwOS8FC14wxNw4tRT Bt90u2fRUeqpG5vThs7rVAephv60xIqjeFtlgzAPbnC2+VV8kgnGylD8T490GoqqOw+e/c CVSHrQiJZe4eigRcK5MpQwal8rr48N4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rRjApRQ8; spf=pass (imf06.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43cfe808908so50885e9.0 for ; Fri, 14 Mar 2025 08:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741967765; x=1742572565; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FKoGoA18ujKk5HU/x65AGFBw6cvIwE6a5BEmMBdMtSA=; b=rRjApRQ8jny8fa3+whZNaqVzoN3ZG0LhZnNJUZIUasdOeuNoAVxLqQHh170da02EJC kSMVOmY8UzyEzvrL3tlMtE81N148KLAxR7LKj2++tQ1jNgmFPFaNLXlmwe0l9C98d5dq 8tix+TkKv0lXT/UTZqNmtPaX3+UVqCC7qK2NcLnAcPLidBQ8K55l/hZCDcg1tQdR8x0g 0G1cDWBaxDZPCmCoePjYmrln4bMA5J7xheazPGguab5LYoxT7ezahIhk8zii46Is2nqZ QaIQBsjHXu6heHo/6p0FAxzJbDGlOuc+zS7I1BJlpO7o0ymfMHIw3LlLRTnmIKxKVlCK ZMGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741967765; x=1742572565; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FKoGoA18ujKk5HU/x65AGFBw6cvIwE6a5BEmMBdMtSA=; b=OXOPNh+vz3+0NESe34UZECTvf9G3phLIPHtMq4ydgierqOD4sQ8Pvftk6BACN8CpG5 NiQN49g9V/wHJbIBDfDW3dSgduZiCpy2x3qdUP/gXCUP/hJlhEH1E/prWWENhmkI9P7d RKunoBT62sMFxhdXFgxNN2lJVuJtsFT56a3lv7Xt0YxVVB32ebanrAZeF0ZYaDB+v6uu 0DI9YzsdIv2PshChRcq8KJ00A/UgYardBxwgg3y1NEAe6P0ou9kXAd0ELN/hceFPUHtZ Zjh/Z0eDNqBBGW0TZB3dFry31sNmxyNNovet1e2SnWwbY/BnB4kp7w0UaOCzYnhAdCJI X4eA== X-Forwarded-Encrypted: i=1; AJvYcCUGuUTWD+NxUovJzfwzyclSICgqftifWYD2hjqvHPmKYgYK32EEN9reFhEfN2Ee8u73O7M3iuyAxw==@kvack.org X-Gm-Message-State: AOJu0Yz2hBe/+dcMIxZNrNeE1Iu97vz6qB5AAnEWtZ+Vdsp8RGIG+I2U RoFXS4A04ehmHspbxcc2TmsmOnvXOxGSbNBk+XwXckr2xo7Gr0qZvwUmxNrLOw== X-Gm-Gg: ASbGncv1ufl4+38iiLKdSTGXb+OxrS6KBUWD9rnYuO75TKlf698TE3doHTxCIGrI7Cy XuDQPxoZgezKz9yAwmEMZzwUC3FFKksCsUXkIKfFxHtwynjSPt8o51G6HZRZ76Z+iftTS9rnDL5 EBbmc+qZQhjyrTSIoZ2gLXyyJIMrnKs07/Mz0ZeF25vP1lE6vibtojPn5uzIy8dMO4C2R8wKz51 Lagnd1ZJnoDVglHe7D3MpJaC6VGP8MXsW3Q7EN9ujO4xaK1pJz33D6SOsi7iWq+YaiJLgOQr0DW B2XK41f0PxD8Ay3n3crZma6tWgrjDCQMc+dfXxDQzInv67kECDfaoIgYG9J4Pj8LT1MEEhfP7Hb SSZeSde8= X-Google-Smtp-Source: AGHT+IEwYCKoSx0cSs3htw+SGMCjLhU2RU9hodxnkl419jpY8lUbMFXoXkJQoMHy2icUExOKjxJZxA== X-Received: by 2002:a05:600c:4748:b0:43b:df25:8c4 with SMTP id 5b1f17b1804b1-43d1ded2193mr1458335e9.4.1741967764799; Fri, 14 Mar 2025 08:56:04 -0700 (PDT) Received: from google.com (158.100.79.34.bc.googleusercontent.com. [34.79.100.158]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395cb318acfsm6097615f8f.70.2025.03.14.08.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 08:56:04 -0700 (PDT) Date: Fri, 14 Mar 2025 15:56:00 +0000 From: Brendan Jackman To: David Hildenbrand Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 08/10] selftests/mm: Skip gup_longerm tests on weird filesystems Message-ID: References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-8-958e3b6f0203@google.com> <08023d47-dcf4-4efb-bf13-5aef3c6dca14@redhat.com> <16023193-6cb4-46d1-91c4-43342e7e6d30@redhat.com> <41923b80-55f4-44b6-bc59-60327e5308f4@redhat.com> <15cc0c1d-2b02-41de-bf48-3c57cee97c53@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15cc0c1d-2b02-41de-bf48-3c57cee97c53@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A235A180019 X-Stat-Signature: t7q9577yeqbbejpgz4rzizetfa9xkp1f X-HE-Tag: 1741967766-899288 X-HE-Meta: U2FsdGVkX1/9WSuWQZYh+msF0dyQZThLrGNIgDKkOsl/RPFiGbQbU5chjWWBRER1xhqv1g1495+DA5GlJTv8jQJUpH4mCmZ/3sqRW6ihZ95Gfjlr8oH1MOSyVmexncDpgHg3rN75xYIepoFBq3k7roosmY9PwVcPnIr1xJAdeP45Xde1MhU3vNOjUufcJEqVOae10PNIGTcsvQ8Xg2wMHrKG5KMhDLvmmtcAynVJLdg9UksibvpVAShh2Q1QgKoa4CfSzLuJjE8yuUN5B2RLfdpGdars5t5DDbf1O6QOWDB9Ckvk9a5nTn74/MASH6YXKPojTw7IYykt1zXkrI1Ohvx08FxvHvWUvP4fnnCqMEQjX34IdD3ndntjI6LMnQbOXyjO2S3/5u0cC9ZWaJtZ1Lv1vMrZk/7N67QcmecuYCcVIU3Ac4fNkHlWqksZTokIqX4UILRYFtr+qMseqizLY7QgKKjC4R5XHUH/wf3bTotHkaNgm29Sf0SKvF9rLPlmuxXxjCAbvTLNGPvXs2i1bGy6oy43kIDOoj9pv8sXNk5CA9p94Tb/9H4h+f/14cRpMEPmaGBlucf7quwZkTd4yGFZiIA/sUwiiCoONoJCsmd2Vjgklo8t/xSTH7PpzMUoVb7NVAser9y2vbM/ZPZx/4UbEGbj9wSag+WyRSmnJwNLcERFDgxy4NxktdZKDrgY9I+PEqaM1PG/ZP3jANiV2qEQ8oSBQ+Q1Y9BygMxHAQATxxfEVgovgrzopCaWlQfmgGg6WqMRzBicQErY1shJX8LNfk9T5bMXTRhpff7yEfodr2RzlCYHBP/MYVoj3Rusx39WoCa8URR6TagvTt99ZILwVpYzV19HEiEXj8hNs/24wQcbDZo1RPhr1mO0rLd5hOlVBrk88etEw6erlLpNeKffSx+Xehhssq6YBXqURXO0nxh+HlHUsoNIbax+DpZPsjQng6/Mw7Qam4r2tuO xAK87bqI RptCTfWa12dkb5mazYxVf1QbJYEi4Yf59seTmharW1CzfuAQ99892LGzn1vbox0u062SVOBOvIHnKGAQSVFEiW1epT7mUo+eG6wm9li5CPpFlF1FgzIBDmy9S3dsAgt4lVeEE+uOtlvlbZTwOg7Pa5rtNi62LkKUjCXPJhe/m8o2CNNfPxXP4jNqRdSN2shqleyjZBMxggL5zzgccr+qHEjsdClc+5K7weKXfVhXD0YEGNBxekoDjCCBoH2Y1tTv4tJZuvQRClTkEO2wDmJ+nhqOlGBUGIgBj02Y55swuXQO3TdlKi8Rt+80Gm/sXEwkWr7rsBNPtSMpMd58zmQ2NkHV47FBjcYe+hiFHnICF0jKOr0rPpmzSo1fpAd935bPSL9VI19x8bVuMKNw4j+3BWvDj69M+sMj8+rNy X-Bogosity: Unsure, tests=bogofilter, spamicity=0.471118, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > Even if it's a bug in QEMU, I think it is worth working around this > > one way or another. QEMU by far the most practical way to run these > > tests, and virtme-ng is probably the most popular/practical way to do > > that. > > I'm afraid yes. Although allocating temp files form 9pfs is rather ... > weird. :) One would assume that /tmp is usually backed by tmpfs. But well, a > disto can do what it wants. Ah yeah but these tests also use mkstemp() in the CWD i.e. the location of run_vmtests.sh, it isn't /tmp that is causing this at the moment. (At some point I thought I was hitting the issue there too, but I think I was mistaken, like just not reading the test logs properly or something). > > I think even if we are confident it's just a bunch of broken > > code that isn't even in Linux, it's pragmatic to spend a certain > > amount of energy on having green tests there. > > > > Yeah, we're trying ... > > > (Also, this f_type thing might be totally intentional specified > > filesystem behaviour, I don't know). > > I assume it's broken in various ways to mimic that you are a file system > which you are not. > > Your approach is likely the easiest approach to deal with this 9pfs crap. > > Can you document in the code+description better what we learned, and why we > cannot even trust f_type with crappy 9pfs? Sure, I will be more verbose about it. I've already sent v4 here: https://lore.kernel.org/all/20250311-mm-selftests-v4-7-dec210a658f5@google.com/ So I will wait and see if there are any comments on the v4, if there are I'll spin the extra commentary into v5 otherwise send it as a followup, does that sound OK?