From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61466C282EC for ; Fri, 14 Mar 2025 08:34:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A9BA280010; Fri, 14 Mar 2025 04:34:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3593A280001; Fri, 14 Mar 2025 04:34:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AD07280010; Fri, 14 Mar 2025 04:34:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EC2AC280001 for ; Fri, 14 Mar 2025 04:34:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 640711C998A for ; Fri, 14 Mar 2025 08:34:47 +0000 (UTC) X-FDA: 83219495814.16.7CF4A6B Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf26.hostedemail.com (Postfix) with ESMTP id 1F114140004 for ; Fri, 14 Mar 2025 08:34:43 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=nrvoYhcw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=nY3JA7w2; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf26.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741941284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G2mg48SOIN4E+EIq2gKL7N5s/EqxEVVV5l+23PT5phE=; b=j5IFWhgV45fnGzlGJ5FYwAmleFWpgiEbfFN+ZRXs9r/rpBsM8jlSPnqezrcxLC3zdZhvFJ FDr+xPGr0Oo8RN4gEwWhJCJK790DOwWYfY57t1w6PKtneKFSIfmvErRoWiB6aUcKnz5ooL pLz5OPUjBvRaEmCBwIz5xINVKdHEgFo= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741941284; a=rsa-sha256; cv=pass; b=phHKXQzpGFnBJNr+aGQF9+jGkgXXOWIvlOQIdP0QRj/opE+33+iGgbOUhZk79RgGxZmdHo o9lIV5jxxDee2S06YnRJkBK/xzHhe0Y/EYL4eh9s2zo3NOeXS3PuXM5jr/DAoQxe8fcwSE rnr+5Ikea18vYl3HawEfvsBXzmG/aXA= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=nrvoYhcw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=nY3JA7w2; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf26.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52E7tkC1029366; Fri, 14 Mar 2025 08:34:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=G2mg48SOIN4E+EIq2gKL7N5s/EqxEVVV5l+23PT5phE=; b= nrvoYhcwDPNrMeSG8X+MuGTXRGobfWmiHDHjOGIyp8aBf28QxiyuSWb88xrqrH9l CpXyyvakw8LDwFYHQYAu8dt8Le0K2b4PJNmzkU0tqMZ+9FyHiKEo59BfsEfbfYNA lg7vyRKyzvVWMCikueMSnYERjgavzoR0vB6GhKP+40nWUCvtJ3cKLTtyyoGkDOT2 VlnucFljaCz5MMAzw3vXZnHpSawAbCbUm+9hJoKc/RYZdRjCViMESaM4Iq4QlRWW dGMus2JG0o5Jzdmf9RAoDy6tS7rqL0WvEi4JHSoOboF0ESNSICksBRWTwOeRGfWa i+PxP7xbYMqBmq2xnTQGtQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 45au4he1m7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Mar 2025 08:34:40 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 52E7cR6P002187; Fri, 14 Mar 2025 08:34:39 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2049.outbound.protection.outlook.com [104.47.66.49]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 45atn9u4pg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Mar 2025 08:34:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YDRiy8Wkvk1suRmsa1w+S+ja+J0pQmI+Opv4Jk6Z5gjbCMhpDWYnJIxAI0KuIzTb6rptJd+8u9/Tu8LrmpAXWshXyKh2b+NFkHYQ3ZJTaiDXEd9vTCn3WSlvU+67iHHiK6xcKIu5Liij/WTuo+dwTgZWfWcoK8KZpcHeqTl5Vdezx/nnvuLRh2OzlHuidcBdAM4pknFPqlBxZa82wflCVc4AVIwDtIPl6vXD4Z+bWef9npn67v5k26bf33llWld7ynzt+oGsYR+Ecq2DWIQKbLUSmlskJDyRlTKnTmUdpO9mezzFXGyH9X0Kr4PcfVG78uzeouLHEPcmnu3Y1orobg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G2mg48SOIN4E+EIq2gKL7N5s/EqxEVVV5l+23PT5phE=; b=a8vliOm0ctgjkVDJieDN/xMHwe9wLHgtPPEPExKtwG+25jE7/REXTqonw1fzP2wIydhqrC5ZwgMOfYwLXpbChPCnEVMWvY4F+hve5BlgEF6gWuNRuNkpr4660EWH/b0r/amb3yPhsLowlsx2PJf7PR+USVs0my6N2HrV3+YlhqNjN7AeQFjI/uO3T4AidEzZ8rq/1oadeXzpzR03xe8D3ffEOY+MM5VsO3ZxE3GvMVwJbLR4RHHfCeo574gISkdunOstFJZUXMAMVTXjta4WvbAnqUX80rJ2d8d8pbA7v02URlOM2LjudsypRDBl9sECSCgEbIpYDvpgY/3FIsyAlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G2mg48SOIN4E+EIq2gKL7N5s/EqxEVVV5l+23PT5phE=; b=nY3JA7w2h+6CiNh24iOeA6lhSY1JYzPB+R3cX4uKtl3agbHPbVpqlJ3nSzrQL+t/4uTM5JlFqVR1m+MGNpgBJDKCSDIEFRN2MDtUiELZ2aGmMYJ/auW0koWWixY+7rW/FKxn74vABd27NqNHV8gh8e8aLXOa0LRixe6uoOSpfCs= Received: from CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) by PH7PR10MB6484.namprd10.prod.outlook.com (2603:10b6:510:1ef::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.27; Fri, 14 Mar 2025 08:34:37 +0000 Received: from CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23]) by CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23%6]) with mapi id 15.20.8511.026; Fri, 14 Mar 2025 08:34:37 +0000 Date: Fri, 14 Mar 2025 17:34:31 +0900 From: Harry Yoo To: Mateusz Guzik Cc: Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm , Dennis Zhou Subject: Re: a case for a destructor for slub: mm_struct Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: SE2P216CA0178.KORP216.PROD.OUTLOOK.COM (2603:1096:101:2ca::10) To CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR10MB7329:EE_|PH7PR10MB6484:EE_ X-MS-Office365-Filtering-Correlation-Id: bf2e201f-f48d-4b7e-302d-08dd62d30dd0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N1VVekI5dDZKcWJIcGtqei91bFB0ZDU2RHM4VHBzcnQ4UlFxdXZkSWVIUjY4?= =?utf-8?B?bjhtY3JuNk5IdTJSWktGQ09CbkF5ZExxMGhGaVlvb2xhejB0N3ZLVi9IWnZa?= =?utf-8?B?S1MvN0VmVFZZMXErRDNaYng1N045WU95UUtSTzdBNWJPeGNvK0pET0FkNEJS?= =?utf-8?B?VHlXeE9UcmZlTWxpTlFFVFBnNVBKdGFZblczMXJSbkNYRGk1NUxOSUZwK2pw?= =?utf-8?B?ZlY0L3M1NlpJQkR4QzgrbnNCci9yRHJoNkRaTHROb0grTlVNRXBFOEZ6dFJo?= =?utf-8?B?VitTVTFiMjdJQzNZOGdYOUpTUDNGSGhESm1vdUNVUHJTYVQ3eXNDcVFVN1pu?= =?utf-8?B?R2RJUUtrYlFTZUpqdlhKS1M5QWRPWjJ4djFNSzNITlhTVGRLcFNxTzdqbjg2?= =?utf-8?B?YjY1SmFlVnFIWU13R3RIZzFrOWNwYVRNRElHWUZvMGhuVU5BbkgvdWdBQ0pT?= =?utf-8?B?U2JiUFA4Smg3UUpGZEhQQ2FKSFBtelV6ZDR4K1FKT0lqYWsrRVcvK3N0ZitD?= =?utf-8?B?U2VYZnBrODNSdUlLczVETzlsRVJsdkNKOEp3UURZUVhwb0I3WmdRL0Jick54?= =?utf-8?B?YXBQb2FIelErNFNnOWJuTTFYS2U5Z2pyTHdIQlpWbFhpTnlaYnVicVUyMFU5?= =?utf-8?B?WCsraFhod2grY2RNYjFDYVoyQ3ZPRUJNb21lRUw1THQ2d1gwaURheEJjbHB2?= =?utf-8?B?YXVOV2VCTk5xdTA3TjlVcjU2NU1BVnhTNk4wQUVJaXUvMEo0eDc5N2VOSDk4?= =?utf-8?B?ZG9sYXlDMENlMEJ5amFBazhCTUFFVGdMZFRNVGJQeXg5SXVxSit6dGNaUjkz?= =?utf-8?B?MEl2RllTdlUxQnhSYW9GTjAwVE1tcVVwY2RNbUg4QnBtaW5zYUpPWkZ4WnVs?= =?utf-8?B?WkkvMWtmNThndEhkSi9NSjRCNnZxN0pEcExseE9yM0w3TGlGY2RVT0t2RUth?= =?utf-8?B?ZjBOQmdSUFUxTzFSR0I4eU9OY1ZVQlN6QUlKOWlqM3o4MUVJazExNUV6WVlL?= =?utf-8?B?NWk3dlJteGdoR2FEVHlVUWdwUVR6dnNMbk02TjMraGtYU2pSaGIrdzRWVXk1?= =?utf-8?B?WlVBWVc4aDRmUCszL2hNdDF3RUJWOFVmTHN6cWJUMDhOUkFETml3R09KT0dF?= =?utf-8?B?NWdGdGtrRU5VVVZscldlTSt0MmMwS1ErSXFYWmJxNlRGeitvbm1Jb0Z6aVFw?= =?utf-8?B?UjVwdHBDWVM2UHR3dDB4REMyV21XQXZlMkUvQ2pSNSsxRlc0MUhTdkNndHd3?= =?utf-8?B?K3F0SmpBNTlvOW1FNmQrSVZXVGlaN2JPQ1ZGR0FvVkk0Q1BFNXZlRlpiWmNk?= =?utf-8?B?aXUwOGVGYXJGdEIzU1M4OWFncGJhanZBMDk2WUdIRGpqT1Z1eEF6QzNCQ0NW?= =?utf-8?B?QkRyUkFld1J3S3JLV0FRNDh1aWZaamYxYTFXdjR6N0k0T28rMEVsTkxCSGV0?= =?utf-8?B?bVFrdkttTERUbnRyVkI2MFkzWkMxTGV3eEhSQWVnS2hjT040Q0dyT1crdjhB?= =?utf-8?B?ZlhGRGlaWGc1c1dtQ056K21jQ1pDU2laRU00K0NnZ3RZd0FwTDl4TExOblEz?= =?utf-8?B?SGZRRFU1aE55UlBaWVlFRnF6STJTL05jZVArbzhoTEp0NUpmSzNadjRBb1VS?= =?utf-8?B?SDErYXpDajJRS0R0aW9iUlAxS0tybzJVT1FXQnNFVVZRbnFZSU1iQ2xJZ2FX?= =?utf-8?B?Z0p5WW45MEJpL2RacmNsY0dKTVpTNE50K29kUUQ0ZGg1ZDJ6MHJRd3JNTDlZ?= =?utf-8?B?YVk5UGJlZkZJUEZUK2hHWnFwSWd0SlY5RTZKcjM2MjRUZW1mZVdOeldTQ1BS?= =?utf-8?B?S1ZtckJKUU9BNDFjZUNxczN1TzNNVDhFNlJHUHZMSnpuNjZYcTRPVGNMTnF4?= =?utf-8?Q?VxmFz0VazT8UL?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR10MB7329.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QU0zSXdwRkQvUEpkQTVVb3VDcXB2WjBlSGdVNDIrQWtoMmlDZkVLRTRKNGlk?= =?utf-8?B?NkNkOTdOR0VhU082RElFanVyOGdTOTJjZG9BbTROUDRidjFtZU9FeFlxdE12?= =?utf-8?B?ak5XU1lhOUxPcVVyN1VtUmpmQWp6Kys4U3RPeS9Yc3VISnd4R2tYMGNzbFRv?= =?utf-8?B?V0RERFhtNDVvdm92UWpIWUNpQkZjT1lXWnZZbm55T1ZIUHljY0JqZk91TEFt?= =?utf-8?B?T1F0ZzJtTk51MDZVQmFjVC9ocHFtMEZaeXc4c0o1Zy9NeHE2TjB3d0hlKytN?= =?utf-8?B?RWUyQml3RjRiajJNSWtCb091eEUvM09VWXBKWHFmUGN6cW1HU1B5cThEd0dn?= =?utf-8?B?NTBmNTRCL2NEaXVaN2E4MDJpZGhoSVpRRkNiMmxnWVYzMjlRMElGN3JFRGky?= =?utf-8?B?Q2IrdmtUSkRhOEdnK0Y1cUkxMlg0ZnlYK1JqWlkwaFd3ZDlzN3p0bkRUSmtk?= =?utf-8?B?dHNqbEthOVJTZTA4VVU4bnRjeUhaazhQc200RXcxUmRUaUtMalA4YVNlanN0?= =?utf-8?B?ZHhJUjVGWXJHdFphclppd3RhZ1NGZXpKclVsK2pHbGRxMW1wR1lQbVFwYWFy?= =?utf-8?B?MklWdzNOdStEMDJHalp2cHV4L2Z2QlRHYnNWa1FNaW9nNXRHMW5NekE0bi9N?= =?utf-8?B?K2I5WDQyMXZ1Z0tlWmZMalRoUzQxRTllZzF5SS9CWTUvS3N3ZU5VaHNEcE5j?= =?utf-8?B?Q2dielhPQUhJY3ljRWptdkE0alpPZ09XWTBTYU1saTBvcmNnQnNRN216NzUv?= =?utf-8?B?anhwNld0bGN6RENobkxUd1JENFJmWTJ4QVJCNmJQZmNpUjBXbVZKc21tMEVV?= =?utf-8?B?bjV3dnpLbndWK0VQajBKREZVY1lwV2ZjVy9hKzIxUXBTdEdCS2dzdmF0M0FR?= =?utf-8?B?MmNuazVqR1haUlFaMzBaaFhkUXRFdmd1V3NnZ05jVy81ZEYxUXpRUFRveFdB?= =?utf-8?B?VGc5M3B6Z2p6VnlITDFldVhtMnh4Sko1YnRvd29OMXRraUhCSUpURGtmbFE4?= =?utf-8?B?cStaaVZBQjNER3RVRktsRHJTTDhLVE9HdExrYU03OWd1WmJLdTExWkVXRmhS?= =?utf-8?B?ZFdPc0k3TzFzY2dZYUhNdEFKOXpQMUJjaWIxR1FOOUJrVjhJMjdJUUkydTBl?= =?utf-8?B?b1g3dU1JZHZMUWdLY0pvTzlqS25hOWZmNS93WnhJcFVUMGpxbmtobnUyemFI?= =?utf-8?B?RzdncDk2MXFEV3JJaE5TODUwUDNyVzE5NWNtWVRJd3RmaTFqNExDVFR1TXph?= =?utf-8?B?N1l5OVZlUUUrZEo4Zmo0Y0RGMHBoOUVRSUN4MDJrWk5ZcDcvcTJ5N2RFaUMw?= =?utf-8?B?WllkQ2UvSy9xemRSOGJwR04vSHIwMytTdXk0UUhTbUIxbllQZ3BvVUcwYnNq?= =?utf-8?B?KzNCU2FpS1pjazF6TVNsZkJ5Wi9ZdXdEYUFxQWZiWEtFQ1BVaGEvOFhVS015?= =?utf-8?B?N1FMc0Fxazl0MFRvZkpwa0RzdSs2a2tzSmZZNEszQnV4cXI2cFVWZ3VoU1po?= =?utf-8?B?RUhQdU9ZeTEzcjRIdjhENU9LOXk2NzhDNUlUZkZ5d3VCLy80U2MxUTNuV0da?= =?utf-8?B?KzVpNnpkR09HcUxNMmpPTkVDczVjU1F6YzRnQjJTNElpZUxCb3p4VENqWkdH?= =?utf-8?B?dG1pL2FOVGMzSlBXQXVPM04vOWFSS0NGZDhrUjFKbUE4eis0OW9vRkRSWEpy?= =?utf-8?B?SFV4Q2J5eCs0Mkk0MCs3by9WUEw2VFE1L0xTV1d5SXl4eDF1L2lrNjdzM0k1?= =?utf-8?B?TUt0N1cvSVR2eWhxQnR6elYzL1ZGTE1PZ0dmaUxjajI3NW9ZcjIxZkJncjdn?= =?utf-8?B?TEo3YnZFWDkrVDFOY2tVRXR6bmF0SmFzc0NNWkJUa3ZLN0k2QmYwVlU1L0dR?= =?utf-8?B?OFZzTldoMzBGUDBoSCtnc0FEOW5lMW1PemFkQ3gySDVXSEVRYU94ZmVIVEhC?= =?utf-8?B?MWwvSVU1cEtwY1BEZTVRNGp4OHk4SHFsZU80Ui9Xc3BIVHJEQWtBM1BhTU15?= =?utf-8?B?OVNrcGxDSXVMN1N0dXRZRlJKRW5obXRMMGNQQzJWZUt6U3I2SVg4VjRDTi9R?= =?utf-8?B?SkJhSlZBUWg4dzhodlRRb1l0c25NYUdxWEhTUDBnYU9DamczNElHQnNmdSt3?= =?utf-8?Q?iYE0OudLT3O0O7O8Ydf8CG1cL?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: h1VejqHwolioC0PDJ+TxuucrBcU/FbjDmosrdGooGXvrh0l1jhe9Qr/HHaQ6z/Ge7wyfN/mX+hxksECViXAnNSrxksd4XyREGrYxnjsAyQd7yBSKbZKUg/jerm1HHRiZDpBavYFTlZVQUZyYXRcsfeeJuXPt7gdWr5uYJi+XXy+PoTSjQ/LPQ8hlXR7cPjaceAHScRAzwzhh0AbYftlJEufCfH25Xl2+lh6aksGkgWhjTfauhbftLKbmh1DMxk3CLU1HRcVeUjVMLo8vTS57n4s1ASXtZZ0QkOJr36Qnp6pyxV4mi2UzNQHs3kUk6JrlF2nBm2OrUXH/3ubjUxRZYy/39+FrgXvuox82CzuzpLlSrvKhO4jG0Ys4PEanT5lIY3CJBmKKRY/e4137pMEeYLLBKhP/p4OppY7xIJYn5fLCXnUDpCd/ji46oFlK16SroXlfeQG1BAwT1VSYm0zrBJaDZ+8ZdViD1kmSVnzFWIWKXo+JQ4dCyj1FBH9estADui+m7nQZW/qA1US/cVLlcAnMy8W1VvnpTqufIN2oGwEQ+kAezM9UCN6iSnZLr/ypfSTV68ZaIvmLvIHpq9neJOxb16m0JXppmAu7ROjYBAs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf2e201f-f48d-4b7e-302d-08dd62d30dd0 X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7329.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2025 08:34:36.8875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qxABHwBN5lxXcpFDfM/Y86SYkxpIeHJ+StOdH/Edwz71arRttZguYLW8K3rvEjuSYmQwsd1MCCCXEP9DRZj3qQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6484 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-14_03,2025-03-13_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 suspectscore=0 adultscore=0 spamscore=0 mlxscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502280000 definitions=main-2503140067 X-Proofpoint-GUID: 0PFSdEM22XGZboM2Jmy9XEkJERhGYvcP X-Proofpoint-ORIG-GUID: 0PFSdEM22XGZboM2Jmy9XEkJERhGYvcP X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1F114140004 X-Stat-Signature: pxmzmosctonsj9ytueb4f1nzhsp793gs X-HE-Tag: 1741941283-101637 X-HE-Meta: U2FsdGVkX1/ZB5JO7OL7auLLHr+T1yPJto0vIKaB97AYsX19v54fc5uqjkeZTOdvLHQvRqGNWjcnON+nZnqW1aPTPh7JW4WpFvmV/lO/awBnawZjj1utk/1m+QFVaeVB4UjOgef836MvQKE04DBnow0WfrwxF8bL6Mob1Bl9SXS2/SnA9V8eMAq/zcoG6jczzeHhyb9JyQutnlB+ke2CQpT2E2l4gz64ZgLC+/zew15YTzwWyr8ZnNuQVddZeh5wsgRdcWzhFKtP8kfb8qRbw060Pmr6oDCdAWZ1PveXNiXq0V9GZeas47NWAfVXtMFA/bMOLNH32T5OCMnd7DdG+3Lh7UkoVcchfkblb5+cmykGvjr1ezj1x1Ue5w/Olih+OBAoNSD0Qrxnex7+Mz0KOaX2ze2592RcV+U3IfF384UXLGNItqIgjhN6CKJY0l15LCQc92PNKdyc0jNpKFUA+sgIgcnoZGOfTOHfKkTJlcd32HFWoNhSHTS+iFaRUtlDbZp2aHDsh+M70frekuJGUAEPjTI9l+agbQiLVvMVHb5NIup3XVPl3mjCiXEYx7+BizaHVJ6HSKPUHac0B4b6Z30ly+ITm79WPPMSkgwFBrTUAdWxBUq8f5SGIm0QcTZFp1vhpt0UCQJKs6fZ94F+oJHfTyu6ASgk/oTgA6M4oebne5AGUCRnhl+Yipc1q1CC5WkdC9fhtGfBRjSevC8SJ448OKQwO6TQP5WbONgT1fg6t0x7fvxvFeWjGv+fQfZDQ2gLqSwk/H0lE2A0FxBiK/xcgO+mZo2EjS3ggaKqXKbn8R1uhkoM8R8t07lVS7R2klKsNqHor4khlblktDsRSLf5UibBr9AwBpcgcKlriKeOGuvz1nwT3pw4hl2h+mtaEMtWZxfh6CBKFXCBIrHDvj8bmGKeEoE1DgMBEeg54SPyK1JLglZ69YcVmYEsJoI02ujLYLIay2CA9JgGnDh tBZ8il6i 0yZrMx2JAD6MN4H6Q8WqZkFjJceG94B/r3zYwQ2P0ecKISeTs/I8G6o/KKPok8ImcaWnsB1153qCd9JNIyFFQrcHSyTWoLgkPillOCf+9EtIHmcNoZSQpxv6/YiQgKoMuqlVNQDVAyvAGOv8SWNVoQnDA60yrcdRGCKMsv+ojPcNiIuyZC3DKZG8JQbgLdQHas97aEoVn42raJ7RZU6K3wBWmw4QRPbp/3QDP02Co9Yd3J+2Mh9vP0iiiBl5JMBNHJ7yktHtZaIhIjyg2pMfYsCdU3F8g3t7kGHiGlwXZe9TV51CdtdQGQj7hQGhDHhnEnBLLcKg1jgEmH3EwvMn624c4YG/Ac+MYz+kIhhoW2Uqb5OWTrG+n1mcbqeXG1H2NZ4HmOt+u3cRQE7W8cUKijapYxTsZT15ZFuBUq64AD3NLe5321td7e7xz5+adfErnYdb7f4gmk4+Igc+tvb6t7F0nFiyTT+TrLifSnnd9Gfu0rBzdSHKQUzQGbLLAjiVkjR4hq+oHqXw7XEB+Yql6dSmTvIZqDo/oH7u1KTh6JyS0G4APz4Yu0TBxHgjbPl29imURQ6djPigOZkedXYBOe1PtUSBaBuvbPKOIxOpI3J3GjEBW0RL63zqR5LmbguSbA82mOIsq9syno64zOxlmZ/6jOa/zodjl+p1vX7ElYwiiaPskgcKjg37np5XHG9dhaFPxq0r8bJejd8tSx0lmFmrh/0n1IZ7GnC3SOBRuZJi1AQtWhtZO9p2medZRRTNSo7aQBU43opG6G5W3NqH2BcFG7kId4612OY/fPjbQIHpYd7kUK1Cqo5PYzAGqt7HFIZwDpmvJt63NrXXrf4RvVGBNKgMlE4NeJZtANtGhumcoE3m5V7exTpIcag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 14, 2025 at 05:27:33PM +0900, Harry Yoo wrote: > On Thu, Mar 13, 2025 at 12:23:55PM +0100, Mateusz Guzik wrote: > > On Thu, Mar 13, 2025 at 9:59 AM Harry Yoo wrote: > > > > There is other expensive work which can also be modified this way. > > > > > > Not sure what you're referring to? > > > > > > > There is pgd_alloc/free calls which end up taking the global pgd_list > > lock. Instead, this could be patched to let mm hang out on the get > > skipped by the pgd list iterating machinery as needed. > > Okay, IIUC, you want to remove it from the list in the destructor > and not remove it from the list when freeing it, and the code iterating > over the list needs to verify whether it is still allocated. > > Would this be with SLAB_TYPESAFE_BY_RCU, or by taking a lock within > the destructor? Nah, slipped my mind. a lock needs to be acquired even with SLAB_TYPESAFE_BY_RCU. > The RFC patch [1] that removes the destructor states that "taking a spinlock > in a destructor is a bit risky since the slab allocators may run the > destructors anytime they decide a slab is no longer needed", > but I need to think a bit more about how risky that actually is. > > [1] https://lore.kernel.org/linux-kernel/Pine.LNX.4.64.0705101156190.10663@schroedinger.engr.sgi.com/#t > > > > > there may be spurious mm_struct's hanging out and eating pcpu resources. > > > > Something can be added to reclaim those by the pcpu allocator. > > > > > > Not sure if I follow. What do you mean by spurious mm_struct, and how > > > does the pcpu allocator reclaim that? > > > > > > > Suppose a workload was ran which created tons of mm_struct. The > > workload is done and they can be reclaimed, but hang out just in case. > > > > Another workload showed up, but one which wants to do many percpu > > allocs and is not mm_struct-heavy. > > > > In case of resource shortage it would be good if the percpu allocator > > knew how to reclaim the known cached-but-not-used memory instead of > > grabbing new patches. > > > > As for how to get there, so happens the primary consumer (percpu > > counters) already has a global list of all allocated objects. The > > allocator could walk it and reclaim as needed. > > You mean reclaiming per-cpu objects along withthe slab objects that uses them? > That sounds like a new slab shrinker for mm_struct? > > > > > So that's it for making the case, as for the APIs, I think it would be > > > > best if both dtor and ctor accepted a batch of objects to operate on, > > > > but that's a lot of extra churn due to pre-existing ctor users. > > > > > > Why do you want to pass batch of objects, instead of calling one by one > > > for each object when a slab folio is allocated/freed? > > > > > > Is it solely to reduce the overhead of extra function calls when > > > allocating or freeing a slab folio? > > > > > > > The single-threaded overhead is one thing, some contention is another. > > back-to-back acquires are a degenerate case from scalability > > standpoint. > > > > While these codepaths should be executing rarely, there is still no > > need to get spikes when they do. > > > > Even so, that's a minor thing which can be patched up later -- even a > > ctor/dtor pair which operates one obj at a time is almost entirety of > > the improvement. > > Hmm, but I think even a ctor/dtor pair that operations on one object at > a time requires changing the semantic of how the ctor works :'( > > For now the constructor is not expected to fail, but looking at > mm_init()... it can fail. There is no way to let slab allocator know > that it failed. > > Looks like some churn is needed anyway? > > > > > ACHTUNG: I think this particular usage would still want some buy in > > > > from the mm folk and at least Dennis (the percpu allocator > > > > maintainer), but one has to start somewhere. There were 2 different > > > > patchsets posted to move rss counters away from the current pcpu > > > > scheme, but both had different tradeoffs and ultimately died off. > > > > > > > > Should someone(tm) commit to sorting this out, I'll handle the percpu > > > > thing. There are some other tweaks warranted here (e.g., depessimizing > > > > the rss counter validation loop at exit). > > > > > > > > So what do you think? > > > > > > I'd love to take the project and work on it, it makes sense to revive > > > the destructor feature if that turns out to be beneficial. > > > > > > I'll do that the slab part. > > > > Cool, thanks. > > -- > Cheers, > Harry -- Cheers, Harry