From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA3EC282EC for ; Fri, 14 Mar 2025 08:27:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00A53280004; Fri, 14 Mar 2025 04:27:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED5C1280001; Fri, 14 Mar 2025 04:27:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C667F280004; Fri, 14 Mar 2025 04:27:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9E43F280001 for ; Fri, 14 Mar 2025 04:27:51 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5C5FFA95F4 for ; Fri, 14 Mar 2025 08:27:53 +0000 (UTC) X-FDA: 83219478426.05.A782B63 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf29.hostedemail.com (Postfix) with ESMTP id 56A87120008 for ; Fri, 14 Mar 2025 08:27:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=KNMIu4T3; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="YFYI/EkY"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf29.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741940870; a=rsa-sha256; cv=pass; b=cJ+nRpBFlTLxcvbama/zeLxhkjYx9smbpjU7zKJHZRjqJTaCRYMcc7EqDMWiAybpH8yHQU LXkXRS5uWPsspkXGo1lIVYB84gjCjJSpV8PKhyD5p6FTlUh3Zg+97M8RZbhGqcOOLEfusM BSbgiFiTZ8Cm5HpCl1huAbiqXAsFDWE= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=KNMIu4T3; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="YFYI/EkY"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf29.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741940870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J6ja2zB5SmflzAzQBXP+pEky/MARqUbVRtPPEkkWloE=; b=NreohezoJDCO3hmhyJCNJaUUArcaxlILlW3YxXJHzJbom+fa1hnlTku3rSZEtJ7Dk3WKoB rW4daxoIYlLKYoNixH20fU/b/1EwRQvstdS9c6meS2hn2E0ZRJQShDxOTD0eEt7OBUQXav DAIr74IAns126aYylQE4y8rXKEmwZ4g= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52E7tpdj004454; Fri, 14 Mar 2025 08:27:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=J6ja2zB5SmflzAzQBXP+pEky/MARqUbVRtPPEkkWloE=; b= KNMIu4T3Cl+HfTtTaLxldOi8Vu2EYiLGsu9wWP6g3229/vT/VcGmATkVTkg58HaX k0iO7wtbYCQ4cXgwLGbDPPEC18jhv0EZVZsBSasHDqREolx35kRgWitAtllm/I9H BFMC20fUp+PZa1c4+13fz4rL0Kh3shK62INAKzpAUoXMXY3WcfLodJ+5Y3fZ0wEg 603x+top9quAHmygNmlUhlwUjgEZhdiNWoKqnMsmu/cs0sczf609QXLmaHS1Q9GC CLdE568cliKQMmdYfaOHfbH5dQJcWK2Q8aKdV62WRrr0SHYuFhafl9XBJVv75RfQ m3EHFqr35QQRxQHbbXOqPA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 45au4he2u8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Mar 2025 08:27:44 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 52E7e8C4008591; Fri, 14 Mar 2025 08:27:42 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 45atn5t06q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Mar 2025 08:27:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hjG5VJueJWNBZ14B7GOXRYAOVc0CfR76RUcr031/6nxXY+3wYH4UJRzDvwdMav9xHsXfuJ1fMPIQWU1+fQ9RCwWelawaGTaFeMKnzrcOBVoQR4McXecG6f5pWQeHuHe8ooQ0Ze5OGC8fuSuKY7fhUdr54eS9XVpObX0mFmXveJz0e1uLt/QWDFwHUmKcnEYcyUSJAL7FGOIqc7yBAQtqUDGdpMbEXzvweG5vLKfSXR8zza9saMk+gIjNcQP3yL96eUKj4NZhR6DjtJMIV967H6pw7ns82CxRoO0MDEO1bcuTQbl7Aoci6JwMykab0pItxJsYwwMB9UMdhCa0DVGOzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J6ja2zB5SmflzAzQBXP+pEky/MARqUbVRtPPEkkWloE=; b=JSMfcnT/FQwhhlH/ZIvRgS7vs5uuUtS26LqsEtIiIwBLLYWRgc5e/lwTcjYJYk+4K6FKoXvYCd1hxKbwuaVqCWcg+TIWrQK6sS+IQsWsYJhvi3mFK7MKunm24nEW4qK6IFrjXgW8waulUosr9VSrtenTzBbKBMocrJccCoarxoObwPAbKqDuafOwzT9JSRgN5ijdaGL5hLKCGssUYQPhErlRcAf5Y9tycZx11pSHpWoOyNeX0YcyZxfUj0pRBRvnlxJsvcunjsqMmGrSj58dmxbPfr90IBGVd6q6vUakEHL+JZTnRrFDYQd9ag8DOMjFb/TBdRSRP3SrT84ucvp1OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J6ja2zB5SmflzAzQBXP+pEky/MARqUbVRtPPEkkWloE=; b=YFYI/EkY3LnJ4ybHug9+NF2aQ1mIvnN6qnrFc110L8ko3pbGtBIeXsfkss0i1hWAeKYnQOyhkDfyJlJmPUz4GJKSP2YTzUiH7fIRCZIcbR/hlnkodLgmLd+ijNleUt6PLwJkh8ehgCVFyLziGf/gdDmfNlJLE1Ian32zHvZVCK0= Received: from CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) by PH7PR10MB6484.namprd10.prod.outlook.com (2603:10b6:510:1ef::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.27; Fri, 14 Mar 2025 08:27:40 +0000 Received: from CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23]) by CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23%6]) with mapi id 15.20.8511.026; Fri, 14 Mar 2025 08:27:39 +0000 Date: Fri, 14 Mar 2025 17:27:33 +0900 From: Harry Yoo To: Mateusz Guzik Cc: Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm , Dennis Zhou Subject: Re: a case for a destructor for slub: mm_struct Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: SL2PR04CA0002.apcprd04.prod.outlook.com (2603:1096:100:2d::14) To CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR10MB7329:EE_|PH7PR10MB6484:EE_ X-MS-Office365-Filtering-Correlation-Id: ec982523-3631-4a07-aef4-08dd62d21547 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dFh4NzF6VHV4WU9aRDNzNGUvTDNJUWhoTjgyVUg0OWpEVTNVMkpGbnQ5eGZs?= =?utf-8?B?TllkcmFLYmdqanREbFh4TlRKNGtia3FObzErSGRtSG91RWdGYzdFbVNaZ1FI?= =?utf-8?B?cWVGL0ErczBVODNiZmNsQ3BLMHJ0QzhoOW5PNldqT3E1VjN5djRhcWlsb2Jy?= =?utf-8?B?N25MV0c4S2RjNy92WWpFTTIzNTlnaE9HNi94a0xtTnJKQ3JnM2xpQjVIc1dU?= =?utf-8?B?L2hwWVFuTE5kcUNoT0MvYUh5aytXOHZObWpTclZkdTlqcGdyNHBzTjErSlI4?= =?utf-8?B?aEFIN0I5SHhXUzMvaHRLMSttR1Nkdk1Ya09yMTRyWFRwdEYvS3RxOWZXZmU1?= =?utf-8?B?SWw3VXp1aitzbmlwOVNXMkN2czJkN0UwVVk0ZFJzenpLd2F1a2JsSmJ0am5W?= =?utf-8?B?bGRQZFB4WnBnbDhTM080aURXTmhJRU8rSGNEMS8wNDhZQllyZW1yTnI4V1Vm?= =?utf-8?B?TXhIOVpQczhqVTdGVmFMUmprNkNJaDN4UjVaYktkejFxUytqd0JqZitzcmNO?= =?utf-8?B?d3EvSU1vMGFUVlhvaktJRlRvZGNqT2FQNFdRd0l6UzBqeGg0a25NNGMvSnds?= =?utf-8?B?VGFaTE92aGxBczlNUHQ3a3hHc0lFTXV6MWVRMGd4OGJuRTMxQVlldGlzT2pT?= =?utf-8?B?RE9CSDB3Vmlpajc3TWorcE9MVkJUR2RoSjA1VkM4UXlnNjM2QVFBWHdQc3F2?= =?utf-8?B?RnRGTFFqaXByOVZSNVJsVDFmY3krTXF6NFhEbUk2azBiMGFWRmVvVTR2ajNt?= =?utf-8?B?dmptVGxUWDlNd2ZBbzNzaTJPSXJ0SnNGV3NsVVc2TXJ3NHRlZ05EUzJOUmNu?= =?utf-8?B?eEhCOE91MHlXdFVvSFRiOUQrbCt3RWRTTHZrN2hBVjlCNm9vbmt1WUhvTnF4?= =?utf-8?B?aVdqYTVEUWxoNnBKejBJZmlCcmY3OUJlMnFINTNvdzhkNVdwRkE2NjY4a0Iy?= =?utf-8?B?Z2VjUDk5ZWJUVFpMa01oT2lhQkltYlcrL1h3MkEwcDVrT2d5K2M4RVVLTUd3?= =?utf-8?B?SldXQ1J0T0V6QVQ2a2Rya1VPeFJzNU1Pby9NTU5hc25Bck8rbkRzTmszWDVN?= =?utf-8?B?QU1TQWdxeDhkQnRGSksrb3FyS0VGWC9ZTzUvZnQ1U05yV2oybHBXM0o4b05J?= =?utf-8?B?KzBDTFovZ1F6S1hFKzIzaHEreDJmbDUxdEpNQnUwUXZqSmRUaVdkTWRlWmJE?= =?utf-8?B?MW82akdQeGdFN24vcnpaUEU5R3ZubElUbm04dEJYL1JNMUxVR094cHR3SU8v?= =?utf-8?B?UXJZWmdTMnEwOTVXN2l6RWRzRlpUR3JncXptZlFpT0NPS0lLUEtETUErRTJM?= =?utf-8?B?MlREaXErUWtiMEpSSDJJY0xrZG9Va3Y1WjhaalM0OHBUbkNDMGU0MkNVZjFn?= =?utf-8?B?KzZpWnZvOUlGdmt0U1h2ckVyY204RkE4Q1Z4QUpIUS83OXFMYnJ3TDljOW01?= =?utf-8?B?MWJRU09PeFBmRE9WTjdqUU1nS21zaXowd0hoeXB4bVRvVmNJRklxMVJvdDBM?= =?utf-8?B?Zk5JWk1JYkJyRVV3aCtNS2NaVUhEVDM3TXlDRTBkK2dLVERPQlBrUGJzcHNN?= =?utf-8?B?VUZGaC8zZ09tTkZCNmlxVlBXUUR4cTc5RGR4TmhZUDZxQXBQZjY0QklpMC9T?= =?utf-8?B?cW1hVDRqVGU1MEpCTUx6MzRvSGxqb2FlNkZKRUE1bFNUbVUrWkoyODE1dk81?= =?utf-8?B?T3FUVnVGZFhRZFRSNk9aY2VhWXZvencvd1NvaExoMkFRZlA3M2h5a0FYOEVo?= =?utf-8?B?a0FNbHRkUkVsK1d6VGpTdkFGeVh0aHdSWTl4ckJkS2wvcUxDRWZnSWVJM0p3?= =?utf-8?B?enBaRHlvNGxCQTZKdFdtMjFVT2ZYZkNNZnlLUm4ybU1haWZmd3RYSGJ6cWV2?= =?utf-8?Q?yZ7ts1wgZbX7L?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR10MB7329.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3hzdVF3c2FQMXpnWDRaTlZ1ZTVWTy9TUDlxbVg5ZFQyUjZtYTZIRFNyUmFR?= =?utf-8?B?ektRNXl2VE9vVkJxTWJLODRBRGxmTDRZbThkeXB1N2FZUzFYZ2F6d3JrOXpi?= =?utf-8?B?Y0Z5QW5UOW9FVktnRlhoVFlwNFpWRG01STVwZUh2bElSVUpjSmlPZGtBdXdZ?= =?utf-8?B?R2lSM2swQ3JZZGU4NGs1aHZEU1p3TE9MZ3c4TXFzTEFmWmRUbXNhUFJ3MFBh?= =?utf-8?B?SWVFWTYrNmFBU1dUbnBiWWRQTW9Wc1RIVmtENlZxQkxtTERiamZTbkNFVHR0?= =?utf-8?B?WmFLS0s0U1hJRFl6VjQ1SEU3MXhjNlB2SzJHemk3ZXd3UGVNL2xlNjJuWlBV?= =?utf-8?B?WTVpWXNkNSt4aEttZDBhRmxseGRiSVlYYlBZak8xY2JjUnV6M20vdldXMWdG?= =?utf-8?B?ai9nTFlyN0JrbnExRUFDc2QzR0Joait1NjhDYXR0YkU3UGNmY0RCQ1RpbFk2?= =?utf-8?B?VlRCbVhDWHRMWlZDQ3VuN3VDOHF6TERabTNPRUZtQjdpdXBEbDJkbTl0L0Ir?= =?utf-8?B?VHAvSjNCNmVybzVxUzMwSmUrMjV4NTArVWtTOUtGN0czZ0JDT29EblpCVlhK?= =?utf-8?B?VjRrK2hudys0ZFdFTDBLRlFMSnM1THdPWW5DVzRremtwQTlNQ25HZmJHdTR0?= =?utf-8?B?L3pWVFlTVEtaL2xlZnNMS0dHcEVISGQvVzVkQ1NqWTU3ZFR6dGc4blpncTdC?= =?utf-8?B?SkhIbmtKN3U2UkxnTEdHR2VEUUU5WFNCdXpOWUJmQU1td0ZqUktrdzdtR0ty?= =?utf-8?B?Wkk3bm56bWxJVHNsT3R0b3RCeHVTMGwwemQxT2V5cGprZzdBSUo2OXVSS0JM?= =?utf-8?B?RFh0aGxOT3V1dlAvNG4yMFcrMHQycHJkcVZrRDYwcHlud3N3Yys4TFVkRm1i?= =?utf-8?B?QXRZZGliZXJ5OTladFl3Q2paY3ZIUzdZc1FxcXA0ODQvdlMrd3ZYY3VieGQx?= =?utf-8?B?T0JKZHdiaXZBcVR3eEV6OUJHckR6Mzk2eUlUWHRheWRsOXlHbXFrWlJnRkQz?= =?utf-8?B?UEk0Y3pFWENPZ2trUjdyK3JXampHVlpGUngzaE4vTFYxREl1ZWVGc2d6cWVh?= =?utf-8?B?U3hOSGlLV2h0VHd1bHdzblA5c1hyR0FwclpHYXB0aU54RXlQVUtQWjg2WVNm?= =?utf-8?B?clVmV3lmZTJxNExtRi9mNWZIRnZoQVpabXBnVkJWczNkQXRYN3QwZTFLQkhB?= =?utf-8?B?azZHcTczR1h6VjRSdXVOSkRWK3FJNEkwZWpBRURkL21YclgvTnhzRE9jRWxa?= =?utf-8?B?NjBuNlRFR0p6MnA0amNpUFpyNk1rV0xUYkJhcTlIbm5ESUtlbCtMTnBsMFNZ?= =?utf-8?B?Z0lvTndOMjEyaWNLcFJweXhsMFhvSWxIaCtoM0sySjVlSlp4T2lFL3FSNDNv?= =?utf-8?B?cXJSdEFzQVkrc09Za01GUS9oejZob2Yvb0tsR1lxWWRHbXEwbDF4clArSHdO?= =?utf-8?B?cFpmdFgvdzVOTllJZFBEdzZPOXFnWDhTQitLQzlNb0RMdXB2VmpOSzBRR2Rk?= =?utf-8?B?KzNsYUtCMmZVcFF3ZHFHb1MrQzRXT0VkQ2pINnoralkrcm9SV01oQ1loSmZm?= =?utf-8?B?UTNpRklhQ2VMaEI5RWM0eXV3eVJVcWtaQUZMTUMzR0owK0YwMWtWVjczNzN2?= =?utf-8?B?ZjI2WmI0dG5vbU10UExWWm9Rbm0rQ2lTY09pU3hGQ0dSb29NeWxtbTdrWlEz?= =?utf-8?B?dWJUL0RoQXk1MDJyWnR2cUoxMnBQWUd2NE1qSHhuNGcrU3ZBbEFJVXV6eUw2?= =?utf-8?B?RDF6b2ZoMnNpb0hNRUdFL0hjQUQvSHB4WE9rOGJQcXpUc3NxKzI5SG1qVEpH?= =?utf-8?B?WUYyN3ZYcWd2MFdOUzdvTkdFczlhV0gvWlJJZVpsMDA2YkpUSHBNY0E3NlZP?= =?utf-8?B?eGdxWXBhemRmQ21HbFRrNTJDMmU2SjIvK2tna0I1Z0V3Zk9QbCsveDRPVjlT?= =?utf-8?B?VnpTaUJONDkwTlJTSVhCSnl4MDFLalpBQjNIdzNJT1NmbUdINE11SldVaDJT?= =?utf-8?B?bFIzb0NMaWsyV3M4VHVTdEpHZHhRQUNTZnVBT29ER0tRU3g3cHhKN1l4Q2N1?= =?utf-8?B?aHhwS2FjdzFWeklraE5yVmNYdURxdCt3c0VicG5QaTE5c0dkczdpaVpjYmpj?= =?utf-8?Q?UJvgbxJGOI+rJ7ocR4YzO/388?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XzPnyvvxNcAzFk/ICJcIlC7CZl+aqug+yCZhWI/z4Ivy3nLikpA46ced5xyeLMdZd/oYOMzffvUNiBS/EUGY+bSuaOp9sDKpZsxCGKuSF0B+rR7Iqi0YMg8/xYLnyJrtF0/jNgpw3vEhKrZUmNg94b8y/bqqjTfNBoSVlCuLeyMlfEVqbIc75qxNCwuit7VdQh96OLtX5hJPFTLdeUzpsq3Zbf/vtPVfqyk/NXfV1vvCFD2PN4MfWt9JaYNLm8a2ltM1uBd6ZZ6E3kjebheoezLrjP3ZGx0W8+KHaH04qb9i920JNwL0B7K38O23qeencR4XZyiPfoOhIvd+JfkbRC1AaNeDMDviLv/HKiyAdoqqjRBT+99gQMHVuv4Rz12bNGmdcEJZ2rwo9iD1+Pbj/NlFJ45FCPhMIGIKHfHAsfgODv3cWjWbE5RkwQNlJNY2/0JUSI5Hd2s9qXEFhnE3OF1POUCY/ugrk/2uAHuM6qZX2jOPrqFMc7yfYeLkRz5mP9gUmc+hheXE/1DNtrS0pnA/2qTAQXTm96fo2Eylll3RJlxXheFfDB4TdtI+O/G8SSWNjFmLoySvpJOep7uut4qOA3+0v6U8qb5pDiu2FRQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec982523-3631-4a07-aef4-08dd62d21547 X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7329.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2025 08:27:39.9089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dJCw4ZxbUtA6odd5Rx+HIS2cMVKvRxGtYQgooAYBHQQ1bnLfrBNup4rvG58Sv5d9KvIfr20WrDo5rtKTnrj8Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6484 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-14_03,2025-03-13_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502280000 definitions=main-2503140066 X-Proofpoint-GUID: zZgdcUPCQgBfUTeiuI2a_ulvXXnLalOg X-Proofpoint-ORIG-GUID: zZgdcUPCQgBfUTeiuI2a_ulvXXnLalOg X-Rspam-User: X-Rspamd-Queue-Id: 56A87120008 X-Rspamd-Server: rspam05 X-Stat-Signature: jj7as5amb6b49ojz67co7gitcmbcbped X-HE-Tag: 1741940869-502543 X-HE-Meta: U2FsdGVkX1/0ULN/Z2M7+tXt8dpv3QumO+6I8It/ok86TNBX/BvQbm0zI9AzdrE/kmiYGNQGAmX7XHnomDSC2FvT191nQ3b7yD8N4qrhNFk2SIBK4fGWFFr3+XTPhz+Q5eIA0DPWcV2aO0TtnEamAiOoA2wThwb6wJwzSBwe+SjlbBpAqOX5ptQXVLZl8O4L3Sh7egW2D9dOJ8lALIxtQUUM8Y3k+W3paWobLY4W16cBTUEt0sqZHUckLWD9tDeGtrI03fOnzl+p9xmSMRL6pVFgdErB+cfLAWVYm4Eu9A8BgL8ngxC5gX3VcxmKw9RmrDiSUNo9FG3voLjXZ3X/MptmSI620xPriKD94C2HWODMBkAAvjaOHcG0cYPmO0zHVY3GA0BmWmqJZsdLCZa33+/LN+jZIsAFF2nNlsCdLpSDg20P7VY/5PmZcSpfT1J0RhCk7rl4ry0kOLO98SvDkuhnA+CS0gDo3vemer3tsp8ub5QQY+CHiZRgS2QAs9NRKlus8oTHNZPhJZf0N7ppbIqYGC5yQIpCyQXkjetygycVwJ/ceUGylB7lUgxqbGSz/oTFH9I2F/HlKsPOCFfXLP3u1HPnKzNNdxAxWiPusgFRAN2rraPlBPrKiSqN/l2nBSt8wM++cxKCo3EbqfPADUjfslZzY0DO8Ce0YuE/Jg9MIfVWXJjlo8HUX4rqrq6JujDlaLnNTA445eCb68FipJOeOiTy784PygajISUz7gLvtKt5wPvUQFVCfg9+7QKFcO6UG2dt2mU/iQ0WTWOPou12JNbpit2SQ2fV9L6TcSIXhGwwN1wbS/iAp/DBiVM4DTWJBSK0+J4KrHMG+Qv+QdgMEk14Mt+PWM6Z76nz6ZTA4DRsPs8I3kjfqssLshu9J6Fnz+PvnbuW5GNnoT3xsuj5s6bZ6p9XjrDAVqbF7zmDe4s7T068Vx2jOrP/3n9Y9dLpfDNXcZGDHTm1GV8 Mom24OME Zu6wgaUnJzsUiRcx4pqu66dOGS37KElqFpgoFeK5ooCmQ9qAqZqN0oU+3RsapuSql1CXp7xEBCJCUf/kIbhecXKIwRS6WKoPBuDmIdnz65Eiu0cB6Of71iY5Ap1i6SGhBpj7V/4icLq0bhyRa0kl/3ItjKN6dnBYyM5ottpMFDELqNtRo+TsqSBQOshV7KUPHC9rnKFk3zFikGVQaetRi4uGjOtquhBXIvx8Fb2EDqQDYg7N4HUKWnPz5ei82ZbiEcY9Njdt+DDY1bIDBpgjS6Xptwme3VBDvhzSNrk/extZcKfBe301JprMeTyQaBYU4ophOlX6Dmq2MH/eWPbEeHFreX3mBAUDxm6/NiJHUMu/uFOOXt73qJ4Pfo8yGP556bqwdis+4GJVhBSDXAD7rHHZxG5/LQplukTlSStJIknDlP+zC3AvzsMcxn9KbJXCPeuC7rylYuE7Qp0vyLz0INdlq4sGPKqHufKldiyEaSlJDCWth4tunWxZjSAc5gvmUFG962F6LWxW2n6Nel19/sKVJlxuKNxeAODp8KjHhcrnA5HjW+yx3WH3OePd9LGY3TFxqqTTKJT3kO73MJIMBWFWcn786smwSusqOE8sWhK+HH9U3Bjdt39jr1nZS94FwYLC1eavvmnPDb9DcbKgVQci6un0i+TuMZdt+upuBxWDNaugyGVqkORWzPSqe3PJr1bsNY5cof7SpdW/avjhkM82YMd7flLv+17sDjkALNRsYHHRkEfFFWOCZJEB6dan9rXoUELcB/VLhW/JyLrgQKt9QYHLhnHFD0lfiBh+QCJe5CoTQioaUBQJG9hhkhpm2UFuCh/dpQflOBaDgAB9G4r0QOwhhWnIBQ4ldR9jWZfnRR95VPOfO28IdQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 13, 2025 at 12:23:55PM +0100, Mateusz Guzik wrote: > On Thu, Mar 13, 2025 at 9:59 AM Harry Yoo wrote: > > > There is other expensive work which can also be modified this way. > > > > Not sure what you're referring to? > > > > There is pgd_alloc/free calls which end up taking the global pgd_list > lock. Instead, this could be patched to let mm hang out on the get > skipped by the pgd list iterating machinery as needed. Okay, IIUC, you want to remove it from the list in the destructor and not remove it from the list when freeing it, and the code iterating over the list needs to verify whether it is still allocated. Would this be with SLAB_TYPESAFE_BY_RCU, or by taking a lock within the destructor? The RFC patch [1] that removes the destructor states that "taking a spinlock in a destructor is a bit risky since the slab allocators may run the destructors anytime they decide a slab is no longer needed", but I need to think a bit more about how risky that actually is. [1] https://lore.kernel.org/linux-kernel/Pine.LNX.4.64.0705101156190.10663@schroedinger.engr.sgi.com/#t > > > there may be spurious mm_struct's hanging out and eating pcpu resources. > > > Something can be added to reclaim those by the pcpu allocator. > > > > Not sure if I follow. What do you mean by spurious mm_struct, and how > > does the pcpu allocator reclaim that? > > > > Suppose a workload was ran which created tons of mm_struct. The > workload is done and they can be reclaimed, but hang out just in case. > > Another workload showed up, but one which wants to do many percpu > allocs and is not mm_struct-heavy. > > In case of resource shortage it would be good if the percpu allocator > knew how to reclaim the known cached-but-not-used memory instead of > grabbing new patches. > > As for how to get there, so happens the primary consumer (percpu > counters) already has a global list of all allocated objects. The > allocator could walk it and reclaim as needed. You mean reclaiming per-cpu objects along withthe slab objects that uses them? That sounds like a new slab shrinker for mm_struct? > > > So that's it for making the case, as for the APIs, I think it would be > > > best if both dtor and ctor accepted a batch of objects to operate on, > > > but that's a lot of extra churn due to pre-existing ctor users. > > > > Why do you want to pass batch of objects, instead of calling one by one > > for each object when a slab folio is allocated/freed? > > > > Is it solely to reduce the overhead of extra function calls when > > allocating or freeing a slab folio? > > > > The single-threaded overhead is one thing, some contention is another. > back-to-back acquires are a degenerate case from scalability > standpoint. > > While these codepaths should be executing rarely, there is still no > need to get spikes when they do. > > Even so, that's a minor thing which can be patched up later -- even a > ctor/dtor pair which operates one obj at a time is almost entirety of > the improvement. Hmm, but I think even a ctor/dtor pair that operations on one object at a time requires changing the semantic of how the ctor works :'( For now the constructor is not expected to fail, but looking at mm_init()... it can fail. There is no way to let slab allocator know that it failed. Looks like some churn is needed anyway? > > > ACHTUNG: I think this particular usage would still want some buy in > > > from the mm folk and at least Dennis (the percpu allocator > > > maintainer), but one has to start somewhere. There were 2 different > > > patchsets posted to move rss counters away from the current pcpu > > > scheme, but both had different tradeoffs and ultimately died off. > > > > > > Should someone(tm) commit to sorting this out, I'll handle the percpu > > > thing. There are some other tweaks warranted here (e.g., depessimizing > > > the rss counter validation loop at exit). > > > > > > So what do you think? > > > > I'd love to take the project and work on it, it makes sense to revive > > the destructor feature if that turns out to be beneficial. > > > > I'll do that the slab part. > > Cool, thanks. -- Cheers, Harry