From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F746C282EC for ; Thu, 13 Mar 2025 16:40:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA958280004; Thu, 13 Mar 2025 12:40:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5861280001; Thu, 13 Mar 2025 12:40:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D213B280004; Thu, 13 Mar 2025 12:40:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B28D0280001 for ; Thu, 13 Mar 2025 12:40:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 10D5EA5A7A for ; Thu, 13 Mar 2025 16:40:08 +0000 (UTC) X-FDA: 83217090096.16.4C87800 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf09.hostedemail.com (Postfix) with ESMTP id 2F2A9140012 for ; Thu, 13 Mar 2025 16:40:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Jg2r1+55; dmarc=none; spf=pass (imf09.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.46 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741884006; a=rsa-sha256; cv=none; b=7scgVF/hPqGTpr9nNdwQZeC4zUdMdtgRE9L9QXbJUA10qNAxcmwHZFIpRLVs/z25kHS1B2 vXHecxGjxcdZ0RrGWGKLnbbbYMYTUh/pfIlnSd1NtblQuR3lmd7WMIVdaHv64xXBxgleVo gShlFSzYf3rN2ldjFzganC/p8KZ/jpo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Jg2r1+55; dmarc=none; spf=pass (imf09.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.46 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741884006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AU1db5kv6b5O3y8o3SsJx1lUw+kz3Y+K2K5M1PC6NRk=; b=WzJI5r5VOkIjjHfeYSTi8ZtK6VbnqnClHZLhtuTyXUgQ11qseMJqanE98WMfBKYOyceaHo inA9SZlD8VUq5fkjlkx2hNZ4ZHE/jVt/JrJdpkRT925SmHqBWDuDN8aCvCltjJcHPkN3TI 2OjP/o06Hvutlm1JX5o5xvlDTk4l66g= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6dd0d09215aso12333346d6.2 for ; Thu, 13 Mar 2025 09:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1741884005; x=1742488805; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AU1db5kv6b5O3y8o3SsJx1lUw+kz3Y+K2K5M1PC6NRk=; b=Jg2r1+55OvxPiDmallUDYWUBCD4G8Zq1h8ka/FTmKNqYL8xafgGtfKkZi0IWGJ8epq Tg38w2DAZV3wVD8N4zbFOnZK8A1kyGkBKWGv+Y/O3UVY4iL8X2VMXl4y5oRdNkw7TDVf WKPGhyyePAfNRtJiABwmjeEZ+OJcvDC2IzTud1Xp7jJ0Klw5i7VKXzEGy0hD+wYagWzv YzY3r1t6QMbDlnI6vAur03EQ84UouaBG0arRpq+SF5a+9HuPaM+n/Fvr+WIboYnJZs0u aznnqDWt+ScOub8WgkongPNHJkcbmks/l1kRg6X91BN7odMl78vP3i5PrJpwWGWBaUzY NG/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741884005; x=1742488805; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AU1db5kv6b5O3y8o3SsJx1lUw+kz3Y+K2K5M1PC6NRk=; b=ui3ux65/MDHOEZdFvWr0Bqud7i7/0AQL3DFJEv7oadIFXKacROK2EaQQjhCP3gdllL njVSGozYAyoLTe7xQLS2LXmRTLyC1J/ToIPXPJcXfyuvb6N1zCI+56GWWg0/HcnNofsk mcrXdSDsnok0GqB7j3MFlWvreBXn/To8FAWUTDpF9kQAqRRGgT2QbrhSOvW8S8U94l8D a+EC8WhOOj6Yorg//Zkl938HWjUkfLCxwIRlvFodmTdQ/jBkf2uIAqIvN4dluS6DE6z+ +NtWffSQwXpcgoVSLR9x+o6mvGLJMZXjYC8INUCnjTqLsutovQIuPzSv+oiQYz1gXtVH 542Q== X-Forwarded-Encrypted: i=1; AJvYcCUDDtxSn9CbpJ/7fStviXzIvQ4JdKheaBD1uzcblRg/6dPKIlRJmeE9ATOthoEJy+i2vjmRN1+nWA==@kvack.org X-Gm-Message-State: AOJu0YyGAoOmOS/ut956FLIcdS51ihre4A2N440f9DhWlU6MDDBGx80G muiPO+tt+NGyom1zjMoKZ0mgWffKNtW7pjV1PFoSxyA7NMSTn2r8XiXgVKAJNcQ= X-Gm-Gg: ASbGncvRx9tvh3psGjh+7A8ob/sJef4aVdW4wqye/mAl408yPdMZuHhVoql5S4LpRAS TcRcxxJ/2wwQ7AootiDslHt62zmvhcumQXUIoIJhwZsX5qx0Ie+1tJyaesg1/0isHMFgr+y0Ew/ XTFtLR51uwYnurpgWWP6bK8FO2ESRSrAax0XXssx3uvNl6vJxSBuqTOtadFpBkqz0r+fY/L19Cm o3fWHF/0cpQcmawgACy3odIHcR9qRKDfn2n8tachRc9org3SzxWNC5GJexaILzZ6CpnHvo5Izp/ fmngACvc0I1GCksuDPq35p9yxUKLnCqY2tHqj8POpQL3ul8JaNLer8fqzAj4iOicGLhHNAQgHdz uTxc4nVPiuTXMTMbAbRL8qACvmHs= X-Google-Smtp-Source: AGHT+IFkbHVcwllGuGBIJA3zC1/en1QL/cRzQlTpw+FJ8AJ/Tz+liHnNiv/rq/e44ltwNEtCG6qzGw== X-Received: by 2002:a05:6214:f62:b0:6e8:9526:5788 with SMTP id 6a1803df08f44-6ea23b41e51mr182171836d6.0.1741884005199; Thu, 13 Mar 2025 09:40:05 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eade24ea07sm11488136d6.66.2025.03.13.09.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 09:40:04 -0700 (PDT) Date: Thu, 13 Mar 2025 12:40:02 -0400 From: Gregory Price To: Rakie Kim Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v2 3/4] mm/mempolicy: Enable sysfs support for memory hotplug in weighted interleave Message-ID: References: <20250313063416.703-1-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250313063416.703-1-rakie.kim@sk.com> X-Rspam-User: X-Rspamd-Queue-Id: 2F2A9140012 X-Stat-Signature: cq1t9bqf9bsxgyeer6ep8s5hf96s545z X-Rspamd-Server: rspam06 X-HE-Tag: 1741884005-875318 X-HE-Meta: U2FsdGVkX1+XAhCsShivWDkle1fDfjqxkOQmWDpYhWvYMgGrIV6vTwcXI/PO7/mV60TBJ4ef5sYVl7tOgjqkphq+PSkPkyxE6SENjgUVnwai8vf18JL7tPJWtMQkqK9hKv2Znr0weJ4nS5IHg9G0luaES5D6qUaOJFWnruwqObp5KNlm5OTpTMoQgzp9iLZDnAkooAK6behRCcVCqMdv9whxFtgOVWc+XfxEtAz/XCwYGi68xFf8ABx9ZtVk39ALe+1a76ZO5p0ccwkdLRfvUOUL4C2XZgN8X/KdsH1CB+EKwPQFf5MJfKhRyfovnhd69GHGEAmozvyi/LpAyB5ozj3U+T6g4a7XkbHIfUlAEGUN4gYgTYJhu2t+OKOkCOEM45mIpLNw417lA5ZFMY7d2x9VjHG9EFu5YCW/rMO6JNTjiYb1TTlL+OFWdvttUQq4K8BMOMzqOiwwd5j+8Kw7348cP/DXMz2GQQlHGPJNRzFqxexMDEPRJ/61RwXvb/Yp8CiOg1u7n3RXEGANFQOIYiA7HibfvOzoqn252XazUoufKtMFWfgxmk6RMMtu22f6OyHs21qBA0sSl6d6d3i+MPGd+zD01YB13P+Msx486wj0hxH55xTQyh4M0vbu6ifaoonDj7owzyuXt54JO0c3LvO121DTemgm5itMH+t7SGF/0/5f6NM5BjY1Bu8+oJV+IOpN6EIp0oOaqGkV+4fHFfMfRBw6e10qZisLOR7lNBZpddb0Ix8juRp/aSWgIbZDIvk2SigsbaXyJuEMTAHBqjOgOJepd5MVf05xJzBEpZW1trt38ebUtBCIAYrcbeznsKuxH4Q/S8EaoGRVbQ6qc3d3biWmFe8lqqbex+Hbs0xjr/6es/qok1umB56VZrgn9cspZlOYbvMDsKpegU8tHSuNG69SKoP+2JjOnYMdnaHxZGsGJ/8tPTXRwr5zzpzaOiDEdxMfW7IQOjwOrpU o8+vgtTi 58wz6njvG+mV1/si19dtW6i930Qy0P/13GMBg7M4PmU27YUxGhHnMTsLR5e9UwULOZOybPYo71qas9O9qqUvQyDq7zkAUfPK3dPIeWcfhYjLZO7JQWdDu659sS74qQWOU5zw3reASOBl0xqAo8RJv06tE9NaCpxh1k8rsAwaWkZm6dRsJHRM+Kw2zsA4/7S3dp+q+CrzQprtgFTzFcq9PHzVjNj+lHuVmGCYkO1IOAXQuhMpNhzHCbZTzMgRhBjJ4v+zR7Nsvsup+OP5b6JqwgIgpsYCktU2XvXtH9XvrFTXwTxETYzuSaqtDrw+gLWHikfcvHvPeUZ2QqxaOhB+wTlDDwMs3pV866FYrI9Cdoyuuw61WBGGsMSedB88WN79A70aKTkb6a2PLeIsQV0YsYp2IG10jnwa30mRABazXHWciNAyZ1KpGKpiuBzkQFzicgOKsm5T1lFCyqQU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 13, 2025 at 03:34:10PM +0900, Rakie Kim wrote: > On Wed, 12 Mar 2025 12:14:48 -0400 Gregory Price wrote: > > Given that this adjustment is part of integrating the refactored > structure, I believe this patch does not need to be split into two. > However, I would appreciate any further input you may have on this. > Another way of saying this is: can you please change the ordering of patch 2 and 3 and place the functional changes into "make mempolicy support memory hotplug" patch. It's a little odd to "make mempolicy support memory hotplug" and then follow that up with a patch that says "now make it REALLY support it". Patch 2 should read: "Refactor weighted_interleave sysfs to allow node structure to be dynamic" Patch 3 should read: "Make weighted interleave sysfs structure support memory hotplug" I think you'll find the patches end up looking much cleaner this way as well. ~Gregory