From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164AAC282EC for ; Thu, 13 Mar 2025 16:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 995C5280005; Thu, 13 Mar 2025 12:42:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 944A8280001; Thu, 13 Mar 2025 12:42:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80CDC280005; Thu, 13 Mar 2025 12:42:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 634BF280001 for ; Thu, 13 Mar 2025 12:42:07 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0B0B312023B for ; Thu, 13 Mar 2025 16:42:09 +0000 (UTC) X-FDA: 83217095178.06.5AC1217 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf21.hostedemail.com (Postfix) with ESMTP id 1A85D1C0019 for ; Thu, 13 Mar 2025 16:42:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=TzWAcBzV; spf=pass (imf21.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741884127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3xNl+N7q/9OaetzEUva/jSWqSKwZzi+icZYg2l4BR/w=; b=f5YUTJHyH2o7/d3CpnJ+blZNtqHN+tq3+1ueDXpgpzOxNB3/YtL5s19wxqAyvmTzTnv5l5 dAXvkgsvdfr8mi1JoVkkycRKM/7WCmB840rjh5H/8G2xznCurAy9WUVGBk/9fiJgMdeJMj DTf1NYKKXC8Qg+Fa5Zg75IOMpHtHxMw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=TzWAcBzV; spf=pass (imf21.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741884127; a=rsa-sha256; cv=none; b=kYZ88xCSDf0ONjIwur0cypuFzabnFlJgYd7O/44oJlfeY69whEr1yxN7akV+s2SgiYkdIN 3WM9l3dka15a18b9nKXmZsfEdJepbh+ri0kXDtJpwfYq+gdeAzNXeSRyBPKEWfi/CdRPBZ ct/mKHg3dYRdCJw03jVT5ZSOqP1FN0I= Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7c559b3eb0bso72330485a.1 for ; Thu, 13 Mar 2025 09:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1741884126; x=1742488926; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3xNl+N7q/9OaetzEUva/jSWqSKwZzi+icZYg2l4BR/w=; b=TzWAcBzVTb2/n52pMZX31UkwSNpH6ND3U0JuNU8hv26/TKSdGwheUtJZ2Fpu/pGSif f00d2I+VqVFvuaeCnmz01yhZVG1E/uLJleHqEWYDaO+154IQwtZsbRf+jkQ7up9DmPj5 1oU8utAHzKK1jqy/FRHK1X+57jhsB6KqeQZZMKtZKs74/OtfVeNyfyiBtcI47FrxxubX 7p5woYzOo2QykxQzy0G+Z9aZqWzTh7sIb2+/l+dflaQMPNYkEePnbFCMrK2tUk0r3w/T 21pEeYZ5MnFC4D+yVxVvQrgM0RtnhpAqLBSUKChbTZ9FdxpVu4oxxt5NRl9d/J2Hh2/z f/tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741884126; x=1742488926; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3xNl+N7q/9OaetzEUva/jSWqSKwZzi+icZYg2l4BR/w=; b=bU0URJCR4dqW5Edo8osJH3ngk2mg/PHajAfWQHkGuOmFnqBHi1pcgVLMEZJhcWY8Wi O4IMY7tch1Rx6LPhEsEXgs3Qq0I5LoBlFj/RLkRxwRBDfLvNBhAbFHkLU2w61tVvK4j9 5tFjq0biFkkjHwGdL1+sj9lhAyJDyPfbfbxOaRP+xRvERV+cnpPNPlLhf+AR/miwwPRC 3JVn05i8z7D42Qounw2vUG39+nTAQYRhB64dmx7YBOVqCzCO9JuA2/8z0p+hTzHGo39B FkeQIzU+tTDsnUe7Sxu3MI3mQdyhU1o6eUT/9n8YvV+/V2n2OIf7avu6AJXt56KKt821 ujlQ== X-Forwarded-Encrypted: i=1; AJvYcCXaPtgEXvxeAAeqhKfwtjeoXc+ESRUtirb8piWTatEQqaQBN6Jpukkc8BhYDYnImqd63fSbN1u5cQ==@kvack.org X-Gm-Message-State: AOJu0YwUarKKYUu3EQlSacnsJc6GKBH2+RBECPXo3cPHz68At16CgIXr k51YkM3uzm40E8dVcd8D0ovEid/I73C4UY5aRJAVi2wCElpv4RqL9J0ujwq/Kog= X-Gm-Gg: ASbGncs8/h+zoM6veA6xmh/MES8VOFnY1L/f3Kt+3tB9huAnlyoT2gIoIHE4xvYKluI caHrHBW+HdC6sKITKmZ8FwGIHWojCe4N4KrBdDeJc3XQ09kmhcG0Tc1qRIfejELCx6jjBgDRGJ3 aMd05HBrlwFDxWBuwfrBHy6AzSKZdLnlNhgQDNMJLhGfWbsjUTDB09YyLW0WD5+FyeCugYzzqcZ yRJh9Evq/17tvMrbjWYnQOgSp17u8DQFoJHjBArg1GHg8G0tDXkXmZVEOWvSudA1fkzIKWa+Dvq Kx3l0idPj1rFro4tjQknRlTxWoIUEs/49YeAzE0u7Z34+clJj0UcCQeO0b0Ag7y7CzNe4hgFfV8 R1pWVzD7xlbySqDtSm/ivPUTldhw= X-Google-Smtp-Source: AGHT+IHaB5FwZypTre9bnElu4UDtRtYp5sIvDPiHQLQTt/iuCUfLb7vvYamZOzrYkeW67XJ4d1mSDA== X-Received: by 2002:a05:620a:800f:b0:7c5:467f:d131 with SMTP id af79cd13be357-7c579fa4e92mr61386685a.36.1741884125950; Thu, 13 Mar 2025 09:42:05 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c573c9d8absm117900385a.55.2025.03.13.09.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 09:42:05 -0700 (PDT) Date: Thu, 13 Mar 2025 12:42:03 -0400 From: Gregory Price To: Rakie Kim Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v2 4/4] mm/mempolicy: Fix duplicate node addition in sysfs for weighted interleave Message-ID: References: <20250312075628.648-1-rakie.kim@sk.com> <20250312075628.648-4-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312075628.648-4-rakie.kim@sk.com> X-Rspam-User: X-Rspamd-Queue-Id: 1A85D1C0019 X-Rspamd-Server: rspam08 X-Stat-Signature: u6p37je3hhd9yfggzfi58d8p5m5fae5s X-HE-Tag: 1741884126-204441 X-HE-Meta: U2FsdGVkX187RAlQGUXOud0d358vts8gsHoVcz5SNz5blFb1QzvJH3580R8Peoks5mAEJjo9wlc/l7LQtgNCNEwltmkDwvBSJEk6Ski1d+txbtzQ6GJ67v3+aHFFIZpX+KNi9ilN/QGG2HGBndaD840ClvLtdad83vWNhM203MrD8XesBQPXujgqQFDdf3sqHjPgtJL9RuoYbhXooAZvBShCtvN1zgKbBd6pfS4eOIMcQjQIjoaRJ21tOrlvq7D6Vm4tmcaY+sDORs9KN+5GLPjcJxJ87oNRuC0vM13QbqypeFB1ben/YHam/vvZJWZO60jAv1Z7iipETp6r+1f1PsOjBaSgI5FdDU7TGuis7hkwRxr7V1Qx0UMgcXvwgtkM61mRhFPPRzk+p/3BkLhkZ9m9T2IoNJGsRbVhAjvMuRSnOvsV8N3rAOd79YSWgo5m1lff2ttmRkzwLUGVVbmStpmxLgZw6fasvxOoRN+37TusyFHtCCnmHOxcgz72WXgVwsnb2VO1dUcpBns/V/3ndiwcxIOsBxpOK4918JFcPHCms6FjlLtRsIoNMChLc/FvelTQgMkJGz/V6620MKCM3nseGsT/dc75zVvqYvkb3NsLjNrKul766x1zIPprhLLvfeb6zRyFVKol72D6T9q/LspYCN3pKuPDIO31Io3qsydQHf5/H42Bknlqv0QeqYrSjMX3tA0ydm/a7IhOmwWQCaWH4RWxM0I9dE31XCqRZHQlHDY2RYTDnE2FmvxoNtHOU+69aA3R4NSHXUJ1ci4HP5jqSh3c8FiOBQ2Nt0JubIEqHo/14f4XfcGIoI5aWZc/fQ7i8HLpHECIFQwrjnnj2HyA2Df7r4E4VwfploxAc9Pfo6J5kE46blkZ9gTnn1gtMTyLB52xBG84wBmKA8tyM0jjWbx4yLf7fxxxxBx88TpdnSHn7L1tRjaMJ/jjhwkaml1fZAifyueETuhdmm9 Fq56qAah S8NZuZr99/D/ReS3hBycVuRIc8htdMafnMo+ydJF4y5l+ZQdKZSnCIiD9vOFYzDAAsHqgOWr3e82Rbo1/rE1fysT7zmG9dmA3V4ZsSgcIByg3Gh9az9zSDEnQLjPcNvD7jE04C3cXTu8r4pY33XZrwe4V55r6p/gGJA7h2z1UGOinBiW8jZPCQ1Hxhqab8BH2Obo9+akfS9YGF1ogumG9VPyVR6/C4GwxE+CMEVBF+ZCAJ9BPOxNiG5MbzRrbkNuHzVnqisICF2k0zLTqQjuaeaQgWil8RNHXTSUBGNk1EPMhfWjaHgyHLXew4JAFXrzb21lVtjn/04HlezA/Av3hvWOToq0fW1/0vKEK/XUH5ijj5jQ/DE6Qb3QJkmuenz8gz10jC95cssvwD8DT27sd/2LtZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000562, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 12, 2025 at 04:56:27PM +0900, Rakie Kim wrote: > Sysfs attributes for interleave control were registered both at initialization > and when new nodes were detected via hotplug, leading to potential duplicates. > > This patch ensures that each node is registered only once, preventing conflicts > and redundant sysfs entries. > After looking more closely at patch 2, this seems to suggest we're not understanding the OFFLINE/ONLINE events well enough to use for this purpose. I think this patch won't be needed once we address the concerns in patch 2 - and more generally if we discover it is needed this should just be rolled into patch 2 rather than kept separate. ~Gregory