From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7979C282DE for ; Thu, 13 Mar 2025 15:42:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BFC9280004; Thu, 13 Mar 2025 11:42:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67020280002; Thu, 13 Mar 2025 11:42:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51114280004; Thu, 13 Mar 2025 11:42:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2F118280002 for ; Thu, 13 Mar 2025 11:42:07 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B469414015D for ; Thu, 13 Mar 2025 15:42:07 +0000 (UTC) X-FDA: 83216943894.08.12B5575 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf06.hostedemail.com (Postfix) with ESMTP id 89C9E18001E for ; Thu, 13 Mar 2025 15:42:05 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CKh58mif; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741880525; a=rsa-sha256; cv=none; b=gzEP0b+zs1Sz0w40vNAUKSv8o9ItuxnY5WKs7d1qhutq2/oRQX+5BinW7kN9br8RZN1Qwd UealJAFnqrG3ZUxaGUTmDqVrYaZPzGBeZFSIvG6oxk1sgsdSUT3iXWcz4QItAVqbg8s/Xw yTih3lYjP8hOER1rJ2XtnJpd0o64N4E= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CKh58mif; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741880525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CswYvkTCCpMoqI89+nDZxiVOs2267PjAonInzOt/Nt8=; b=eu7Q9mdjl123BXvcO6O+XCSHCVi/GzRNt6Cv0iJbjq0BpJEFoZnQLTPW9RrYFxo/hAZKNh 3A4NHDVNA6HhylZ2t9vFFFbz3FvHIIX+2kzJhMHgRzGuDUapT5o6BwNeQK4Cc0BDcGipzj cAWiH70W2YpKzXBniDNtiHrvq4Z40ao= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5A9CFA4761A; Thu, 13 Mar 2025 15:36:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 551C0C4CEDD; Thu, 13 Mar 2025 15:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741880523; bh=GcM0bWRw3lqkKiGt9DpFV6nSyrYsqck9QyyQooLhfPQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CKh58mif1encnvopzGQ5g8u81BpNzKKnyR1m8qQQQQFsKjRMEMmH1J//1xRJ5mY+w +H0rEJc6wrjQUj3wd777qw2QfvQjIWB0AR2T70uuujeB1ejksQBfCUO87h9BVIHPSU EZf/Vb9bfsLAd5804VEg7rkdIybciqmUjvetIuWmGMJ84FXQyT7iHjS568tt72VEVk FRkxZ8Ca9aZ6XB58b8x0LzI5TYCEjiBXVU6/z6yxmeUH5TYR/UvYrtb/yreyKwFLSF WcTGizKXWyQKnMpHaxLruLRZukNBESLeygP4Jc1ORmrQ2H+ICYqgn7slmdqFHAU+2/ gJkGfc1gvGyRw== Date: Thu, 13 Mar 2025 17:41:47 +0200 From: Mike Rapoport To: Changyuan Lyu Cc: Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 02/14] memblock: add MEMBLOCK_RSRV_KERN flag Message-ID: References: <20250206132754.2596694-3-rppt@kernel.org> <20250226015342.2136669-1-changyuanl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250226015342.2136669-1-changyuanl@google.com> X-Rspam-User: X-Rspamd-Queue-Id: 89C9E18001E X-Rspamd-Server: rspam05 X-Stat-Signature: gr9w1eyajdeumakfww7c15fryf1fpxwo X-HE-Tag: 1741880525-115685 X-HE-Meta: U2FsdGVkX1+o1suWEIUYacYW7yioC7RmItxhatJJuFvE43SgtOSwwTcygndNEGImtdmPgsvrJtjyqd0B7RQiT9UyQWuHbXeXmYkuX3atVdt6214LccK2xVBs2GP95E4yLMEMwwzqqS+nHQPAsvOMFaXLL2urfMIaP7OXA04GHKOwm+Gh0T42Ze2UbfvmUnSdOhE56AFTCKwT4VLAnveQrDFfCdY6jUXlS0UWTgPll7sxzHNpqvgFDbydDW0FRqGbHJOJOH/iui4F+jCrSB0H1ly3ZwLjw3iXTJZG4ZWOlOGihGxyrujRuuBzeRsw+oouKSpFCVLxT7JyijEOIcU+ciT4c4Uw2apopoonbeBDlUbiZoWl6KPo3a5V38sswXPN+TeN3ePugmIZfALvPlG5u3LJh0gXX0ZhieVkDaC3YQkPVrvPGpjMAxXuIfWQ4PzivCIa8nMaqSzSxrBftFatiNe7jyFlRkgeaI3IOLSLbhYdJZVG71F65KnE+nT5JJYiLREc3SWsfQk5/aYN4CVGAznd2lvuXZZ0nygbEDMXgFvWfCTksamcM0+KClvrKOSoidNAQF9awJsi4ZQ2M8isn5bHbbK7A6hdDwyWwactQMdVE9TrE15E1udHINxEq3rW/SLy0Xw8/EJIKZKYwZaD1qhP95spRKSmn0Kf/wGJ3kTkYqgPiBiDbq194y5Y/c2S/18DYOQDes26systScCg6WMKonv482EIdyo1tHeMk1wfZXmC9c8yBKKgGSF3SmzBsuJ36RNV9IBH86ckby6OaOsoYm9ViQ1QO+S9M5nT9Jkgr+5XN0k5/a2CSNUct3SfjUJGnl9Z5hwkodyoaUXaBpOlT5PmLu8fspHrWxcJmFvIjPmpPC/lRs8qTeFdSYtboAegTBTM7ZJpxxMP5vgvPIzyMnmHY2UT/GUExz89A06BmmqXp8f1kVVEyoch33Aqsb+toNKH3zIbm/4Zt/M YXUN6sOl 8DQIAawUnJwpvgDzNZa3C9MOkkqZB330D7Kqek6Aehiz1wl96lvtWyO/O6u2wqyJEJoBxtXScZT8DHtE9/QBmkTgeP0c7gSIqbsYsfzmP5D7pl4tqeuPhzbGLTCfQkBw4NjUUVvEOSjvuhO9KlUXUjs4t6O24C2tScsGk8eAwwsloftd/lvsFLlf6bipsW5FZAKWRnIYFygKLH/Azz1fX5nTHMR48aYadVyreTo5+RZuND5FDrskb4JjsyAighMwaPOEITUd228Rbym5CRcjDA/GONAZ2+d5EKz+8sXfVFzJRBTSvtsHRmJxbCWqoidFzC0SF6PWpUhdeNghY9zDLPb8FIUrMxd8chwVOB5HP0+he3xSrGMrDQTTU9E+ORjPIoYJE6KUeOcFsosEA35xymbv8pw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Changyuan, On Tue, Feb 25, 2025 at 05:53:39PM -0800, Changyuan Lyu wrote: > Hi Mike, > > On Thu, 6 Feb 2025 15:27:42 +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > to denote areas that were reserved for kernel use either directly with > > memblock_reserve_kern() or via memblock allocations. > > > > Signed-off-by: Mike Rapoport (Microsoft) > > --- > > include/linux/memblock.h | 16 +++++++++++++++- > > mm/memblock.c | 32 ++++++++++++++++++++++++-------- > > 2 files changed, 39 insertions(+), 9 deletions(-) > > > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > > index e79eb6ac516f..65e274550f5d 100644 > > --- a/include/linux/memblock.h > > +++ b/include/linux/memblock.h > > ...... > > @@ -116,7 +117,19 @@ int memblock_add_node(phys_addr_t base, phys_addr_t size, int nid, > > int memblock_add(phys_addr_t base, phys_addr_t size); > > int memblock_remove(phys_addr_t base, phys_addr_t size); > > int memblock_phys_free(phys_addr_t base, phys_addr_t size); > > -int memblock_reserve(phys_addr_t base, phys_addr_t size); > > +int __memblock_reserve(phys_addr_t base, phys_addr_t size, int nid, > > + enum memblock_flags flags); > > + > > +static __always_inline int memblock_reserve(phys_addr_t base, phys_addr_t size) > > +{ > > + return __memblock_reserve(base, size, NUMA_NO_NODE, 0); > > Without this patch `memblock_reserve` eventually calls `memblock_add_range` > with `MAX_NUMNODES`, but with this patch, `memblock_reserve` calls > `memblock_add_range` with `NUMA_NO_NODE`. Is it intended or an > accidental typo? Thanks! We were mixing NUMA_NO_NODE and MAX_NUMNODES for memory with undefined node id for a while, with MAX_NUMNODES being older and NUMA_NO_NODE newer define for the same thing. To make sure both are treated correctly in memblock we use numa_valid_node() to check if a range has node id set. > Best, > Changyuan -- Sincerely yours, Mike.