From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4FBC282DE for ; Thu, 13 Mar 2025 15:08:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 110E4280003; Thu, 13 Mar 2025 11:08:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C135280002; Thu, 13 Mar 2025 11:08:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF365280003; Thu, 13 Mar 2025 11:08:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CFF81280002 for ; Thu, 13 Mar 2025 11:08:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F3F3C1201CF for ; Thu, 13 Mar 2025 15:08:07 +0000 (UTC) X-FDA: 83216858214.13.73724F4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 3032480023 for ; Thu, 13 Mar 2025 15:08:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rSauxTuk; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741878486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f3yBK23FtoX0HLlZKhz146n0H5NJwhzRIo1fT3rP9yE=; b=kmzK/PVkPYEUhMKReR8L/KikDMnvkVY9NcJxtCFhVSQ6R87bFIUASasxtjB9OC27gyPlkh z3Lhrd8YVH8XT6sCXYCkZ2ey3VJVh2GWV5TdO0HjpPjP9RBEbhI0TZmExR7TneN4XWnQEq cDfT84cRxvnS5cJ8w/mkzRe1145Vd+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741878486; a=rsa-sha256; cv=none; b=mNvWFY0iDvhQnMLBFo46KbLJim/9mW1ovLHAMkScM+Tv0k5FeiohJargTL2UzHy7G/NSNX NzoQtF9xIVpD0jrPRGeFeAUifBJ0StIQkECvzYARRYHwlLDlyH/KNkqU3FOsbRm7GTL5DF hf0Rf/1+r07vdbeAyjotP7ovrUZn424= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rSauxTuk; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3880B5C5F11; Thu, 13 Mar 2025 15:05:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D04F3C4CEDD; Thu, 13 Mar 2025 15:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741878484; bh=y8q36y3Lm1c3c/d6TMfN3OT27SfYv+jqL3eKxPhx8qA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rSauxTuk2RCTIVYhktiJE2ImioNmDhGTsMV27H3WO3L/Xn2X+m83n0yRtiF8uIBvE hFALaUPQ7gcoLxvPxRcivCsdf0F/+gSfIzdF0WvZ5jV1mJgCQdDaS0bApWyP1zxXYN ujr/6ZjXY0Lz80+H8Pt3jTcG+mAwjK8he5FXINUUOoR62/Upqyj2LKTQSbUvXXILm4 2PA12nZwTJNI6SVojnbV/EEn5DYHac3KWksSHh/DhoEnW4l/PSmGifmM576EfY3hVM JvXbeORgbiGcVUmrJbwwpUzBKKh5e8mpsHZTnxbzfxGrDwMofkzcgPbzPXIPdhmFmP cEb5gU0jubkmQ== Date: Thu, 13 Mar 2025 17:07:59 +0200 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Yajun Deng , stable@vger.kernel.org Subject: Re: [PATCH 2/3] mm/memblock: repeat setting reserved region nid if array is doubled Message-ID: References: <20250312130728.1117-1-richard.weiyang@gmail.com> <20250312130728.1117-3-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312130728.1117-3-richard.weiyang@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3032480023 X-Stat-Signature: hf5maakn46wxxk6nyhe9efkn5dtqk94r X-HE-Tag: 1741878486-191853 X-HE-Meta: U2FsdGVkX1+FvXz/bdE2Po5CrIk1krgVSPfeufv49Y9G3qFmCPKSm6wbMeXymzcntws6kHDlDLEPINSO3Fj0KeczdEd+JCc+WMFlOsfxNW1eohsk8EeUeUde9w35yuXTcDQOQcbNu5egIwaXCuORK48OQzbs+4CSDGNgaspcPGEmoeknJP4+hnTQ5Gtv/jdWUj/bemgmOeb7aFHKa62g0cPcu2ltQ+rQUW9S7zugQYjlkrVs74Mk+Co+iPTOhGATRrBXG18TNPxdocJhlBM/AgRro005XgvNzDSPYNmUgJLUTB4sQqF4AXN7PrXqwhONMxD8LXt/iMNDoAUA8fwsb3B3FLcomNs6iHzB1/3W+cXn3knjnlRBh8lx+hhKrsn6jK3eHoiWXy7iDhOg4Yb8Tho/ivj7puadSIDELKdvuWaQxptFTk/ZDjruxfhdS31z/fz3hV1zAqM2yAC4HRW/EOPY/vnhFBo9nyjah3pnku3goW20/dS1qFU4ojGt/T5c5IfGhysF5RP4iraCkfOublNpNfwKhu8hHh3Mxhxr/RsflJQRmuTp5mHdezj9pIdn2WIqDvPOHIwvnxbEV4hZ9FeUvuHvR1KqxCAWnggeDXWdYrEKrp4QSmvOBQHHyOlEbFqKC64N8gTkiwE27ONAypWIyuXKIoJENVNYYMqrIj7SWvnRItiCMAg38N37yXiQaGftsfLyglEisnRatE6h3Jj4KjhKkZ3NA8od1CluGvYpYuVeOLq0kMfhZgu8LOesr4lHTU3943i6jqTE+m5ii3EazWx4Pa9AlUc84BmalFED2P4wtMfhde7op9ASe+Lciu4+h+JbewYDfU9idIOLv1jHaKF007GQpT4hDVyNAbsgU3NzwlQn2Ox7c+KM0phpaVhokbttuyE9mjUr8f99YNuAV+1Hz9EjJiGDNGYO3tYoc99lluSh8eW+bww4d09FL1epC6z2Jgd+8LvImEV A/vk628o azfDKlbGQi9CqJn89oWEkJQg3DpCSy3yQxIZoiCbtZqe0MVDQxZcjhvPb9xfBb9BboDCGmkNFa3YCddnJXe/vfqouSfZiP0xs1WDLD3IudXjytfZRPJP6hdfgWvMalww0JdxhiAjZ96Tbavwoxgh5nl0eKD2LdWo+rhzA7ZHZXbgW8EbY1rjXvWByJbKsVDPEb20QPZypj8/fqE8aKNNy0W95luzBIuHnADwWhHgsLfmMLhFuGaXqyhgAp+8vbVeIivmueiRfueeLjZmUMcLMIIS1IanWlxHzFI/sGPBWJAKJiEMbRwmMABKpq0YLtJm7SogSC8exj3fnOahhjRS8/bqnOD/tQ8K/U5o5uXYoa+hIwB69kQNy7u5tnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Wei, On Wed, Mar 12, 2025 at 01:07:27PM +0000, Wei Yang wrote: > Commit 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") introduce > a way to set nid to all reserved region. > > But there is a corner case it will leave some region with invalid nid. > When memblock_set_node() doubles the array of memblock.reserved, it may > lead to a new reserved region before current position. The new region > will be left with an invalid node id. > > Repeat the process when detecting it. > > Fixes: 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") > Signed-off-by: Wei Yang > CC: Mike Rapoport > CC: Yajun Deng > CC: > --- > mm/memblock.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 85442f1b7f14..302dd7bc622d 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2184,7 +2184,10 @@ static void __init memmap_init_reserved_pages(void) > * set nid on all reserved pages and also treat struct > * pages for the NOMAP regions as PageReserved > */ > +repeat: > for_each_mem_region(region) { > + unsigned long max = memblock.reserved.max; > + > nid = memblock_get_region_node(region); > start = region->base; > end = start + region->size; > @@ -2193,6 +2196,15 @@ static void __init memmap_init_reserved_pages(void) > reserve_bootmem_region(start, end, nid); > > memblock_set_node(start, region->size, &memblock.reserved, nid); > + > + /* > + * 'max' is changed means memblock.reserved has been doubled > + * its array, which may result a new reserved region before > + * current 'start'. Now we should repeat the procedure to set > + * its node id. > + */ > + if (max != memblock.reserved.max) > + goto repeat; This check can be moved outside the loop, can't it? > } > > /* > -- > 2.34.1 > -- Sincerely yours, Mike.