From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDC49C282DE for ; Thu, 13 Mar 2025 09:42:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B4A5280003; Thu, 13 Mar 2025 05:42:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83E71280001; Thu, 13 Mar 2025 05:42:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B832280003; Thu, 13 Mar 2025 05:42:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4A293280001 for ; Thu, 13 Mar 2025 05:42:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7AE99121D6C for ; Thu, 13 Mar 2025 09:42:26 +0000 (UTC) X-FDA: 83216037492.10.0266423 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf29.hostedemail.com (Postfix) with ESMTP id 70CF4120007 for ; Thu, 13 Mar 2025 09:42:24 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=HtB6ErFB; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741858944; a=rsa-sha256; cv=none; b=RxGDDc+uYmYWfG2AnMZVRIjGB5c0EUPTGOdc3rpQndVp5QiuWUbMm7dcD1I7Q2DHUZuJnS EtpO+HbFQXPsCK8AhKLa00qpXwBwyVDxnWzOxbVKgSfo8iuHL4ZEjEdbqCa2Nl6by96PcY y0bof9Rk6gNGlDICc/cvNIcBCacWw2I= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=HtB6ErFB; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741858944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=20DBW7AehNpQ2Om/8eHwOLATn1HbHZB6DDKZV2Anxq4=; b=FTRKNc45D3jLHgWr2SA4ucNHYheYga2DbYvcQOmPXi2IkWn7OFMASM6PIC8SRK0azIiB0c 9tEABMTLw+m5jzapNP14Qp94DJ9NDvQeDCiB+BX9PyC1raDNVY3niLQQpXEx5E0BDE6+tL WI2tgG1HdeouW1REArLOBQcQ9G9pXeY= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43948f77f1aso4479825e9.0 for ; Thu, 13 Mar 2025 02:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741858943; x=1742463743; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=20DBW7AehNpQ2Om/8eHwOLATn1HbHZB6DDKZV2Anxq4=; b=HtB6ErFBpijnhryCHUONHtjnjiIzKs/xfzpsFDsbsVxjxqb0uxIxRoF3IhzAlwBQdk uxPTQWLjIuMfBTdxtDDYNjaLx2rMQDU8lcwgg+UAHOyIhfXmf9czYtbnGvuiilGrnPP/ w7jI7KWBV9dgx88Tch6qqiTtGhqQPnymEiUFShFOSCtnTYs+5MW+YwwXfxHnkF/IwAbM Nl00yxf4hT8FpFc+oFbq1z5qXu+AbjnpjweizOTfkp9K1xFDUk569joptQlfWg2JlXrt nW5jSbcooXhD/4dxO1Z0OmRoHtf4vcqI4fJ1dyoFwxM7GC43glashURmP4TYCKsoo9c+ JcOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741858943; x=1742463743; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=20DBW7AehNpQ2Om/8eHwOLATn1HbHZB6DDKZV2Anxq4=; b=eSb4LM8mMCwmvkpN7dmcGSBQo8ePF1fO8MBPXT++WeMdF2beaHoq5gisDt9WFLQ0hd 7oKa3Khg7B/Iw2SRPsItvSj0uKWVDCfxMvVkjoilsFL4c7WFgoS9PnB4CLy6rzzhO7Rq XRGrLw8sjZGtiuA/M+GXJstvUPWszf/SaT++uux37wDungr3pAWzcFuXeXNc060UQpzv Ndj0h6Yel9do/kpD0TqkDYGg02ucaO+p33v3mftUuJhNIamhUQ3eXG04+F/tIZjzZwoN f9V6KY/5dTog28aDPB+FSUuziK+ycCAEqFlZP6623B0Cnif9k2CFhQzNOruMabluz5r0 Ye3w== X-Forwarded-Encrypted: i=1; AJvYcCUGPVUFcvLfBCeFFYbMoBswRRNurNA1hOSwZ6vUA2U9nLhTOoo2U0yZFFdUr/fF/2WN+XnqVduU9A==@kvack.org X-Gm-Message-State: AOJu0YwvaYCsz2DSsFy1HHJMpAUFrFLHYeNQEHV9a0UXkw7cmFF/4oLy 46+EuET2mcmhFHWccGOvK8HeCrf0pNp3pZeO+0K84tQsi7eXT1zI7HQOggoMpCo= X-Gm-Gg: ASbGncsMXEqTI291zLtFyD1f4Tvtrn/4VUQ8dUAQ6cTUwFmAMAm2Eufs5LZRo9BDEeV FayzV+N9JacKR6UiOUi/mf1lTAOuj610eJfoTdtZ/Q9HANNQSsFf4r0rNuBGchKOUT51psFvDYm Ddu5v2LO/KwIACJJEclHogZdpmhixj8maXF4vMA4N5hu1U15hom2wmUlzG2yAuEqPG4r2CnPpbO X1jv4INrfYwwZP+3naY5xgkqFhurGNJeJ2kyraecT++8FrbAttgBrK9Zdm+G20McqeCX9iIvMQY B0OOebJs7jbViNa6Tvgq1VX2gv4qW6id/AyPGNqDhUc/PlYUdsP87Z4INQ== X-Google-Smtp-Source: AGHT+IGxRh3flJu8cpJEo76OI5sO+1IMQEI9ARpuF8szI75gmS7y4b4K75SiX5C7SWGF6Co22nhSyA== X-Received: by 2002:a5d:64c3:0:b0:391:31c8:ba58 with SMTP id ffacd0b85a97d-39132d16dd6mr21732061f8f.10.1741858942811; Thu, 13 Mar 2025 02:42:22 -0700 (PDT) Received: from localhost (109-81-85-167.rct.o2.cz. [109.81.85.167]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-395cb7eb8c2sm1466935f8f.85.2025.03.13.02.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 02:42:22 -0700 (PDT) Date: Thu, 13 Mar 2025 10:42:21 +0100 From: Michal Hocko To: Zhongkun He Cc: Andrew Morton , Johannes Weiner , muchun.song@linux.dev, linux-mm , LKML Subject: Re: Re: [PATCH V1] mm: vmscan: skip the file folios in proactive reclaim if swappiness is MAX Message-ID: References: <20250313034812.3910627-1-hezhongkun.hzk@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 70CF4120007 X-Rspamd-Server: rspam05 X-Stat-Signature: ieoswkd9ftqrzn6pj844yo91osuxkq69 X-HE-Tag: 1741858944-312116 X-HE-Meta: U2FsdGVkX19+XziA7GcggkUzRKIorwJ8epHGRAqG2sfnFxMZi+Nz3QEMdLqBpRD9wy2/k8XBSilKl/PltUxFB/lBuJG/Ka7aBrXJ9gISrNOlfL25ADdffwXVO1hgyR9REOSy7MMRWDbBAQ5UR8vmTqRjWTsxVzmkhmDw9vHNp3uaIk+s1Pi6V3ziNpBthK9E3WqIAVI1XyxFIXNfUZQxsXT6BB15IF4WhET2oBglixh6/KxlrS6aIdY5rJdkcZCz64uxVo9ANY8gOTObPRp1k9HrXPoezr8ohbjqOoCtV/YZR+meq+vRQIvWzZMIDTGyoYvpM2DZIrY1QmPj2o7lA9P03oivXhrKl9KvzY4KFX+bV45Jq1tpFQRrzhm0ReflmWDtiEZwyjqpjOL76c0koT3XBLKViiDbVUKOB/xbWOW3b4nlN6sJfeCdzWN9gtg6RuH+PwUVQia0SeiK8aSwiWz1jXsCOcmS8N7xg5KgQFY8JmJiEmrzz06l6/Ab28BvjuX3pMggAToJwFBWB6xj5pZxP9vuUyvG1nuocYVSbyNV5xlVIegCiXsMkIQZZvP5WH2BbgLHGq7WjgRGqpTL0nipiTClIIPmspKPnjGF21u3P1ON5vexH7ZO64R/RCuI1RSI6gr6OeP/UgS1hcywsgBpRowNH3WrSbkMwr5280LLJ2r8WfXVfGPFI8YjucEeZpuCMdSRspnEhLcW20U6qkpTADFlqTORQGvLuhtpFlzN2gE8Sk+as7QdTV11tjbrw8k1XRQizqg9ILP/6C3elXRy3dtSsLnjTY5m720luvo+H/2mrooRB0tzuEqYevV0DFVvbHlbOtQqHa+i27+m8bkRhNasmQIXACkeR/q9u4dVXcqWT0ynbDxZxKox6FSbt3485jNbReFQQcBiJEeVNsl6FOiLm0Oc2kLNRlGCJyUIme47+RzkWIEno1Vl1+KdhFJKpa4t+WoYPDvvOju ColCtzmg M8cKZRWuL8Kvxyyp9enurDB0pDIFBLih/xM+px1vGWUKzD7la3UOEuEO/saFWY4jT4dtDd++0utRvBNPyeAzlyzze6cbOyI2oby71Eoo4D60ienonuuQDBNRATg3Gra1KpXSArdHt6lHB+uAOPIGGJZpIDsjaY2sNCrpLl9UXjkm9tsojOGb8UHQVr0CrStmC+B3NEWswoa+zHHgY/L/h/WvEnVYG2YznFCP+lzZIgWgQX0YDNAhIl2Yv/6XW1D2zK9Q6R5JguWne1MDZENHWeGvJCYt64HIqegfV8zbuh9wEyT2jWrfxjo89ajdoHUwOozORfF/MEXjjQFHvwoj1tKpV6b34fXd/E+2lyRyQE17OCRF8+2Kt7RJyZrUN88thV4f6PDMNxIQbE/w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 13-03-25 16:57:34, Zhongkun He wrote: > On Thu, Mar 13, 2025 at 3:57 PM Michal Hocko wrote: > > > > On Thu 13-03-25 11:48:12, Zhongkun He wrote: > > > With this patch 'commit <68cd9050d871> ("mm: add swappiness= arg to > > > memory.reclaim")', we can submit an additional swappiness= argument > > > to memory.reclaim. It is very useful because we can dynamically adjust > > > the reclamation ratio based on the anonymous folios and file folios of > > > each cgroup. For example,when swappiness is set to 0, we only reclaim > > > from file folios. > > > > > > However,we have also encountered a new issue: when swappiness is set to > > > the MAX_SWAPPINESS, it may still only reclaim file folios. This is due > > > to the knob of cache_trim_mode, which depends solely on the ratio of > > > inactive folios, regardless of whether there are a large number of cold > > > folios in anonymous folio list. > > > > > > So, we hope to add a new control logic where proactive memory reclaim only > > > reclaims from anonymous folios when swappiness is set to MAX_SWAPPINESS. > > > For example, something like this: > > > > > > echo "2M swappiness=200" > /sys/fs/cgroup/memory.reclaim > > > > > > will perform reclaim on the rootcg with a swappiness setting of 200 (max > > > swappiness) regardless of the file folios. Users have a more comprehensive > > > view of the application's memory distribution because there are many > > > metrics available. For example, if we find that a certain cgroup has a > > > large number of inactive anon folios, we can reclaim only those and skip > > > file folios, because with the zram/zswap, the IO tradeoff that > > > cache_trim_mode is making doesn't hold - file refaults will cause IO, > > > whereas anon decompression will not. > > > > > > With this patch, the swappiness argument of memory.reclaim has a more > > > precise semantics: 0 means reclaiming only from file pages, while 200 > > > means reclaiming just from anonymous pages. > > > > Well, with this patch we have 0 - always swap, 200 - never swap and > > anything inbetween behaves more or less arbitrary, right? Not a new > > problem with swappiness but would it make more sense to drop all the > > heuristics for scanning LRUs and simply use the given swappiness when > > doing the pro active reclaim? > > Thanks for your suggestion! I totally agree with you. I'm preparing to send > another patch to do this and a new thread to discuss, because I think the > implementation doesn't conflict with this one. Do you think so ? If the change will enforce SCAN_FRACT for proactive reclaim with swappiness given then it will make the balancing much smoother but I do not think the behavior at both ends of the scale would imply only single LRU scanning mode. -- Michal Hocko SUSE Labs