From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89AC4C28B28 for ; Thu, 13 Mar 2025 09:15:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F695280002; Thu, 13 Mar 2025 05:15:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A4AD280001; Thu, 13 Mar 2025 05:15:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 395E1280002; Thu, 13 Mar 2025 05:15:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1B274280001 for ; Thu, 13 Mar 2025 05:15:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 402C3161D50 for ; Thu, 13 Mar 2025 09:15:58 +0000 (UTC) X-FDA: 83215970796.20.5DEAC5A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 5FC371C0002 for ; Thu, 13 Mar 2025 09:15:56 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0Fo9esKP; spf=none (imf20.hostedemail.com: domain of BATV+f9b963a332ab099747ce+7872+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f9b963a332ab099747ce+7872+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741857356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5wSKsE3YELzEVgXy2XV3NXt81xWdZW97g6MBMlpBv0I=; b=e3CEhs2RhE22tRslmxspNNgbBmzblU3ygjsh/loS6C9i00UMUnWLMdjR574H8O0nuHOoF4 nKS+1H/f5Uk35CKC4ek2HTG7jcLnntI1SndGBM6sT7aLA1djM1ukBgIFKNFuyLDlih1bCm UTWd7+BW6Zxt5gIKLC99tCqCLjEuzLY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741857356; a=rsa-sha256; cv=none; b=8TbG26Q8WI5MSqySAgATvfQUWCLLA+N+aWRLf+WcP6VPsOWbj1QE5r+YS3DnP2WWps/szY KeWM7gDCIPb1kS/Tj6wBc/3gVxz+y9QCA0MpdHfG0vFarb81E943MI51AlSPo12vSTrIK+ 9PhwXzA+gCcDDl3/iyjggCkvavEVJAY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0Fo9esKP; spf=none (imf20.hostedemail.com: domain of BATV+f9b963a332ab099747ce+7872+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f9b963a332ab099747ce+7872+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5wSKsE3YELzEVgXy2XV3NXt81xWdZW97g6MBMlpBv0I=; b=0Fo9esKPg//YV1hia5QzvfRY1W qeDFnPGMzFE5M8Vr5FliM4SO1cE8e4v4SeDxP/YrBtXWGxunRkUHSmuUwYG4g5e78vmxeLdTyKT87 m5M73EXpJdwMAr1YLZ5uAy8vkz6MieagEMJmz1TqbTT8hgRru99ZJ+nU+Si6fign9xuEC6LKM87Q7 nruVvjkccKdaHNrMgfylxU6CegljDs9Xre3OXdXf8c/H88KiHCJRRdG3VujV9JJaFYBo7t7Sd+vlI rqEwGeYXi2Z9DW3fylcGIncg/IjhN66ussaATCvnXOglOd915rB2SSzWi240EWY1XEE5M07ZgBvUk uK3hLpZQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tsefS-0000000AhKI-0atq; Thu, 13 Mar 2025 09:15:54 +0000 Date: Thu, 13 Mar 2025 02:15:54 -0700 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Matthew Wilcox , Jakub Kicinski , Andrew Morton , netdev@vger.kernel.org, Vlastimil Babka , linux-mm@kvack.org Subject: Re: [PATCH] mm: Decline to manipulate the refcount on a slab page Message-ID: References: <20250310143544.1216127-1-willy@infradead.org> <20250311111511.2531b260@kernel.org> <4fc21641-e258-474b-9409-4949fe2fda2d@suse.de> <9af6dff3-adce-40f8-8649-282212acad9e@suse.de> <17f4795a-f6c8-4e6c-ba31-c65eab18efd1@suse.de> <5075cd03-0a4a-46d3-abac-3eda27b9ddcc@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5075cd03-0a4a-46d3-abac-3eda27b9ddcc@suse.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5FC371C0002 X-Stat-Signature: twr3ns5c3cjdzwrgz4uwuriq1ttph8b9 X-HE-Tag: 1741857356-4059 X-HE-Meta: U2FsdGVkX1+dkM+ZVJntfVDB8JwpGElzkehPOpz4gwIqgme+xJ9Xri2kJJtH+FdGSL3Fj+w+nTjJOWsQDFgcNpjsVkz6q67qpeozyEQBj4Pt7pTflT6utO7Mnbe+g59Vw9LkseatGZa8Bp7920MpjVCN2nO8bzuIwWykvkqIksvf2qxZd03QcAirgfi/CHMwpdLvlPB0d9+3yHEG7LCFJk8xReIytAjgGPsjDU/EPFTCV1zr1uP4+txhtic3Ba83dVs3cNFJDcXDumE5acgOJ2HL35+O+eguI4Lco+I5/2fguYJiZdhaCBGNbjC9+kFIbWYrJpmoz5rnr5uTGuMJy/5gAmHTsbdHVSBxWSVn33/LwtqTefkHShSofOMAanjbQGava6sXfW9QAs45fHBdGWH69/Lo6rfnMf/qVt7r7cjJ0q5VwwpbugSq2lqevI2pgmp5ruWeXgYL3tcsyxSEuYSmma7y0CdViYwA0A3BQNqdg/594jbmyegKDuHm8Kv+QXRNbR7QhvHHVrhnOPbzzWtYx3lXPmFCvp3lXhSwxHP0hdxa8yQXt+tJr7Ch5R9s9b0ENJ/4I8EBqAO99au968eVQfYxMMw1muei8537QtCCw35ANwCowivN06PRYv51HsWIPQ60B9dz6QcordQwJZWotEHGB6n1Td6DGBiJeHeVPp421a4AJeGdy4ylzdsi2VJNT3Cn7DyZkcRq8y2lRrdjnJLYTvUoDyYwTObXDOciSgz1+UfeDTJzc7/yCbJmKqIzIwioY9uEMP8OLWexaKAA+KLBXb9qL6VaTHwJRhlHGsscESJXZN8pXn8/PiE+uoyasg4wK4Y1D/rYGbGELyUH0kimC2CLttA8YNsfuu5F+I7TQZDppQlbUMCPrUvC3/7ARCe/Ccps/GB64pM/UwqUiayyNUCsDDcNhgEU2wna4u7RKDGbFzbtDzzJjTW1E9EoNmUi2kXPZnWD8/m 2Q+mgPCb ph/bb5NXQbuLYceEw4XRAv8rHE9yzn0S6Ulz+DUzTl8AoDaQvr/blltjtrhV3KmXYjhjkJ34fpeXTulX7NMMypOZWcmDEhwHFHW1RjzNrMGHLIzzG0tzPjlTW2ksSGJejcZdjxuQ4/H0H+PILDxUiJ6lAiiYi9J1ugSdUPfnrCOjOPkt+5H+INxvnTLo1FphaHyriEzbK0S1nAqJ+deaDsN902nIoJyAn6jEp9MaDxj36tq6CdQaQgBSdkBg5Op/fiQHsESvcat6J/zwZ1E7IxCC/Y65Gz8nEAMMaLV2NBhIwv0f/qnfUN6fXa0dBHTCCvjBO4S3n8L9A/IW8Dj55eWcQa8J4bpWPG3vij0bqpA9TDxhyQ1wr21QhvFK3FF7/DuGQx8BLP2JRcdK3/bEr4UjK1v1p5Y9pfxZcQjGXBIFlDKH4jhpBaayAWPktu4Qb4JU5DSf1e3ejQV4JNO8BXMxTup3wxBXe/khA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 13, 2025 at 09:52:18AM +0100, Hannes Reinecke wrote: > > It doesn't. It just doesn't want you to use ->sendpage. > > > But we don't; we call 'sendpage_ok()' and disabling the MSG_SPLICE_PAGES > flag. MSG_SPLICE_PAGES really just is the new name for the old ->sendpage. Sorry for being stuck in the old naming. > Actual issue is that tls_sw() is calling iov_iter_alloc_pages(), > which is taking a page reference. > It probably should be calling iov_iter_extract_pages() (which does not > take a reference), but then one would need to review the entire network > stack as taking and releasing page references are littered throughout > the stack. Yes, it needs to use the proper pinning helpers, if only to not corrupt out of place write file systems when receiving from a TLS socket. But for the network stack below it that doesn't matter, it expects to be able to grab and release references, and for that you need page backing. If that page was pinned or referenced when resolving the user address does not matter at all.