From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AFE7C282DE for ; Thu, 13 Mar 2025 07:33:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3A9E280003; Thu, 13 Mar 2025 03:33:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC349280001; Thu, 13 Mar 2025 03:33:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3E96280003; Thu, 13 Mar 2025 03:33:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 86E2C280001 for ; Thu, 13 Mar 2025 03:33:52 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2CA31161BD1 for ; Thu, 13 Mar 2025 07:33:54 +0000 (UTC) X-FDA: 83215713588.05.B2E550B Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf13.hostedemail.com (Postfix) with ESMTP id 2ED822000E for ; Thu, 13 Mar 2025 07:33:51 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=SicepSrF; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741851232; a=rsa-sha256; cv=none; b=5MFW3ABW6Lp1hqD1GGb9KQ2JATO7NR3DBK/X6Ceb9HUrRC0AlOL/R0vPnl7tDHHismFALH QWpBM6YvFb5bFEa5TPowlKq6Th+t493iewoJULVeVYi911KlohQz/58Gl1m+o948QUnq7i yrTcY+Uti8A8omulsH2L/crMmzduHCk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=SicepSrF; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741851232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5iry1yvg4WZMN2YDV1CqlFA/zutLhrsd/H0iQw/Ekw8=; b=XnAAcPQLyX/2e19P9t+Gqlec44hlohtJbvcHVXWEVrcxZDN695zx+i512XXq40N94shw5N GUZkzBtK+FTOm98sM81bi/7IOC8TiaXHhUlFLgkunz6kg3CwonKGdEC98qzAqhVLa38PYW l9NuRv66mm3jDdunQrGimYPcSiM2+QI= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso3420385e9.3 for ; Thu, 13 Mar 2025 00:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741851230; x=1742456030; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5iry1yvg4WZMN2YDV1CqlFA/zutLhrsd/H0iQw/Ekw8=; b=SicepSrFMmNmtzmkvROfj8NXVF90CGz92qO3meVb4uk10vQYjXI7aHhne1rv+gmiOh NTRN/p5TNV8orIleMmp5PN1Vn00aR+Hx1PRvLkSZOkjNilG4rm311ZMjufqMuQvXN6w9 8+ucpQqhzI7DndDd3hEFWgMnc0UfRjbXQ1kiB/l+V4rVC+BZP4Te6s8sCe7BOsD5dITC 8ttDMd5UyAEpaFR8bc2HESwf/w2KiBFrurjVuVFB9AmmmgfFlTwz44ogyanq5QiFMSAf SNu2jbwZFrDBQLhDK/Uo5YvaIRu1GU473aBSy4eQ3CzcehADgMkZT1IO00qjsn1hHTiG c0WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741851230; x=1742456030; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5iry1yvg4WZMN2YDV1CqlFA/zutLhrsd/H0iQw/Ekw8=; b=Gp9O2qsKBa33Et10PbbS3NYMaDEQIP2iOQePS5VuTalegR6oZ6TbaI5GMyC1WOzdcB gZyAExGcTG0ZuIG8AeNRkMl3PGmUsXpdJFPWBmiwzN9Yxr9T/ddGRftIGCDFkxRzUhhm L7gysXJBzJV/CdU71ZFyxEbIJjrvSobMnpakWy9SVDRagN9BEyQLJ8hPuJ09X7DsFboc P5tr57yFCeio1P+x+zChhEEiW1LT6TJ+dnH+VN9qHVSYOBgL3hoZk0TOelI4503vveC7 wk6LxPG7eKu3VsG5cjuERMzRzrwEcLkswvvDCFO9WbJkVKNFwkOXd+hMDexA1fAnDfGk aGcg== X-Forwarded-Encrypted: i=1; AJvYcCUm9IcnkK1h7SYXilsgjtIFBVza3mNKo+yqkWf3lg4iiSpXWitHs12noZswmPB3L03EJXa/GegoGw==@kvack.org X-Gm-Message-State: AOJu0YwrDYHFOjxE0+bc8e6j751GRedpQU4q1iuSczwYo+e/drkFmv4q /hsg4fjX0C6cJEhHCVgNdAF+XVazCIfVS/DgWp5zMSevB7+FkROI3hr0hw3lGto= X-Gm-Gg: ASbGncutop8OW037/sAAJ52EO4+bCjBPLNs9tEoCZHeHM3L8XUnkth+g2Pz/Rf232o1 UpKEY+IFYL3aYCDAcDZGt/lVDl50uG7D6lpc24U70G3CJ5stBcJHCoz8gcRG6vAw6GmDZRiinDQ 1pEr/x46YRLofEbqx7Hfb5TNpgtya168e59LQQWa1pl+aOs+2mxff10dL9srdbfRarJblXQBlmO n4ZxceSwC656dKaXNEYveHuK7nHs6jdWRvBa0z6cIo56TFWe+yUI4Oj7+Hk/i7Oo8WHM4xshZWr VQDQtXdRg0mNxNaMHw0kEyMAQ9xNMO5PDmFAATEJV1XQhSpRE/KkZ5CnnQ== X-Google-Smtp-Source: AGHT+IGqSdtxUzy4WVCEjGF5SMHyXXXJMyFQAnCcaO8h0IsRnJgjQQ/oyOP70bQSW5L64iW4bCi0rA== X-Received: by 2002:a05:600c:3512:b0:43c:fded:9654 with SMTP id 5b1f17b1804b1-43cfded98b3mr105776725e9.19.1741851230496; Thu, 13 Mar 2025 00:33:50 -0700 (PDT) Received: from localhost (109-81-85-167.rct.o2.cz. [109.81.85.167]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43d0a731031sm45483895e9.7.2025.03.13.00.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 00:33:50 -0700 (PDT) Date: Thu, 13 Mar 2025 08:33:48 +0100 From: Michal Hocko To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: move do_memsw_account() to CONFIG_MEMCG_V1 Message-ID: References: <20250312222552.3284173-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312222552.3284173-1-shakeel.butt@linux.dev> X-Stat-Signature: 7ni44yxriei7mkbtmqwedus96fbim1dd X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2ED822000E X-Rspam-User: X-HE-Tag: 1741851231-366858 X-HE-Meta: U2FsdGVkX1+vTBD9DeOiGs1UQwwaU+Hm5PEh6Pv2pxBoBMDXPC9+vNZ5lCn9IPTd+EKNYOyuK4dpXl98e1Uo/m3KugoM1lcqiKGi0/veqQpNkhUROqMZ+1+pfUkLC0BzCLUQLrCA+jMnaqUVJAEaXwnfwxEKarJ7E8Erx6e82ez3g7hnOR2d7uXOKwk+L/xIPcqvzf/R/kbmx/HiSLYJdfXNdRR6EneR6ELkEMTCj429B/6KmwQTPavZT0gyOc99i9qfiSs6PI8IrmePldp5GtBKAu44Vdvpt1FnSXwOta/DKTFBkzG4wxccMvcWRrc7UuJ6cla9StxWzFCX7UUIECjl2S0S0Dj/FcTZqu+6KBeDIwRTojAegp4fQz8JRsN4sEuPW178U/IgGsRoC4+lLrykL6LDGj5O6VNw7odCspAD35ds+PuRLsGZc2WCmx6agJ+KrTW284SlHzXFtVQsvosQUbTFZmPRM1DpHytvfX8qzduNQAOIbZDQnDeVVF8IcI63Cw373BcqBwdCiy37KjXk2BLStptYHYk/Mg2Gy9bbwdPt58KECbJ2kSfJXPiaONj4U7+vgNxoYbdJAzyDfd8XLMRQJW8xWtgqtGYtZ605kOg9dBew4xpbW/L8Ff+n78cpfYeNNzOOwL2wEXEA8IFhBgdJ18/tse1yqn20frHAUt4tdTfpZDx928EIBdczovK0b5kOBf3dpSF/G0LqB5+/w6m183uWrid6jf35fgK4AQRFEJYjUDlPm5suwG/3I/QHnoClR/uH0OqRH3E9+58G+QRj8/Jr2iJcXICbuLWKOmKsWHGoxLUDMDk9+MKkyZCnJSS8KoBYAR4kMy69ktFCFeKebnrn9B4wKnn1hVB2v3Ieb02Pv4i5l/n5v+VdGUCYHEA8/O9qujNZIVMnWnaBet24/t2I71hKVikw7VTaOsqjE2j2PTzgx8bm0BKmKdtNE7IKj8zUCr2hx1m +Yz/6QhK mlc7uHz3duVMtOqMeLSsBb1v2HyOFVMM9eAA1oMNrt7afYKrsHOhF6O08rWk72uhGcgzakADHc4FFYKbadyve0iG39N1zRYhvU0xYMtSOkWTgmQPmVKD5JHDk8ayT35u+ilpGCdrH+FXxJHkYyEhR7zJsyczASAzZyMtkoUfEzGT3FtvAkymCf2BY63rPlnKeepj/kDlw2SevNu+iQNmpiuuxG/qnoF2ZoNcKRe++2Ay9yEzw6er9qBcG6Zog87tScao/b8Iu3WRsIkpg//8xh2zfOaRoONzPIfEBqnanzCyCQgilwti++AxRbVMtt5nMOrZ5Iu8EFuVRbZ6QrxciEn086CXP/LrAfmtRzHI0ju8AoWKWHP1T7+6KHM2/Rgy4m7hq8V+5KGcJRbTU59p+mEZvKNlOpxskBR/b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 12-03-25 15:25:52, Shakeel Butt wrote: > The do_memsw_account() is used to enable or disable legacy memory+swap > accounting in memory cgroup. However with disabled CONFIG_MEMCG_V1, we > don't need to keep checking it. So, let's always return false for > !CONFIG_MEMCG_V1 configs. > > Before the patch: > > $ size mm/memcontrol.o > text data bss dec hex filename > 49928 10736 4172 64836 fd44 mm/memcontrol.o > > After the patch: > > $ size mm/memcontrol.o > text data bss dec hex filename > 49430 10480 4172 64082 fa52 mm/memcontrol.o > > Signed-off-by: Shakeel Butt Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol-v1.h | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/memcontrol-v1.h b/mm/memcontrol-v1.h > index 653ff1bad244..6358464bb416 100644 > --- a/mm/memcontrol-v1.h > +++ b/mm/memcontrol-v1.h > @@ -22,12 +22,6 @@ > iter != NULL; \ > iter = mem_cgroup_iter(NULL, iter, NULL)) > > -/* Whether legacy memory+swap accounting is active */ > -static inline bool do_memsw_account(void) > -{ > - return !cgroup_subsys_on_dfl(memory_cgrp_subsys); > -} > - > unsigned long mem_cgroup_usage(struct mem_cgroup *memcg, bool swap); > > void drain_all_stock(struct mem_cgroup *root_memcg); > @@ -42,6 +36,12 @@ struct mem_cgroup *mem_cgroup_id_get_online(struct mem_cgroup *memcg); > /* Cgroup v1-specific declarations */ > #ifdef CONFIG_MEMCG_V1 > > +/* Whether legacy memory+swap accounting is active */ > +static inline bool do_memsw_account(void) > +{ > + return !cgroup_subsys_on_dfl(memory_cgrp_subsys); > +} > + > unsigned long memcg_events_local(struct mem_cgroup *memcg, int event); > unsigned long memcg_page_state_local(struct mem_cgroup *memcg, int idx); > unsigned long memcg_page_state_local_output(struct mem_cgroup *memcg, int item); > @@ -94,6 +94,7 @@ extern struct cftype mem_cgroup_legacy_files[]; > > #else /* CONFIG_MEMCG_V1 */ > > +static inline bool do_memsw_account(void) { return false; } > static inline bool memcg1_alloc_events(struct mem_cgroup *memcg) { return true; } > static inline void memcg1_free_events(struct mem_cgroup *memcg) {} > > -- > 2.47.1 -- Michal Hocko SUSE Labs