From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4CBC28B28 for ; Wed, 12 Mar 2025 16:14:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C83D4280002; Wed, 12 Mar 2025 12:14:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C090D280001; Wed, 12 Mar 2025 12:14:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A843D280002; Wed, 12 Mar 2025 12:14:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8B5C2280001 for ; Wed, 12 Mar 2025 12:14:52 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E9B02121160 for ; Wed, 12 Mar 2025 16:14:53 +0000 (UTC) X-FDA: 83213397666.15.720904E Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf19.hostedemail.com (Postfix) with ESMTP id E97F21A0010 for ; Wed, 12 Mar 2025 16:14:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Iy9EaqWu; spf=pass (imf19.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741796092; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JIjT65nGfepzfzKoi41aW6eYKNFsxtk8vKr2eFrJrrM=; b=LwvKpUgPebqTXjYet2+QPX16N1UnIgvLvc6p2bY6msfadGGYpmreNXVUrxUS8MYM2VKD+G xnqzMUnXOG/vvc67L297JzXmHvUBlTjc5g4y/X7cCJDnwfgy2hezAEdIS3xJyxGpF8JW9B rnsrFwQBGOSTNX6fu2gGsVoq0pkmDfw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741796092; a=rsa-sha256; cv=none; b=VALdEaY9RLKw74V3u6dV6v4WAsjHeC2+D7KdnVypCceaSez+WfaGfyBAkRKrzFN1k2dxSa sUKrbclMAi1NBdgRhihH/k1cXG2bXZyLZRpa1q1tE1ij4y/apj8L/JNgdOUlDJccCGsa0e tvHGMi8KJYskQmfuNREI3Okgh7fY+/0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Iy9EaqWu; spf=pass (imf19.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7be8f281714so696177085a.1 for ; Wed, 12 Mar 2025 09:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1741796091; x=1742400891; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JIjT65nGfepzfzKoi41aW6eYKNFsxtk8vKr2eFrJrrM=; b=Iy9EaqWu1OauFWKHSUCkgwTlUHjRrg9yvygcqxr/bXSQbz/OCYEX3YN+0tfO+c7Ue3 5vlUfQpb+jqd7zJRcAkOilqRcbiNk9WUSHbmVhIUSarLsXgJjKkEHTflViK7IpfO6vC1 QpGXXSm/cRQubEDH2hdtHq3hXTOb3PO6jOYjxfxMDyqCdWsvc6tav1ngYnUS5j0oM+/Q biZ/1ISGhbp2nQdmtfpZwUrV24BmiYbfS6H7LDy2buIfU0y2nCM45gFjKKFuenUgmS4P 3MnvVQqARBNhTBe7EDRmvLzSdLMmEPvfB8YjEW5IOo9P0y1ThYGi0WEXTkR3oP/N/Zxy pr0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741796091; x=1742400891; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JIjT65nGfepzfzKoi41aW6eYKNFsxtk8vKr2eFrJrrM=; b=XBKknteKH2pOoSD2jdjTF2dje53egYmqD0mCpWKta3mNgTU/wUfc7q9jiFK5eX9Mh4 bYMklg9c7ZZ0dh6Jb4I/zOTaMwtz+8n7Y9vtElSN9llIuV2xMMxfskBVI/nt9YSbpytU Z3Q/DQa+QZfRGJK9sW/GNNgQIN1KyZ4yzWNITFiemW+mLInhKlXKT3WKy7W8G5jY6p9Z tb/K5+wj11rlDX+EW5t8GNqIvEdOZhnsxwnJSZ1a71mrETPrcufxd+CjNCK8/5E2+RWO mEW8YNHI3Jjt+tKvpyQWy4+0iExBKJ+XtfPaVGW9PCJNSXUL6BCvcrRoMQVe2KYNWe03 SY4Q== X-Forwarded-Encrypted: i=1; AJvYcCUITxXHxlLrM+1iSwmPoE+b/Lsx8lX5iSMxBrXzUeO19B7yPuKVVGZGb/yzSoF/pn6UxBUUX3Cs/A==@kvack.org X-Gm-Message-State: AOJu0Yw0iDeWcfAoZ4pP1vb2g/vldUE4nh3BM69sPfi7nKCZEcTFELdu XMS4/Sb9b1hJBGRDufYGWZPAVCSpVcEGGwwOthbgTCJgviuMmiYrv5ZmdHQ4EniAN8s537lMM3T o X-Gm-Gg: ASbGncsFxHoqIArlfGWdIspYIMxKkwqFQw4fXPlf9ME6w/KiKEYWdeL8PzmSHAXMLE5 cTX+JrxliQsNIKxYb/4xR8dFBsnFbaIUXLmsF0C4Gu3fZJZP8fDpuswdS/idh5sDpEM9HbGb3Wc bSuC2Ul6KKztjMw8KDYYBUo+SMHOo+CnqxxsGQFvk26puvYFqE2WrPcXfB1bQPJB1llIFNanVsH GZ+IGejvp7GUp3e/MuG0Piif4CwYHVIM5dOUZTjGznAsUyzvHBRHFQrKvimjYEyWQSA32RJPZkn MG9EJf2/ZVBDyYEi89kon/xGEO/LBQN7IX+BzXrCXO3+o3XDJ0ZZBo4fBepexiP309DYRWyQ5++ alUHppXQWAc404VNAAKsJHlwVgEI= X-Google-Smtp-Source: AGHT+IG+8rERSwdLPDmJ7q5S5rs/MpxcJmuKt121pRGZODlzzovdTpsRc1C244/5Pj4nPgKibBScWQ== X-Received: by 2002:a05:620a:439a:b0:7c5:5e05:df2d with SMTP id af79cd13be357-7c55e05e0e5mr1268460785a.29.1741796090969; Wed, 12 Mar 2025 09:14:50 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c45e28c86asm890301385a.16.2025.03.12.09.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 09:14:50 -0700 (PDT) Date: Wed, 12 Mar 2025 12:14:48 -0400 From: Gregory Price To: Rakie Kim Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v2 3/4] mm/mempolicy: Enable sysfs support for memory hotplug in weighted interleave Message-ID: References: <20250312075628.648-1-rakie.kim@sk.com> <20250312075628.648-3-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312075628.648-3-rakie.kim@sk.com> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E97F21A0010 X-Stat-Signature: 95scfwansjqeecn817njin8e48pqede6 X-HE-Tag: 1741796091-760254 X-HE-Meta: U2FsdGVkX19sjPSWxT8klE4JrNTKO1NGffGOU8BmFKYFItq88T77C9LxehfDqm+IuMWAhJrVxxq0E52s5xBid+naNpQCx4vclRrmHkWdqW+dsli2L0Q4kLxcFDzY/AtUFZPiiOIJr65BOxnDDOPcGuVvh2lhIAW5ELae+4Dpqf2HEMflqFZLndFz0F1cMUg5hJpCPog1URe+hfVpp1IlbijVAaQW3l2M01SBfwbw0rUhgs+zNjQgay6bg+cJhBLWJoAllYcgEV59uTBoiuH5H/nEsv14rcrqkrrbBp6o0UUbMhkyXJuUMeZ+L0I0yHs71vR6Xu/nd9WLOiFpaQuy0eg2u4a+TQYcc0Re72npdQ9kXAF/Q+TRJ2S9xuTDkqRfMZPhuU5mj5m9XSWz9+PEQuqcjOhBx/VqPvRuprNpnlww1ozrR3xeZEl5pMyAc+lK9OTCoTzPdEx797+H6IeKcDN0hOboQd5ec/XPWgY+BkZNZxAkArBqcKZ1yFFutS575yuMNCm94WMKAkqSNhhX4avBggkLM8z0sdOuHiAGc0CVVBPHH2dKNbMSrnbKbEbJhI2tGKwvLqol/jfOYKa36F5X/PmRIgJtU2H/Qs2lAlnUppjHeJF6fpeckamEc+t0GSKkRvHVYTa4DNFDzOBcSoqIf466Aia3UGc80Pz/rL/PKQCKjeAHhXR6UuvVSbCjObF3iFH0w/8grapqIii0VXzTKzxHv/Z4gNwDC18CD4tl5AfcznGBylTc8UXX0D13MwNPyFs0A9OMC5ncQcIXW0EzLU+gBdnfQ7IXRm+eATus5qUA3uqnxkN5olV/x5HoUVbrVHauhgZdNNcb6aL3iNzl/2znW91RmSJYqfccKu7dqdbPo9C9pdA/g3w2t4Cfnz9Qnoy0GEPb7gLGKZGJ7mCdZsitX6AIBzyxpPCpPsApXwrQ1ybnb20iFeLvtrzqVeMHqy7CxQacG0EeGpb a297afd+ b1eacAAQIurdHGWfjppIY1N+eE94kLESaimOws7RommJxOe+Q4j/TMavivZMX7xLFt6rW44+46rK3HEXzQBewXiDxfESweECFSV8a4Zmq+53PeJeceL1i90Pyl1a8uvPcfNsgkKEYOurUggfCCLp486widVcl5myhiQzXS81d2rdmEGTqAOw/dPCRTNPjo0rSrao6JptLgojomkZw4pzLuVxbblL1uGjZNPUpzOaRgcTP5wkHoYFotc0iqglitQoxxgoo9T7lYGAtAsrmHHyJJjNbC9ZWp2mWELZii+Nd7QX0vlqfU/PnG4IfnuFC4pwz02+kJFH/ak6aGytTjJ/6k2a8tY+zFVYfJ2+sVVTfaRrxQgDbtZ2vOXp1/SAHkShF1DD22dMj1kViiL9v6QRRWZdw3QqG7XkVE652Hi0A3qAwKlGDfEcklDnvu63LePxPCo1viHJJHTS4QTM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 12, 2025 at 04:56:26PM +0900, Rakie Kim wrote: > Previously, sysfs entries for weighted interleave were only created during > initialization, preventing dynamically added memory nodes from being recognized. > > This patch enables sysfs registration for nodes added via memory hotplug, > allowing weighted interleave settings to be updated as the system memory > configuration changes. > In patch 2 you said: ``` With this enhancement, the weighted interleave policy now properly supports memory hotplug, ensuring that newly added nodes are recognized and sysfs entries are created accordingly. ``` By description, this claims to accomplish functionally the same thing patch 2 claim. The code below actually does two things: 1) Refactors the sysfs code to break out the weighted_interleave group into a global that can be referenced by the hotplug callback. 2) The change the the memory hotplug callback to add/remove nodes. Move the refactor work out ahead in a separate patch to make it easier to review the changes individually please. > Signed-off-by: Rakie Kim > --- > mm/mempolicy.c | 78 +++++++++++++++++++++++++++++--------------------- > 1 file changed, 45 insertions(+), 33 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 94efff89e0be..71aff1276d4d 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3389,6 +3389,13 @@ struct iw_node_attr { > int nid; > }; > > +struct iw_node_group { > + struct kobject *wi_kobj; > + struct iw_node_attr **nattrs; > +}; > + > +static struct iw_node_group *ngrp; > + for a global, this should have a more descriptive name. And since this actually represents the weighted_interleave sysfs entry, it should maybe be `sysfs_wi_group`? Since it will include more than just nodes (e.g. the upcoming `auto`) > static ssize_t node_show(struct kobject *kobj, struct kobj_attribute *attr, > char *buf) > { > @@ -3431,24 +3438,22 @@ static ssize_t node_store(struct kobject *kobj, struct kobj_attribute *attr, > return count; > } > > -static struct iw_node_attr **node_attrs; > - > -static void sysfs_wi_node_release(struct iw_node_attr *node_attr, > - struct kobject *parent) > +static void sysfs_wi_node_release(int nid) > { > - if (!node_attr) > + if (!ngrp->nattrs[nid]) > return; > - sysfs_remove_file(parent, &node_attr->kobj_attr.attr); > - kfree(node_attr->kobj_attr.attr.name); > - kfree(node_attr); > + > + sysfs_remove_file(ngrp->wi_kobj, &ngrp->nattrs[nid]->kobj_attr.attr); > + kfree(ngrp->nattrs[nid]->kobj_attr.attr.name); > + kfree(ngrp->nattrs[nid]); > } > > static void sysfs_wi_release(struct kobject *wi_kobj) > { > - int i; > + int nid; > > - for (i = 0; i < nr_node_ids; i++) > - sysfs_wi_node_release(node_attrs[i], wi_kobj); > + for (nid = 0; nid < nr_node_ids; nid++) > + sysfs_wi_node_release(nid); > kobject_put(wi_kobj); > } > > @@ -3457,7 +3462,7 @@ static const struct kobj_type wi_ktype = { > .release = sysfs_wi_release, > }; > > -static int add_weight_node(int nid, struct kobject *wi_kobj) > +static int sysfs_wi_node_add(int nid) > { > struct iw_node_attr *node_attr; > char *name; > @@ -3479,19 +3484,17 @@ static int add_weight_node(int nid, struct kobject *wi_kobj) > node_attr->kobj_attr.store = node_store; > node_attr->nid = nid; > > - if (sysfs_create_file(wi_kobj, &node_attr->kobj_attr.attr)) { > + if (sysfs_create_file(ngrp->wi_kobj, &node_attr->kobj_attr.attr)) { > kfree(node_attr->kobj_attr.attr.name); > kfree(node_attr); > pr_err("failed to add attribute to weighted_interleave\n"); > return -ENOMEM; > } > > - node_attrs[nid] = node_attr; > + ngrp->nattrs[nid] = node_attr; > return 0; > } > > -struct kobject *wi_kobj; > - > static int wi_node_notifier(struct notifier_block *nb, > unsigned long action, void *data) > { > @@ -3504,15 +3507,15 @@ static int wi_node_notifier(struct notifier_block *nb, > > switch(action) { > case MEM_ONLINE: > - err = add_weight_node(nid, wi_kobj); > + err = sysfs_wi_node_add(nid); > if (err) { > pr_err("failed to add sysfs [node%d]\n", nid); > - kobject_put(wi_kobj); > + kobject_put(ngrp->wi_kobj); > return NOTIFY_BAD; > } > break; > case MEM_OFFLINE: > - sysfs_wi_node_release(node_attrs[nid], wi_kobj); > + sysfs_wi_node_release(nid); > break; > } > > @@ -3524,14 +3527,14 @@ static int add_weighted_interleave_group(struct kobject *root_kobj) > { > int nid, err; > > - wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL); > - if (!wi_kobj) > + ngrp->wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL); > + if (!ngrp->wi_kobj) > return -ENOMEM; > > - err = kobject_init_and_add(wi_kobj, &wi_ktype, root_kobj, > + err = kobject_init_and_add(ngrp->wi_kobj, &wi_ktype, root_kobj, > "weighted_interleave"); > if (err) { > - kfree(wi_kobj); > + kfree(ngrp->wi_kobj); > return err; > } > > @@ -3539,7 +3542,7 @@ static int add_weighted_interleave_group(struct kobject *root_kobj) > if (!node_state(nid, N_MEMORY)) > continue; > > - err = add_weight_node(nid, wi_kobj); > + err = sysfs_wi_node_add(nid); > if (err) { > pr_err("failed to add sysfs [node%d]\n", nid); > goto err_out; > @@ -3550,7 +3553,7 @@ static int add_weighted_interleave_group(struct kobject *root_kobj) > return 0; > > err_out: > - kobject_put(wi_kobj); > + kobject_put(ngrp->wi_kobj); > return err; > } > > @@ -3565,7 +3568,9 @@ static void mempolicy_kobj_release(struct kobject *kobj) > mutex_unlock(&iw_table_lock); > synchronize_rcu(); > kfree(old); > - kfree(node_attrs); > + > + kfree(ngrp->nattrs); > + kfree(ngrp); > kfree(kobj); > } > > @@ -3578,17 +3583,23 @@ static int __init mempolicy_sysfs_init(void) > int err; > static struct kobject *mempolicy_kobj; > > - node_attrs = kcalloc(nr_node_ids, sizeof(struct iw_node_attr *), > - GFP_KERNEL); > - if (!node_attrs) { > + ngrp = kzalloc(sizeof(*ngrp), GFP_KERNEL); > + if (!ngrp) { > err = -ENOMEM; > goto err_out; > } > > + ngrp->nattrs = kcalloc(nr_node_ids, sizeof(struct iw_node_attr *), > + GFP_KERNEL); > + if (!ngrp->nattrs) { > + err = -ENOMEM; > + goto ngrp_out; > + } > + > mempolicy_kobj = kzalloc(sizeof(*mempolicy_kobj), GFP_KERNEL); > if (!mempolicy_kobj) { > err = -ENOMEM; > - goto node_out; > + goto nattr_out; > } > > err = kobject_init_and_add(mempolicy_kobj, &mempolicy_ktype, mm_kobj, > @@ -3606,12 +3617,13 @@ static int __init mempolicy_sysfs_init(void) > > return 0; > > -node_out: > - kfree(node_attrs); > +nattr_out: > + kfree(ngrp->nattrs); > +ngrp_out: > + kfree(ngrp); > err_out: > pr_err("mempolicy sysfs structure failed to initialize\n"); > return err; > - > } > > late_initcall(mempolicy_sysfs_init); > -- > 2.34.1 >